22484 2008-11-25 04:19:39 -0800 [Gtk] add/remove tests from Skipped and fix netscape plugin test 2008-11-26 03:32:42 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED Gtk P2 Normal --- 1 jmalonzo webkit-unassigned oldest_to_newest 100193 0 jmalonzo 2008-11-25 04:19:39 -0800 Skipped: Add tests that needs confirmation of new results. Also, remove some tests that are already passing. TestNetscapePlugin.cpp: Remove printing to stderr as it's messing up with some tests. Patch follows. 100194 1 25477 jmalonzo 2008-11-25 04:20:44 -0800 Created attachment 25477 Patch to fix the issue I raised above 100215 2 25477 zecke 2008-11-25 07:41:52 -0800 Comment on attachment 25477 Patch to fix the issue I raised above > > - > - white space changes, please try to avoid them. Please land these patches in two separate commits. 100391 3 jmalonzo 2008-11-26 03:32:42 -0800 Landed in r38783 (Netscape plugin fix) and r38784 (Skipped fix). Thanks! 25477 2008-11-25 04:20:44 -0800 2008-11-25 07:41:52 -0800 Patch to fix the issue I raised above testsfixes.patch text/plain 5822 jmalonzo ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1MjEyNDhmLi41OTQyYTdhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMTEt MjUgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtpdC5vcmc+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgdGVzdHMgYXJlIHRl c3RzIHRoYXQgbmVlZHMgY29uZmlybWF0aW9uIG9mIHJlc3VsdHMgKHBvc3NpYmxlIG5ldykuCisg ICAgICAgIFJlbW92ZWQgdGVzdHMgYXJlIHRlc3RzIHRoYXQgYXJlIGN1cnJlbnRseSBwYXNzaW5n LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1NraXBwZWQ6CisKIDIwMDgtMTEtMjUgIEFsZXhl eSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdl b2ZmIEdhcmVuLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAppbmRleCAyYTkyODEwLi4zMTQzNDVh IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAorKysgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApAQCAtMjEyLDggKzIxMiw2IEBAIGZhc3QvanMv bmF2aWdhdG9yLW1pbWVUeXBlcy1sZW5ndGguaHRtbAogZmFzdC9qcy9rZGUvbWQ1LTEuaHRtbAog ZmFzdC9sYXllcnMvcmVzaXplLWxheWVyLWRlbGV0aW9uLWNyYXNoLmh0bWwKIGZhc3QvbG9hZGVy L2NhbmNlbC1sb2FkLWR1cmluZy1wb3J0LWJsb2NrLXRpbWVyLmh0bWwKLWZhc3QvbG9hZGVyL2lm cmFtZS1jcmFzaC1vbi1taXNzaW5nLWltYWdlLnhodG1sCi1mYXN0L2xvYWRlci9sb2FkSW5Qcm9n cmVzcy5odG1sCiBmYXN0L2xvYWRlci9sb2NhbC1DU1MtZnJvbS1sb2NhbC5odG1sCiBmYXN0L2xv YWRlci9sb2NhbC1KYXZhU2NyaXB0LWZyb20tbG9jYWwuaHRtbAogZmFzdC9sb2FkZXIvbG9jYWwt aUZyYW1lLXNvdXJjZS1mcm9tLWxvY2FsLmh0bWwKQEAgLTIyMiw3ICsyMjAsNiBAQCBmYXN0L2xv YWRlci9vbnVubG9hZC1mb3JtLXN1Ym1pdC1jcmFzaC0yLmh0bWwKIGZhc3QvbG9hZGVyL29udW5s b2FkLWZvcm0tc3VibWl0LWNyYXNoLmh0bWwKIGZhc3QvbG9hZGVyL29wYXF1ZS1iYXNlLXVybC5o dG1sCiBmYXN0L2xvYWRlci9zdG9wLXByb3Zpc2lvbmFsLWxvYWRzLmh0bWwKLWZhc3QvbG9hZGVy L3VubG9hZGFibGUtc2NyaXB0Lmh0bWwKIGZhc3QvbG9hZGVyL3htbGh0dHByZXF1ZXN0LW1pc3Np bmctZmlsZS1leGNlcHRpb24uaHRtbAogZmFzdC9vdmVyZmxvdy9zY3JvbGwtdmVydGljYWwtbm90 LWhvcml6b250YWwuaHRtbAogZmFzdC9wYXJzZXIvYXNzZXJ0aW9uLWVtcHR5LWF0dHJpYnV0ZS5o dG1sCkBAIC0yOTQsOCArMjkxLDYgQEAgZmFzdC94c2wvbW96aWxsYS10ZXN0cy54bWwKIAogCiAK LQotCiAjIGNyYXNoaW5nIHRlc3RzCiBmYXN0L2Nzcy9mb250LWZhY2UtdW5pY29kZS1yYW5nZS5o dG1sCiBmYXN0L2RvbS9IVE1MSGVhZEVsZW1lbnQvaGVhZC1jaGVjay5odG1sCkBAIC05MjAsNiAr OTE1LDcgQEAgZmFzdC9jc3MvcGVyY2VudGFnZS1ub24taW50ZWdlci5odG1sCiBmYXN0L2Nzcy9w b3NpdGlvbi1uZWdhdGl2ZS10b3AtbWFyZ2luLmh0bWwKIGZhc3QvY3NzL3F1aXJrLW9ycGhhbmVk LXVuaXRzLmh0bWwKIGZhc3QvY3NzL3Jlc2l6ZS1jb3JuZXItdHJhY2tpbmcuaHRtbAorZmFzdC9j c3MvcmVzaXplLWNvcm5lci10cmFja2luZy10cmFuc2Zvcm1lZC5odG1sCiBmYXN0L2Nzcy9yZ2It ZmxvYXQuaHRtbAogZmFzdC9jc3MvcnRsLW9yZGVyaW5nLmh0bWwKIGZhc3QvY3NzL3NlbGVjdG9y LXNldC1hdHRyaWJ1dGUuaHRtbApAQCAtMTA1NSw2ICsxMDUxLDcgQEAgZmFzdC9keW5hbWljL2Zs b2F0aW5nLXRvLXBvc2l0aW9uZWQtMi5odG1sCiBmYXN0L2R5bmFtaWMvZmxvYXRpbmctdG8tcG9z aXRpb25lZC5odG1sCiBmYXN0L2R5bmFtaWMvZ2VuQ29udGVudERlc3Ryb3lDaGlsZHJlbi5odG1s CiBmYXN0L2R5bmFtaWMvaW5zZXJ0LWJlZm9yZS10YWJsZS1wYXJ0LWluLWNvbnRpbnVhdGlvbi5o dG1sCitmYXN0L2R5bmFtaWMvaW5zZXJ0QWRqYWNlbnRFbGVtZW50Lmh0bWwKIGZhc3QvZHluYW1p Yy9sYXllci1oaXQtdGVzdC1jcmFzaC5odG1sCiBmYXN0L2R5bmFtaWMvbGluay1ocmVmLWNoYW5n ZS5odG1sCiBmYXN0L2R5bmFtaWMvbW92ZS1ub2RlLXdpdGgtc2VsZWN0aW9uLmh0bWwKQEAgLTEy MzYsNiArMTIzMyw3IEBAIGZhc3QvZm9ybXMvc2VhcmNoLWNhbmNlbC1idXR0b24tc3R5bGUtc2hh cmluZy5odG1sCiBmYXN0L2Zvcm1zL3NlYXJjaC1kaXNwbGF5LW5vbmUtY2FuY2VsLWJ1dHRvbi5o dG1sCiBmYXN0L2Zvcm1zL3NlYXJjaC1wbGFjZWhvbGRlci12YWx1ZS1jaGFuZ2VkLmh0bWwKIGZh c3QvZm9ybXMvc2VhcmNoLXJ0bC5odG1sCitmYXN0L2Zvcm1zL3NlYXJjaC10cmFuc2Zvcm1lZC5o dG1sCiBmYXN0L2Zvcm1zL3NlYXJjaGZpZWxkLWhlaWdodHMuaHRtbAogZmFzdC9mb3Jtcy9zZWxl Y3QtYWxpZ24uaHRtbAogZmFzdC9mb3Jtcy9zZWxlY3QtYmFzZWxpbmUuaHRtbApAQCAtMTU4Miw2 ICsxNTgwLDcgQEAgZmFzdC9yZXBhaW50L2J1Z3ppbGxhLTY0NzMuaHRtbAogZmFzdC9yZXBhaW50 L2J1Z3ppbGxhLTcyMzUuaHRtbAogZmFzdC9yZXBhaW50L2J1dHRvbi1zcHVyaW91cy1sYXlvdXQt aGludC5odG1sCiBmYXN0L3JlcGFpbnQvY2FyZXQtb3V0c2lkZS1ibG9jay5odG1sCitmYXN0L3Jl cGFpbnQvY2hhbmdlLXRyYW5zZm9ybS5odG1sCiBmYXN0L3JlcGFpbnQvY2xpcC13aXRoLWxheW91 dC1kZWx0YS5odG1sCiBmYXN0L3JlcGFpbnQvY2xpcHBlZC1yZWxhdGl2ZS5odG1sCiBmYXN0L3Jl cGFpbnQvY29udGFpbmluZy1ibG9jay1wb3NpdGlvbi1jaGFuZ2UuaHRtbApAQCAtMTYyNyw2ICsx NjI2LDcgQEAgZmFzdC9yZXBhaW50L2xpc3QtbWFya2VyLTIuaHRtbAogZmFzdC9yZXBhaW50L2xp c3QtbWFya2VyLmh0bWwKIGZhc3QvcmVwYWludC9tYWtlLWNoaWxkcmVuLW5vbi1pbmxpbmUuaHRt bAogZmFzdC9yZXBhaW50L291dGxpbmUtaW5zZXQuaHRtbAorZmFzdC9yZXBhaW50L291dGxpbmUt Y2hpbGQtcmVwYWludC5odG1sCiBmYXN0L3JlcGFpbnQvb3V0bGluZS1yZXBhaW50LWdsaXRjaC5o dG1sCiBmYXN0L3JlcGFpbnQvb3V0bGluZS1zaHJpbmtpbmcuaHRtbAogZmFzdC9yZXBhaW50L292 ZXJmbG93LWNsaXAtc3VidHJlZS1sYXlvdXQuaHRtbApAQCAtMTY2Myw2ICsxNjYzLDkgQEAgZmFz dC9yZXBhaW50L3RleHQtc2VsZWN0aW9uLXJlY3QtaW4tb3ZlcmZsb3ctMi5odG1sCiBmYXN0L3Jl cGFpbnQvdGV4dC1zZWxlY3Rpb24tcmVjdC1pbi1vdmVyZmxvdy5odG1sCiBmYXN0L3JlcGFpbnQv dGV4dC1zaGFkb3ctaG9yaXpvbnRhbC5odG1sCiBmYXN0L3JlcGFpbnQvdGV4dC1zaGFkb3cuaHRt bAorZmFzdC9yZXBhaW50L3RyYW5zZm9ybS1hYnNvbHV0ZS1jaGlsZC5odG1sCitmYXN0L3JlcGFp bnQvdHJhbnNmb3JtLWFic29sdXRlLWluLXBvc2l0aW9uZWQtY29udGFpbmVyLmh0bWwKK2Zhc3Qv cmVwYWludC90cmFuc2Zvcm0tcmVsYXRpdmUtcG9zaXRpb24uaHRtbAogZmFzdC9yZXBhaW50L3Ry YW5zZm9ybS10cmFuc2xhdGUuaHRtbAogZmFzdC9yZXBsYWNlZC8wMDEuaHRtbAogZmFzdC9yZXBs YWNlZC8wMDIuaHRtbApAQCAtMjA5MCw2ICsyMDkzLDcgQEAgZmFzdC90cmFuc2Zvcm1zL3NoYWRv d3MuaHRtbAogZmFzdC90cmFuc2Zvcm1zL3NrZXctd2l0aC11bml0bGVzcy16ZXJvLmh0bWwKIGZh c3QvdHJhbnNmb3Jtcy90cmFuc2Zvcm0tb3ZlcmZsb3cuaHRtbAogZmFzdC90cmFuc2Zvcm1zL3Ry YW5zZm9ybS1wb3NpdGlvbmVkLWFuY2VzdG9yLmh0bWwKK2Zhc3QvdHJhbnNmb3Jtcy90cmFuc2Zv cm1lZC1mb2N1c2VkLXRleHQtaW5wdXQuaHRtbAogZmFzdC90cmFuc2Zvcm1zL3RyYW5zZm9ybXMt d2l0aC1vcGFjaXR5Lmh0bWwKIGZhc3QveHNsL2RvY3VtZW50LWZ1bmN0aW9uLnhtbAogZmFzdC94 c2wveHNsdC1lbmMxNi54bWwKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dl YktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCA4OGRkMTEwLi5mZWUwZjg5IDEwMDY0NAotLS0gYS9X ZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTQgQEAKKzIwMDgtMTEtMjUgIEphbiBNaWNoYWVsIEFsb256byAgPGptYWxvbnpvQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVtb3ZlIHByaW50aW5nIHRvIHN0ZGVyciBhcyBpdCBtZXNzZXMgdXAgc29tZSBsYXlvdXQgdGVz dHMgKHNob3dpbmcKKyAgICAgICAgdXAgYXMgdGVzdHMgd2l0aCBzdGRlcnIpLgorCisgICAgICAg ICogRHVtcFJlbmRlclRyZWUvZ3RrL1Rlc3ROZXRzY2FwZVBsdWdpbi9UZXN0TmV0c2NhcGVQbHVn aW4uY3BwOgorICAgICAgICAoTlBfSW5pdGlhbGl6ZSk6CisgICAgICAgIChOUF9TaHV0ZG93bik6 CisKIDIwMDgtMTEtMjQgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBGaXggYnVzdGFnZS4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L2d0ay9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1Z2luLmNwcCBiL1dlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9UZXN0TmV0c2NhcGVQbHVnaW4vVGVzdE5ldHNjYXBlUGx1 Z2luLmNwcAppbmRleCAzZTMxOTg0Li45ZDg1NDc2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9ndGsvVGVzdE5ldHNjYXBlUGx1Z2luL1Rlc3ROZXRzY2FwZVBsdWdpbi5j cHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL1Rlc3ROZXRzY2FwZVBsdWdp bi9UZXN0TmV0c2NhcGVQbHVnaW4uY3BwCkBAIC0yNjMsOCArMjYzLDYgQEAgTlBfR2V0TUlNRURl c2NyaXB0aW9uKHZvaWQpCiBOUEVycm9yCiBOUF9Jbml0aWFsaXplIChOUE5ldHNjYXBlRnVuY3Mg KmFNb3ppbGxhVlRhYmxlLCBOUFBsdWdpbkZ1bmNzICphUGx1Z2luVlRhYmxlKQogewotICAgIGZw cmludGYoc3RkZXJyLCAiV2ViS2l0VGVzdFBsdWdJbiAtIE5QX0luaXRpYWxpemVcbiIpOwotCiAg ICAgaWYgKGFNb3ppbGxhVlRhYmxlID09IE5VTEwgfHwgYVBsdWdpblZUYWJsZSA9PSBOVUxMKQog ICAgICAgICByZXR1cm4gTlBFUlJfSU5WQUxJRF9GVU5DVEFCTEVfRVJST1I7CiAKQEAgLTI5NSwx NiArMjkzLDEyIEBAIE5QX0luaXRpYWxpemUgKE5QTmV0c2NhcGVGdW5jcyAqYU1vemlsbGFWVGFi bGUsIE5QUGx1Z2luRnVuY3MgKmFQbHVnaW5WVGFibGUpCiAgICAgICAgIGFQbHVnaW5WVGFibGUt PmdldHZhbHVlICAgICAgID0gd2Via2l0X3Rlc3RfcGx1Z2luX2dldF92YWx1ZTsKICAgICAgICAg YVBsdWdpblZUYWJsZS0+c2V0dmFsdWUgICAgICAgPSB3ZWJraXRfdGVzdF9wbHVnaW5fc2V0X3Zh bHVlOwogCi0gICAgZnByaW50ZihzdGRlcnIsICJXZWJLaXRUZXN0UGx1Z0luIC0gTlBfSW5pdGlh bGl6ZSBzdWNjZWVkZWRcbiIpOwotCiAgICAgcmV0dXJuIE5QRVJSX05PX0VSUk9SOwogfQogCiBO UEVycm9yCiBOUF9TaHV0ZG93bih2b2lkKQogewotICAgIGZwcmludGYoc3RkZXJyLCAiV2ViS2l0 VGVzdFBsdWdJbiAtIE5QX1NodXRkb3duXG4iKTsKLQogICAgIHJldHVybiBOUEVSUl9OT19FUlJP UjsKIH0KIAo=