224838 2021-04-20 15:48:19 -0700 [SOUP] Null pointer dereference in ResourceLoader::didReceiveAuthenticationChallenge 2021-04-22 15:31:12 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224452 P2 Normal --- 1 mcatanzaro mcatanzaro aperez berto bugs-noreply cdumez cgarcia ews-watchlist gustavo mcatanzaro oldest_to_newest 1752484 0 mcatanzaro 2021-04-20 15:48:19 -0700 [840/1793] Building CXX object Source/WebCore/CMakeFiles/...vedSources/unified-sources/UnifiedSource-c57e08af-6.cpp.o In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-c57e08af-6.cpp:3: ../../Source/WebCore/loader/ResourceLoader.cpp: In member function ‘virtual void WebCore::ResourceLoader::didReceiveAuthenticationChallenge(WebCore::ResourceHandle*, const WebCore::AuthenticationChallenge&)’: ../../Source/WebCore/loader/ResourceLoader.cpp:809:81: warning: ‘this’ pointer is null [-Wnonnull] 809 | challenge.authenticationClient()->receivedRequestToContinueWithoutCredential(challenge); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ At first I incorrectly thought this was a false positive, but in bug #224452, Chris noticed that our AuthenticationChallenge::authenticationClient now always returns nullptr. That is no good. Carlos, I guess this is not quite what you had intended? 1753163 1 cgarcia 2021-04-22 07:51:42 -0700 I think that code is never actually reached, that's only used by ResourceHandle which is no longer supported by the soup based ports. The soup implementation of ResourceHandle::receivedRequestToContinueWithoutCredential() is an assert. 1753210 2 426825 mcatanzaro 2021-04-22 10:13:00 -0700 Created attachment 426825 Patch 1753319 3 ews-feeder 2021-04-22 15:31:09 -0700 Committed r276471 (236931@main): <https://commits.webkit.org/236931@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426825. 426825 2021-04-22 10:13:00 -0700 2021-04-22 15:31:10 -0700 Patch bug-224838-20210422121259.patch text/plain 1513 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWZhNjU3ZDEzYTlhMzA0 Y2I0YjkwYjZiOWQzMjJmMWRlMDA0MTgyMi4uYWFlZmM4NGIxOTJjODA0NDhlZTJjZGNhYzZjZGYz MzMxZTA3MGEzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA0LTIyICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtTT1VQXSBO dWxsIHBvaW50ZXIgZGVyZWZlcmVuY2UgaW4gUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVBdXRo ZW50aWNhdGlvbkNoYWxsZW5nZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI0ODM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkIGEgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKSB0byBhdm9pZCB0 aGlzIHdhcm5pbmcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQXV0aGVudGlj YXRpb25DaGFsbGVuZ2UuaDoKKwogMjAyMS0wNC0yMSAgTWFydGluIFJvYmluc29uICA8bXJvYmlu c29uQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIGJhc2ljIChub24tbW9tZW50dW0pIHdoZWVs IGV2ZW50IGhhbmRsaW5nIGZvciBzY3JvbGwgc25hcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL0F1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlLmggYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQXV0aGVudGljYXRpb25DaGFsbGVuZ2Uu aAppbmRleCA4ZWQwNThjYmM3ZTVjZTY5MTg3ODI1MzZmYzliYjExY2ViYTZiNThmLi4wYTkzNTlj NWIxMzk4ZGYwNTFjNWFkNDkxN2YyZjg5NTI3MGFjOGRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQXV0aGVudGljYXRpb25DaGFsbGVuZ2UuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQXV0aGVudGljYXRpb25DaGFs bGVuZ2UuaApAQCAtNDUsNyArNDUsNyBAQCBwdWJsaWM6CiAgICAgfQogCiAgICAgQXV0aGVudGlj YXRpb25DaGFsbGVuZ2UoU291cE1lc3NhZ2UqLCBTb3VwQXV0aCosIGJvb2wgcmV0cnlpbmcpOwot ICAgIEF1dGhlbnRpY2F0aW9uQ2xpZW50KiBhdXRoZW50aWNhdGlvbkNsaWVudCgpIGNvbnN0IHsg cmV0dXJuIG51bGxwdHI7IH0KKyAgICBBdXRoZW50aWNhdGlvbkNsaWVudCogYXV0aGVudGljYXRp b25DbGllbnQoKSBjb25zdCB7IFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0KICNpZiBV U0UoU09VUDIpCiAgICAgU291cE1lc3NhZ2UqIHNvdXBNZXNzYWdlKCkgY29uc3QgeyByZXR1cm4g bV9zb3VwTWVzc2FnZS5nZXQoKTsgfQogI2VuZGlmCg==