224826 2021-04-20 12:54:36 -0700 Static asserts in WasmAirIRGenerator.cpp and WasmB3IRGenerator.cpp trigger -Wnonnull warnings with GCC 11 2021-04-23 01:08:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224452 InRadar P2 Normal --- 1 mcatanzaro mcatanzaro ews-watchlist keith_miller mark.lam mcatanzaro msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1752385 0 mcatanzaro 2021-04-20 12:54:36 -0700 These asserts are understandably triggering -Wnonnull warnings: static_assert(sizeof(decltype(static_cast<Instance*>(nullptr)->cachedStackLimit())) == sizeof(uint64_t), ""); In https://bugs.webkit.org/show_bug.cgi?id=224452#c26, Jonathan Wakely has a tip to rewrite the assert: static_assert(sizeof(std::declval<Instance*>()->cachedStackLimit()) == sizeof(uint64_t), ""); It works. 1752391 1 426584 mcatanzaro 2021-04-20 13:02:43 -0700 Created attachment 426584 Patch 1752598 2 ews-feeder 2021-04-20 19:38:22 -0700 Committed r276343 (236821@main): <https://commits.webkit.org/236821@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426584. 1753489 3 webkit-bug-importer 2021-04-23 01:08:19 -0700 <rdar://problem/77061153> 426584 2021-04-20 13:02:43 -0700 2021-04-20 19:38:23 -0700 Patch bug-224826-20210420150242.patch text/plain 3786 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MjQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx NTdjMjBhZjA5MzFiYWZkMjY3NmEyMDhlYjM5YjJmYjQ5NGU4NjdjLi5mODk4YjRkOTBlZjZkMTRh ODYzNGNhODQzOTBmMTcxZWE1ZGEyNmM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMS0wNC0yMCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdu b21lLm9yZz4KKworICAgICAgICBTdGF0aWMgYXNzZXJ0cyBpbiBXYXNtQWlySVJHZW5lcmF0b3Iu Y3BwIGFuZCBXYXNtQjNJUkdlbmVyYXRvci5jcHAgdHJpZ2dlciAtV25vbm51bGwgd2FybmluZ3Mg d2l0aCBHQ0MgMTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyNDgyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJld3JpdGUgdGhlc2Ugc3RhdGljIGFzc2VydHMgdG8gYXZvaWQgd2FybmluZ3Mgd2hlbiBi dWlsdCB3aXRoIEdDQyAxMS4gQ3JlZGl0IHRvIEpvbmF0aGFuCisgICAgICAgIFdha2VseSBmb3Ig cHJvdmlkaW5nIHRoaXMgbWluZC1iZW5kaW5nIHNvbHV0aW9uLgorCisgICAgICAgICogd2FzbS9X YXNtQWlySVJHZW5lcmF0b3IuY3BwOgorICAgICAgICAoSlNDOjpXYXNtOjpBaXJJUkdlbmVyYXRv cjo6cmVzdG9yZVdlYkFzc2VtYmx5R2xvYmFsU3RhdGUpOgorICAgICAgICAoSlNDOjpXYXNtOjpB aXJJUkdlbmVyYXRvcjo6YWRkQ3VycmVudE1lbW9yeSk6CisgICAgICAgICogd2FzbS9XYXNtQjNJ UkdlbmVyYXRvci5jcHA6CisgICAgICAgIChKU0M6Oldhc206OkIzSVJHZW5lcmF0b3I6OmFkZEN1 cnJlbnRNZW1vcnkpOgorCiAyMDIxLTA0LTE4ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBs ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYnVpbGQgZml4CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtQWlySVJHZW5lcmF0b3IuY3BwIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3dhc20vV2FzbUFpcklSR2VuZXJhdG9yLmNwcAppbmRleCBmOTAwZTkwZTNh NTJhMjZhOTE3ODNkYWJhZjE1NTViNWRhMzRiNzZhLi45ZTE4Y2JhY2I0YjkwZmI3ZTk5MjRjNjRi NTQyYzRlNGEzZTdkOGNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9X YXNtQWlySVJHZW5lcmF0b3IuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dh c21BaXJJUkdlbmVyYXRvci5jcHAKQEAgLTk0NCw3ICs5NDQsNyBAQCB2b2lkIEFpcklSR2VuZXJh dG9yOjpyZXN0b3JlV2ViQXNzZW1ibHlHbG9iYWxTdGF0ZShSZXN0b3JlQ2FjaGVkU3RhY2tMaW1p dCByZXN0bwogCiAgICAgaWYgKHJlc3RvcmVDYWNoZWRTdGFja0xpbWl0ID09IFJlc3RvcmVDYWNo ZWRTdGFja0xpbWl0OjpZZXMpIHsKICAgICAgICAgLy8gVGhlIEluc3RhbmNlIGNhY2hlcyB0aGUg c3RhY2sgbGltaXQsIGJ1dCBhbHNvIGtub3dzIHdoZXJlIGl0cyBjYW5vbmljYWwgbG9jYXRpb24g aXMuCi0gICAgICAgIHN0YXRpY19hc3NlcnQoc2l6ZW9mKGRlY2x0eXBlKHN0YXRpY19jYXN0PElu c3RhbmNlKj4obnVsbHB0ciktPmNhY2hlZFN0YWNrTGltaXQoKSkpID09IHNpemVvZih1aW50NjRf dCksICIiKTsKKyAgICAgICAgc3RhdGljX2Fzc2VydChzaXplb2Yoc3RkOjpkZWNsdmFsPEluc3Rh bmNlKj4oKS0+Y2FjaGVkU3RhY2tMaW1pdCgpKSA9PSBzaXplb2YodWludDY0X3QpLCAiY29kZWdl biByZWxpZXMgb24gdGhpcyBzaXplIik7CiAKICAgICAgICAgUkVMRUFTRV9BU1NFUlQoQXJnOjpp c1ZhbGlkQWRkckZvcm0oSW5zdGFuY2U6Om9mZnNldE9mUG9pbnRlclRvQWN0dWFsU3RhY2tMaW1p dCgpLCBCMzo6V2lkdGg2NCkpOwogICAgICAgICBSRUxFQVNFX0FTU0VSVChBcmc6OmlzVmFsaWRB ZGRyRm9ybShJbnN0YW5jZTo6b2Zmc2V0T2ZDYWNoZWRTdGFja0xpbWl0KCksIEIzOjpXaWR0aDY0 KSk7CkBAIC0xMjYzLDcgKzEyNjMsNyBAQCBhdXRvIEFpcklSR2VuZXJhdG9yOjphZGRHcm93TWVt b3J5KEV4cHJlc3Npb25UeXBlIGRlbHRhLCBFeHByZXNzaW9uVHlwZSYgcmVzdWx0KQogCiBhdXRv IEFpcklSR2VuZXJhdG9yOjphZGRDdXJyZW50TWVtb3J5KEV4cHJlc3Npb25UeXBlJiByZXN1bHQp IC0+IFBhcnRpYWxSZXN1bHQKIHsKLSAgICBzdGF0aWNfYXNzZXJ0KHNpemVvZihkZWNsdHlwZShz dGF0aWNfY2FzdDxNZW1vcnkqPihudWxscHRyKS0+c2l6ZSgpKSkgPT0gc2l6ZW9mKHVpbnQ2NF90 KSwgImNvZGVnZW4gcmVsaWVzIG9uIHRoaXMgc2l6ZSIpOworICAgIHN0YXRpY19hc3NlcnQoc2l6 ZW9mKHN0ZDo6ZGVjbHZhbDxNZW1vcnkqPigpLT5zaXplKCkpID09IHNpemVvZih1aW50NjRfdCks ICJjb2RlZ2VuIHJlbGllcyBvbiB0aGlzIHNpemUiKTsKIAogICAgIGF1dG8gdGVtcDEgPSBnNjQo KTsKICAgICBhdXRvIHRlbXAyID0gZzY0KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvd2FzbS9XYXNtQjNJUkdlbmVyYXRvci5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d2FzbS9XYXNtQjNJUkdlbmVyYXRvci5jcHAKaW5kZXggMGJiNzRjOGJmZWE4ZTBjODYyNWVhNGU4 YzdiYzI5NmI2NGZmNGMxMi4uN2FmMDhmY2M2OGZiMjFjODI2MDEzZTUyOGY1ZmM5N2RiNzZkMzM3 MCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUIzSVJHZW5lcmF0 b3IuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21CM0lSR2VuZXJhdG9y LmNwcApAQCAtODc5LDcgKzg3OSw4IEBAIGF1dG8gQjNJUkdlbmVyYXRvcjo6YWRkR3Jvd01lbW9y eShFeHByZXNzaW9uVHlwZSBkZWx0YSwgRXhwcmVzc2lvblR5cGUmIHJlc3VsdCkKIAogYXV0byBC M0lSR2VuZXJhdG9yOjphZGRDdXJyZW50TWVtb3J5KEV4cHJlc3Npb25UeXBlJiByZXN1bHQpIC0+ IFBhcnRpYWxSZXN1bHQKIHsKLSAgICBzdGF0aWNfYXNzZXJ0KHNpemVvZihkZWNsdHlwZShzdGF0 aWNfY2FzdDxNZW1vcnkqPihudWxscHRyKS0+c2l6ZSgpKSkgPT0gc2l6ZW9mKHVpbnQ2NF90KSwg ImNvZGVnZW4gcmVsaWVzIG9uIHRoaXMgc2l6ZSIpOworICAgIHN0YXRpY19hc3NlcnQoc2l6ZW9m KHN0ZDo6ZGVjbHZhbDxNZW1vcnkqPigpLT5zaXplKCkpID09IHNpemVvZih1aW50NjRfdCksICJj b2RlZ2VuIHJlbGllcyBvbiB0aGlzIHNpemUiKTsKKwogICAgIFZhbHVlKiBtZW1vcnkgPSBtX2N1 cnJlbnRCbG9jay0+YXBwZW5kTmV3PE1lbW9yeVZhbHVlPihtX3Byb2MsIExvYWQsIEludDY0LCBv cmlnaW4oKSwgaW5zdGFuY2VWYWx1ZSgpLCBzYWZlQ2FzdDxpbnQzMl90PihJbnN0YW5jZTo6b2Zm c2V0T2ZNZW1vcnkoKSkpOwogICAgIFZhbHVlKiBoYW5kbGUgPSBtX2N1cnJlbnRCbG9jay0+YXBw ZW5kTmV3PE1lbW9yeVZhbHVlPihtX3Byb2MsIExvYWQsIEludDY0LCBvcmlnaW4oKSwgbWVtb3J5 LCBzYWZlQ2FzdDxpbnQzMl90PihNZW1vcnk6Om9mZnNldE9mSGFuZGxlKCkpKTsKICAgICBWYWx1 ZSogc2l6ZSA9IG1fY3VycmVudEJsb2NrLT5hcHBlbmROZXc8TWVtb3J5VmFsdWU+KG1fcHJvYywg TG9hZCwgSW50NjQsIG9yaWdpbigpLCBoYW5kbGUsIHNhZmVDYXN0PGludDMyX3Q+KE1lbW9yeUhh bmRsZTo6b2Zmc2V0T2ZTaXplKCkpKTsK