224815 2021-04-20 08:41:55 -0700 Fix isCSSWideKeyword to stop including `default` 2021-11-06 09:09:46 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 232750 InRadar P2 Normal --- 1 ntim webkit-unassigned darin esprehn+autocc ews-watchlist glenn gyuyoung.kim macpherson menard webkit-bug-importer oldest_to_newest 1752269 0 ntim 2021-04-20 08:41:55 -0700 I discovered that isCSSWideKeywords included CSSValueDefault, which was slightly surprising. Antti mentioned this was because `default` used to be the old name for `revert`. Since this is not supported in any browser, let's remove it. 1752270 1 webkit-bug-importer 2021-04-20 08:43:21 -0700 <rdar://problem/76900167> 1752275 2 426551 ntim 2021-04-20 08:52:43 -0700 Created attachment 426551 Patch 1752278 3 426552 ntim 2021-04-20 09:01:54 -0700 Created attachment 426552 Patch 1754017 4 darin 2021-04-25 10:35:43 -0700 I think it’s important to talk about the observable change we want in behavior rather than the internal function name. Do we have a test for the case where we end up handling "default" incorrectly? I still fully expect this will end up being a useful change once we understand why the tests we already have start indicating a failure and take care of that. We may need a different internal function to use where we are currently using isCSSWideKeyword. 1812392 5 ntim 2021-11-06 09:08:31 -0700 *** This bug has been marked as a duplicate of bug 232750 *** 426551 2021-04-20 08:52:43 -0700 2021-04-20 09:08:59 -0700 Patch bug-224815-20210420175241.patch text/plain 2721 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjFlNTNiNDBjYjRkYjQw YTk2MWJlY2U0OWU5Y2ViNzdkMzQ4Mzc2Yy4uZDE1ZTQ1NDM0MzMzMjMzMDQxNjFhYjE0ZWM5MDEy YmE0ODNkNzkwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA0LTIwICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGlzQ1NTV2lkZUtleXdvcmQg dG8gc3RvcCBpbmNsdWRpbmcgYGRlZmF1bHRgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ4MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBbHNvIHJlcGxhY2VkIGFuIGluY29ycmVjdCB1c2Ugb2YgQ1NT VmFsdWVEZWZhdWx0IGluIHRoZSB3aWxsLWNoYW5nZSBwcm9wZXJ0eS4KKworICAgICAgICAqIGNz cy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y29uc3Vt ZVdpbGxDaGFuZ2UpOgorICAgICAgICAqIGNzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXJIZWxw ZXJzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1Byb3BlcnR5UGFyc2VySGVscGVyczo6aXND U1NXaWRlS2V5d29yZCk6CisKIDIwMjEtMDQtMjAgIEtpbW1vIEtpbm51bmVuICA8a2tpbm51bmVu QGFwcGxlLmNvbT4KIAogICAgICAgICBBdWRpb1NvdXJjZVByb3ZpZGVyQVZGT2JqQyB1c2VzIGF0 b21pYyB2YXJpYWJsZXMgYnV0IGFsc28gbG9ja3Mgd2l0aCBtdXRleApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmNwcAppbmRleCBlNTE0YzM5OGI0NWI3 MzhmOTBhYTEwNzZjMTI2NWExZTY4OGNkNjVjLi4zOGE4YzQ1NzcwODc0NDliYjQ0MzZiYWRjY2Yy Y2Y2OGVkYWIwNjg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1By b3BlcnR5UGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3Bl cnR5UGFyc2VyLmNwcApAQCAtNDk4LDEzICs0OTgsMTQgQEAgc3RhdGljIFJlZlB0cjxDU1NWYWx1 ZT4gY29uc3VtZVdpbGxDaGFuZ2UoQ1NTUGFyc2VyVG9rZW5SYW5nZSYgcmFuZ2UpCiAgICAgICAg ICAgICB2YWx1ZXMtPmFwcGVuZChDU1NWYWx1ZVBvb2w6OnNpbmdsZXRvbigpLmNyZWF0ZUlkZW50 aWZpZXJWYWx1ZShwcm9wZXJ0eUlEKSk7CiAgICAgICAgICAgICByYW5nZS5jb25zdW1lSW5jbHVk aW5nV2hpdGVzcGFjZSgpOwogICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgc3dpdGNoIChy YW5nZS5wZWVrKCkuaWQoKSkgeworICAgICAgICAgICAgYXV0byBpZCA9IHJhbmdlLnBlZWsoKS5p ZCgpOworICAgICAgICAgICAgaWYgKGlzQ1NTV2lkZUtleXdvcmQoaWQpKQorICAgICAgICAgICAg ICAgIHJldHVybiBudWxscHRyOworCisgICAgICAgICAgICBzd2l0Y2ggKGlkKSB7CiAgICAgICAg ICAgICBjYXNlIENTU1ZhbHVlTm9uZToKICAgICAgICAgICAgIGNhc2UgQ1NTVmFsdWVBbGw6CiAg ICAgICAgICAgICBjYXNlIENTU1ZhbHVlQXV0bzoKLSAgICAgICAgICAgIGNhc2UgQ1NTVmFsdWVE ZWZhdWx0OgotICAgICAgICAgICAgY2FzZSBDU1NWYWx1ZUluaXRpYWw6Ci0gICAgICAgICAgICBj YXNlIENTU1ZhbHVlSW5oZXJpdDoKICAgICAgICAgICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAg ICAgICAgICAgIGNhc2UgQ1NTVmFsdWVDb250ZW50czoKICAgICAgICAgICAgIGNhc2UgQ1NTVmFs dWVTY3JvbGxQb3NpdGlvbjoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIv Q1NTUHJvcGVydHlQYXJzZXJIZWxwZXJzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIv Q1NTUHJvcGVydHlQYXJzZXJIZWxwZXJzLmNwcAppbmRleCA1NzA2Njg0ZjdkNjZjNzFlNzk0MTgx NjdmMGU3OTdlOTBhNTRkNTQ5Li4xMzY0MzhjNTExMDA2NDlhYWM1YTU3NTQyYmY5NDFiMzIwMmM5 ZDJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFy c2VySGVscGVycy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQcm9wZXJ0 eVBhcnNlckhlbHBlcnMuY3BwCkBAIC01NSw3ICs1NSw3IEBAIG5hbWVzcGFjZSBDU1NQcm9wZXJ0 eVBhcnNlckhlbHBlcnMgewogCiBzdGF0aWMgaW5saW5lIGJvb2wgaXNDU1NXaWRlS2V5d29yZChD U1NWYWx1ZUlEIGlkKQogewotICAgIHJldHVybiBpZCA9PSBDU1NWYWx1ZUluaXRpYWwgfHwgaWQg PT0gQ1NTVmFsdWVJbmhlcml0IHx8IGlkID09IENTU1ZhbHVlVW5zZXQgfHwgaWQgPT0gQ1NTVmFs dWVSZXZlcnQgfHwgaWQgPT0gQ1NTVmFsdWVEZWZhdWx0OworICAgIHJldHVybiBpZCA9PSBDU1NW YWx1ZUluaXRpYWwgfHwgaWQgPT0gQ1NTVmFsdWVJbmhlcml0IHx8IGlkID09IENTU1ZhbHVlVW5z ZXQgfHwgaWQgPT0gQ1NTVmFsdWVSZXZlcnQ7CiB9CiAKIGJvb2wgY29uc3VtZUNvbW1hSW5jbHVk aW5nV2hpdGVzcGFjZShDU1NQYXJzZXJUb2tlblJhbmdlJiByYW5nZSkK 426552 2021-04-20 09:01:54 -0700 2021-04-21 14:44:39 -0700 Patch bug-224815-20210420180152.patch text/plain 2445 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjFlNTNiNDBjYjRkYjQw YTk2MWJlY2U0OWU5Y2ViNzdkMzQ4Mzc2Yy4uZDE1ZTQ1NDM0MzMzMjMzMDQxNjFhYjE0ZWM5MDEy YmE0ODNkNzkwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA0LTIwICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGlzQ1NTV2lkZUtleXdvcmQg dG8gc3RvcCBpbmNsdWRpbmcgYGRlZmF1bHRgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ4MTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBbHNvIHJlcGxhY2VkIGFuIGluY29ycmVjdCB1c2Ugb2YgQ1NT VmFsdWVEZWZhdWx0IGluIHRoZSB3aWxsLWNoYW5nZSBwcm9wZXJ0eS4KKworICAgICAgICAqIGNz cy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y29uc3Vt ZVdpbGxDaGFuZ2UpOgorICAgICAgICAqIGNzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXJIZWxw ZXJzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1Byb3BlcnR5UGFyc2VySGVscGVyczo6aXND U1NXaWRlS2V5d29yZCk6CisKIDIwMjEtMDQtMjAgIEtpbW1vIEtpbm51bmVuICA8a2tpbm51bmVu QGFwcGxlLmNvbT4KIAogICAgICAgICBBdWRpb1NvdXJjZVByb3ZpZGVyQVZGT2JqQyB1c2VzIGF0 b21pYyB2YXJpYWJsZXMgYnV0IGFsc28gbG9ja3Mgd2l0aCBtdXRleApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmNwcAppbmRleCBlNTE0YzM5OGI0NWI3 MzhmOTBhYTEwNzZjMTI2NWExZTY4OGNkNjVjLi43NDYwMThiNmQyNTc0OTJhYzU4ODMyYmY0Nzlh MjM4YmYwY2ZiZTIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1By b3BlcnR5UGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3Bl cnR5UGFyc2VyLmNwcApAQCAtNTAyLDkgKzUwMiwxMCBAQCBzdGF0aWMgUmVmUHRyPENTU1ZhbHVl PiBjb25zdW1lV2lsbENoYW5nZShDU1NQYXJzZXJUb2tlblJhbmdlJiByYW5nZSkKICAgICAgICAg ICAgIGNhc2UgQ1NTVmFsdWVOb25lOgogICAgICAgICAgICAgY2FzZSBDU1NWYWx1ZUFsbDoKICAg ICAgICAgICAgIGNhc2UgQ1NTVmFsdWVBdXRvOgotICAgICAgICAgICAgY2FzZSBDU1NWYWx1ZURl ZmF1bHQ6CiAgICAgICAgICAgICBjYXNlIENTU1ZhbHVlSW5pdGlhbDoKICAgICAgICAgICAgIGNh c2UgQ1NTVmFsdWVJbmhlcml0OgorICAgICAgICAgICAgY2FzZSBDU1NWYWx1ZVVuc2V0OgorICAg ICAgICAgICAgY2FzZSBDU1NWYWx1ZVJldmVydDoKICAgICAgICAgICAgICAgICByZXR1cm4gbnVs bHB0cjsKICAgICAgICAgICAgIGNhc2UgQ1NTVmFsdWVDb250ZW50czoKICAgICAgICAgICAgIGNh c2UgQ1NTVmFsdWVTY3JvbGxQb3NpdGlvbjoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXJIZWxwZXJzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXJIZWxwZXJzLmNwcAppbmRleCA1NzA2Njg0ZjdkNjZj NzFlNzk0MTgxNjdmMGU3OTdlOTBhNTRkNTQ5Li4xMzY0MzhjNTExMDA2NDlhYWM1YTU3NTQyYmY5 NDFiMzIwMmM5ZDJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1By b3BlcnR5UGFyc2VySGVscGVycy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9D U1NQcm9wZXJ0eVBhcnNlckhlbHBlcnMuY3BwCkBAIC01NSw3ICs1NSw3IEBAIG5hbWVzcGFjZSBD U1NQcm9wZXJ0eVBhcnNlckhlbHBlcnMgewogCiBzdGF0aWMgaW5saW5lIGJvb2wgaXNDU1NXaWRl S2V5d29yZChDU1NWYWx1ZUlEIGlkKQogewotICAgIHJldHVybiBpZCA9PSBDU1NWYWx1ZUluaXRp YWwgfHwgaWQgPT0gQ1NTVmFsdWVJbmhlcml0IHx8IGlkID09IENTU1ZhbHVlVW5zZXQgfHwgaWQg PT0gQ1NTVmFsdWVSZXZlcnQgfHwgaWQgPT0gQ1NTVmFsdWVEZWZhdWx0OworICAgIHJldHVybiBp ZCA9PSBDU1NWYWx1ZUluaXRpYWwgfHwgaWQgPT0gQ1NTVmFsdWVJbmhlcml0IHx8IGlkID09IENT U1ZhbHVlVW5zZXQgfHwgaWQgPT0gQ1NTVmFsdWVSZXZlcnQ7CiB9CiAKIGJvb2wgY29uc3VtZUNv bW1hSW5jbHVkaW5nV2hpdGVzcGFjZShDU1NQYXJzZXJUb2tlblJhbmdlJiByYW5nZSkK