224812 2021-04-20 06:46:24 -0700 gtest.a exports symbols, causing link-time warning: direct access in function ... means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings. 2021-04-23 02:45:56 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=141912 InRadar P2 Normal --- 1 kkinnunen kkinnunen achristensen ap lingcherd_ho webkit-bug-importer oldest_to_newest 1752242 0 kkinnunen 2021-04-20 06:46:24 -0700 gtest.a exports symbols, causing link-time warning: direct access in function ... means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings. ld: warning: direct access in function 'testing::internal::SuiteApiResolver<testing::internal::(anonymous namespace)::FailureTest>::GetSetUpCaseOrSuite(char const*, int)' from file '/Users/kkinnunen/Build/Debug/libgtest.a(gtest-all.o)' to global weak symbol 'testing::Test::SetUpTestSuite()' from file '/Users/kkinnunen/Build/Debug/libTestWTF.a(AtomString.o)' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings. This is due to gtest.a static library is being compiled with dynamic library settings. This causes the symbols to be marked as default visibility. This is being worked around by hiding the symbols explicitly via ld flags This causes ld warning. 1752244 1 kkinnunen 2021-04-20 07:00:49 -0700 Chromium similar setup (at the time of writing): https://chromium.googlesource.com/chromium/src/+/master/third_party/googletest/BUILD.gn 1752245 2 426544 kkinnunen 2021-04-20 07:04:33 -0700 Created attachment 426544 Patch 1752445 3 ews-feeder 2021-04-20 15:06:25 -0700 Committed r276319 (236800@main): <https://commits.webkit.org/236800@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426544. 1753514 4 lingcherd_ho 2021-04-23 02:45:56 -0700 rdar://76920626 426544 2021-04-20 07:04:33 -0700 2021-04-20 15:06:26 -0700 Patch bug-224812-20210420170432.patch text/plain 6988 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKaW5kZXggM2Y3OTUyMWY1 YzI1MzY4ODQxZTQ1OTExYWQzOWIwNjkzMDM0MWM3Yi4uZDZkNWEyMDczOTc5ZTg3OTkxODIzNTI3 YjAwNzI0NjQ2NWVmMWViMyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIx LTA0LTIwICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CisKKyAgICAgICAg Z3Rlc3QuYSBleHBvcnRzIHN5bWJvbHMsIGNhdXNpbmcgbGluay10aW1lIHdhcm5pbmc6IGRpcmVj dCBhY2Nlc3MgaW4gZnVuY3Rpb24gLi4uIG1lYW5zIHRoZSB3ZWFrIHN5bWJvbCBjYW5ub3QgYmUg b3ZlcnJpZGRlbiBhdCBydW50aW1lLiBUaGlzIHdhcyBsaWtlbHkgY2F1c2VkIGJ5IGRpZmZlcmVu dCB0cmFuc2xhdGlvbiB1bml0cyBiZWluZyBjb21waWxlZCB3aXRoIGRpZmZlcmVudCB2aXNpYmls aXR5IHNldHRpbmdzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjI0ODEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ29tcGlsZSBhbmQgdXNlIGd0ZXN0IGFzIGEgc3RhdGljIGxpYnJhcnkgdGhhdCBkb2Vz IG5vdCBleHBvcnQgYW55IHN5bWJvbHMuCisgICAgICAgIEZpeGVzIGxpbmstdGltZSB3YXJuaW5n cyBhYm91dCBtaXNtYXRjaCBvZiBzeW1ib2wgdmlzaWJpbGl0eS4gVGhlIGVycm9yIG9jY3VycyB3 aGVuCisgICAgICAgIGd0ZXN0LmEgaXMgY29tcGlsZWQgZXhwb3J0aW5nIHN5bWJvbHMgd2l0aCBk ZWZhdWx0IHZpc2liaWxpdHksIGJ1dCB0aGUgY2xpZW50cyB1c2UgdGhlIGxpYnJhcnkKKyAgICAg ICAgYW5kIGhpZGUgdGhlIHN5bWJvbHMgdmlhIGxkIGZsYWdzLgorCisgICAgICAgICogZ3Rlc3Qv eGNvZGUvQ29uZmlnL1N0YXRpY0xpYnJhcnlUYXJnZXQueGNjb25maWc6CisgICAgICAgIENvbXBp bGUgdGhlIHN0YXRpYyBndGVzdCB3aXRoIEdURVNUX0FQSV89CisKIDIwMjEtMDQtMDcgIERvbiBP bG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBbUGxheVN0YXRpb25d IERvIG5vdCBpbmNsdWRlIDxhbnk+IGluIGd0ZXN0IGJlY2F1c2UgaXQgcmVxdWlyZXMgUlRUSQpk aWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QveGNvZGUvQ29uZmlnL1N0YXRpY0xp YnJhcnlUYXJnZXQueGNjb25maWcgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdC94Y29kZS9Db25m aWcvU3RhdGljTGlicmFyeVRhcmdldC54Y2NvbmZpZwppbmRleCAwNGI3M2JjOTJkMDEyMWQ5NThm NWY4Njk5ZGFmMzc3ZWI2OThjMzlhLi5jMjU1NjNlYzUzMzViNjFiNjkzNjJmY2ViMjY2MTI0ZmFj Nzc4NWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdC94Y29kZS9Db25maWcv U3RhdGljTGlicmFyeVRhcmdldC54Y2NvbmZpZworKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9ndGVz dC94Y29kZS9Db25maWcvU3RhdGljTGlicmFyeVRhcmdldC54Y2NvbmZpZwpAQCAtMTcsNCArMTcs NiBAQCBTVFJJUF9TVFlMRSA9IGRlYnVnZ2luZwogLy8gTGV0IHRoZSB1c2VyIGluc3RhbGwgYnkg c3BlY2lmeWluZyB0aGUgJERTVFJPT1Qgd2l0aCB4Y29kZWJ1aWxkCiBTS0lQX0lOU1RBTEwgPSBO TwogCitHQ0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TID0gJChpbmhlcml0ZWQpIEdURVNUX0FQ SV89CisKIE9USEVSX0xERkxBR1MgPSA7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9U b29scy9DaGFuZ2VMb2cKaW5kZXggMDU5YzM3OTUzYTkwZWEyODY0NmQ0ZjBmZWFlOGYxMTI3ZTZh M2JkMC4uMDQ5YzRlNDdjODg2NGRkNWU1MTFmOTdjYzEwYjQzOGUxZmQ1OTZhZiAxMDA2NDQKLS0t IGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBA CisyMDIxLTA0LTIwICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CisKKyAg ICAgICAgZ3Rlc3QuYSBleHBvcnRzIHN5bWJvbHMsIGNhdXNpbmcgbGluay10aW1lIHdhcm5pbmc6 IGRpcmVjdCBhY2Nlc3MgaW4gZnVuY3Rpb24gLi4uIG1lYW5zIHRoZSB3ZWFrIHN5bWJvbCBjYW5u b3QgYmUgb3ZlcnJpZGRlbiBhdCBydW50aW1lLiBUaGlzIHdhcyBsaWtlbHkgY2F1c2VkIGJ5IGRp ZmZlcmVudCB0cmFuc2xhdGlvbiB1bml0cyBiZWluZyBjb21waWxlZCB3aXRoIGRpZmZlcmVudCB2 aXNpYmlsaXR5IHNldHRpbmdzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI0ODEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ29tcGlsZSBhbmQgdXNlIGd0ZXN0IGFzIGEgc3RhdGljIGxpYnJhcnkgdGhh dCBkb2VzIG5vdCBleHBvcnQgYW55IHN5bWJvbHMuCisgICAgICAgIEZpeGVzIGxpbmstdGltZSB3 YXJuaW5ncyBhYm91dCBtaXNtYXRjaCBvZiBzeW1ib2wgdmlzaWJpbGl0eS4gVGhlIGVycm9yIG9j Y3VycyB3aGVuCisgICAgICAgIGd0ZXN0LmEgaXMgY29tcGlsZWQgZXhwb3J0aW5nIHN5bWJvbHMg d2l0aCBkZWZhdWx0IHZpc2liaWxpdHksIGJ1dCB0aGUgY2xpZW50cyB1c2UgdGhlIGxpYnJhcnkK KyAgICAgICAgYW5kIGhpZGUgdGhlIHN5bWJvbHMgdmlhIGxkIGZsYWdzLgorCisgICAgICAgICog VGVzdFdlYktpdEFQSS9Db25maWd1cmF0aW9ucy9UZXN0V1RGLnhjY29uZmlnOgorICAgICAgICAq IFRlc3RXZWJLaXRBUEkvQ29uZmlndXJhdGlvbnMvVGVzdFdlYktpdEFQSS54Y2NvbmZpZzoKKyAg ICAgICAgQ29tcGlsZSB0aGUgZ3Rlc3QgY2xpZW50cyB3aXRoIEdURVNUX0FQSV89CisKIDIwMjEt MDQtMTkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OIChyMjc2MTg5KTogR1BVUHJvY2Vzcy5XZWJQcm9jZXNzVGVybWluYXRpb25BZnRlclRvb01h bnlHUFVQcm9jZXNzQ3Jhc2hlcyBpcyBjcmFzaGluZwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdl YktpdEFQSS9Db25maWd1cmF0aW9ucy9UZXN0V1RGLnhjY29uZmlnIGIvVG9vbHMvVGVzdFdlYktp dEFQSS9Db25maWd1cmF0aW9ucy9UZXN0V1RGLnhjY29uZmlnCmluZGV4IGVhY2ZiMTIzNjA5ZTBl ZDA0NWU2NDA5MWMzNDc5ZTA4MjUzYmZjMGUuLmUyNzVkMWVhODdlNzc4NTdiZDM2MzU5N2QyY2Nl ZjhjNTU4ZmRiNGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ29uZmlndXJhdGlv bnMvVGVzdFdURi54Y2NvbmZpZworKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRp b25zL1Rlc3RXVEYueGNjb25maWcKQEAgLTI3LDExICsyNyw5IEBAIExJQlJBUllfU0VBUkNIX1BB VEhTID0gJChQUk9KRUNUX0RJUikvVGVzdHMvV1RGL2RhcndpbiAkKGluaGVydGllZCk7CiAKIEdD Q19FTkFCTEVfT0JKQ19FWENFUFRJT05TID0gWUVTOwogCi1HQ0NfUFJFUFJPQ0VTU09SX0RFRklO SVRJT05TID0gJChpbmhlcml0ZWQpIEJVSUxESU5HX1RFU1RfV1RGCitHQ0NfUFJFUFJPQ0VTU09S X0RFRklOSVRJT05TID0gJChpbmhlcml0ZWQpIEJVSUxESU5HX1RFU1RfV1RGIEdURVNUX0FQSV89 CiAKLVVORVhQT1JURURfU1lNQk9MX0xERkxBR1MgPSAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sIC1X bCxfX1pON3Rlc3Rpbmc0VGVzdDE2VGVhckRvd25UZXN0Q2FzZUV2IC1XbCwtdW5leHBvcnRlZF9z eW1ib2wgLVdsLF9fWk43dGVzdGluZzRUZXN0MTNTZXRVcFRlc3RDYXNlRXYKLQotT1RIRVJfTERG TEFHUyA9ICQoaW5oZXJpdGVkKSAkKFVORVhQT1JURURfU1lNQk9MX0xERkxBR1MpIC1sZ3Rlc3Qg LWZvcmNlX2xvYWQgJChCVUlMVF9QUk9EVUNUU19ESVIpL2xpYlRlc3RXVEYuYSAkKE9USEVSX0xE RkxBR1NfUExBVEZPUk0pOworT1RIRVJfTERGTEFHUyA9ICQoaW5oZXJpdGVkKSAtbGd0ZXN0IC1m b3JjZV9sb2FkICQoQlVJTFRfUFJPRFVDVFNfRElSKS9saWJUZXN0V1RGLmEgJChPVEhFUl9MREZM QUdTX1BMQVRGT1JNKTsKIE9USEVSX0xERkxBR1NfUExBVEZPUk1bc2RrPW1hY29zeCpdID0gLWZy YW1ld29yayBDb2NvYSAtZnJhbWV3b3JrIENhcmJvbjsKIAogLy8gRklYTUU6IFRoaXMgc2hvdWxk IG5vdCBiZSBidWlsdCBvbiBpT1MuIEluc3RlYWQgd2Ugc2hvdWxkIGNyZWF0ZSBhbmQgdXNlIGEg VGVzdFdURiBhcHBsaWNhdGlvbi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvQ29u ZmlndXJhdGlvbnMvVGVzdFdlYktpdEFQSS54Y2NvbmZpZyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv Q29uZmlndXJhdGlvbnMvVGVzdFdlYktpdEFQSS54Y2NvbmZpZwppbmRleCA5ZDRkZGQwMjQ0YTcy ODU0ZGM4NmIxYjkzOTZlODNhYWI1NDgzNWFjLi4wODRkOWYyMmU3OGQxZjQ4YTMxNTU0MzNhMjhm OGJhNjQxNzZmMzU4IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL0NvbmZpZ3VyYXRp b25zL1Rlc3RXZWJLaXRBUEkueGNjb25maWcKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9Db25m aWd1cmF0aW9ucy9UZXN0V2ViS2l0QVBJLnhjY29uZmlnCkBAIC0yNyw2ICsyNyw4IEBAIFBST0RV Q1RfTkFNRSA9IFRlc3RXZWJLaXRBUEk7CiBQUk9EVUNUX0JVTkRMRV9JREVOVElGSUVSID0gY29t LmFwcGxlLldlYktpdC5UZXN0V2ViS2l0QVBJOwogR0NDX0VOQUJMRV9PQkpDX0VYQ0VQVElPTlMg PSBZRVM7CiAKK0dDQ19QUkVQUk9DRVNTT1JfREVGSU5JVElPTlMgPSAkKGluaGVyaXRlZCkgR1RF U1RfQVBJXz0KKwogV0tfUFJJVkFURV9GUkFNRVdPUktTX0RJUiA9ICQoV0tfUFJJVkFURV9GUkFN RVdPUktTX0RJUl8kKFVTRV9JTlRFUk5BTF9TREspKTsKIFdLX1BSSVZBVEVfRlJBTUVXT1JLU19E SVJfW3Nkaz1tYWNvcypdID0gJChQUk9KRUNUX0RJUikvLi4vLi4vV2ViS2l0TGlicmFyaWVzL1dl YktpdFByaXZhdGVGcmFtZXdvcmtTdHVicy9NYWMvJChUQVJHRVRfTUFDX09TX1hfVkVSU0lPTl9N QUpPUik7CiBXS19QUklWQVRFX0ZSQU1FV09SS1NfRElSX1tzZGs9aXBob25lKl0gPSAkKFBST0pF Q1RfRElSKS8uLi8uLi9XZWJLaXRMaWJyYXJpZXMvV2ViS2l0UHJpdmF0ZUZyYW1ld29ya1N0dWJz L2lPUy8kKFdLX1RBUkdFVF9JT1NfVkVSU0lPTl9NQUpPUik7CkBAIC00MSw4ICs0Myw2IEBAIEZS QU1FV09SS19TRUFSQ0hfUEFUSFMgPSAkKEZSQU1FV09SS19TRUFSQ0hfUEFUSFNfJChXS19DT0NP QV9UT1VDSCkpOwogRlJBTUVXT1JLX1NFQVJDSF9QQVRIU18gPSAkKGluaGVyaXRlZCkgJChXS19Q UklWQVRFX0ZSQU1FV09SS1NfRElSKSAkKFNZU1RFTV9MSUJSQVJZX0RJUikvUHJpdmF0ZUZyYW1l d29ya3MgJChTWVNURU1fTElCUkFSWV9ESVIpL0ZyYW1ld29ya3MvV2ViS2l0LmZyYW1ld29yay9W ZXJzaW9ucy9BL0ZyYW1ld29ya3M7CiBGUkFNRVdPUktfU0VBUkNIX1BBVEhTX2NvY29hdG91Y2gg PSAkKGluaGVyaXRlZCkgJChXS19QUklWQVRFX0ZSQU1FV09SS1NfRElSKTsKIAotVU5FWFBPUlRF RF9TWU1CT0xfTERGTEFHUyA9IC1XbCwtdW5leHBvcnRlZF9zeW1ib2wgLVdsLF9fWk43dGVzdGlu ZzRUZXN0MTZUZWFyRG93blRlc3RDYXNlRXYgLVdsLC11bmV4cG9ydGVkX3N5bWJvbCAtV2wsX19a Tjd0ZXN0aW5nNFRlc3QxM1NldFVwVGVzdENhc2VFdgotCiBXS19BVVRIS0lUX0xERkxBR1MgPSAk KFdLX0FVVEhLSVRfTERGTEFHU18kKFdLX1BMQVRGT1JNX05BTUUpKTsKIFdLX0FVVEhLSVRfTERG TEFHU19pcGhvbmVvcyA9ICQoV0tfQVVUSEtJVF9MREZMQUdTJChXS19JT1NfMTMpKTsKIFdLX0FV VEhLSVRfTERGTEFHU19pcGhvbmVzaW11bGF0b3IgPSAkKFdLX0FVVEhLSVRfTERGTEFHUyQoV0tf SU9TXzEzKSk7CkBAIC03OCw3ICs3OCw3IEBAIFdLX09QRU5HTF9MREZMQUdTX2FwcGxldHZvcyA9 ICQoV0tfT1BFTkdMX0xERkxBR1NfaXBob25lb3MpOwogV0tfT1BFTkdMX0xERkxBR1NfYXBwbGV0 dnNpbXVsYXRvciA9ICQoV0tfT1BFTkdMX0xERkxBR1NfaXBob25lc2ltdWxhdG9yKTsKIFdLX09Q RU5HTF9MREZMQUdTX21hY29zeCA9IC1mcmFtZXdvcmsgT3BlbkdMOwogCi1PVEhFUl9MREZMQUdT ID0gJChpbmhlcml0ZWQpICQoVU5FWFBPUlRFRF9TWU1CT0xfTERGTEFHUykgLWxndGVzdCAtZm9y Y2VfbG9hZCAkKEJVSUxUX1BST0RVQ1RTX0RJUikvbGliVGVzdFdlYktpdEFQSS5hIC1mcmFtZXdv cmsgSmF2YVNjcmlwdENvcmUgLWZyYW1ld29yayBXZWJLaXQgLWxXZWJDb3JlVGVzdFN1cHBvcnQg JChXS19BVVRIS0lUX0xERkxBR1MpIC1mcmFtZXdvcmsgTmV0d29yayAkKFdLX1NZU1RFTV9MREZM QUdTKSAkKFdLX1BERktJVF9MREZMQUdTKSAkKFdLX0hJRF9MREZMQUdTKSAkKFdLX09QRU5HTF9M REZMQUdTKSAkKE9USEVSX0xERkxBR1NfUExBVEZPUk1fJChXS19DT0NPQV9UT1VDSCkpOworT1RI RVJfTERGTEFHUyA9ICQoaW5oZXJpdGVkKSAtbGd0ZXN0IC1mb3JjZV9sb2FkICQoQlVJTFRfUFJP RFVDVFNfRElSKS9saWJUZXN0V2ViS2l0QVBJLmEgLWZyYW1ld29yayBKYXZhU2NyaXB0Q29yZSAt ZnJhbWV3b3JrIFdlYktpdCAtbFdlYkNvcmVUZXN0U3VwcG9ydCAkKFdLX0FVVEhLSVRfTERGTEFH UykgLWZyYW1ld29yayBOZXR3b3JrICQoV0tfU1lTVEVNX0xERkxBR1MpICQoV0tfUERGS0lUX0xE RkxBR1MpICQoV0tfSElEX0xERkxBR1MpICQoV0tfT1BFTkdMX0xERkxBR1MpICQoT1RIRVJfTERG TEFHU19QTEFURk9STV8kKFdLX0NPQ09BX1RPVUNIKSk7CiBPVEhFUl9MREZMQUdTX1BMQVRGT1JN XyA9IC1mcmFtZXdvcmsgQ29jb2EgLWZyYW1ld29yayBDYXJib247CiAKIC8vIEZJWE1FOiBUaGlz IHNob3VsZCBub3QgYmUgYnVpbHQgb24gaU9TLiBJbnN0ZWFkIHdlIHNob3VsZCBjcmVhdGUgYW5k IHVzZSBhIFRlc3RXZWJLaXRBUEkgYXBwbGljYXRpb24uCg==