224778 2021-04-19 12:12:56 -0700 MotionMark's Canvas-Arcs subtest is broken if the GPUProcess is not yet running 2021-04-20 11:24:00 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 224798 https://bugs.webkit.org/show_bug.cgi?id=224770 https://bugs.webkit.org/show_bug.cgi?id=224556 https://bugs.webkit.org/show_bug.cgi?id=224623 https://bugs.webkit.org/show_bug.cgi?id=224516 InRadar P2 Normal --- 224781 1 cdumez cdumez kkinnunen sabouhallawa simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1751899 0 cdumez 2021-04-19 12:12:56 -0700 MotionMark's Canvas-Arcs subtest is broken if the GPUProcess is not yet running. 1751908 1 426458 cdumez 2021-04-19 12:18:56 -0700 Created attachment 426458 Patch 1751941 2 426458 simon.fraser 2021-04-19 13:30:47 -0700 Comment on attachment 426458 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426458&action=review > Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:78 > + // FIXME: This message shouldn't need to be synchronous. However, we seem to get in a bad state when this message is asynchronous and the GPUProcess has just launched. Would be good to have a bug link here. 1751945 3 cdumez 2021-04-19 13:36:06 -0700 Committed r276271 (236753@main): <https://commits.webkit.org/236753@main> 1752116 4 cdumez 2021-04-19 20:21:55 -0700 It doesn't look like this helped on the bots :/ I may need some help here. I suspect the display list logic either gets into a bad state or is dropping some initial work. It is fairly easy to get in that bad state if constructing the RemoteRenderingBackendProxy launches the GPUProcess (which I made a lot more common since the GPUProcess is now only launched when needed). I spent quite some time trying to understand the DisplayList IPC logic but it is fairly complicated. When running MotionMark's Canvas-Arcs, in the success case, I see RemoteRenderingBackend::didCreateSharedDisplayListHandle() getting called at least 4 times. However, in the failure case, it seems RemoteRenderingBackend::didCreateSharedDisplayListHandle() is only called once. I have no idea why this could be happening. Wenson, do you have any idea? In both failure and success cases, I see many calls to RemoteRenderingBackend::wakeUpAndApplyDisplayList() and the initialization stage (GPUConnectionToWebProcess::createRenderingBackend & RemoteRenderingBackend::createImageBuffer) looks the same. 1752142 5 ryanhaddad 2021-04-19 22:14:49 -0700 rdar://76860669 1752257 6 cdumez 2021-04-20 07:52:05 -0700 Reverted r276271 for reason: It did not fix the Canvas-Arcs subtest on the bots Committed r276304 (236786@main): <https://commits.webkit.org/236786@main> 1752322 7 cdumez 2021-04-20 10:27:07 -0700 Oh, what I was reproducing had nothing to do with the GPUProcess and was actually flakily reproducing with the GPUProcess disabled. I tried on another iPad and I finally have reproduced what I think the bots are experiencing. The GPUProcess exits very shortly after launch due to memory pressure, repeatedly. I think https://commits.webkit.org/236787@main will fix this. 1752347 8 cdumez 2021-04-20 11:24:00 -0700 *** This bug has been marked as a duplicate of bug 224798 *** 426458 2021-04-19 12:18:56 -0700 2021-04-20 08:51:08 -0700 Patch bug-224778-20210419121856.patch text/plain 6463 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYzNDZiOGE4YWJlMTFmZTM3 ODQ1NGU4ZjcyZDhiZDBhZDVmMzVlNTUuLjM1YTAyYTI5NDVmNGI2ZjJlMDJiNWRhN2JkYjE5OTBk N2M0MGU3MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMjEtMDQtMTkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBNb3Rpb25NYXJrJ3MgQ2FudmFzLUFy Y3Mgc3VidGVzdCBpcyBicm9rZW4gaWYgdGhlIEdQVVByb2Nlc3MgaXMgbm90IHlldCBydW5uaW5n CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ3NzgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIHJlY2Vu dGx5IG1hZGUgY2hhbmdlcyBzbyB0aGF0IHRoZSBHUFVQcm9jZXNzIGlzIG9ubHkgbGF1bmNoZWQg d2hlbiBpdCBpcyBuZWVkZWQuIFRoaXMgbWVhbnMKKyAgICAgICAgdGhhdCB1bnRpbCBNb3Rpb25N YXJrJ3MgQ2FudmFzLUFyY3Mgc3VidGVzdCwgdGhlIEdQVVByb2Nlc3MgaXMgdXN1YWxseSBub3Qg eWV0IHJ1bm5pbmcuIEFzIGEKKyAgICAgICAgcmVzdWx0LCBSZW1vdGVSZW5kZXJpbmdCYWNrZW5k UHJveHk6OmNyZWF0ZUltYWdlQnVmZmVyKCkgZW5kcyB1cCBsYXVuY2hpbmcgdGhlIEdQVVByb2Nl c3MKKyAgICAgICAgYW5kIHNlbmRpbmcgdGhlIEdQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OkNy ZWF0ZVJlbmRlcmluZ0JhY2tlbmQgYW5kCisgICAgICAgIFJlbW90ZVJlbmRlcmluZ0JhY2tlbmQ6 OkNyZWF0ZUltYWdlQnVmZmVyIElQQyByaWdodCBhd2F5LiBXZSBzZWVtIHRvIGhhdmUgYSBzeW5j aHJvbml6YXRpb24KKyAgICAgICAgaXNzdWUgYmVjYXVzZSB3aGVuIHRoaXMgaGFwcGVucywgdGhl IHJlbmRlcmluZyBmb3IgdGhlIENhbnZhcy1BcmNzIHN1YnRlc3QgaXMgdmlzaWJseSBicm9rZW4K KyAgICAgICAgYW5kIGl0cyBzY29yZSBpcyB2ZXJ5IGxvdyAoPCA2LCBpbnN0ZWFkIG9mID4gNjAw KS4KKworICAgICAgICBNYWtpbmcgdGhlIEdQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OkNyZWF0 ZVJlbmRlcmluZ0JhY2tlbmQgc3luY2hyb25vdXMgYWdhaW4gKEkgbWFkZSBpdAorICAgICAgICBh c3luYyByZWNlbnRseSkgc2VlbXMgdG8gYWRkcmVzcyB0aGUgc3luY2hyb25pemF0aW9uIGlzc3Vl IGFuZCByZXN0b3JlcyBjb3JyZWN0IGJlaGF2aW9yIG9uCisgICAgICAgIE1vdGlvbk1hcmsuIEkg YW0gdGhlcmVmb3JlIG1ha2luZyB0aGlzIElQQyBzeW5jaHJvbm91cyBhZ2FpbiBpbiB0aGlzIHBh dGNoIHRvIGdldCBiZW5jaG1hcmsKKyAgICAgICAgY292ZXJhZ2UgYWdhaW4gd2hpbGUgSSBpbnZl c3RpZ2F0ZSB0aGUgcm9vdCBjYXVzZSBvZmZsaW5lLgorCisgICAgICAgICogR1BVUHJvY2Vzcy9H UFVDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6R1BVQ29ubmVj dGlvblRvV2ViUHJvY2Vzczo6Y3JlYXRlUmVuZGVyaW5nQmFja2VuZCk6CisgICAgICAgICogR1BV UHJvY2Vzcy9HUFVDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmg6CisgICAgICAgICogR1BVUHJvY2Vz cy9HUFVDb25uZWN0aW9uVG9XZWJQcm9jZXNzLm1lc3NhZ2VzLmluOgorICAgICAgICAqIFdlYlBy b2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZVJlbmRlcmluZ0JhY2tlbmRQcm94eS5jcHA6CisgICAg ICAgIChXZWJLaXQ6OlJlbW90ZVJlbmRlcmluZ0JhY2tlbmRQcm94eTo6ZW5zdXJlR1BVUHJvY2Vz c0Nvbm5lY3Rpb24pOgorCiAyMDIxLTA0LTE5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5j b20+CiAKICAgICAgICAgRml4IHJhY2VzIGluIExpYldlYlJUQ0NvZGVjcyBpbnRyb2R1Y2VkIGlu IHIyNzYyMTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9HUFVDb25uZWN0 aW9uVG9XZWJQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9HUFVDb25uZWN0 aW9uVG9XZWJQcm9jZXNzLmNwcAppbmRleCA4ODIxZWYxYjBkOWI5ZmQ0MDQ0ZThhNThlMjFjMjky OGQxMTM1YzU2Li41ZWYxZGFkZDI4MmE4Y2M0Y2JjMjhhOGUzZmI0MGMwZWM2ZmY2YTA2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvR1BVQ29ubmVjdGlvblRvV2ViUHJvY2Vz cy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL0dQVUNvbm5lY3Rpb25Ub1dlYlBy b2Nlc3MuY3BwCkBAIC00MDksMTIgKzQwOSwxMyBAQCBSZW1vdGVJbWFnZURlY29kZXJBVkZQcm94 eSYgR1BVQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6aW1hZ2VEZWNvZGVyQVZGUHJveHkoKQogfQog I2VuZGlmCiAKLXZvaWQgR1BVQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6Y3JlYXRlUmVuZGVyaW5n QmFja2VuZChSZW1vdGVSZW5kZXJpbmdCYWNrZW5kQ3JlYXRpb25QYXJhbWV0ZXJzJiYgY3JlYXRp b25QYXJhbWV0ZXJzKQordm9pZCBHUFVDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpjcmVhdGVSZW5k ZXJpbmdCYWNrZW5kKFJlbW90ZVJlbmRlcmluZ0JhY2tlbmRDcmVhdGlvblBhcmFtZXRlcnMmJiBj cmVhdGlvblBhcmFtZXRlcnMsIENvbXBsZXRpb25IYW5kbGVyPHZvaWQoKT4mJiBjb21wbGV0aW9u SGFuZGxlcikKIHsKICAgICBhdXRvIGFkZFJlc3VsdCA9IG1fcmVtb3RlUmVuZGVyaW5nQmFja2Vu ZE1hcC5lbnN1cmUoY3JlYXRpb25QYXJhbWV0ZXJzLmlkZW50aWZpZXIsIFsmXSgpIHsKICAgICAg ICAgcmV0dXJuIElQQzo6U2NvcGVkQWN0aXZlTWVzc2FnZVJlY2VpdmVRdWV1ZSB7IFJlbW90ZVJl bmRlcmluZ0JhY2tlbmQ6OmNyZWF0ZSgqdGhpcywgV1RGTW92ZShjcmVhdGlvblBhcmFtZXRlcnMp KSB9OwogICAgIH0pOwogICAgIEFTU0VSVF9VTlVTRUQoYWRkUmVzdWx0LCBhZGRSZXN1bHQuaXNO ZXdFbnRyeSk7CisgICAgY29tcGxldGlvbkhhbmRsZXIoKTsKIH0KIAogdm9pZCBHUFVDb25uZWN0 aW9uVG9XZWJQcm9jZXNzOjpyZWxlYXNlUmVuZGVyaW5nQmFja2VuZChSZW5kZXJpbmdCYWNrZW5k SWRlbnRpZmllciByZW5kZXJpbmdCYWNrZW5kSWRlbnRpZmllcikKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvR1BVUHJvY2Vzcy9HUFVDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmggYi9Tb3VyY2Uv V2ViS2l0L0dQVVByb2Nlc3MvR1BVQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5oCmluZGV4IGI4NGE4 ZjgzNjdiNGExMWM5ZmViYzMyMTFmZjVhYmM4MTIxNjgxNzAuLmNhMGNkZDlhOTI2YmJiNjkyNWU2 NGFjNzk4NzUxZjczN2JiM2RhMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vz cy9HUFVDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmgKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9j ZXNzL0dQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3MuaApAQCAtMTYzLDcgKzE2Myw3IEBAIHByaXZh dGU6CiAgICAgUmVtb3RlTWVkaWFSZWNvcmRlck1hbmFnZXImIG1lZGlhUmVjb3JkZXJNYW5hZ2Vy KCk7CiAjZW5kaWYKIAotICAgIHZvaWQgY3JlYXRlUmVuZGVyaW5nQmFja2VuZChSZW1vdGVSZW5k ZXJpbmdCYWNrZW5kQ3JlYXRpb25QYXJhbWV0ZXJzJiYpOworICAgIHZvaWQgY3JlYXRlUmVuZGVy aW5nQmFja2VuZChSZW1vdGVSZW5kZXJpbmdCYWNrZW5kQ3JlYXRpb25QYXJhbWV0ZXJzJiYsIENv bXBsZXRpb25IYW5kbGVyPHZvaWQoKT4mJik7CiAgICAgdm9pZCByZWxlYXNlUmVuZGVyaW5nQmFj a2VuZChSZW5kZXJpbmdCYWNrZW5kSWRlbnRpZmllcik7CiAKICNpZiBFTkFCTEUoV0VCR0wpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvR1BVQ29ubmVjdGlvblRvV2ViUHJv Y2Vzcy5tZXNzYWdlcy5pbiBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9HUFVDb25uZWN0aW9u VG9XZWJQcm9jZXNzLm1lc3NhZ2VzLmluCmluZGV4IDc3NDU1OGUxMDc1MzdhODIxZjE2MGVkMzNj NmY5NTlmNzBmZThmM2EuLjhkMWRhZjg2ZGRjMjRmYThjZWI5MmIwZTQ3NzgxYTZjZTI4YjkyNjMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9HUFVDb25uZWN0aW9uVG9XZWJQ cm9jZXNzLm1lc3NhZ2VzLmluCisrKyBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9HUFVDb25u ZWN0aW9uVG9XZWJQcm9jZXNzLm1lc3NhZ2VzLmluCkBAIC0yMyw3ICsyMyw3IEBACiAjaWYgRU5B QkxFKEdQVV9QUk9DRVNTKQogCiBtZXNzYWdlcyAtPiBHUFVDb25uZWN0aW9uVG9XZWJQcm9jZXNz IFdhbnRzRGlzcGF0Y2hNZXNzYWdlIHsKLSAgICB2b2lkIENyZWF0ZVJlbmRlcmluZ0JhY2tlbmQo c3RydWN0IFdlYktpdDo6UmVtb3RlUmVuZGVyaW5nQmFja2VuZENyZWF0aW9uUGFyYW1ldGVycyBj cmVhdGlvblBhcmFtZXRlcnMpCisgICAgdm9pZCBDcmVhdGVSZW5kZXJpbmdCYWNrZW5kKHN0cnVj dCBXZWJLaXQ6OlJlbW90ZVJlbmRlcmluZ0JhY2tlbmRDcmVhdGlvblBhcmFtZXRlcnMgY3JlYXRp b25QYXJhbWV0ZXJzKSAtPiAoKSBTeW5jaHJvbm91cwogICAgIHZvaWQgUmVsZWFzZVJlbmRlcmlu Z0JhY2tlbmQoV2ViS2l0OjpSZW5kZXJpbmdCYWNrZW5kSWRlbnRpZmllciByZW5kZXJpbmdCYWNr ZW5kSWRlbnRpZmllcikKICNpZiBFTkFCTEUoV0VCR0wpCiAgICAgdm9pZCBDcmVhdGVHcmFwaGlj c0NvbnRleHRHTChzdHJ1Y3QgV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0R0xBdHRyaWJ1dGVzIGF0 dHJpYnV0ZXMsIFdlYktpdDo6R3JhcGhpY3NDb250ZXh0R0xJZGVudGlmaWVyIGdyYXBoaWNzQ29u dGV4dEdMSWRlbnRpZmllciwgV2ViS2l0OjpSZW5kZXJpbmdCYWNrZW5kSWRlbnRpZmllciByZW5k ZXJpbmdCYWNrZW5kSWRlbnRpZmllciwgSVBDOjpTdHJlYW1Db25uZWN0aW9uQnVmZmVyIHN0cmVh bSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvUmVt b3RlUmVuZGVyaW5nQmFja2VuZFByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9H UFUvZ3JhcGhpY3MvUmVtb3RlUmVuZGVyaW5nQmFja2VuZFByb3h5LmNwcAppbmRleCBkMGRjYTYz ZDJkOTgzZDcyMmI1YTkxMmE3YjU1MzQxMjAyMDk1MmExLi5iNDNmNTc5MTQzOWQyZjY4NTJhZWQ3 NzI2YWQyMjRmYWJkYTI5MmZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv R1BVL2dyYXBoaWNzL1JlbW90ZVJlbmRlcmluZ0JhY2tlbmRQcm94eS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1vdGVSZW5kZXJpbmdCYWNrZW5kUHJv eHkuY3BwCkBAIC03NSw3ICs3NSw4IEBAIEdQVVByb2Nlc3NDb25uZWN0aW9uJiBSZW1vdGVSZW5k ZXJpbmdCYWNrZW5kUHJveHk6OmVuc3VyZUdQVVByb2Nlc3NDb25uZWN0aW9uKCkKICAgICAgICAg YXV0byYgZ3B1UHJvY2Vzc0Nvbm5lY3Rpb24gPSBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5lbnN1 cmVHUFVQcm9jZXNzQ29ubmVjdGlvbigpOwogICAgICAgICBncHVQcm9jZXNzQ29ubmVjdGlvbi5h ZGRDbGllbnQoKnRoaXMpOwogICAgICAgICBncHVQcm9jZXNzQ29ubmVjdGlvbi5tZXNzYWdlUmVj ZWl2ZXJNYXAoKS5hZGRNZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OlJlbW90ZVJlbmRlcmluZ0Jh Y2tlbmRQcm94eTo6bWVzc2FnZVJlY2VpdmVyTmFtZSgpLCByZW5kZXJpbmdCYWNrZW5kSWRlbnRp ZmllcigpLnRvVUludDY0KCksICp0aGlzKTsKLSAgICAgICAgZ3B1UHJvY2Vzc0Nvbm5lY3Rpb24u Y29ubmVjdGlvbigpLnNlbmQoTWVzc2FnZXM6OkdQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OkNy ZWF0ZVJlbmRlcmluZ0JhY2tlbmQobV9wYXJhbWV0ZXJzKSwgMCwgSVBDOjpTZW5kT3B0aW9uOjpE aXNwYXRjaE1lc3NhZ2VFdmVuV2hlbldhaXRpbmdGb3JTeW5jUmVwbHkpOworICAgICAgICAvLyBG SVhNRTogVGhpcyBtZXNzYWdlIHNob3VsZG4ndCBuZWVkIHRvIGJlIHN5bmNocm9ub3VzLiBIb3dl dmVyLCB3ZSBzZWVtIHRvIGdldCBpbiBhIGJhZCBzdGF0ZSB3aGVuIHRoaXMgbWVzc2FnZSBpcyBh c3luY2hyb25vdXMgYW5kIHRoZSBHUFVQcm9jZXNzIGhhcyBqdXN0IGxhdW5jaGVkLgorICAgICAg ICBncHVQcm9jZXNzQ29ubmVjdGlvbi5jb25uZWN0aW9uKCkuc2VuZFN5bmMoTWVzc2FnZXM6OkdQ VUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OkNyZWF0ZVJlbmRlcmluZ0JhY2tlbmQobV9wYXJhbWV0 ZXJzKSwgTWVzc2FnZXM6OkdQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OkNyZWF0ZVJlbmRlcmlu Z0JhY2tlbmQ6OlJlcGx5KCksIDApOwogICAgICAgICBtX2dwdVByb2Nlc3NDb25uZWN0aW9uID0g bWFrZVdlYWtQdHIoZ3B1UHJvY2Vzc0Nvbm5lY3Rpb24pOwogICAgIH0KICAgICByZXR1cm4gKm1f Z3B1UHJvY2Vzc0Nvbm5lY3Rpb247Cg==