224777 2021-04-19 12:09:56 -0700 Web Inspector: Grid overlay column line label placement copy/paste error 2021-04-19 14:18:08 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 221972 1 pangle pangle ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1751894 0 pangle 2021-04-19 12:09:56 -0700 Bug 221972 added logic to place line labels inside the grid when there was not enough space outside of the grid. In that patch, there is a typo for column line label positioning where the line for the label does not extend from the top to the bottom of the column. In practice, this is not noticeable with the current logic, as only the first line will use the line for label placement, and all other columns use only the starting point of the line. None the less, this is currently wrong, and could complicate future fixes that assumed the line was actually a line and not a point in disguise. 1751895 1 webkit-bug-importer 2021-04-19 12:10:20 -0700 <rdar://problem/76856774> 1751911 2 426460 pangle 2021-04-19 12:22:52 -0700 Created attachment 426460 Patch v1.0 1751926 3 426460 hi 2021-04-19 13:05:33 -0700 Comment on attachment 426460 Patch v1.0 rs=me 1751969 4 ews-feeder 2021-04-19 14:18:07 -0700 Committed r276274 (236756@main): <https://commits.webkit.org/236756@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426460. 426460 2021-04-19 12:22:52 -0700 2021-04-19 14:18:07 -0700 Patch v1.0 bug-224777-20210419122251.patch text/plain 2438 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmIwM2Y1M2I2ZTAwNDYz MmVmZjU5NzJiZWFkZGI3MzA1MjZhNjZkYS4uZDUyZDJiYWUzMDU0NmFlNDBhMzRiN2E5NDA4NjFh Njk3NWE1ZDU2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA0LTE5ICBQYXRy aWNrIEFuZ2xlICA8cGFuZ2xlQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBH cmlkIG92ZXJsYXkgY29sdW1uIGxpbmUgbGFiZWwgcGxhY2VtZW50IGNvcHkvcGFzdGUgZXJyb3IK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDc3Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIGdyaWQg b3ZlcmxheXMsIGEgdHlwbyBtZWFudCBmb3IgYWxsIGNvbHVtbiBsaW5lIGxhYmVscyBhZnRlciB0 aGUgaW5pdGlhbCBsaW5lLCBvbmx5IHRoZSBzdGFydCBvZiB0aGUgbGluZSB3YXMKKyAgICAgICAg dXNlZCBmb3IgcGxhY2VtZW50LCB3aGVyZSBpdCBpcyBtb3JlIGFjY3VyYXRlIHRvIHVzZSB0aGUg c3RhcnQgYW5kIGVuZCBwb2ludHMgdG8gbWF0Y2ggdGhlIGJlaGF2aW9yIG9mIHRoZSBmaXJzdAor ICAgICAgICBsaW5lLiBUaGlzIGhhZCBubyB2aXN1YWwgaW1wYWN0IGJlY2F1c2Ugc3Vic2VxdWVu dCBsaW5lcyBkbyBub3QgY3VycmVudGx5IGhhdmUgdGhlaXIgbGFiZWxzIGFkanVzdGVkIGZ1cnRo ZXIgaW50bworICAgICAgICB0aGUgZ3JpZCwgb25seSBmbGlwcGVkIGludG8gdGhlIGdyaWQgYnV0 IHN0aWxsIHJlZmVyZW5jaW5nIHRoZSBzYW1lIHBvaW50LiBUaGlzIHBhdGNoIGNvcnJlY3RzIHRo ZSB2YWx1ZSBvZgorICAgICAgICBgZ2FwTGFiZWxMaW5lYCB0byBhbHdheXMgYmUgYSBsaW5lIG9u IHdoaWNoIHRoZSBsYWJlbCBjYW4gYmUgcGxhY2VkLCBpbnN0ZWFkIG9mIGEgc2luZ2xlIHBvaW50 LgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SW5zcGVjdG9yT3ZlcmxheTo6YnVpbGRHcmlkT3ZlcmxheSk6CisKIDIwMjEtMDQt MTkgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CiAKICAgICAgICAg W3NlbGVjdG9yc10gU2NyaXB0IGZvY3VzIGFuZCA6Zm9jdXMtdmlzaWJsZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwCmluZGV4IGQ0MjBkMTVjZTNkMGJj OWM3OTA5NDk1ZDY2NDY4OTNmYjE3OTAzMzcuLjZkMGFhYWVjZDdiMTQ1NDgzNmI4MDk1ODdiMWYx NzkxZTY4YmFkYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JPdmVybGF5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3Zl cmxheS5jcHAKQEAgLTE3NjgsNyArMTc2OCw3IEBAIE9wdGlvbmFsPEluc3BlY3Rvck92ZXJsYXk6 OkhpZ2hsaWdodDo6R3JpZEhpZ2hsaWdodE92ZXJsYXk+IEluc3BlY3Rvck92ZXJsYXk6OmJ1CiAg ICAgICAgICAgICBncmlkSGlnaGxpZ2h0T3ZlcmxheS5nYXBzLmFwcGVuZCh7IHByZXZpb3VzQ29s dW1uRW5kTGluZS5zdGFydCgpLCBjb2x1bW5TdGFydExpbmUuc3RhcnQoKSwgY29sdW1uU3RhcnRM aW5lLmVuZCgpLCBwcmV2aW91c0NvbHVtbkVuZExpbmUuZW5kKCkgfSk7CiAgICAgICAgICAgICBG bG9hdExpbmUgbGluZUJldHdlZW5Db2x1bW5Ub3BzID0geyBjb2x1bW5TdGFydExpbmUuc3RhcnQo KSwgcHJldmlvdXNDb2x1bW5FbmRMaW5lLnN0YXJ0KCkgfTsKICAgICAgICAgICAgIEZsb2F0TGlu ZSBsaW5lQmV0d2VlbkNvbHVtbkJvdHRvbXMgPSB7IGNvbHVtblN0YXJ0TGluZS5lbmQoKSwgcHJl dmlvdXNDb2x1bW5FbmRMaW5lLmVuZCgpIH07Ci0gICAgICAgICAgICBnYXBMYWJlbExpbmUgPSB7 IGxpbmVCZXR3ZWVuQ29sdW1uVG9wcy5wb2ludEF0UmVsYXRpdmVEaXN0YW5jZSgwLjUpLCBsaW5l QmV0d2VlbkNvbHVtblRvcHMucG9pbnRBdFJlbGF0aXZlRGlzdGFuY2UoMC41KSB9OworICAgICAg ICAgICAgZ2FwTGFiZWxMaW5lID0geyBsaW5lQmV0d2VlbkNvbHVtblRvcHMucG9pbnRBdFJlbGF0 aXZlRGlzdGFuY2UoMC41KSwgbGluZUJldHdlZW5Db2x1bW5Cb3R0b21zLnBvaW50QXRSZWxhdGl2 ZURpc3RhbmNlKDAuNSkgfTsKICAgICAgICAgfQogCiAgICAgICAgIGlmIChpIDwgY29sdW1uV2lk dGhzLnNpemUoKSAmJiBpIDwgY29sdW1uUG9zaXRpb25zLnNpemUoKSkgewo=