224761 2021-04-19 08:02:09 -0700 Add more GPUProcess release logging to facilitate debugging 2021-04-23 03:03:19 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez darin ggaren kkinnunen lingcherd_ho simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1751778 0 cdumez 2021-04-19 08:02:09 -0700 Add more GPUProcess release logging to facilitate debugging. 1751779 1 426420 cdumez 2021-04-19 08:03:04 -0700 Created attachment 426420 Patch 1751817 2 426420 darin 2021-04-19 09:28:21 -0700 Comment on attachment 426420 Patch Is it ever a good idea to log pointer values in a release build? 1751819 3 cdumez 2021-04-19 09:29:31 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 426420 [details] > Patch > > Is it ever a good idea to log pointer values in a release build? This is our common pattern thus far. E.g.: #define RELEASE_LOG_IF_ALLOWED(channel, fmt, ...) RELEASE_LOG_IF(isAlwaysOnLoggingAllowed(), channel, "%p - [pageProxyID=%" PRIu64 ", webPageID=%" PRIu64 ", PID=%i] WebPageProxy::" fmt, this, m_identifier.toUInt64(), m_webPageID.toUInt64(), m_process->processIdentifier(), ##__VA_ARGS__) #define RELEASE_LOG_ERROR_IF_ALLOWED(channel, fmt, ...) RELEASE_LOG_ERROR_IF(isAlwaysOnLoggingAllowed(), channel, "%p - [pageProxyID=%" PRIu64 ", webPageID=%" PRIu64 ", PID=%i] WebPageProxy::" fmt, this, m_identifier.toUInt64(), m_webPageID.toUInt64(), m_process->processIdentifier(), ##__VA_ARGS__) 1751834 4 ews-feeder 2021-04-19 09:46:51 -0700 Committed r276257 (236739@main): <https://commits.webkit.org/236739@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426420. 1753544 5 lingcherd_ho 2021-04-23 03:03:19 -0700 rdar://76849207 426420 2021-04-19 08:03:04 -0700 2021-04-19 09:46:52 -0700 Patch bug-224761-20210419080303.patch text/plain 2799 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYzYWM4MTBiMzU0MmZkM2Q1 YzVjOTc5OTg1ZTAzMDgzMzYwMmU3YjkuLmI4Yjg1MjdlOTBmZTczOTEyOTZkZjU0ZTEwYWE3MTdk ZGQwOTRjODEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDQtMTkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbW9yZSBHUFVQcm9jZXNzIHJl bGVhc2UgbG9nZ2luZyB0byBmYWNpbGl0YXRlIGRlYnVnZ2luZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NzYxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBHUFVQcm9jZXNzL0dQVVByb2Nlc3MuY3Bw OgorICAgICAgICAoV2ViS2l0OjpHUFVQcm9jZXNzOjpHUFVQcm9jZXNzKToKKyAgICAgICAgKFdl YktpdDo6R1BVUHJvY2Vzczo6Y3JlYXRlR1BVQ29ubmVjdGlvblRvV2ViUHJvY2Vzcyk6CisgICAg ICAgIChXZWJLaXQ6OkdQVVByb2Nlc3M6OnJlbW92ZUdQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3Mp OgorICAgICAgICAoV2ViS2l0OjpHUFVQcm9jZXNzOjppbml0aWFsaXplR1BVUHJvY2Vzcyk6CisK IDIwMjEtMDQtMTggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBV cGRhdGUgTGliV2ViUlRDQ29kZWNzUHJveHkgdG8gdXNlIGEgTG9jawpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9HUFVQcm9jZXNzL0dQVVByb2Nlc3MuY3BwIGIvU291cmNlL1dlYktpdC9HUFVQ cm9jZXNzL0dQVVByb2Nlc3MuY3BwCmluZGV4IDc3NjU5NTY0ZDgyNWMzMmIzOTVlOTY0Y2Y1ZDZh MmVhODI2MzRmNjAuLjZiZjIzZTE3ZDI3NGNiMjhmODVjODY3MDczZjViZGMyZTVkZGQxYWIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9HUFVQcm9jZXNzLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvR1BVUHJvY2Vzcy5jcHAKQEAgLTc4LDYgKzc4LDcgQEAg dXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiBHUFVQcm9jZXNzOjpHUFVQcm9jZXNzKEF1eGlsaWFy eVByb2Nlc3NJbml0aWFsaXphdGlvblBhcmFtZXRlcnMmJiBwYXJhbWV0ZXJzKQogewogICAgIGlu aXRpYWxpemUoV1RGTW92ZShwYXJhbWV0ZXJzKSk7CisgICAgUkVMRUFTRV9MT0coUHJvY2Vzcywg IiVwIC0gR1BVUHJvY2Vzczo6R1BVUHJvY2VzczoiLCB0aGlzKTsKIH0KIAogR1BVUHJvY2Vzczo6 fkdQVVByb2Nlc3MoKQpAQCAtODYsNiArODcsNyBAQCBHUFVQcm9jZXNzOjp+R1BVUHJvY2Vzcygp CiAKIHZvaWQgR1BVUHJvY2Vzczo6Y3JlYXRlR1BVQ29ubmVjdGlvblRvV2ViUHJvY2VzcyhQcm9j ZXNzSWRlbnRpZmllciBpZGVudGlmaWVyLCBQQUw6OlNlc3Npb25JRCBzZXNzaW9uSUQsIEdQVVBy b2Nlc3NDb25uZWN0aW9uUGFyYW1ldGVycyYmIHBhcmFtZXRlcnMsIENvbXBsZXRpb25IYW5kbGVy PHZvaWQoT3B0aW9uYWw8SVBDOjpBdHRhY2htZW50PiYmKT4mJiBjb21wbGV0aW9uSGFuZGxlcikK IHsKKyAgICBSRUxFQVNFX0xPRyhQcm9jZXNzLCAiJXAgLSBHUFVQcm9jZXNzOjpjcmVhdGVHUFVD b25uZWN0aW9uVG9XZWJQcm9jZXNzOiBwcm9jZXNzSWRlbnRpZmllcj0lIiBQUkl1NjQsIHRoaXMs IGlkZW50aWZpZXIudG9VSW50NjQoKSk7CiAgICAgYXV0byBpcGNDb25uZWN0aW9uID0gY3JlYXRl SVBDQ29ubmVjdGlvblBhaXIoKTsKICAgICBpZiAoIWlwY0Nvbm5lY3Rpb24pIHsKICAgICAgICAg Y29tcGxldGlvbkhhbmRsZXIoeyB9KTsKQEAgLTEwOSw2ICsxMTEsNyBAQCB2b2lkIEdQVVByb2Nl c3M6OmNyZWF0ZUdQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3MoUHJvY2Vzc0lkZW50aWZpZXIgaWRl bnRpZmllciwgUAogCiB2b2lkIEdQVVByb2Nlc3M6OnJlbW92ZUdQVUNvbm5lY3Rpb25Ub1dlYlBy b2Nlc3MoR1BVQ29ubmVjdGlvblRvV2ViUHJvY2VzcyYgY29ubmVjdGlvbikKIHsKKyAgICBSRUxF QVNFX0xPRyhQcm9jZXNzLCAiJXAgLSBHUFVQcm9jZXNzOjpyZW1vdmVHUFVDb25uZWN0aW9uVG9X ZWJQcm9jZXNzOiBwcm9jZXNzSWRlbnRpZmllcj0lIiBQUkl1NjQsIHRoaXMsIGNvbm5lY3Rpb24u d2ViUHJvY2Vzc0lkZW50aWZpZXIoKS50b1VJbnQ2NCgpKTsKICAgICBBU1NFUlQobV93ZWJQcm9j ZXNzQ29ubmVjdGlvbnMuY29udGFpbnMoY29ubmVjdGlvbi53ZWJQcm9jZXNzSWRlbnRpZmllcigp KSk7CiAgICAgbV93ZWJQcm9jZXNzQ29ubmVjdGlvbnMucmVtb3ZlKGNvbm5lY3Rpb24ud2ViUHJv Y2Vzc0lkZW50aWZpZXIoKSk7CiAgICAgdHJ5RXhpdElmVW51c2VkQW5kVW5kZXJNZW1vcnlQcmVz c3VyZSgpOwpAQCAtMTYyLDYgKzE2NSw3IEBAIHZvaWQgR1BVUHJvY2Vzczo6bG93TWVtb3J5SGFu ZGxlcihDcml0aWNhbCBjcml0aWNhbCwgU3luY2hyb25vdXMgc3luY2hyb25vdXMpCiAKIHZvaWQg R1BVUHJvY2Vzczo6aW5pdGlhbGl6ZUdQVVByb2Nlc3MoR1BVUHJvY2Vzc0NyZWF0aW9uUGFyYW1l dGVycyYmIHBhcmFtZXRlcnMpCiB7CisgICAgUkVMRUFTRV9MT0coUHJvY2VzcywgIiVwIC0gR1BV UHJvY2Vzczo6aW5pdGlhbGl6ZUdQVVByb2Nlc3M6IiwgdGhpcyk7CiAgICAgV1RGOjpUaHJlYWQ6 OnNldEN1cnJlbnRUaHJlYWRJc1VzZXJJbml0aWF0ZWQoKTsKICAgICBBdG9tU3RyaW5nOjppbml0 KCk7CiAK