224755 2021-04-19 06:59:53 -0700 URL::URL(HashTableDeletedValueType) triggers -Wuninitialized warnings with GCC 11 2021-04-23 07:36:06 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224889 https://bugs.webkit.org/show_bug.cgi?id=224975 InRadar P2 Normal --- 1 mcatanzaro mcatanzaro achristensen benjamin cdumez cmarcelo darin ews-watchlist mcatanzaro webkit-bug-importer ysuzuki oldest_to_newest 1751761 0 mcatanzaro 2021-04-19 06:59:53 -0700 [2920/5456] Building CXX object Source/WebCore/CMakeFiles...vedSources/unified-sources/UnifiedSource-f74e0903-7.cpp.o In file included from ../../Source/WebCore/page/SecurityOriginData.h:28, from ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:30, from ../../Source/WebCore/workers/service/server/SWScriptStorage.cpp:32, from WebCore/DerivedSources/unified-sources/UnifiedSource-f74e0903-7.cpp:1: In member function ‘WTF::URL& WTF::URL::operator=(WTF::URL&&)’, inlined from ‘void WebCore::ServiceWorkerRegistrationKey::setScope(WTF::URL&&)’ at ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:52:44, inlined from ‘static void WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::constructDeletedValue(WebCore::ServiceWorkerRegistrationKey&)’ at ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:109:99, inlined from ‘typename std::enable_if<(! WTF::HashTraitHasCustomDelete<Traits, T>::value)>::type WTF::hashTraitsDeleteBucket(T&) [with Traits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>; T = WebCore::ServiceWorkerRegistrationKey]’ at WTF/Headers/wtf/HashTraits.h:305:34, inlined from ‘static void WTF::KeyValuePairHashTraits<KeyTraitsArg, ValueTraitsArg>::customDeleteBucket(WTF::KeyValuePairHashTraits<KeyTraitsArg, ValueTraitsArg>::TraitType&) [with KeyTraitsArg = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>; ValueTraitsArg = WTF::HashTraits<WTF::WeakPtr<WebCore::SWServerRegistration> >]’ at WTF/Headers/wtf/HashTraits.h:378:42, inlined from ‘typename std::enable_if<WTF::HashTraitHasCustomDelete<Traits, T>::value>::type WTF::hashTraitsDeleteBucket(T&) [with Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; T = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >]’ at WTF/Headers/wtf/HashTraits.h:297:31, inlined from ‘static void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::deleteBucket(WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType&) [with Key = WebCore::ServiceWorkerRegistrationKey; Value = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> > >; HashFunctions = WTF::DefaultHash<WebCore::ServiceWorkerRegistrationKey>; Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>]’ at WTF/Headers/wtf/HashTable.h:549:85, inlined from ‘void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::remove(WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType*) [with Key = WebCore::ServiceWorkerRegistrationKey; Value = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> > >; HashFunctions = WTF::DefaultHash<WebCore::ServiceWorkerRegistrationKey>; Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>]’ at WTF/Headers/wtf/HashTable.h:1127:21: WTF/Headers/wtf/URL.h:56:7: warning: ‘*(long unsigned int*)((char*)&<unnamed> + offsetof(WTF::URL, WTF::URL::m_isValid))’ is used uninitialized [-Wuninitialized] 56 | class URL { | ^~~ In file included from ../../Source/WebCore/workers/service/server/SWScriptStorage.cpp:32, from WebCore/DerivedSources/unified-sources/UnifiedSource-f74e0903-7.cpp:1: ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h: In member function ‘void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::remove(WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType*) [with Key = WebCore::ServiceWorkerRegistrationKey; Value = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> > >; HashFunctions = WTF::DefaultHash<WebCore::ServiceWorkerRegistrationKey>; Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>]’: ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:109:125: note: ‘<anonymous>’ declared here 109 | static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { slot.setScope(URL(HashTableDeletedValue)); } | ^ In file included from ../../Source/WebCore/page/SecurityOriginData.h:28, from ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:30, from ../../Source/WebCore/workers/service/server/SWScriptStorage.cpp:32, from WebCore/DerivedSources/unified-sources/UnifiedSource-f74e0903-7.cpp:1: In member function ‘WTF::URL& WTF::URL::operator=(WTF::URL&&)’, inlined from ‘void WebCore::ServiceWorkerRegistrationKey::setScope(WTF::URL&&)’ at ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:52:44, inlined from ‘static void WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::constructDeletedValue(WebCore::ServiceWorkerRegistrationKey&)’ at ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:109:99, inlined from ‘typename std::enable_if<(! WTF::HashTraitHasCustomDelete<Traits, T>::value)>::type WTF::hashTraitsDeleteBucket(T&) [with Traits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>; T = WebCore::ServiceWorkerRegistrationKey]’ at WTF/Headers/wtf/HashTraits.h:305:34, inlined from ‘static void WTF::KeyValuePairHashTraits<KeyTraitsArg, ValueTraitsArg>::customDeleteBucket(WTF::KeyValuePairHashTraits<KeyTraitsArg, ValueTraitsArg>::TraitType&) [with KeyTraitsArg = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>; ValueTraitsArg = WTF::HashTraits<WTF::WeakPtr<WebCore::SWServerRegistration> >]’ at WTF/Headers/wtf/HashTraits.h:378:42, inlined from ‘typename std::enable_if<WTF::HashTraitHasCustomDelete<Traits, T>::value>::type WTF::hashTraitsDeleteBucket(T&) [with Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; T = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >]’ at WTF/Headers/wtf/HashTraits.h:297:31, inlined from ‘static void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::deleteBucket(WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType&) [with Key = WebCore::ServiceWorkerRegistrationKey; Value = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> > >; HashFunctions = WTF::DefaultHash<WebCore::ServiceWorkerRegistrationKey>; Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>]’ at WTF/Headers/wtf/HashTable.h:549:85, inlined from ‘void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::remove(WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType*) [with Key = WebCore::ServiceWorkerRegistrationKey; Value = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> > >; HashFunctions = WTF::DefaultHash<WebCore::ServiceWorkerRegistrationKey>; Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>]’ at WTF/Headers/wtf/HashTable.h:1127:21: WTF/Headers/wtf/URL.h:56:7: warning: ‘*(long unsigned int*)((char*)&<unnamed> + offsetof(WTF::URL, WTF::URL::m_userEnd))’ is used uninitialized [-Wuninitialized] 56 | class URL { | ^~~ In file included from ../../Source/WebCore/workers/service/server/SWScriptStorage.cpp:32, from WebCore/DerivedSources/unified-sources/UnifiedSource-f74e0903-7.cpp:1: ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h: In member function ‘void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::remove(WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType*) [with Key = WebCore::ServiceWorkerRegistrationKey; Value = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> > >; HashFunctions = WTF::DefaultHash<WebCore::ServiceWorkerRegistrationKey>; Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>]’: ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:109:125: note: ‘<anonymous>’ declared here 109 | static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { slot.setScope(URL(HashTableDeletedValue)); } | ^ In file included from ../../Source/WebCore/page/SecurityOriginData.h:28, from ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:30, from ../../Source/WebCore/workers/service/server/SWScriptStorage.cpp:32, from WebCore/DerivedSources/unified-sources/UnifiedSource-f74e0903-7.cpp:1: In member function ‘WTF::URL& WTF::URL::operator=(WTF::URL&&)’, inlined from ‘void WebCore::ServiceWorkerRegistrationKey::setScope(WTF::URL&&)’ at ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:52:44, inlined from ‘static void WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::constructDeletedValue(WebCore::ServiceWorkerRegistrationKey&)’ at ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:109:99, inlined from ‘typename std::enable_if<(! WTF::HashTraitHasCustomDelete<Traits, T>::value)>::type WTF::hashTraitsDeleteBucket(T&) [with Traits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>; T = WebCore::ServiceWorkerRegistrationKey]’ at WTF/Headers/wtf/HashTraits.h:305:34, inlined from ‘static void WTF::KeyValuePairHashTraits<KeyTraitsArg, ValueTraitsArg>::customDeleteBucket(WTF::KeyValuePairHashTraits<KeyTraitsArg, ValueTraitsArg>::TraitType&) [with KeyTraitsArg = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>; ValueTraitsArg = WTF::HashTraits<WTF::WeakPtr<WebCore::SWServerRegistration> >]’ at WTF/Headers/wtf/HashTraits.h:378:42, inlined from ‘typename std::enable_if<WTF::HashTraitHasCustomDelete<Traits, T>::value>::type WTF::hashTraitsDeleteBucket(T&) [with Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; T = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >]’ at WTF/Headers/wtf/HashTraits.h:297:31, inlined from ‘static void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::deleteBucket(WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType&) [with Key = WebCore::ServiceWorkerRegistrationKey; Value = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> > >; HashFunctions = WTF::DefaultHash<WebCore::ServiceWorkerRegistrationKey>; Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>]’ at WTF/Headers/wtf/HashTable.h:549:85, inlined from ‘void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::remove(WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType*) [with Key = WebCore::ServiceWorkerRegistrationKey; Value = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> > >; HashFunctions = WTF::DefaultHash<WebCore::ServiceWorkerRegistrationKey>; Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>]’ at WTF/Headers/wtf/HashTable.h:1127:21: WTF/Headers/wtf/URL.h:56:7: warning: ‘*(long unsigned int*)((char*)&<unnamed> + offsetof(WTF::URL, WTF::URL::m_hostEnd))’ is used uninitialized [-Wuninitialized] 56 | class URL { | ^~~ In file included from ../../Source/WebCore/workers/service/server/SWScriptStorage.cpp:32, from WebCore/DerivedSources/unified-sources/UnifiedSource-f74e0903-7.cpp:1: ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h: In member function ‘void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::remove(WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType*) [with Key = WebCore::ServiceWorkerRegistrationKey; Value = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> > >; HashFunctions = WTF::DefaultHash<WebCore::ServiceWorkerRegistrationKey>; Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>]’: ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:109:125: note: ‘<anonymous>’ declared here 109 | static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { slot.setScope(URL(HashTableDeletedValue)); } | ^ In file included from ../../Source/WebCore/page/SecurityOriginData.h:28, from ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:30, from ../../Source/WebCore/workers/service/server/SWScriptStorage.cpp:32, from WebCore/DerivedSources/unified-sources/UnifiedSource-f74e0903-7.cpp:1: In member function ‘WTF::URL& WTF::URL::operator=(WTF::URL&&)’, inlined from ‘void WebCore::ServiceWorkerRegistrationKey::setScope(WTF::URL&&)’ at ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:52:44, inlined from ‘static void WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>::constructDeletedValue(WebCore::ServiceWorkerRegistrationKey&)’ at ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:109:99, inlined from ‘typename std::enable_if<(! WTF::HashTraitHasCustomDelete<Traits, T>::value)>::type WTF::hashTraitsDeleteBucket(T&) [with Traits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>; T = WebCore::ServiceWorkerRegistrationKey]’ at WTF/Headers/wtf/HashTraits.h:305:34, inlined from ‘static void WTF::KeyValuePairHashTraits<KeyTraitsArg, ValueTraitsArg>::customDeleteBucket(WTF::KeyValuePairHashTraits<KeyTraitsArg, ValueTraitsArg>::TraitType&) [with KeyTraitsArg = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>; ValueTraitsArg = WTF::HashTraits<WTF::WeakPtr<WebCore::SWServerRegistration> >]’ at WTF/Headers/wtf/HashTraits.h:378:42, inlined from ‘typename std::enable_if<WTF::HashTraitHasCustomDelete<Traits, T>::value>::type WTF::hashTraitsDeleteBucket(T&) [with Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; T = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >]’ at WTF/Headers/wtf/HashTraits.h:297:31, inlined from ‘static void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::deleteBucket(WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType&) [with Key = WebCore::ServiceWorkerRegistrationKey; Value = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> > >; HashFunctions = WTF::DefaultHash<WebCore::ServiceWorkerRegistrationKey>; Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>]’ at WTF/Headers/wtf/HashTable.h:549:85, inlined from ‘void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::remove(WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType*) [with Key = WebCore::ServiceWorkerRegistrationKey; Value = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> > >; HashFunctions = WTF::DefaultHash<WebCore::ServiceWorkerRegistrationKey>; Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>]’ at WTF/Headers/wtf/HashTable.h:1127:21: WTF/Headers/wtf/URL.h:56:7: warning: ‘*(long unsigned int*)((char*)&<unnamed> + offsetof(WTF::URL, WTF::URL::m_pathEnd))’ is used uninitialized [-Wuninitialized] 56 | class URL { | ^~~ In file included from ../../Source/WebCore/workers/service/server/SWScriptStorage.cpp:32, from WebCore/DerivedSources/unified-sources/UnifiedSource-f74e0903-7.cpp:1: ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h: In member function ‘void WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::remove(WTF::HashTable<Key, Value, Extractor, HashFunctions, Traits, KeyTraits>::ValueType*) [with Key = WebCore::ServiceWorkerRegistrationKey; Value = WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >; Extractor = WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> > >; HashFunctions = WTF::DefaultHash<WebCore::ServiceWorkerRegistrationKey>; Traits = WTF::HashMap<WebCore::ServiceWorkerRegistrationKey, WTF::WeakPtr<WebCore::SWServerRegistration> >::KeyValuePairTraits; KeyTraits = WTF::HashTraits<WebCore::ServiceWorkerRegistrationKey>]’: ../../Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:109:125: note: ‘<anonymous>’ declared here 109 | static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { slot.setScope(URL(HashTableDeletedValue)); } | ^ From bug #224381, Alex says: "Very interesting, although unrelated to this change. It looks like it's complaining that URL::URL(HashTableDeletedValueType) doesn't initialize any members but m_string. That's fine because only m_string is used for hash-table-deleted-entry-URLs and probably preferred because it does fewer write operations. Maybe there's a way to silence those warnings or initialize all the members only in builds that would see those warnings." I dunno, it's more robust to just always initialize everything. The warning is complaining because the partially-uninitialized URL gets passed to ServiceWorkerRegistrationKey's copy assignment operator, so the uninitialized data does get used to initialize another URL. It might be harmless if the data is really never read, but now ServiceWorkerRegistrationKey::scope is going to return a partially-initialized URL. I guess it's probably OK because it's only ever used as the HashTableDeletedValueType, but I think initializing everything is the safer way to go in this case. I doubt there will be any noticeable performance impact. Alternatively, we could simply silence the warning, which is probably easy to do. 1751903 1 426455 mcatanzaro 2021-04-19 12:15:42 -0700 Created attachment 426455 Patch 1751904 2 426455 mcatanzaro 2021-04-19 12:16:21 -0700 Comment on attachment 426455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426455&action=review > Source/WTF/wtf/URL.h:343 > inline URL::URL(HashTableDeletedValueType) > : m_string(HashTableDeletedValue) > { > + invalidate(); > } Does this look OK, Alex? 1751909 3 mcatanzaro 2021-04-19 12:19:16 -0700 (In reply to Michael Catanzaro from comment #0) > Alternatively, we could simply silence the warning, which is probably easy > to do. I'm not sure. If Alex doesn't like my invalidate() patch, then I will need to investigate more to be certain, but I *think* the warning would have to be suppressed in the copy constructor of ServiceWorkerRegistrationKey, which is far from the URL constructor where the uninitialized data is coming from. So it doesn't seem like a great solution. Another option would be to call invalidate() only on Linux, if you really want to avoid fully-initializing the URL on Apple platforms, but this seems like the worst option. 1751927 4 achristensen 2021-04-19 13:05:45 -0700 Would it work instead to add a constructor to ServiceWorkerRegistrationKey that takes a HashTableDeletedValue and call that instead? This adds an unnecessary function call that writes 0's unnecessarily in possibly hot code. 1751995 5 426455 darin 2021-04-19 15:03:16 -0700 Comment on attachment 426455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426455&action=review >> Source/WTF/wtf/URL.h:343 >> } > > Does this look OK, Alex? This is bad for performance and should be unnecessary. We should suppress the warning instead. 1751998 6 darin 2021-04-19 15:03:47 -0700 I like Alex’s suggestion. 1752002 7 mcatanzaro 2021-04-19 15:12:36 -0700 (In reply to Alex Christensen from comment #4) > Would it work instead to add a constructor to ServiceWorkerRegistrationKey > that takes a HashTableDeletedValue and call that instead? TODO: I will try this. 1752517 8 mcatanzaro 2021-04-20 17:01:44 -0700 (In reply to Alex Christensen from comment #4) > Would it work instead to add a constructor to ServiceWorkerRegistrationKey > that takes a HashTableDeletedValue and call that instead? I got something similar to work, though it doesn't involve a constructor. 1752521 9 426619 mcatanzaro 2021-04-20 17:06:34 -0700 Created attachment 426619 Patch 1752530 10 426619 mcatanzaro 2021-04-20 17:41:05 -0700 Comment on attachment 426619 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426619&action=review > Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:69 > + friend class HashTraits<WebCore::ServiceWorkerRegistrationKey>; Looks like Clang doesn't like 'friend class' since HashTraits is a struct, oops. I'm surprised that GCC allowed it. Anyway, I bet 'friend struct' will work. 1752533 11 426623 mcatanzaro 2021-04-20 17:42:00 -0700 Created attachment 426623 Patch 1752547 12 426623 darin 2021-04-20 18:04:57 -0700 Comment on attachment 426623 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426623&action=review > Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:73 > + bool m_isHashTableDeletedValue; This needs to be initialized to false! 1752550 13 426623 mcatanzaro 2021-04-20 18:11:25 -0700 Comment on attachment 426623 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426623&action=review >> Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:73 >> + bool m_isHashTableDeletedValue; > > This needs to be initialized to false! Ugh, of course, sorry.... 1752551 14 426626 mcatanzaro 2021-04-20 18:13:02 -0700 Created attachment 426626 Patch 1752552 15 mcatanzaro 2021-04-20 18:13:37 -0700 (In reply to Michael Catanzaro from comment #13) > Ugh, of course, sorry.... Especially embarrassing when the goal of the patch was to avoid an uninitialized data copy. I had only one job here.... 1752555 16 426626 ysuzuki 2021-04-20 18:16:43 -0700 Comment on attachment 426626 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426626&action=review > Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:73 > + friend struct HashTraits<WebCore::ServiceWorkerRegistrationKey>; > + > SecurityOriginData m_topOrigin; > URL m_scope; > + bool m_isHashTableDeletedValue { false }; This will enlarge sizeof(ServiceWorkerRegistrationKey) and allocation used in HashMap<ServiceWorkerRegistrationKey, XXX>. 1752556 17 426626 darin 2021-04-20 18:17:54 -0700 Comment on attachment 426626 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426626&action=review >> Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:73 >> + bool m_isHashTableDeletedValue { false }; > > This will enlarge sizeof(ServiceWorkerRegistrationKey) and allocation used in HashMap<ServiceWorkerRegistrationKey, XXX>. How much will it enlarge it? 1752557 18 426626 darin 2021-04-20 18:18:29 -0700 Comment on attachment 426626 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426626&action=review >>> Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:73 >>> + bool m_isHashTableDeletedValue { false }; >> >> This will enlarge sizeof(ServiceWorkerRegistrationKey) and allocation used in HashMap<ServiceWorkerRegistrationKey, XXX>. > > How much will it enlarge it? It is a shame because enlarging it is unnecessary. Instead we can use any unused bit anywhere else in the object. 1752558 19 426626 ysuzuki 2021-04-20 18:19:28 -0700 Comment on attachment 426626 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426626&action=review >>> Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:73 >>> + bool m_isHashTableDeletedValue { false }; >> >> This will enlarge sizeof(ServiceWorkerRegistrationKey) and allocation used in HashMap<ServiceWorkerRegistrationKey, XXX>. > > How much will it enlarge it? 8 byte because of alignment. 64 => 72. I don't think we should pay a memory cost to suppress warnings. 1752566 20 darin 2021-04-20 18:31:57 -0700 Change to review- then. 1752569 21 426626 cdumez 2021-04-20 18:34:41 -0700 Comment on attachment 426626 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426626&action=review >>>>> Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:73 >>>>> + bool m_isHashTableDeletedValue { false }; >>>> >>>> This will enlarge sizeof(ServiceWorkerRegistrationKey) and allocation used in HashMap<ServiceWorkerRegistrationKey, XXX>. >>> >>> How much will it enlarge it? >> >> It is a shame because enlarging it is unnecessary. Instead we can use any unused bit anywhere else in the object. > > 8 byte because of alignment. 64 => 72. I don't think we should pay a memory cost to suppress warnings. Seems indeed unfortunate to add a data member just for this purpose. If the url constructor from a hash table deleting value is no good, then maybe we can use the one of SecurityOriginData (since this is the type of our other data member)? 1752571 22 426626 cdumez 2021-04-20 18:37:17 -0700 Comment on attachment 426626 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426626&action=review > Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:-109 > - static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { slot.setScope(URL(HashTableDeletedValue)); } Would this silence your warning? static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { slot.m_topOrigin = SecurityOriginData { HashTableDeletedValue }; } 1752577 23 cdumez 2021-04-20 18:44:59 -0700 (In reply to Chris Dumez from comment #22) > Comment on attachment 426626 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426626&action=review > > > Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:-109 > > - static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { slot.setScope(URL(HashTableDeletedValue)); } > > Would this silence your warning? > static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& > slot) { slot.m_topOrigin = SecurityOriginData { HashTableDeletedValue }; } BTW, the warning is about the URL constructor from a HashTableDeletedValue. Fixing it by avoiding to call that constructor doesn't seem like a great fix to me, especially if it is by adding an extra data member to the class where it is used. I would be fine using the SecurityOriginData constructor from a HashTableDeletedValue instead since it does not make the ServiceWorkerRegistrationKey worse in any way and it likely silences your warning. However, the root of the issue is URL. I think we either need to make the URL(HashTableDeletedValue) constructor initialize its data member properly OR decide that it is OK for this particular constructor to not initialize those members (since we don't need them for this particular use case and initializing may hurt perf). In the latter case, it seems silencing the warning at compiler level would be an appropriate fix? 1752581 24 mcatanzaro 2021-04-20 19:05:56 -0700 (In reply to Yusuke Suzuki from comment #19) > 8 byte because of alignment. 64 => 72. I don't think we should pay a memory > cost to suppress warnings. Hm, well the warning is there for a reason: we really *are* copying uninitialized data. In this case, I think it's harmless, because it *should* never be read, because the ServiceWorkerRegistrationKey object should only contain a partially-uninitialized URL if the ServiceWorkerRegistrationKey is itself a HashTableDeletedValue, and it seems unlikely that code would try to access ServiceWorkerRegistrationKey::scope on a ServiceWorkerRegistrationKey that is a HashTableDeletedValue. But there is robustness benefit to avoiding this, so code changes are justified IMO. But I think Chris is right, we probably don't need to pay the cost in this particular case. (In reply to Chris Dumez from comment #23) > I would be fine using the SecurityOriginData constructor from a > HashTableDeletedValue instead since it does not make the > ServiceWorkerRegistrationKey worse in any way and it likely silences your > warning. Good point, I didn't notice that. I could certainly try using the SecurityOriginData instead. That would probably work fine. I think it makes sense to rely on the HashTableDeletedValue of any child object when possible. > However, the root of the issue is URL. I think we either need to make the > URL(HashTableDeletedValue) constructor initialize its data member properly Alex is quite opposed to this. > OR decide that it is OK for this particular constructor to not initialize > those members (since we don't need them for this particular use case and > initializing may hurt perf). In the latter case, it seems silencing the > warning at compiler level would be an appropriate fix? In theory, it's safe to leave the data uninitialized, because the HashTableDeletedValue URL should never be copied. But this warning indicates it *does* actually get copied by ServiceWorkerRegistrationKey::operator=. Suppressing the warning in URL itself would potentially hide errors elsewhere. So I think I prefer to try using SecurityOriginData instead. 1752582 25 mcatanzaro 2021-04-20 19:12:48 -0700 (Note: I'm uploading a revised patch for review now, but I still need to test a build tomorrow to ensure the warning is truly gone before landing.) 1752584 26 cdumez 2021-04-20 19:13:18 -0700 (In reply to Michael Catanzaro from comment #24) > (In reply to Yusuke Suzuki from comment #19) > > 8 byte because of alignment. 64 => 72. I don't think we should pay a memory > > cost to suppress warnings. > > Hm, well the warning is there for a reason: we really *are* copying > uninitialized data. In this case, I think it's harmless, because it *should* > never be read, because the ServiceWorkerRegistrationKey object should only > contain a partially-uninitialized URL if the ServiceWorkerRegistrationKey is > itself a HashTableDeletedValue, and it seems unlikely that code would try to > access ServiceWorkerRegistrationKey::scope on a ServiceWorkerRegistrationKey > that is a HashTableDeletedValue. But there is robustness benefit to avoiding > this, so code changes are justified IMO. > > But I think Chris is right, we probably don't need to pay the cost in this > particular case. > > (In reply to Chris Dumez from comment #23) > > I would be fine using the SecurityOriginData constructor from a > > HashTableDeletedValue instead since it does not make the > > ServiceWorkerRegistrationKey worse in any way and it likely silences your > > warning. > > Good point, I didn't notice that. I could certainly try using the > SecurityOriginData instead. That would probably work fine. I think it makes > sense to rely on the HashTableDeletedValue of any child object when possible. > > > However, the root of the issue is URL. I think we either need to make the > > URL(HashTableDeletedValue) constructor initialize its data member properly > > Alex is quite opposed to this. > > > OR decide that it is OK for this particular constructor to not initialize > > those members (since we don't need them for this particular use case and > > initializing may hurt perf). In the latter case, it seems silencing the > > warning at compiler level would be an appropriate fix? > > In theory, it's safe to leave the data uninitialized, because the > HashTableDeletedValue URL should never be copied. But this warning indicates > it *does* actually get copied by ServiceWorkerRegistrationKey::operator=. > Suppressing the warning in URL itself would potentially hide errors > elsewhere. So I think I prefer to try using SecurityOriginData instead. The compiler output is a bit hard to head but it wasn't obvious to me that the issue was with ServiceWorkerRegistrationKey::operator=() copying. It looked to me that the issue was calling the move constructor of URL: WTF::URL::operator=(WTF::URL&&) here: slot.setScope(URL(HashTableDeletedValue)); I see. I missed that this was due to ServiceWorkerRegistrationKey copying. Shouldn't we be able to move such URL constructed from HashTableDeletedValue? 1752585 27 426632 mcatanzaro 2021-04-20 19:14:32 -0700 Created attachment 426632 Patch 1752586 28 426632 cdumez 2021-04-20 19:16:24 -0700 Comment on attachment 426632 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426632&action=review > Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:111 > + static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { slot.m_topOrigin = SecurityOriginData(HashTableDeletedValue); } WebCore::SecurityOriginData 1752590 29 426635 mcatanzaro 2021-04-20 19:27:06 -0700 Created attachment 426635 Patch 1752591 30 mcatanzaro 2021-04-20 19:27:38 -0700 (In reply to Chris Dumez from comment #26) > The compiler output is a bit hard to head but it wasn't obvious to me that > the issue was with ServiceWorkerRegistrationKey::operator=() copying. It > looked to me that the issue was calling the move constructor of URL: > WTF::URL::operator=(WTF::URL&&) > here: > slot.setScope(URL(HashTableDeletedValue)); Well I think you're right, it's not a copy at all, it's a move. You're better at squinting at obtuse warnings than I am. > I see. I missed that this was due to ServiceWorkerRegistrationKey copying. Well... squinting at the warning, I guess it's not. > Shouldn't we be able to move such URL constructed from HashTableDeletedValue? Well, I agree. My opinion is that objects in WebKit should never have uninitialized data unless we are able to demonstrate a real performance improvement caused by leaving the data uninitialized, which I assume will be very rare. Uninitialized data is dangerous for robustness because programmers do not expect data to be uninitialized. But Alex is worried about performance. I have no doubt that hash tables containing URLs are performance-sensitive, though I do doubt that leaving URLs partially-initialized is really a significant optimization. Anyway, my patches to ServiceWorkerRegistrationKey only make sense if patches to fully-initialize URL will not be accepted. 1752595 31 cdumez 2021-04-20 19:34:49 -0700 (In reply to Michael Catanzaro from comment #30) > (In reply to Chris Dumez from comment #26) > > The compiler output is a bit hard to head but it wasn't obvious to me that > > the issue was with ServiceWorkerRegistrationKey::operator=() copying. It > > looked to me that the issue was calling the move constructor of URL: > > WTF::URL::operator=(WTF::URL&&) > > here: > > slot.setScope(URL(HashTableDeletedValue)); > > Well I think you're right, it's not a copy at all, it's a move. You're > better at squinting at obtuse warnings than I am. > > > I see. I missed that this was due to ServiceWorkerRegistrationKey copying. > > Well... squinting at the warning, I guess it's not. > > > Shouldn't we be able to move such URL constructed from HashTableDeletedValue? > > Well, I agree. My opinion is that objects in WebKit should never have > uninitialized data unless we are able to demonstrate a real performance > improvement caused by leaving the data uninitialized, which I assume will be > very rare. Uninitialized data is dangerous for robustness because > programmers do not expect data to be uninitialized. > > But Alex is worried about performance. I have no doubt that hash tables > containing URLs are performance-sensitive, though I do doubt that leaving > URLs partially-initialized is really a significant optimization. Anyway, my > patches to ServiceWorkerRegistrationKey only make sense if patches to > fully-initialize URL will not be accepted. I think this latest patch is completely fine. It does not make things worse in anyway. I have a feeling though that this will bite us again in the future in other places if we don't fix it at URL level. I could buy that URL construction from HashTableDeletedValue may be hot enough that we don't want to initialize those members. That is why I suggested that maybe we want to silence this at compiler level, at URL layer. The move constructor for URL will do the right thing, even if constructed from HashTableDeletedValue. Yes, it will copy some data members that are garbage, but this is fine. It will copy the data member we properly initialized and URL.isDeletedHashTableValue() will still be true. Anyway, something to consider in a follow-up maybe? 1752599 32 426635 cdumez 2021-04-20 19:40:25 -0700 Comment on attachment 426635 Patch r=me. If we see this issue in other places, maybe we'll consider silencing the warning at URL layer instead? 1752600 33 mcatanzaro 2021-04-20 19:49:28 -0700 Thanks for reviewing. (In reply to Chris Dumez from comment #32) > r=me. If we see this issue in other places, maybe we'll consider silencing > the warning at URL layer instead? I haven't tried, but I think we could do this in URL.h: IGNORE_WARNINGS_BEGIN(uninitialized) class URL { IGNORE_WARNING_END That's the line that's ultimately associated with the warning, so I think that's where the suppression would need to be. That seems non-ideal. Alternatively, we could remove SWScriptStorage.cpp from unified build and suppress -Wuninitialized for the entire file, which seems worse, and is punitive to SWScriptStorage.cpp, which isn't doing anything objectionable at all. 1752601 34 426635 darin 2021-04-20 20:01:00 -0700 Comment on attachment 426635 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426635&action=review > Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:111 > + static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { slot.m_topOrigin = WebCore::SecurityOriginData(HashTableDeletedValue); } This isn’t quite right. What we want to do is to use placement new to put SecurityOriginData(HashTableDeletedValue) on top of m_topOrigin, not do an assignment to replace an existing value. We don't want to destroy the existing value that is there. The whole point of "constructDeletedValue" is that it makes a deleted value out of uninitialized memory, not on top of an already valid object. It would be better to get this right. There are lots of other examples of how to use the placement new syntax to do this correctly. 1752603 35 426635 cdumez 2021-04-20 20:18:45 -0700 Comment on attachment 426635 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426635&action=review >> Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:111 >> + static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { slot.m_topOrigin = WebCore::SecurityOriginData(HashTableDeletedValue); } > > This isn’t quite right. What we want to do is to use placement new to put SecurityOriginData(HashTableDeletedValue) on top of m_topOrigin, not do an assignment to replace an existing value. We don't want to destroy the existing value that is there. The whole point of "constructDeletedValue" is that it makes a deleted value out of uninitialized memory, not on top of an already valid object. > > It would be better to get this right. There are lots of other examples of how to use the placement new syntax to do this correctly. Ok. I didn't know that. Looking at existing examples, seems like we want this then? ``` static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { new (NotNull, &slot) WebCore::ServiceWorkerRegistrationKey { WebCore::SecurityOriginData { WTF::HashTableDeletedValue }, { } }; } ``` 1752605 36 426635 mcatanzaro 2021-04-20 20:18:55 -0700 Comment on attachment 426635 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426635&action=review >> Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:111 >> + static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { slot.m_topOrigin = WebCore::SecurityOriginData(HashTableDeletedValue); } > > This isn’t quite right. What we want to do is to use placement new to put SecurityOriginData(HashTableDeletedValue) on top of m_topOrigin, not do an assignment to replace an existing value. We don't want to destroy the existing value that is there. The whole point of "constructDeletedValue" is that it makes a deleted value out of uninitialized memory, not on top of an already valid object. > > It would be better to get this right. There are lots of other examples of how to use the placement new syntax to do this correctly. OK, sure. I'll look closer tomorrow. Note that the original code does not do that, it assumes that the ServiceWorkerRegistrationKey it is passed is already valid and calls setScope on it, which does a move assignment: void setScope(URL&& scope) { m_scope = WTFMove(scope); } 1752610 37 cdumez 2021-04-20 20:23:52 -0700 (In reply to Michael Catanzaro from comment #36) > Comment on attachment 426635 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426635&action=review > > >> Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:111 > >> + static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { slot.m_topOrigin = WebCore::SecurityOriginData(HashTableDeletedValue); } > > > > This isn’t quite right. What we want to do is to use placement new to put SecurityOriginData(HashTableDeletedValue) on top of m_topOrigin, not do an assignment to replace an existing value. We don't want to destroy the existing value that is there. The whole point of "constructDeletedValue" is that it makes a deleted value out of uninitialized memory, not on top of an already valid object. > > > > It would be better to get this right. There are lots of other examples of how to use the placement new syntax to do this correctly. > > OK, sure. I'll look closer tomorrow. > > Note that the original code does not do that, it assumes that the > ServiceWorkerRegistrationKey it is passed is already valid and calls > setScope on it, which does a move assignment: > > void setScope(URL&& scope) { m_scope = WTFMove(scope); } Yes, your new code is not worse than the existing one as far as I can tell. I probably wrote the original code and did not know about this. Looking at our code base, I see a lot of them using placement new and a lot of them using what we had. Anyway, I'll make sure to get this right from now on. 1752611 38 cdumez 2021-04-20 20:28:30 -0700 (In reply to Chris Dumez from comment #35) > Comment on attachment 426635 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426635&action=review > > >> Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:111 > >> + static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& slot) { slot.m_topOrigin = WebCore::SecurityOriginData(HashTableDeletedValue); } > > > > This isn’t quite right. What we want to do is to use placement new to put SecurityOriginData(HashTableDeletedValue) on top of m_topOrigin, not do an assignment to replace an existing value. We don't want to destroy the existing value that is there. The whole point of "constructDeletedValue" is that it makes a deleted value out of uninitialized memory, not on top of an already valid object. > > > > It would be better to get this right. There are lots of other examples of how to use the placement new syntax to do this correctly. > > Ok. I didn't know that. Looking at existing examples, seems like we want > this then? > ``` > static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& > slot) > { > new (NotNull, &slot) WebCore::ServiceWorkerRegistrationKey { > WebCore::SecurityOriginData { WTF::HashTableDeletedValue }, { } }; > } > ``` Or maybe even better: ``` static void constructDeletedValue(WebCore:: ServiceWorkerRegistrationKey& slot) { new (NotNull, &slot.m_topOrigin) WebCore::SecurityOriginData(WTF::HashTableDeletedValue); } ``` 1752613 39 darin 2021-04-20 20:37:43 -0700 (In reply to Chris Dumez from comment #38) > static void constructDeletedValue(WebCore:: ServiceWorkerRegistrationKey& > slot) { new (NotNull, &slot.m_topOrigin) > WebCore::SecurityOriginData(WTF::HashTableDeletedValue); } Yes, that looks pretty good. 1752614 40 darin 2021-04-20 20:39:13 -0700 By the way, there may be some more modern way to do this with "emplace" or something like that; I didn’t really keep up with this aspect of C++ as it evolved, but I have some vague idea that there is a way to do this without using "new" in more modern code. 1752619 41 mcatanzaro 2021-04-20 20:51:33 -0700 (In reply to Chris Dumez from comment #35) > Ok. I didn't know that. Looking at existing examples, seems like we want > this then? > ``` > static void constructDeletedValue(WebCore::ServiceWorkerRegistrationKey& > slot) > { > new (NotNull, &slot) WebCore::ServiceWorkerRegistrationKey { > WebCore::SecurityOriginData { WTF::HashTableDeletedValue }, { } }; > } > ``` The only place I've seen placement new used before is to implement boxed types in the GLib public APIs. One gotcha is that when the object is deallocated, its destructor will not be called, so you have to do that manually. I suppose we are fine with that never happening for HashTableDeletedValues. I have not seen a placement new with more than one argument before. I got curious and eventually found we have our own special placement new in StdLibExtras.h to assert that the location is non-null, which seems like a good idea. That was hard to find! > By the way, there may be some more modern way to do this with "emplace" or something like that; I didn’t really keep up with this aspect of C++ as it evolved, but I have some vague idea that there is a way to do this without using "new" in more modern code. Hm, I'm not sure about that. At least, I don't know how else to do it other than with placement new. emplace operations are defined for containers, e.g. std::vector::emplace_back is similar to push_back. It forwards its args to placement new, instead of copying like a push operation would do. Useful when you're constructing data and then immediately adding it to a container, but internally it is just doing placement new, and we aren't operating on a container in our example case here. 1752621 42 darin 2021-04-20 20:55:57 -0700 (In reply to Michael Catanzaro from comment #41) > One gotcha is that when the object is > deallocated, its destructor will not be called, so you have to do that > manually. I suppose we are fine with that never happening for > HashTableDeletedValues. That's right. The design of HashTable is that a deleted slot is never destroyed and is only constructed by calling the constructDeletedValue function. The thing you need to be able to do with a deleted slot is to return true from the isDeletedValue trait function and return false for actual valid constructed objects. > Hm, I'm not sure about that. You're right. I was wrong to think "emplace" had anything to do with this. 1752703 43 mcatanzaro 2021-04-21 04:46:23 -0700 (In reply to Darin Adler from comment #42) > That's right. The design of HashTable is that a deleted slot is never > destroyed and is only constructed by calling the constructDeletedValue > function. The thing you need to be able to do with a deleted slot is to > return true from the isDeletedValue trait function and return false for > actual valid constructed objects. So with this in mind, I think Chris and I were both wrong about the value of fully-initializing the URL. Our solution for ServiceWorkerRegistrationKey using placement new is not going to be fully-initialized anyway, since we're now only initializing m_topOrigin. 1752704 44 mcatanzaro 2021-04-21 04:51:24 -0700 (In reply to Chris Dumez from comment #38) > static void constructDeletedValue(WebCore:: ServiceWorkerRegistrationKey& > slot) { new (NotNull, &slot.m_topOrigin) > WebCore::SecurityOriginData(WTF::HashTableDeletedValue); } > ``` That only constructs the SecurityOriginData data member, though, leaving it in memory allocated for a ServiceWorkerRegistrationKey but not constructing a ServiceWorkerRegistrationKey. We probably need to construct a real ServiceWorkerRegistrationKey. I think this can be done by adding a constructor that takes HashTableDeletedValueType, as you originally suggested. Let's see.... 1752711 45 426674 mcatanzaro 2021-04-21 06:06:35 -0700 Created attachment 426674 Patch 1752744 46 ews-feeder 2021-04-21 08:01:23 -0700 Committed r276361 (236839@main): <https://commits.webkit.org/236839@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426674. 1752907 47 426674 darin 2021-04-21 13:43:35 -0700 Comment on attachment 426674 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426674&action=review > Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:79 > +inline ServiceWorkerRegistrationKey::ServiceWorkerRegistrationKey(WTF::HashTableDeletedValueType) > + : m_topOrigin(WTF::HashTableDeletedValue) > +{ > +} This is OK. However, here’s a note for the future: From a hash table implementation point of view, the goal when implementing constructDeletedValue is *not* to construct a valid object. All we want to do is to set a bit indicating that something is a deleted value. We would like to leave the rest of the object uninitialized, for performance reasons. The only operations that will be done on a "deleted value" in a slot are: 1) calls to the isDeletedValue function 2) call to the == function iff safeToCompareToEmptyOrDeleted is set in the hash function traits In particular: these objects are never destroyed, so it’s critical that the constructor not do anything that needs to be un-done. This means that often we want to do something like just set a single bit or a set of bits to a value that we know will never be set that way for any valid value. Thus "not initializing everything" is often a goal, not a bug. Initializing things creates a risk of allocating something that needs to be destroyed, and also means we are writing things we will never read, with a small but unnecessary performance cost. We sometimes do find it handy to implement the constructDeletedValue operation with a constructor, but it really has different requirements that most constructors. We don’t want to initialize things like vtable pointers, and we don’t want to do more than minimum initialization. So I’m not sure that the pattern of using a special constructor is necessarily going to be the best over time. 1753371 48 426674 darin 2021-04-22 17:05:21 -0700 Comment on attachment 426674 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426674&action=review > Source/WebCore/workers/service/ServiceWorkerRegistrationKey.h:77 > +inline ServiceWorkerRegistrationKey::ServiceWorkerRegistrationKey(WTF::HashTableDeletedValueType) > + : m_topOrigin(WTF::HashTableDeletedValue) This unnecessarily initializes m_scope to a null URL. A more efficient approach is to not touch m_scope at all and we should consider that refinement in future. 1753475 49 webkit-bug-importer 2021-04-23 00:13:22 -0700 <rdar://problem/77059533> 1753577 50 mcatanzaro 2021-04-23 07:36:06 -0700 (In reply to Darin Adler from comment #48) > This unnecessarily initializes m_scope to a null URL. A more efficient > approach is to not touch m_scope at all and we should consider that > refinement in future. Bug #224975 426455 2021-04-19 12:15:42 -0700 2021-04-20 17:06:32 -0700 Patch bug-224755-20210419141541.patch text/plain 1270 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MjQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDYyMGZkYzY1YmE3Yzg5YWIzYzg0Mzc0 ZDE1NzI3ZjQyOTcyZmY4MDUuLjY1OGVkN2ViMmY5MGY1YjNjNGMyMDk1ODNhOGM5ZGY2NzVlMjY5 MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDQtMTkgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgVVJMOjpVUkwoSGFzaFRhYmxlRGVsZXRl ZFZhbHVlVHlwZSkgdHJpZ2dlcnMgLVd1bmluaXRpYWxpemVkIHdhcm5pbmdzIHdpdGggR0NDIDEx CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ3NTUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnZhbGlk YXRlIHRoZSBuZXdseS1jb25zdHJ1Y3RlZCBVUkwgdG8gZW5zdXJlIGl0cyBtZW1iZXIgdmFyaWFi bGVzIGFyZSB6ZXJvLWluaXRpYWxpemVkLgorICAgICAgICBUaGlzIHNlbWFudGljYWxseSBtYWtl cyBzZW5zZSBiZWNhdXNlIGEgaGFzaCB0YWJsZSBkZWxldGVkIHZhbHVlIGlzIG5vdCBhIHZhbGlk IFVSTC4KKworICAgICAgICAqIHd0Zi9VUkwuaDoKKyAgICAgICAgKFdURjo6VVJMOjpVUkwpOgor CiAyMDIxLTA0LTE3ICBTYW0gV2VpbmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBN b3ZlIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXMgdG8gU2V0dGluZ3MgKFBhcnQgMSkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL1VSTC5oIGIvU291cmNlL1dURi93dGYvVVJMLmgKaW5kZXggYjIy NTkzNWViZDk0ZjcyNjZlNWUzNmM5MjdiYzZmOTE2ZDBlYjRkMC4uMDk5MGNkNzgxMjdkODVmNWVk ODU1NzdkNzg5ZTA0YmM3NmYzOGUzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvVVJMLmgK KysrIGIvU291cmNlL1dURi93dGYvVVJMLmgKQEAgLTMzOSw2ICszMzksNyBAQCBpbmxpbmUgYm9v bCBvcGVyYXRvciE9KGNvbnN0IFN0cmluZyYgYSwgY29uc3QgVVJMJiBiKQogaW5saW5lIFVSTDo6 VVJMKEhhc2hUYWJsZURlbGV0ZWRWYWx1ZVR5cGUpCiAgICAgOiBtX3N0cmluZyhIYXNoVGFibGVE ZWxldGVkVmFsdWUpCiB7CisgICAgaW52YWxpZGF0ZSgpOwogfQogCiBpbmxpbmUgYm9vbCBVUkw6 OmlzTnVsbCgpIGNvbnN0Cg== 426619 2021-04-20 17:06:34 -0700 2021-04-20 17:42:49 -0700 Patch bug-224755-20210420190634.patch text/plain 3012 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTM3OGUyN2UzN2I4MjUx ZTUzZmM0Nzk5OTBhNTAxYzU3OTZmYjI2MS4uOTkwMjI5MDk2NWVhZDA5OWZiZGE1NDM1YTA1MDk4 OTI5NWIzMDQwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA0LTIwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFVSTDo6VVJM KEhhc2hUYWJsZURlbGV0ZWRWYWx1ZVR5cGUpIHRyaWdnZXJzIC1XdW5pbml0aWFsaXplZCB3YXJu aW5ncyB3aXRoIEdDQyAxMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI0NzU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTXkgZmlyc3QgdGhvdWdodCBoZXJlIHdhcyB0byBqdXN0IGFsd2F5cyBmdWxseS1p bml0aWFsaXplIHRoZSBVUkwgb2JqZWN0IHdoZW4gdXNlZCBhcyBhCisgICAgICAgIEhhc2hUYWJs ZURlbGV0ZWRWYWx1ZSwgYnV0IEFsZXggaXMgY29uY2VybmVkIGl0IG1pZ2h0IGhhdmUgYSBwZXJm b3JtYW5jZSBpbXBhY3QuIEluc3RlYWQsCisgICAgICAgIGxldCdzIGhhdmUgU2VydmljZVdvcmtl clJlZ2lzdHJhdGlvbktleSB0cmFjayBmb3IgaXRzZWxmIHdoZXRoZXIgaXQgaXMgYQorICAgICAg ICBIYXNoVGFibGVEZWxldGVkVmFsdWUgaW5zdGVhZCBvZiByZWx5aW5nIG9uIGl0cyBtX3Njb3Bl IFVSTCB0byBkbyBzbyBmb3IgdXMuIFRoaXMgYXZvaWRzCisgICAgICAgIGNvcHlpbmcgdW5pbml0 aWFsaXplZCBkYXRhLCBhbmQgaXMgdW5saWtlbHkgdG8gcmVzdWx0IGluIHBlcmZvcm1hbmNlIGlt cGFjdC4KKworICAgICAgICBUaGVyZSBzaG91bGQgYmUgbm8gYmVoYXZpb3IgY2hhbmdlLiAoQWx0 aG91Z2ggd2Ugd2VyZSBjb3B5aW5nIHVuaW5pdGlhbGl6ZWQgZGF0YSBiZWZvcmUsIGl0CisgICAg ICAgIHdhcyBuZXZlciByZWFkLikKKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9TZXJ2aWNl V29ya2VyUmVnaXN0cmF0aW9uS2V5Lmg6CisgICAgICAgIChXVEY6Okhhc2hUcmFpdHM8V2ViQ29y ZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleT46OmNvbnN0cnVjdERlbGV0ZWRWYWx1ZSk6 CisgICAgICAgIChXVEY6Okhhc2hUcmFpdHM8V2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJh dGlvbktleT46OmlzRGVsZXRlZFZhbHVlKToKKwogMjAyMS0wNC0yMCAgQWRpdHlhIEtlZXJ0aGkg IDxha2VlcnRoaUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU11bRkNSXSBVcGRhdGUgZGF0ZS90 aW1lIHBpY2tlciBhcHBlYXJhbmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJz L3NlcnZpY2UvU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleS5oIGIvU291cmNlL1dlYkNvcmUv d29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXkuaAppbmRleCAyNzkx MjEyMTg4YjYyNGQwNGU0NWRmOWJlM2E3Y2I3NzU5M2IzOGViLi4wZTUzYWQyMjMyODg1MjJlMjdm ZjBlNThhYjg5OTk1MTBmMDVjMTE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJz L3NlcnZpY2UvU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5LmgKQEAgLTY2 LDggKzY2LDExIEBAIHB1YmxpYzoKICNlbmRpZgogCiBwcml2YXRlOgorICAgIGZyaWVuZCBjbGFz cyBIYXNoVHJhaXRzPFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXk+OworCiAg ICAgU2VjdXJpdHlPcmlnaW5EYXRhIG1fdG9wT3JpZ2luOwogICAgIFVSTCBtX3Njb3BlOworICAg IGJvb2wgbV9pc0hhc2hUYWJsZURlbGV0ZWRWYWx1ZTsKIH07CiAKIHRlbXBsYXRlPGNsYXNzIEVu Y29kZXI+CkBAIC0xMDYsOCArMTA5LDggQEAgc3RydWN0IFNlcnZpY2VXb3JrZXJSZWdpc3RyYXRp b25LZXlIYXNoIHsKIHRlbXBsYXRlPD4gc3RydWN0IEhhc2hUcmFpdHM8V2ViQ29yZTo6U2Vydmlj ZVdvcmtlclJlZ2lzdHJhdGlvbktleT4gOiBHZW5lcmljSGFzaFRyYWl0czxXZWJDb3JlOjpTZXJ2 aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5PiB7CiAgICAgc3RhdGljIFdlYkNvcmU6OlNlcnZpY2VX b3JrZXJSZWdpc3RyYXRpb25LZXkgZW1wdHlWYWx1ZSgpIHsgcmV0dXJuIFdlYkNvcmU6OlNlcnZp Y2VXb3JrZXJSZWdpc3RyYXRpb25LZXk6OmVtcHR5S2V5KCk7IH0KIAotICAgIHN0YXRpYyB2b2lk IGNvbnN0cnVjdERlbGV0ZWRWYWx1ZShXZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9u S2V5JiBzbG90KSB7IHNsb3Quc2V0U2NvcGUoVVJMKEhhc2hUYWJsZURlbGV0ZWRWYWx1ZSkpOyB9 Ci0gICAgc3RhdGljIGJvb2wgaXNEZWxldGVkVmFsdWUoY29uc3QgV2ViQ29yZTo6U2VydmljZVdv cmtlclJlZ2lzdHJhdGlvbktleSYgc2xvdCkgeyByZXR1cm4gc2xvdC5zY29wZSgpLmlzSGFzaFRh YmxlRGVsZXRlZFZhbHVlKCk7IH0KKyAgICBzdGF0aWMgdm9pZCBjb25zdHJ1Y3REZWxldGVkVmFs dWUoV2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleSYgc2xvdCkgeyBzbG90Lm1f aXNIYXNoVGFibGVEZWxldGVkVmFsdWUgPSB0cnVlOyB9CisgICAgc3RhdGljIGJvb2wgaXNEZWxl dGVkVmFsdWUoY29uc3QgV2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleSYgc2xv dCkgeyByZXR1cm4gc2xvdC5tX2lzSGFzaFRhYmxlRGVsZXRlZFZhbHVlOyB9CiB9OwogCiB0ZW1w bGF0ZTw+IHN0cnVjdCBEZWZhdWx0SGFzaDxXZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0 aW9uS2V5PiA6IFNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXlIYXNoIHsgfTsK 426623 2021-04-20 17:42:00 -0700 2021-04-20 18:13:00 -0700 Patch bug-224755-20210420194159.patch text/plain 3013 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTM3OGUyN2UzN2I4MjUx ZTUzZmM0Nzk5OTBhNTAxYzU3OTZmYjI2MS4uOTkwMjI5MDk2NWVhZDA5OWZiZGE1NDM1YTA1MDk4 OTI5NWIzMDQwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA0LTIwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFVSTDo6VVJM KEhhc2hUYWJsZURlbGV0ZWRWYWx1ZVR5cGUpIHRyaWdnZXJzIC1XdW5pbml0aWFsaXplZCB3YXJu aW5ncyB3aXRoIEdDQyAxMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI0NzU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTXkgZmlyc3QgdGhvdWdodCBoZXJlIHdhcyB0byBqdXN0IGFsd2F5cyBmdWxseS1p bml0aWFsaXplIHRoZSBVUkwgb2JqZWN0IHdoZW4gdXNlZCBhcyBhCisgICAgICAgIEhhc2hUYWJs ZURlbGV0ZWRWYWx1ZSwgYnV0IEFsZXggaXMgY29uY2VybmVkIGl0IG1pZ2h0IGhhdmUgYSBwZXJm b3JtYW5jZSBpbXBhY3QuIEluc3RlYWQsCisgICAgICAgIGxldCdzIGhhdmUgU2VydmljZVdvcmtl clJlZ2lzdHJhdGlvbktleSB0cmFjayBmb3IgaXRzZWxmIHdoZXRoZXIgaXQgaXMgYQorICAgICAg ICBIYXNoVGFibGVEZWxldGVkVmFsdWUgaW5zdGVhZCBvZiByZWx5aW5nIG9uIGl0cyBtX3Njb3Bl IFVSTCB0byBkbyBzbyBmb3IgdXMuIFRoaXMgYXZvaWRzCisgICAgICAgIGNvcHlpbmcgdW5pbml0 aWFsaXplZCBkYXRhLCBhbmQgaXMgdW5saWtlbHkgdG8gcmVzdWx0IGluIHBlcmZvcm1hbmNlIGlt cGFjdC4KKworICAgICAgICBUaGVyZSBzaG91bGQgYmUgbm8gYmVoYXZpb3IgY2hhbmdlLiAoQWx0 aG91Z2ggd2Ugd2VyZSBjb3B5aW5nIHVuaW5pdGlhbGl6ZWQgZGF0YSBiZWZvcmUsIGl0CisgICAg ICAgIHdhcyBuZXZlciByZWFkLikKKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9TZXJ2aWNl V29ya2VyUmVnaXN0cmF0aW9uS2V5Lmg6CisgICAgICAgIChXVEY6Okhhc2hUcmFpdHM8V2ViQ29y ZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleT46OmNvbnN0cnVjdERlbGV0ZWRWYWx1ZSk6 CisgICAgICAgIChXVEY6Okhhc2hUcmFpdHM8V2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJh dGlvbktleT46OmlzRGVsZXRlZFZhbHVlKToKKwogMjAyMS0wNC0yMCAgQWRpdHlhIEtlZXJ0aGkg IDxha2VlcnRoaUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU11bRkNSXSBVcGRhdGUgZGF0ZS90 aW1lIHBpY2tlciBhcHBlYXJhbmNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJz L3NlcnZpY2UvU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleS5oIGIvU291cmNlL1dlYkNvcmUv d29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXkuaAppbmRleCAyNzkx MjEyMTg4YjYyNGQwNGU0NWRmOWJlM2E3Y2I3NzU5M2IzOGViLi4yNzhmZWZkYWQ3YzgzMmZhOTRj YmYxM2FkNGNiOTQwZTc5OWJhNjQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJz L3NlcnZpY2UvU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleS5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5LmgKQEAgLTY2 LDggKzY2LDExIEBAIHB1YmxpYzoKICNlbmRpZgogCiBwcml2YXRlOgorICAgIGZyaWVuZCBzdHJ1 Y3QgSGFzaFRyYWl0czxXZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5PjsKKwog ICAgIFNlY3VyaXR5T3JpZ2luRGF0YSBtX3RvcE9yaWdpbjsKICAgICBVUkwgbV9zY29wZTsKKyAg ICBib29sIG1faXNIYXNoVGFibGVEZWxldGVkVmFsdWU7CiB9OwogCiB0ZW1wbGF0ZTxjbGFzcyBF bmNvZGVyPgpAQCAtMTA2LDggKzEwOSw4IEBAIHN0cnVjdCBTZXJ2aWNlV29ya2VyUmVnaXN0cmF0 aW9uS2V5SGFzaCB7CiB0ZW1wbGF0ZTw+IHN0cnVjdCBIYXNoVHJhaXRzPFdlYkNvcmU6OlNlcnZp Y2VXb3JrZXJSZWdpc3RyYXRpb25LZXk+IDogR2VuZXJpY0hhc2hUcmFpdHM8V2ViQ29yZTo6U2Vy dmljZVdvcmtlclJlZ2lzdHJhdGlvbktleT4gewogICAgIHN0YXRpYyBXZWJDb3JlOjpTZXJ2aWNl V29ya2VyUmVnaXN0cmF0aW9uS2V5IGVtcHR5VmFsdWUoKSB7IHJldHVybiBXZWJDb3JlOjpTZXJ2 aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5OjplbXB0eUtleSgpOyB9CiAKLSAgICBzdGF0aWMgdm9p ZCBjb25zdHJ1Y3REZWxldGVkVmFsdWUoV2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlv bktleSYgc2xvdCkgeyBzbG90LnNldFNjb3BlKFVSTChIYXNoVGFibGVEZWxldGVkVmFsdWUpKTsg fQotICAgIHN0YXRpYyBib29sIGlzRGVsZXRlZFZhbHVlKGNvbnN0IFdlYkNvcmU6OlNlcnZpY2VX b3JrZXJSZWdpc3RyYXRpb25LZXkmIHNsb3QpIHsgcmV0dXJuIHNsb3Quc2NvcGUoKS5pc0hhc2hU YWJsZURlbGV0ZWRWYWx1ZSgpOyB9CisgICAgc3RhdGljIHZvaWQgY29uc3RydWN0RGVsZXRlZFZh bHVlKFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXkmIHNsb3QpIHsgc2xvdC5t X2lzSGFzaFRhYmxlRGVsZXRlZFZhbHVlID0gdHJ1ZTsgfQorICAgIHN0YXRpYyBib29sIGlzRGVs ZXRlZFZhbHVlKGNvbnN0IFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXkmIHNs b3QpIHsgcmV0dXJuIHNsb3QubV9pc0hhc2hUYWJsZURlbGV0ZWRWYWx1ZTsgfQogfTsKIAogdGVt cGxhdGU8PiBzdHJ1Y3QgRGVmYXVsdEhhc2g8V2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJh dGlvbktleT4gOiBTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5SGFzaCB7IH07Cg== 426626 2021-04-20 18:13:02 -0700 2021-04-20 19:14:29 -0700 Patch bug-224755-20210420201302.patch text/plain 3071 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmY5NmU5MjU5N2I5OGQz NDQ1ZDk0OGNmMjBiNDM3ZTJjMmQzYjI3My4uZWRmMWFjNWY1NjY1ZjEzYWVlM2EwNzlhMmY2Yzg0 M2I2MjIxODRlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA0LTIwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFVSTDo6VVJM KEhhc2hUYWJsZURlbGV0ZWRWYWx1ZVR5cGUpIHRyaWdnZXJzIC1XdW5pbml0aWFsaXplZCB3YXJu aW5ncyB3aXRoIEdDQyAxMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI0NzU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTXkgZmlyc3QgdGhvdWdodCBoZXJlIHdhcyB0byBqdXN0IGFsd2F5cyBmdWxseS1p bml0aWFsaXplIHRoZSBVUkwgb2JqZWN0IHdoZW4gdXNlZCBhcyBhCisgICAgICAgIEhhc2hUYWJs ZURlbGV0ZWRWYWx1ZSwgYnV0IEFsZXggaXMgY29uY2VybmVkIGl0IG1pZ2h0IGhhdmUgYSBwZXJm b3JtYW5jZSBpbXBhY3QuIEluc3RlYWQsCisgICAgICAgIGxldCdzIGhhdmUgU2VydmljZVdvcmtl clJlZ2lzdHJhdGlvbktleSB0cmFjayBmb3IgaXRzZWxmIHdoZXRoZXIgaXQgaXMgYQorICAgICAg ICBIYXNoVGFibGVEZWxldGVkVmFsdWUgaW5zdGVhZCBvZiByZWx5aW5nIG9uIGl0cyBtX3Njb3Bl IFVSTCB0byBkbyBzbyBmb3IgdXMuIFRoaXMgYXZvaWRzCisgICAgICAgIGNvcHlpbmcgdW5pbml0 aWFsaXplZCBkYXRhLCBhbmQgaXMgdW5saWtlbHkgdG8gcmVzdWx0IGluIHBlcmZvcm1hbmNlIGlt cGFjdC4KKworICAgICAgICBUaGVyZSBzaG91bGQgYmUgbm8gYmVoYXZpb3IgY2hhbmdlLiAoQWx0 aG91Z2ggd2Ugd2VyZSBjb3B5aW5nIHVuaW5pdGlhbGl6ZWQgZGF0YSBiZWZvcmUsIGl0CisgICAg ICAgIHdhcyBuZXZlciByZWFkLikKKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9TZXJ2aWNl V29ya2VyUmVnaXN0cmF0aW9uS2V5Lmg6CisgICAgICAgIChXVEY6Okhhc2hUcmFpdHM8V2ViQ29y ZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleT46OmNvbnN0cnVjdERlbGV0ZWRWYWx1ZSk6 CisgICAgICAgIChXVEY6Okhhc2hUcmFpdHM8V2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJh dGlvbktleT46OmlzRGVsZXRlZFZhbHVlKToKKwogMjAyMS0wNC0yMCAgQnJlbnQgRnVsZ2hhbSAg PGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbQ29jb2FdIFByZXZlbnQgR1BVIGFuZCBX ZWJDb250ZW50IHByb2Nlc3NlcyBmcm9tIGF0dGVtcHRpbmcgdG8gY29ubmVjdCB0byB0aGUgQXBw U1NPIHNlcnZpY2UgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uv U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleS5oIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9z ZXJ2aWNlL1NlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXkuaAppbmRleCAyNzkxMjEyMTg4YjYy NGQwNGU0NWRmOWJlM2E3Y2I3NzU5M2IzOGViLi5iYjNiZTQ1OTQwNDk0N2QyYzQzMWZlOWQ5Zjhl YTNlYWY1YmM2ZWZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2Uv U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtl cnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5LmgKQEAgLTY2LDggKzY2LDEx IEBAIHB1YmxpYzoKICNlbmRpZgogCiBwcml2YXRlOgorICAgIGZyaWVuZCBzdHJ1Y3QgSGFzaFRy YWl0czxXZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5PjsKKwogICAgIFNlY3Vy aXR5T3JpZ2luRGF0YSBtX3RvcE9yaWdpbjsKICAgICBVUkwgbV9zY29wZTsKKyAgICBib29sIG1f aXNIYXNoVGFibGVEZWxldGVkVmFsdWUgeyBmYWxzZSB9OwogfTsKIAogdGVtcGxhdGU8Y2xhc3Mg RW5jb2Rlcj4KQEAgLTEwNiw4ICsxMDksOCBAQCBzdHJ1Y3QgU2VydmljZVdvcmtlclJlZ2lzdHJh dGlvbktleUhhc2ggewogdGVtcGxhdGU8PiBzdHJ1Y3QgSGFzaFRyYWl0czxXZWJDb3JlOjpTZXJ2 aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5PiA6IEdlbmVyaWNIYXNoVHJhaXRzPFdlYkNvcmU6OlNl cnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXk+IHsKICAgICBzdGF0aWMgV2ViQ29yZTo6U2Vydmlj ZVdvcmtlclJlZ2lzdHJhdGlvbktleSBlbXB0eVZhbHVlKCkgeyByZXR1cm4gV2ViQ29yZTo6U2Vy dmljZVdvcmtlclJlZ2lzdHJhdGlvbktleTo6ZW1wdHlLZXkoKTsgfQogCi0gICAgc3RhdGljIHZv aWQgY29uc3RydWN0RGVsZXRlZFZhbHVlKFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRp b25LZXkmIHNsb3QpIHsgc2xvdC5zZXRTY29wZShVUkwoSGFzaFRhYmxlRGVsZXRlZFZhbHVlKSk7 IH0KLSAgICBzdGF0aWMgYm9vbCBpc0RlbGV0ZWRWYWx1ZShjb25zdCBXZWJDb3JlOjpTZXJ2aWNl V29ya2VyUmVnaXN0cmF0aW9uS2V5JiBzbG90KSB7IHJldHVybiBzbG90LnNjb3BlKCkuaXNIYXNo VGFibGVEZWxldGVkVmFsdWUoKTsgfQorICAgIHN0YXRpYyB2b2lkIGNvbnN0cnVjdERlbGV0ZWRW YWx1ZShXZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5JiBzbG90KSB7IHNsb3Qu bV9pc0hhc2hUYWJsZURlbGV0ZWRWYWx1ZSA9IHRydWU7IH0KKyAgICBzdGF0aWMgYm9vbCBpc0Rl bGV0ZWRWYWx1ZShjb25zdCBXZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5JiBz bG90KSB7IHJldHVybiBzbG90Lm1faXNIYXNoVGFibGVEZWxldGVkVmFsdWU7IH0KIH07CiAKIHRl bXBsYXRlPD4gc3RydWN0IERlZmF1bHRIYXNoPFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJSZWdpc3Ry YXRpb25LZXk+IDogU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleUhhc2ggeyB9Owo= 426632 2021-04-20 19:14:32 -0700 2021-04-20 19:29:56 -0700 Patch bug-224755-20210420211431.patch text/plain 3004 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmY5NmU5MjU5N2I5OGQz NDQ1ZDk0OGNmMjBiNDM3ZTJjMmQzYjI3My4uZjJlZDM3OGZhMjIzZTY2NjdhYWI0MjU2YWI1ZDY1 NzA3ZjQzMTMyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA0LTIwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFVSTDo6VVJM KEhhc2hUYWJsZURlbGV0ZWRWYWx1ZVR5cGUpIHRyaWdnZXJzIC1XdW5pbml0aWFsaXplZCB3YXJu aW5ncyB3aXRoIEdDQyAxMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI0NzU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkKKwor ICAgICAgICBNeSBmaXJzdCB0aG91Z2h0IGhlcmUgd2FzIHRvIGp1c3QgYWx3YXlzIGZ1bGx5LWlu aXRpYWxpemUgdGhlIFVSTCBvYmplY3Qgd2hlbiB1c2VkIGFzIGEKKyAgICAgICAgSGFzaFRhYmxl RGVsZXRlZFZhbHVlLCBidXQgQWxleCBpcyBjb25jZXJuZWQgaXQgbWlnaHQgaGF2ZSBhIHBlcmZv cm1hbmNlIGltcGFjdC4gSW5zdGVhZCwKKyAgICAgICAgQ2hyaXMgc3VnZ2VzdGVkIHdlIGNvdWxk IHVzZSB0aGUgU2VjdXJpdHlPcmlnaW5EYXRhIHJhdGhlciB0aGFuIFVSTCB0byB0cmFjayB3aGV0 aGVyIHdlIGFyZQorICAgICAgICBhIEhhc2hUYWJsZURlbGV0ZWRWYWx1ZS4gVGhpcyBzZWVtcyBn b29kIGJlY2F1c2UgaXQgYXZvaWRzIGFueSBzaXplIGluY3JlYXNlIGluCisgICAgICAgIFNlcnZp Y2VXb3JrZXJSZWdpc3RyYXRpb25LZXkuCisKKyAgICAgICAgVGhlcmUgc2hvdWxkIGJlIG5vIGJl aGF2aW9yIGNoYW5nZS4gKEFsdGhvdWdoIHdlIHdlcmUgY29weWluZyB1bmluaXRpYWxpemVkIGRh dGEgYmVmb3JlLCBpdAorICAgICAgICB3YXMgbmV2ZXIgcmVhZC4gSG9wZWZ1bGx5LikKKworICAg ICAgICAqIHdvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5Lmg6Cisg ICAgICAgIChXVEY6Okhhc2hUcmFpdHM8V2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlv bktleT46OmNvbnN0cnVjdERlbGV0ZWRWYWx1ZSk6CisgICAgICAgIChXVEY6Okhhc2hUcmFpdHM8 V2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleT46OmlzRGVsZXRlZFZhbHVlKToK KwogMjAyMS0wNC0yMCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAg ICAgICBbQ29jb2FdIFByZXZlbnQgR1BVIGFuZCBXZWJDb250ZW50IHByb2Nlc3NlcyBmcm9tIGF0 dGVtcHRpbmcgdG8gY29ubmVjdCB0byB0aGUgQXBwU1NPIHNlcnZpY2UgCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktl eS5oIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJSZWdpc3Ry YXRpb25LZXkuaAppbmRleCAyNzkxMjEyMTg4YjYyNGQwNGU0NWRmOWJlM2E3Y2I3NzU5M2IzOGVi Li5mM2Y3MGQ4ZjhhMzI5M2QyZDhiNTQ0YzFiYzk5NTkzZTVkNTE1MjE3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktl eS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUmVn aXN0cmF0aW9uS2V5LmgKQEAgLTY2LDYgKzY2LDggQEAgcHVibGljOgogI2VuZGlmCiAKIHByaXZh dGU6CisgICAgZnJpZW5kIHN0cnVjdCBIYXNoVHJhaXRzPFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJS ZWdpc3RyYXRpb25LZXk+OworCiAgICAgU2VjdXJpdHlPcmlnaW5EYXRhIG1fdG9wT3JpZ2luOwog ICAgIFVSTCBtX3Njb3BlOwogfTsKQEAgLTEwNiw4ICsxMDgsOCBAQCBzdHJ1Y3QgU2VydmljZVdv cmtlclJlZ2lzdHJhdGlvbktleUhhc2ggewogdGVtcGxhdGU8PiBzdHJ1Y3QgSGFzaFRyYWl0czxX ZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5PiA6IEdlbmVyaWNIYXNoVHJhaXRz PFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXk+IHsKICAgICBzdGF0aWMgV2Vi Q29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleSBlbXB0eVZhbHVlKCkgeyByZXR1cm4g V2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleTo6ZW1wdHlLZXkoKTsgfQogCi0g ICAgc3RhdGljIHZvaWQgY29uc3RydWN0RGVsZXRlZFZhbHVlKFdlYkNvcmU6OlNlcnZpY2VXb3Jr ZXJSZWdpc3RyYXRpb25LZXkmIHNsb3QpIHsgc2xvdC5zZXRTY29wZShVUkwoSGFzaFRhYmxlRGVs ZXRlZFZhbHVlKSk7IH0KLSAgICBzdGF0aWMgYm9vbCBpc0RlbGV0ZWRWYWx1ZShjb25zdCBXZWJD b3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5JiBzbG90KSB7IHJldHVybiBzbG90LnNj b3BlKCkuaXNIYXNoVGFibGVEZWxldGVkVmFsdWUoKTsgfQorICAgIHN0YXRpYyB2b2lkIGNvbnN0 cnVjdERlbGV0ZWRWYWx1ZShXZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5JiBz bG90KSB7IHNsb3QubV90b3BPcmlnaW4gPSBTZWN1cml0eU9yaWdpbkRhdGEoSGFzaFRhYmxlRGVs ZXRlZFZhbHVlKTsgfQorICAgIHN0YXRpYyBib29sIGlzRGVsZXRlZFZhbHVlKGNvbnN0IFdlYkNv cmU6OlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXkmIHNsb3QpIHsgcmV0dXJuIHNsb3QubV90 b3BPcmlnaW4uaXNIYXNoVGFibGVEZWxldGVkVmFsdWUoKTsgfQogfTsKIAogdGVtcGxhdGU8PiBz dHJ1Y3QgRGVmYXVsdEhhc2g8V2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleT4g OiBTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5SGFzaCB7IH07Cg== 426635 2021-04-20 19:27:06 -0700 2021-04-21 06:06:32 -0700 Patch bug-224755-20210420212705.patch text/plain 3013 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmY5NmU5MjU5N2I5OGQz NDQ1ZDk0OGNmMjBiNDM3ZTJjMmQzYjI3My4uZjJlZDM3OGZhMjIzZTY2NjdhYWI0MjU2YWI1ZDY1 NzA3ZjQzMTMyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA0LTIwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFVSTDo6VVJM KEhhc2hUYWJsZURlbGV0ZWRWYWx1ZVR5cGUpIHRyaWdnZXJzIC1XdW5pbml0aWFsaXplZCB3YXJu aW5ncyB3aXRoIEdDQyAxMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI0NzU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkKKwor ICAgICAgICBNeSBmaXJzdCB0aG91Z2h0IGhlcmUgd2FzIHRvIGp1c3QgYWx3YXlzIGZ1bGx5LWlu aXRpYWxpemUgdGhlIFVSTCBvYmplY3Qgd2hlbiB1c2VkIGFzIGEKKyAgICAgICAgSGFzaFRhYmxl RGVsZXRlZFZhbHVlLCBidXQgQWxleCBpcyBjb25jZXJuZWQgaXQgbWlnaHQgaGF2ZSBhIHBlcmZv cm1hbmNlIGltcGFjdC4gSW5zdGVhZCwKKyAgICAgICAgQ2hyaXMgc3VnZ2VzdGVkIHdlIGNvdWxk IHVzZSB0aGUgU2VjdXJpdHlPcmlnaW5EYXRhIHJhdGhlciB0aGFuIFVSTCB0byB0cmFjayB3aGV0 aGVyIHdlIGFyZQorICAgICAgICBhIEhhc2hUYWJsZURlbGV0ZWRWYWx1ZS4gVGhpcyBzZWVtcyBn b29kIGJlY2F1c2UgaXQgYXZvaWRzIGFueSBzaXplIGluY3JlYXNlIGluCisgICAgICAgIFNlcnZp Y2VXb3JrZXJSZWdpc3RyYXRpb25LZXkuCisKKyAgICAgICAgVGhlcmUgc2hvdWxkIGJlIG5vIGJl aGF2aW9yIGNoYW5nZS4gKEFsdGhvdWdoIHdlIHdlcmUgY29weWluZyB1bmluaXRpYWxpemVkIGRh dGEgYmVmb3JlLCBpdAorICAgICAgICB3YXMgbmV2ZXIgcmVhZC4gSG9wZWZ1bGx5LikKKworICAg ICAgICAqIHdvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5Lmg6Cisg ICAgICAgIChXVEY6Okhhc2hUcmFpdHM8V2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlv bktleT46OmNvbnN0cnVjdERlbGV0ZWRWYWx1ZSk6CisgICAgICAgIChXVEY6Okhhc2hUcmFpdHM8 V2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleT46OmlzRGVsZXRlZFZhbHVlKToK KwogMjAyMS0wNC0yMCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAg ICAgICBbQ29jb2FdIFByZXZlbnQgR1BVIGFuZCBXZWJDb250ZW50IHByb2Nlc3NlcyBmcm9tIGF0 dGVtcHRpbmcgdG8gY29ubmVjdCB0byB0aGUgQXBwU1NPIHNlcnZpY2UgCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktl eS5oIGIvU291cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJSZWdpc3Ry YXRpb25LZXkuaAppbmRleCAyNzkxMjEyMTg4YjYyNGQwNGU0NWRmOWJlM2E3Y2I3NzU5M2IzOGVi Li5lZWUxNjQ5ZWE3ZDI5NjkxMTk5NDU3ZjFlZTdlOWUwMmNlMjJiZTZkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktl eS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUmVn aXN0cmF0aW9uS2V5LmgKQEAgLTY2LDYgKzY2LDggQEAgcHVibGljOgogI2VuZGlmCiAKIHByaXZh dGU6CisgICAgZnJpZW5kIHN0cnVjdCBIYXNoVHJhaXRzPFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJS ZWdpc3RyYXRpb25LZXk+OworCiAgICAgU2VjdXJpdHlPcmlnaW5EYXRhIG1fdG9wT3JpZ2luOwog ICAgIFVSTCBtX3Njb3BlOwogfTsKQEAgLTEwNiw4ICsxMDgsOCBAQCBzdHJ1Y3QgU2VydmljZVdv cmtlclJlZ2lzdHJhdGlvbktleUhhc2ggewogdGVtcGxhdGU8PiBzdHJ1Y3QgSGFzaFRyYWl0czxX ZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5PiA6IEdlbmVyaWNIYXNoVHJhaXRz PFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXk+IHsKICAgICBzdGF0aWMgV2Vi Q29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleSBlbXB0eVZhbHVlKCkgeyByZXR1cm4g V2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleTo6ZW1wdHlLZXkoKTsgfQogCi0g ICAgc3RhdGljIHZvaWQgY29uc3RydWN0RGVsZXRlZFZhbHVlKFdlYkNvcmU6OlNlcnZpY2VXb3Jr ZXJSZWdpc3RyYXRpb25LZXkmIHNsb3QpIHsgc2xvdC5zZXRTY29wZShVUkwoSGFzaFRhYmxlRGVs ZXRlZFZhbHVlKSk7IH0KLSAgICBzdGF0aWMgYm9vbCBpc0RlbGV0ZWRWYWx1ZShjb25zdCBXZWJD b3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5JiBzbG90KSB7IHJldHVybiBzbG90LnNj b3BlKCkuaXNIYXNoVGFibGVEZWxldGVkVmFsdWUoKTsgfQorICAgIHN0YXRpYyB2b2lkIGNvbnN0 cnVjdERlbGV0ZWRWYWx1ZShXZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5JiBz bG90KSB7IHNsb3QubV90b3BPcmlnaW4gPSBXZWJDb3JlOjpTZWN1cml0eU9yaWdpbkRhdGEoSGFz aFRhYmxlRGVsZXRlZFZhbHVlKTsgfQorICAgIHN0YXRpYyBib29sIGlzRGVsZXRlZFZhbHVlKGNv bnN0IFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXkmIHNsb3QpIHsgcmV0dXJu IHNsb3QubV90b3BPcmlnaW4uaXNIYXNoVGFibGVEZWxldGVkVmFsdWUoKTsgfQogfTsKIAogdGVt cGxhdGU8PiBzdHJ1Y3QgRGVmYXVsdEhhc2g8V2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJh dGlvbktleT4gOiBTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5SGFzaCB7IH07Cg== 426674 2021-04-21 06:06:35 -0700 2021-04-21 08:30:31 -0700 Patch bug-224755-20210421080634.patch text/plain 3832 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWZhNjU3ZDEzYTlhMzA0 Y2I0YjkwYjZiOWQzMjJmMWRlMDA0MTgyMi4uMzY5YTE4ZmNjMjA3OTg5MjdlZjNkNzgwODlkMTE1 YTJlMGJmMTM3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTA0LTIxICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFVSTDo6VVJM KEhhc2hUYWJsZURlbGV0ZWRWYWx1ZVR5cGUpIHRyaWdnZXJzIC1XdW5pbml0aWFsaXplZCB3YXJu aW5ncyB3aXRoIEdDQyAxMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjI0NzU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMgRHVtZXoKKworICAg ICAgICBNeSBmaXJzdCB0aG91Z2h0IGhlcmUgd2FzIHRvIGp1c3QgYWx3YXlzIGZ1bGx5LWluaXRp YWxpemUgdGhlIFVSTCBvYmplY3Qgd2hlbiB1c2VkIGFzIGEKKyAgICAgICAgSGFzaFRhYmxlRGVs ZXRlZFZhbHVlLCBidXQgQWxleCBpcyBjb25jZXJuZWQgaXQgbWlnaHQgaGF2ZSBhIHBlcmZvcm1h bmNlIGltcGFjdC4gSW5zdGVhZCwKKyAgICAgICAgQ2hyaXMgc3VnZ2VzdGVkIHdlIGNvdWxkIHVz ZSB0aGUgU2VjdXJpdHlPcmlnaW5EYXRhIHJhdGhlciB0aGFuIFVSTCB0byB0cmFjayB3aGV0aGVy IHdlIGFyZQorICAgICAgICBhIEhhc2hUYWJsZURlbGV0ZWRWYWx1ZS4gVGhpcyBzZWVtcyBnb29k IGJlY2F1c2UgaXQgYXZvaWRzIGFueSBzaXplIGluY3JlYXNlIGluCisgICAgICAgIFNlcnZpY2VX b3JrZXJSZWdpc3RyYXRpb25LZXkuIEFkZGl0aW9uYWxseSwgbGV0J3MgZm9sbG93IERhcmluJ3Mg YWR2aWNlIHRvIGNvbnN0cnVjdCB0aGUKKyAgICAgICAgU2VydmljZVdvcmtlclJlZ2lzdHJhdGlv bktleSB1c2luZyBwbGFjZW1lbnQgbmV3IHJhdGhlciB0aGFuIHZpYSBhc3NpZ25tZW50IHRvIHRo ZQorICAgICAgICB1bmluaXRpYWxpemVkIHN0b3JhZ2UuCisKKyAgICAgICAgVGhlcmUgc2hvdWxk IGJlIG5vIGJlaGF2aW9yIGNoYW5nZS4gKEFsdGhvdWdoIHdlIHdlcmUgY29weWluZyB1bmluaXRp YWxpemVkIGRhdGEgYmVmb3JlLCBpdAorICAgICAgICB3YXMgbmV2ZXIgcmVhZC4gSG9wZWZ1bGx5 LikKKworICAgICAgICAqIHdvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9u S2V5Lmg6CisgICAgICAgIChXVEY6Okhhc2hUcmFpdHM8V2ViQ29yZTo6U2VydmljZVdvcmtlclJl Z2lzdHJhdGlvbktleT46OmNvbnN0cnVjdERlbGV0ZWRWYWx1ZSk6CisgICAgICAgIChXVEY6Okhh c2hUcmFpdHM8V2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleT46OmlzRGVsZXRl ZFZhbHVlKToKKwogMjAyMS0wNC0yMSAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQHdlYmtp dC5vcmc+CiAKICAgICAgICAgQWRkIGJhc2ljIChub24tbW9tZW50dW0pIHdoZWVsIGV2ZW50IGhh bmRsaW5nIGZvciBzY3JvbGwgc25hcApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vy cy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXkuaCBiL1NvdXJjZS9XZWJDb3Jl L3dvcmtlcnMvc2VydmljZS9TZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5LmgKaW5kZXggMjc5 MTIxMjE4OGI2MjRkMDRlNDVkZjliZTNhN2NiNzc1OTNiMzhlYi4uYWQ5NTZkMTFhY2YzMTI4YjBk NzA1OTE0YjAwZTNiMTMwMDdjNjUzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29ya2Vy cy9zZXJ2aWNlL1NlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXkuaAorKysgYi9Tb3VyY2UvV2Vi Q29yZS93b3JrZXJzL3NlcnZpY2UvU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleS5oCkBAIC0z NSw2ICszNSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIFNlcnZpY2VXb3JrZXJSZWdp c3RyYXRpb25LZXkgewogcHVibGljOgogICAgIFNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXko KSA9IGRlZmF1bHQ7CisgICAgZXhwbGljaXQgU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleShX VEY6Okhhc2hUYWJsZURlbGV0ZWRWYWx1ZVR5cGUpOwogICAgIFdFQkNPUkVfRVhQT1JUIFNlcnZp Y2VXb3JrZXJSZWdpc3RyYXRpb25LZXkoU2VjdXJpdHlPcmlnaW5EYXRhJiYgdG9wT3JpZ2luLCBV UkwmJiBzY29wZSk7CiAKICAgICBzdGF0aWMgU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleSBl bXB0eUtleSgpOwpAQCAtNjUsMTEgKzY2LDE4IEBAIHB1YmxpYzoKICAgICBTdHJpbmcgbG9nZ2lu Z1N0cmluZygpIGNvbnN0OwogI2VuZGlmCiAKKyAgICBib29sIGlzSGFzaFRhYmxlRGVsZXRlZFZh bHVlKCkgY29uc3QgeyByZXR1cm4gbV90b3BPcmlnaW4uaXNIYXNoVGFibGVEZWxldGVkVmFsdWUo KTsgfQorCiBwcml2YXRlOgogICAgIFNlY3VyaXR5T3JpZ2luRGF0YSBtX3RvcE9yaWdpbjsKICAg ICBVUkwgbV9zY29wZTsKIH07CiAKK2lubGluZSBTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5 OjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5KFdURjo6SGFzaFRhYmxlRGVsZXRlZFZhbHVl VHlwZSkKKyAgICA6IG1fdG9wT3JpZ2luKFdURjo6SGFzaFRhYmxlRGVsZXRlZFZhbHVlKQorewor fQorCiB0ZW1wbGF0ZTxjbGFzcyBFbmNvZGVyPgogdm9pZCBTZXJ2aWNlV29ya2VyUmVnaXN0cmF0 aW9uS2V5OjplbmNvZGUoRW5jb2RlciYgZW5jb2RlcikgY29uc3QKIHsKQEAgLTEwNiw4ICsxMTQs OCBAQCBzdHJ1Y3QgU2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleUhhc2ggewogdGVtcGxhdGU8 PiBzdHJ1Y3QgSGFzaFRyYWl0czxXZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5 PiA6IEdlbmVyaWNIYXNoVHJhaXRzPFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25L ZXk+IHsKICAgICBzdGF0aWMgV2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleSBl bXB0eVZhbHVlKCkgeyByZXR1cm4gV2ViQ29yZTo6U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktl eTo6ZW1wdHlLZXkoKTsgfQogCi0gICAgc3RhdGljIHZvaWQgY29uc3RydWN0RGVsZXRlZFZhbHVl KFdlYkNvcmU6OlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXkmIHNsb3QpIHsgc2xvdC5zZXRT Y29wZShVUkwoSGFzaFRhYmxlRGVsZXRlZFZhbHVlKSk7IH0KLSAgICBzdGF0aWMgYm9vbCBpc0Rl bGV0ZWRWYWx1ZShjb25zdCBXZWJDb3JlOjpTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9uS2V5JiBz bG90KSB7IHJldHVybiBzbG90LnNjb3BlKCkuaXNIYXNoVGFibGVEZWxldGVkVmFsdWUoKTsgfQor ICAgIHN0YXRpYyB2b2lkIGNvbnN0cnVjdERlbGV0ZWRWYWx1ZShXZWJDb3JlOjpTZXJ2aWNlV29y a2VyUmVnaXN0cmF0aW9uS2V5JiBzbG90KSB7IG5ldyAoTm90TnVsbCwgJnNsb3QpIFdlYkNvcmU6 OlNlcnZpY2VXb3JrZXJSZWdpc3RyYXRpb25LZXkoSGFzaFRhYmxlRGVsZXRlZFZhbHVlKTsgfQor ICAgIHN0YXRpYyBib29sIGlzRGVsZXRlZFZhbHVlKGNvbnN0IFdlYkNvcmU6OlNlcnZpY2VXb3Jr ZXJSZWdpc3RyYXRpb25LZXkmIHNsb3QpIHsgcmV0dXJuIHNsb3QuaXNIYXNoVGFibGVEZWxldGVk VmFsdWUoKTsgfQogfTsKIAogdGVtcGxhdGU8PiBzdHJ1Y3QgRGVmYXVsdEhhc2g8V2ViQ29yZTo6 U2VydmljZVdvcmtlclJlZ2lzdHJhdGlvbktleT4gOiBTZXJ2aWNlV29ya2VyUmVnaXN0cmF0aW9u S2V5SGFzaCB7IH07Cg==