224732 2021-04-18 11:19:47 -0700 GraphicsLayer::distributeOpacity, GraphicsLayer::setOpacityInternal and GraphicsLayer::accumulatedOpacity are never used 2021-04-24 15:05:43 -0700 1 1 1 Unclassified WebKit Compositing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam sam darin ews-watchlist kondapallykalyan sergio simon.fraser webkit-bug-importer oldest_to_newest 1751631 0 sam 2021-04-18 11:19:47 -0700 GraphicsLayer::distributeOpacity and GraphicsLayer::setOpacityInternal are never used 1751632 1 426381 sam 2021-04-18 11:24:30 -0700 Created attachment 426381 Patch 1751647 2 ews-feeder 2021-04-18 14:14:44 -0700 Committed r276232 (236714@main): <https://commits.webkit.org/236714@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426381. 1753915 3 webkit-bug-importer 2021-04-24 15:05:43 -0700 <rdar://problem/77110065> 426381 2021-04-18 11:24:30 -0700 2021-04-18 14:14:45 -0700 Patch bug-224732-20210418112429.patch text/plain 5060 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3NjIzMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA0LTE4ICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBHcmFwaGljc0xheWVyOjpkaXN0cmli dXRlT3BhY2l0eSwgR3JhcGhpY3NMYXllcjo6c2V0T3BhY2l0eUludGVybmFsIGFuZCBHcmFwaGlj c0xheWVyOjphY2N1bXVsYXRlZE9wYWNpdHkgYXJlIG5ldmVyIHVzZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDczMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBkZWFkIGNvZGUuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkdyYXBoaWNzTGF5ZXI6OmFjY3VtdWxhdGVkT3BhY2l0eSBjb25zdCk6IERlbGV0ZWQu CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0xheWVyOjpkaXN0cmlidXRlT3BhY2l0eSk6IERl bGV0ZWQuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllci5oOgorICAg ICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllcjo6c2V0T3BhY2l0eUludGVybmFsKTogRGVsZXRl ZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYS9HcmFwaGljc0xheWVyQ0EuY3BwOgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5oOgorCiAyMDIx LTA0LTE4ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgogCiAgICAgICAgIEZp eCBpbnRlcnBvbGF0aW9uIG9mIHRoZSByb3RhdGUgQ1NTIHByb3BlcnR5CkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmNwcAkocmV2 aXNpb24gMjc2MjMwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhp Y3NMYXllci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1NywzMCArNjU3LDYgQEAgdm9pZCBHcmFw aGljc0xheWVyOjpzZXRaUG9zaXRpb24oZmxvYXQgcAogICAgIG1felBvc2l0aW9uID0gcG9zaXRp b247CiB9CiAKLWZsb2F0IEdyYXBoaWNzTGF5ZXI6OmFjY3VtdWxhdGVkT3BhY2l0eSgpIGNvbnN0 Ci17Ci0gICAgaWYgKCFwcmVzZXJ2ZXMzRCgpKQotICAgICAgICByZXR1cm4gMTsKLSAgICAgICAg Ci0gICAgcmV0dXJuIG1fb3BhY2l0eSAqIChwYXJlbnQoKSA/IHBhcmVudCgpLT5hY2N1bXVsYXRl ZE9wYWNpdHkoKSA6IDEpOwotfQotCi12b2lkIEdyYXBoaWNzTGF5ZXI6OmRpc3RyaWJ1dGVPcGFj aXR5KGZsb2F0IGFjY3VtdWxhdGVkT3BhY2l0eSkKLXsKLSAgICAvLyBJZiB0aGlzIGlzIGEgdHJh bnNmb3JtIGxheWVyIHdlIG5lZWQgdG8gZGlzdHJpYnV0ZSBvdXIgb3BhY2l0eSB0byBhbGwgb3Vy IGNoaWxkcmVuCi0gICAgCi0gICAgLy8gSW5jb21pbmcgYWNjdW11bGF0ZWRPcGFjaXR5IGlzIHRo ZSBjb250cmlidXRpb24gZnJvbSBvdXIgcGFyZW50KHMpLiBXZSBtdXRpcGx5IHRoaXMgYnkgb3Vy IG93bgotICAgIC8vIG9wYWNpdHkgdG8gZ2V0IHRoZSB0b3RhbCBjb250cmlidXRpb24KLSAgICBh Y2N1bXVsYXRlZE9wYWNpdHkgKj0gbV9vcGFjaXR5OwotICAgIAotICAgIHNldE9wYWNpdHlJbnRl cm5hbChhY2N1bXVsYXRlZE9wYWNpdHkpOwotICAgIAotICAgIGlmIChwcmVzZXJ2ZXMzRCgpKSB7 Ci0gICAgICAgIGZvciAoYXV0byYgbGF5ZXIgOiBjaGlsZHJlbigpKQotICAgICAgICAgICAgbGF5 ZXItPmRpc3RyaWJ1dGVPcGFjaXR5KGFjY3VtdWxhdGVkT3BhY2l0eSk7Ci0gICAgfQotfQotCiBz dGF0aWMgaW5saW5lIGNvbnN0IEZpbHRlck9wZXJhdGlvbnMmIGZpbHRlck9wZXJhdGlvbnNBdChj b25zdCBLZXlmcmFtZVZhbHVlTGlzdCYgdmFsdWVMaXN0LCBzaXplX3QgaW5kZXgpCiB7CiAgICAg cmV0dXJuIHN0YXRpY19jYXN0PGNvbnN0IEZpbHRlckFuaW1hdGlvblZhbHVlJj4odmFsdWVMaXN0 LmF0KGluZGV4KSkudmFsdWUoKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL0dyYXBoaWNzTGF5ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9HcmFwaGljc0xheWVyLmgJKHJldmlzaW9uIDI3NjIzMCkKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuaAkod29ya2luZyBjb3B5KQpA QCAtNTYzLDkgKzU2Myw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGZsb2F0IHpQb3NpdGlvbigp IGNvbnN0IHsgcmV0dXJuIG1felBvc2l0aW9uOyB9CiAgICAgV0VCQ09SRV9FWFBPUlQgdmlydHVh bCB2b2lkIHNldFpQb3NpdGlvbihmbG9hdCk7CiAKLSAgICBXRUJDT1JFX0VYUE9SVCB2aXJ0dWFs IHZvaWQgZGlzdHJpYnV0ZU9wYWNpdHkoZmxvYXQpOwotICAgIFdFQkNPUkVfRVhQT1JUIHZpcnR1 YWwgZmxvYXQgYWNjdW11bGF0ZWRPcGFjaXR5KCkgY29uc3Q7Ci0KICAgICB2aXJ0dWFsIEZsb2F0 U2l6ZSBwaXhlbEFsaWdubWVudE9mZnNldCgpIGNvbnN0IHsgcmV0dXJuIEZsb2F0U2l6ZSgpOyB9 CiAgICAgCiAgICAgdmlydHVhbCB2b2lkIHNldEFwcGxpZXNQYWdlU2NhbGUoYm9vbCBhcHBsaWVz U2NhbGUgPSB0cnVlKSB7IG1fYXBwbGllc1BhZ2VTY2FsZSA9IGFwcGxpZXNTY2FsZTsgfQpAQCAt NjYyLDggKzY1OSw2IEBAIHByb3RlY3RlZDoKIAogICAgIHZpcnR1YWwgYm9vbCBzaG91bGRSZXBh aW50T25TaXplQ2hhbmdlKCkgY29uc3QgeyByZXR1cm4gZHJhd3NDb250ZW50KCk7IH0KIAotICAg IHZpcnR1YWwgdm9pZCBzZXRPcGFjaXR5SW50ZXJuYWwoZmxvYXQpIHsgfQotCiAgICAgLy8gVGhl IGxheWVyIGJlaW5nIHJlcGxpY2F0ZWQuCiAgICAgR3JhcGhpY3NMYXllciogcmVwbGljYXRlZExh eWVyKCkgY29uc3QgeyByZXR1cm4gbV9yZXBsaWNhdGVkTGF5ZXI7IH0KICAgICB2aXJ0dWFsIHZv aWQgc2V0UmVwbGljYXRlZExheWVyKEdyYXBoaWNzTGF5ZXIqIGxheWVyKSB7IG1fcmVwbGljYXRl ZExheWVyID0gbGF5ZXI7IH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2NhL0dyYXBoaWNzTGF5ZXJDQS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNwcAkocmV2aXNpb24gMjc2MjMwKQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDM3OSwyNyArNDM3OSw2IEBAIFJlZjxQbGF0Zm9ybUNBTGF5 ZXI+IEdyYXBoaWNzTGF5ZXJDQTo6Y2wKICAgICByZXR1cm4gbmV3TGF5ZXI7CiB9CiAKLXZvaWQg R3JhcGhpY3NMYXllckNBOjpzZXRPcGFjaXR5SW50ZXJuYWwoZmxvYXQgYWNjdW11bGF0ZWRPcGFj aXR5KQotewotICAgIExheWVyTWFwKiBsYXllckNsb25lTWFwID0gbnVsbHB0cjsKLSAgICAKLSAg ICBpZiAocHJlc2VydmVzM0QoKSkgewotICAgICAgICBtX2xheWVyLT5zZXRPcGFjaXR5KGFjY3Vt dWxhdGVkT3BhY2l0eSk7Ci0gICAgICAgIGxheWVyQ2xvbmVNYXAgPSBtX2xheWVyQ2xvbmVzID8g Jm1fbGF5ZXJDbG9uZXMtPnByaW1hcnlMYXllckNsb25lcyA6IG51bGxwdHI7Ci0gICAgfSBlbHNl IHsKLSAgICAgICAgcHJpbWFyeUxheWVyKCktPnNldE9wYWNpdHkoYWNjdW11bGF0ZWRPcGFjaXR5 KTsKLSAgICAgICAgbGF5ZXJDbG9uZU1hcCA9IHByaW1hcnlMYXllckNsb25lcygpOwotICAgIH0K LQotICAgIGlmIChsYXllckNsb25lTWFwKSB7Ci0gICAgICAgIGZvciAoYXV0byYgY2xvbmUgOiAq bGF5ZXJDbG9uZU1hcCkgewotICAgICAgICAgICAgaWYgKG1fcmVwbGljYUxheWVyICYmIGlzUmVw bGljYXRlZFJvb3RDbG9uZShjbG9uZS5rZXkpKQotICAgICAgICAgICAgICAgIGNvbnRpbnVlOwot ICAgICAgICAgICAgY2xvbmUudmFsdWUtPnNldE9wYWNpdHkobV9vcGFjaXR5KTsKLSAgICAgICAg fQotICAgIH0KLX0KLQogdm9pZCBHcmFwaGljc0xheWVyQ0E6OnVwZGF0ZU9wYWNpdHlPbkxheWVy KCkKIHsKICAgICBwcmltYXJ5TGF5ZXIoKS0+c2V0T3BhY2l0eShtX29wYWNpdHkpOwpJbmRleDog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NMYXllckNBLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvR3JhcGhpY3NM YXllckNBLmgJKHJldmlzaW9uIDI3NjIzMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NhL0dyYXBoaWNzTGF5ZXJDQS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xODgsOSArMTg4 LDYgQEAgcHVibGljOgogCiAgICAgV0VCQ09SRV9FWFBPUlQgVmVjdG9yPHN0ZDo6cGFpcjxTdHJp bmcsIGRvdWJsZT4+IGFjY2VsZXJhdGVkQW5pbWF0aW9uc0ZvclRlc3RpbmcoKSBjb25zdCBmaW5h bDsKIAotcHJvdGVjdGVkOgotICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgc2V0T3BhY2l0eUludGVy bmFsKGZsb2F0KSBvdmVycmlkZTsKLSAgICAKIHByaXZhdGU6CiAgICAgYm9vbCBpc0dyYXBoaWNz TGF5ZXJDQSgpIGNvbnN0IG92ZXJyaWRlIHsgcmV0dXJuIHRydWU7IH0KIAo=