224729 2021-04-18 01:41:47 -0700 [JSC] Use FixedVector for LLIntPrototypeLoadAdaptiveStructureWatchpoint vector 2021-04-23 02:55:50 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki darin ews-watchlist keith_miller lingcherd_ho mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1751590 0 ysuzuki 2021-04-18 01:41:47 -0700 [JSC] Use FixedVector for LLIntPrototypeLoadAdaptiveStructureWatchpoint vector 1751591 1 426374 ysuzuki 2021-04-18 01:42:09 -0700 Created attachment 426374 Patch 1751643 2 426374 darin 2021-04-18 14:02:23 -0700 Comment on attachment 426374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426374&action=review > Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:48 > + : Watchpoint(Watchpoint::Type::LLIntPrototypeLoadAdaptiveStructure) > + , m_owner(nullptr) > + , m_bytecodeOffset(0) Can we initialize some or all of these in the class definition instead of in the constructor? I guess not because of JSC_WATCHPOINT_FIELD. 1752158 3 426374 ysuzuki 2021-04-20 00:23:53 -0700 Comment on attachment 426374 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426374&action=review >> Source/JavaScriptCore/bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:48 >> + , m_bytecodeOffset(0) > > Can we initialize some or all of these in the class definition instead of in the constructor? I guess not because of JSC_WATCHPOINT_FIELD. Yes, we cannot do that. 1752160 4 ysuzuki 2021-04-20 00:26:20 -0700 Committed r276290 (236772@main): <https://commits.webkit.org/236772@main> 1753534 5 lingcherd_ho 2021-04-23 02:55:50 -0700 rdar://76884672 426374 2021-04-18 01:42:09 -0700 2021-04-18 14:02:23 -0700 Patch bug-224729-20210418014208.patch text/plain 5520 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx NTdjMjBhZjA5MzFiYWZkMjY3NmEyMDhlYjM5YjJmYjQ5NGU4NjdjLi5hMTA3YjE0OGQ1MTBhM2I1 ZTIxYTIxMzIyNWQ5ZWZmOWRkYTNkNjdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMS0wNC0xOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFVzZSBGaXhlZFZlY3RvciBmb3IgTExJbnRQcm90b3R5cGVMb2Fk QWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50IHZlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NzI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFjZSBWZWN0b3I8TExJbnRQcm90b3R5cGVM b2FkQWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50PiB3aXRoIEZpeGVkVmVjdG9yLgorCisgICAg ICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmg6CisgICAgICAgICogYnl0ZWNvZGUvTExJbnRQcm90 b3R5cGVMb2FkQWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50LmNwcDoKKyAgICAgICAgKEpTQzo6 TExJbnRQcm90b3R5cGVMb2FkQWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50OjpMTEludFByb3Rv dHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQpOgorICAgICAgICAoSlNDOjpMTElu dFByb3RvdHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQ6OmluaXRpYWxpemUpOgor ICAgICAgICAqIGJ5dGVjb2RlL0xMSW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0 Y2hwb2ludC5oOgorICAgICAgICAqIGxsaW50L0xMSW50U2xvd1BhdGhzLmNwcDoKKyAgICAgICAg KEpTQzo6TExJbnQ6OnNldHVwR2V0QnlJZFByb3RvdHlwZUNhY2hlKToKKwogMjAyMS0wNC0xOCAg WXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IGJ1aWxkIGZpeApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0Nv ZGVCbG9jay5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCmlu ZGV4IGRhMGUyMDc0MmYzMTBjMjdiMmM2M2ZjYTU0NzA3ZWE3MDhhYzlhNTcuLjE2ZThkNTFlMzI3 YzYyNzQ3NDhjMjUwZGFmNjc0NmFhN2ViNmQ3Y2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Ynl0ZWNvZGUvQ29kZUJsb2NrLmgKQEAgLTY2OSw3ICs2NjksNyBAQCBjbGFzcyBDb2RlQmxvY2sg OiBwdWJsaWMgSlNDZWxsIHsKICAgICAgICAgcmV0dXJuIG1fbGxpbnRFeGVjdXRlQ291bnRlcjsK ICAgICB9CiAKLSAgICB0eXBlZGVmIEhhc2hNYXA8c3RkOjp0dXBsZTxTdHJ1Y3R1cmVJRCwgdW5z aWduZWQ+LCBWZWN0b3I8TExJbnRQcm90b3R5cGVMb2FkQWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBv aW50Pj4gU3RydWN0dXJlV2F0Y2hwb2ludE1hcDsKKyAgICB0eXBlZGVmIEhhc2hNYXA8c3RkOjp0 dXBsZTxTdHJ1Y3R1cmVJRCwgdW5zaWduZWQ+LCBGaXhlZFZlY3RvcjxMTEludFByb3RvdHlwZUxv YWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQ+PiBTdHJ1Y3R1cmVXYXRjaHBvaW50TWFwOwog ICAgIFN0cnVjdHVyZVdhdGNocG9pbnRNYXAmIGxsaW50R2V0QnlJZFdhdGNocG9pbnRNYXAoKSB7 IHJldHVybiBtX2xsaW50R2V0QnlJZFdhdGNocG9pbnRNYXA7IH0KIAogICAgIC8vIEZ1bmN0aW9u cyBmb3IgY29udHJvbGxpbmcgd2hlbiB0aWVyZWQgY29tcGlsYXRpb24ga2lja3MgaW4uIFRoaXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9MTEludFByb3RvdHlw ZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQuY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL0xMSW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2lu dC5jcHAKaW5kZXggMjNhOWIxMzljOGRiMjE3M2ZiOGUzNDVhMTI4ZjMxMDU4YmU1YjJjYy4uMTFl YWEyMDc0YTBiYjU4ZDIyNTQ4N2RjNjAwODMzZjA5ZGFhYTQ4MyAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0xMSW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0 dXJlV2F0Y2hwb2ludC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0xM SW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludC5jcHAKQEAgLTQyLDYg KzQyLDIwIEBAIExMSW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludDo6 TExJbnRQcm90b3R5cGVMb2FkQWRhcHRpdmVTdHJ1Y3R1CiAgICAgUkVMRUFTRV9BU1NFUlQoIWtl eS53YXRjaGluZ1JlcXVpcmVzUmVwbGFjZW1lbnRXYXRjaHBvaW50KCkpOwogfQogCitMTEludFBy b3RvdHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQ6OkxMSW50UHJvdG90eXBlTG9h ZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludCgpCisgICAgOiBXYXRjaHBvaW50KFdhdGNocG9p bnQ6OlR5cGU6OkxMSW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlKQorICAgICwgbV9v d25lcihudWxscHRyKQorICAgICwgbV9ieXRlY29kZU9mZnNldCgwKQoreworfQorCit2b2lkIExM SW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludDo6aW5pdGlhbGl6ZShD b2RlQmxvY2sqIGNvZGVCbG9jaywgY29uc3QgT2JqZWN0UHJvcGVydHlDb25kaXRpb24mIGtleSwg dW5zaWduZWQgYnl0ZWNvZGVPZmZzZXQpCit7CisgICAgbV9vd25lciA9IGNvZGVCbG9jazsKKyAg ICBtX2J5dGVjb2RlT2Zmc2V0ID0gYnl0ZWNvZGVPZmZzZXQ7CisgICAgbV9rZXkgPSBrZXk7Cit9 CisKIHZvaWQgTExJbnRQcm90b3R5cGVMb2FkQWRhcHRpdmVTdHJ1Y3R1cmVXYXRjaHBvaW50Ojpp bnN0YWxsKFZNJiB2bSkKIHsKICAgICBSRUxFQVNFX0FTU0VSVChtX2tleS5pc1dhdGNoYWJsZSgp KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9MTEludFByb3Rv dHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ieXRlY29kZS9MTEludFByb3RvdHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9p bnQuaAppbmRleCAxZDU5NTdlZmY4MTA5MmExZGFiZGVlNTAyNWNhYzVlNmYzODY3ODJhLi4zNDlm NWEwYjhhNjg1YjUzNTA3YmQ4YjE3MWI2NjFhNGM0ODg5ZjllIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvTExJbnRQcm90b3R5cGVMb2FkQWRhcHRpdmVTdHJ1Y3R1 cmVXYXRjaHBvaW50LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0xMSW50 UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludC5oCkBAIC0zNiw2ICszNiw5 IEBAIG5hbWVzcGFjZSBKU0MgewogY2xhc3MgTExJbnRQcm90b3R5cGVMb2FkQWRhcHRpdmVTdHJ1 Y3R1cmVXYXRjaHBvaW50IGZpbmFsIDogcHVibGljIFdhdGNocG9pbnQgewogcHVibGljOgogICAg IExMSW50UHJvdG90eXBlTG9hZEFkYXB0aXZlU3RydWN0dXJlV2F0Y2hwb2ludChDb2RlQmxvY2sq LCBjb25zdCBPYmplY3RQcm9wZXJ0eUNvbmRpdGlvbiYsIHVuc2lnbmVkIGJ5dGVjb2RlT2Zmc2V0 KTsKKyAgICBMTEludFByb3RvdHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQoKTsK KworICAgIHZvaWQgaW5pdGlhbGl6ZShDb2RlQmxvY2sqLCBjb25zdCBPYmplY3RQcm9wZXJ0eUNv bmRpdGlvbiYsIHVuc2lnbmVkIGJ5dGVjb2RlT2Zmc2V0KTsKIAogICAgIHZvaWQgaW5zdGFsbChW TSYpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTExJbnRTbG93 UGF0aHMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmNw cAppbmRleCBiMDRmMGRjZWMxMTQ5ZjRkZmVlYmU0MTA1ZDU1ZmZiMThhYjAwMGU2Li4xNWZhMWFi YTA5MTRmYTIzNDc5ZDc4YWI2M2JkOTFjY2NmYmRmYjI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvbGxpbnQvTExJbnRTbG93UGF0aHMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9sbGludC9MTEludFNsb3dQYXRocy5jcHAKQEAgLTcyMywxNSArNzIzLDE2IEBAIHN0 YXRpYyB2b2lkIHNldHVwR2V0QnlJZFByb3RvdHlwZUNhY2hlKEpTR2xvYmFsT2JqZWN0KiBnbG9i YWxPYmplY3QsIFZNJiB2bSwgQ29kCiAgICAgdW5zaWduZWQgYnl0ZWNvZGVPZmZzZXQgPSBjb2Rl QmxvY2stPmJ5dGVjb2RlT2Zmc2V0KHBjKTsKICAgICBQcm9wZXJ0eU9mZnNldCBvZmZzZXQgPSBp bnZhbGlkT2Zmc2V0OwogICAgIENvZGVCbG9jazo6U3RydWN0dXJlV2F0Y2hwb2ludE1hcCYgd2F0 Y2hwb2ludE1hcCA9IGNvZGVCbG9jay0+bGxpbnRHZXRCeUlkV2F0Y2hwb2ludE1hcCgpOwotICAg IFZlY3RvcjxMTEludFByb3RvdHlwZUxvYWRBZGFwdGl2ZVN0cnVjdHVyZVdhdGNocG9pbnQ+IHdh dGNocG9pbnRzOwotICAgIHdhdGNocG9pbnRzLnJlc2VydmVJbml0aWFsQ2FwYWNpdHkoY29uZGl0 aW9ucy5zaXplKCkpOworICAgIEZpeGVkVmVjdG9yPExMSW50UHJvdG90eXBlTG9hZEFkYXB0aXZl U3RydWN0dXJlV2F0Y2hwb2ludD4gd2F0Y2hwb2ludHMoY29uZGl0aW9ucy5zaXplKCkpOworICAg IHVuc2lnbmVkIGluZGV4ID0gMDsKICAgICBmb3IgKE9iamVjdFByb3BlcnR5Q29uZGl0aW9uIGNv bmRpdGlvbiA6IGNvbmRpdGlvbnMpIHsKKyAgICAgICAgYXV0byYgd2F0Y2hwb2ludCA9IHdhdGNo cG9pbnRzW2luZGV4KytdOwogICAgICAgICBpZiAoIWNvbmRpdGlvbi5pc1dhdGNoYWJsZSgpKQog ICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBpZiAoY29uZGl0aW9uLmNvbmRpdGlvbigpLmtp bmQoKSA9PSBQcm9wZXJ0eUNvbmRpdGlvbjo6UHJlc2VuY2UpCiAgICAgICAgICAgICBvZmZzZXQg PSBjb25kaXRpb24uY29uZGl0aW9uKCkub2Zmc2V0KCk7Ci0gICAgICAgIHdhdGNocG9pbnRzLnVu Y2hlY2tlZENvbnN0cnVjdEFuZEFwcGVuZChjb2RlQmxvY2ssIGNvbmRpdGlvbiwgYnl0ZWNvZGVP ZmZzZXQpOwotICAgICAgICB3YXRjaHBvaW50cy5sYXN0KCkuaW5zdGFsbCh2bSk7CisgICAgICAg IHdhdGNocG9pbnQuaW5pdGlhbGl6ZShjb2RlQmxvY2ssIGNvbmRpdGlvbiwgYnl0ZWNvZGVPZmZz ZXQpOworICAgICAgICB3YXRjaHBvaW50Lmluc3RhbGwodm0pOwogICAgIH0KIAogICAgIEFTU0VS VCgob2Zmc2V0ID09IGludmFsaWRPZmZzZXQpID09IHNsb3QuaXNVbnNldCgpKTsK