224721 2021-04-17 12:47:30 -0700 [Curl] Remove warnings on curl layer. 2021-04-24 15:07:03 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke basuke darin don.olmstead ews-watchlist galpeter stephan.szabo takashi.komori webkit-bug-importer oldest_to_newest 1751450 0 basuke 2021-04-17 12:47:30 -0700 There's several warnings: [2033/5049] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/network/curl/CurlFormDataStream.cpp.o ../../Source/WebCore/platform/network/curl/CurlFormDataStream.cpp:131:60: warning: unused parameter 'blobData' [-Wunused-parameter] }, [] (const FormDataElement::EncodedBlobData& blobData) { ^ 1 warning generated. [2043/5049] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/network/curl/CookieJarDB.cpp.o ../../Source/WebCore/platform/network/curl/CookieJarDB.cpp:641:9: warning: unused variable 'ret' [-Wunused-variable] int ret = statement->prepare(); ^ 1 warning generated. [2044/5049] Building CXX object Source/WebCore/CMakeFiles/....dir/platform/network/curl/NetworkStorageSessionCurl.cpp.o ../../Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:98:133: warning: unused parameter 'frameID' [-Wunused-parameter] void NetworkStorageSession::setCookiesFromDOM(const URL& firstParty, const SameSiteInfo&, const URL& url, Optional<FrameIdentifier> frameID, Optional<PageIdentifier> pageID, ShouldAskITP, const String& value, ShouldRelaxThirdPartyCookieBlocking shouldRelaxThirdPartyCookieBlocking) const ^ ../../Source/WebCore/platform/network/curl/NetworkStorageSessionCurl.cpp:98:246: warning: unused parameter 'shouldRelaxThirdPartyCookieBlocking' [-Wunused-parameter] void NetworkStorageSession::setCookiesFromDOM(const URL& firstParty, const SameSiteInfo&, const URL& url, Optional<FrameIdentifier> frameID, Optional<PageIdentifier> pageID, ShouldAskITP, const String& value, ShouldRelaxThirdPartyCookieBlocking shouldRelaxThirdPartyCookieBlocking) const ^ 2 warnings generated. [2048/5049] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/network/curl/CurlRequest.cpp.o ../../Source/WebCore/platform/network/curl/CurlRequest.cpp:532:45: warning: unused parameter 'request' [-Wunused-parameter] void CurlRequest::setupPUT(ResourceRequest& request) ^ ../../Source/WebCore/platform/network/curl/CurlRequest.cpp:546:46: warning: unused parameter 'request' [-Wunused-parameter] void CurlRequest::setupPOST(ResourceRequest& request) ^ 2 warnings generated. 1751460 1 426346 basuke 2021-04-17 13:41:31 -0700 Created attachment 426346 PATCH 1751486 2 ews-feeder 2021-04-17 15:55:21 -0700 Committed r276211 (236693@main): <https://commits.webkit.org/236693@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426346. 1753926 3 webkit-bug-importer 2021-04-24 15:07:03 -0700 <rdar://problem/77110088> 426346 2021-04-17 13:41:31 -0700 2021-04-17 16:19:50 -0700 PATCH test.diff text/plain 5999 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyOGIyYWMyM2Q1ODYuLjkzOGYxYzc4ZmQ5YyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDI4IEBACisyMDIxLTA0LTE3ICBCYXN1a2UgU3V6dWtpICA8YmFzdWtlLnN1enVraUBz b255LmNvbT4KKworICAgICAgICBbQ3VybF0gUmVtb3ZlIHdhcm5pbmdzIG9uIGN1cmwgbGF5ZXIu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ3MjEK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUg dW51c2VkIHBhcmFtZXRlcnMgdG8gcHJldmVudCB3YXJuaW5ncy4gRm9yIEN1cmxSZXF1ZXN0LCBp dCBwYXNzZXMKKyAgICAgICAgbWVtYmVyIHZhcmlhYmxlIHRvIHByaXZhdGUgbWV0aG9kIHdoaWNo IGlzIG1lYW5pbmdsZXNzIHNvIHRoYXQgaXQgd2FzCisgICAgICAgIHJlbW92ZWQuCisKKyAgICAg ICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0IGZpbGVzLgorCisgICAgICAgICogcGxhdGZvcm0v bmV0d29yay9jdXJsL0Nvb2tpZUphckRCLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvb2tpZUph ckRCOjpjcmVhdGVQcmVwYXJlU3RhdGVtZW50KToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3Jr L2N1cmwvQ3VybEZvcm1EYXRhU3RyZWFtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkN1cmxGb3Jt RGF0YVN0cmVhbTo6cmVhZCk6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxS ZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkN1cmxSZXF1ZXN0OjpzZXR1cFRyYW5zZmVy KToKKyAgICAgICAgKFdlYkNvcmU6OkN1cmxSZXF1ZXN0OjpzZXR1cFBVVCk6CisgICAgICAgIChX ZWJDb3JlOjpDdXJsUmVxdWVzdDo6c2V0dXBQT1NUKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL2N1cmwvQ3VybFJlcXVlc3QuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwv TmV0d29ya1N0b3JhZ2VTZXNzaW9uQ3VybC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3Jr U3RvcmFnZVNlc3Npb246OnNldENvb2tpZXNGcm9tRE9NIGNvbnN0KToKKwogMjAyMS0wNC0xNiAg QnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBQZXJmb3JtIHBv cnQgYmxvY2tpbmcgZWFybGllciBpbiB0aGUgbG9hZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckRCLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvY3VybC9Db29raWVKYXJEQi5jcHAKaW5kZXggZGJjNDIzZjk0OTA3 Li4yNDI1ZjgzZDcyNjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY3VybC9Db29raWVKYXJEQi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9jdXJsL0Nvb2tpZUphckRCLmNwcApAQCAtNjM5LDcgKzYzOSw3IEBAIHZvaWQgQ29va2ll SmFyREI6OmNyZWF0ZVByZXBhcmVTdGF0ZW1lbnQoY29uc3QgU3RyaW5nJiBzcWwpCiB7CiAgICAg YXV0byBzdGF0ZW1lbnQgPSBtYWtlVW5pcXVlPFNRTGl0ZVN0YXRlbWVudD4obV9kYXRhYmFzZSwg c3FsKTsKICAgICBpbnQgcmV0ID0gc3RhdGVtZW50LT5wcmVwYXJlKCk7Ci0gICAgQVNTRVJUKHJl dCA9PSBTUUxJVEVfT0spOworICAgIEFTU0VSVF9VTlVTRUQocmV0LCByZXQgPT0gU1FMSVRFX09L KTsKICAgICBtX3N0YXRlbWVudHMuYWRkKHNxbCwgV1RGTW92ZShzdGF0ZW1lbnQpKTsKIH0KIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxGb3Jt RGF0YVN0cmVhbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3Vy bEZvcm1EYXRhU3RyZWFtLmNwcAppbmRleCAyNDdjNWYyZWIyZDkuLmNmZGJmMGExMWY0NSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxGb3JtRGF0 YVN0cmVhbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1 cmxGb3JtRGF0YVN0cmVhbS5jcHAKQEAgLTEyOCw3ICsxMjgsNyBAQCBPcHRpb25hbDxzaXplX3Q+ IEN1cmxGb3JtRGF0YVN0cmVhbTo6cmVhZChjaGFyKiBidWZmZXIsIHNpemVfdCBzaXplKQogICAg ICAgICAgICAgICAgIHJldHVybiByZWFkRnJvbURhdGEoYnl0ZXMsIGJ1ZmZlclBvc2l0aW9uLCBi dWZmZXJTaXplKTsKICAgICAgICAgICAgIH0sIFsmXSAoY29uc3QgRm9ybURhdGFFbGVtZW50OjpF bmNvZGVkRmlsZURhdGEmIGZpbGVEYXRhKSB7CiAgICAgICAgICAgICAgICAgcmV0dXJuIHJlYWRG cm9tRmlsZShmaWxlRGF0YSwgYnVmZmVyUG9zaXRpb24sIGJ1ZmZlclNpemUpOwotICAgICAgICAg ICAgfSwgW10gKGNvbnN0IEZvcm1EYXRhRWxlbWVudDo6RW5jb2RlZEJsb2JEYXRhJiBibG9iRGF0 YSkgeworICAgICAgICAgICAgfSwgW10gKGNvbnN0IEZvcm1EYXRhRWxlbWVudDo6RW5jb2RlZEJs b2JEYXRhJikgewogICAgICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAg ICAgICAgICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CiAgICAgICAgICAgICB9CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3QuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmNwcAppbmRl eCA0NjMzMDk3NzkzMWMuLmFhMDc0MTMzMGM2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3QuY3BwCkBAIC0yMTYsMTQgKzIxNiwx NCBAQCBDVVJMKiBDdXJsUmVxdWVzdDo6c2V0dXBUcmFuc2ZlcigpCiAgICAgaWYgKG1ldGhvZCA9 PSAiR0VUIikKICAgICAgICAgbV9jdXJsSGFuZGxlLT5lbmFibGVIdHRwR2V0UmVxdWVzdCgpOwog ICAgIGVsc2UgaWYgKG1ldGhvZCA9PSAiUE9TVCIpCi0gICAgICAgIHNldHVwUE9TVChtX3JlcXVl c3QpOworICAgICAgICBzZXR1cFBPU1QoKTsKICAgICBlbHNlIGlmIChtZXRob2QgPT0gIlBVVCIp Ci0gICAgICAgIHNldHVwUFVUKG1fcmVxdWVzdCk7CisgICAgICAgIHNldHVwUFVUKCk7CiAgICAg ZWxzZSBpZiAobWV0aG9kID09ICJIRUFEIikKICAgICAgICAgbV9jdXJsSGFuZGxlLT5lbmFibGVI dHRwSGVhZFJlcXVlc3QoKTsKICAgICBlbHNlIHsKICAgICAgICAgbV9jdXJsSGFuZGxlLT5zZXRI dHRwQ3VzdG9tUmVxdWVzdChtZXRob2QpOwotICAgICAgICBzZXR1cFBVVChtX3JlcXVlc3QpOwor ICAgICAgICBzZXR1cFBVVCgpOwogICAgIH0KIAogICAgIGlmICghbV91c2VyLmlzRW1wdHkoKSB8 fCAhbV9wYXNzd29yZC5pc0VtcHR5KCkpIHsKQEAgLTUyOSw3ICs1MjksNyBAQCB2b2lkIEN1cmxS ZXF1ZXN0OjphcHBlbmRBY2NlcHRMYW5ndWFnZUhlYWRlcihIVFRQSGVhZGVyTWFwJiBoZWFkZXIp CiAgICAgICAgIGhlYWRlci5hZGQoSFRUUEhlYWRlck5hbWU6OkFjY2VwdExhbmd1YWdlLCBsYW5n dWFnZSk7CiB9CiAKLXZvaWQgQ3VybFJlcXVlc3Q6OnNldHVwUFVUKFJlc291cmNlUmVxdWVzdCYg cmVxdWVzdCkKK3ZvaWQgQ3VybFJlcXVlc3Q6OnNldHVwUFVUKCkKIHsKICAgICBtX2N1cmxIYW5k bGUtPmVuYWJsZUh0dHBQdXRSZXF1ZXN0KCk7CiAKQEAgLTU0Myw3ICs1NDMsNyBAQCB2b2lkIEN1 cmxSZXF1ZXN0OjpzZXR1cFBVVChSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QpCiAgICAgc2V0dXBT ZW5kRGF0YSh0cnVlKTsKIH0KIAotdm9pZCBDdXJsUmVxdWVzdDo6c2V0dXBQT1NUKFJlc291cmNl UmVxdWVzdCYgcmVxdWVzdCkKK3ZvaWQgQ3VybFJlcXVlc3Q6OnNldHVwUE9TVCgpCiB7CiAgICAg bV9jdXJsSGFuZGxlLT5lbmFibGVIdHRwUG9zdFJlcXVlc3QoKTsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ3VybFJlcXVlc3QuaAppbmRleCBlNTMxNjU0 MjdjNTUuLmM5ZjM0YzAyNjdmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jdXJsL0N1cmxSZXF1ZXN0LmgKQEAgLTEzNSw4ICsxMzUsOCBAQCBwcml2YXRlOgog CiAgICAgLy8gRm9yIHNldHVwIAogICAgIHZvaWQgYXBwZW5kQWNjZXB0TGFuZ3VhZ2VIZWFkZXIo SFRUUEhlYWRlck1hcCYpOwotICAgIHZvaWQgc2V0dXBQT1NUKFJlc291cmNlUmVxdWVzdCYpOwot ICAgIHZvaWQgc2V0dXBQVVQoUmVzb3VyY2VSZXF1ZXN0Jik7CisgICAgdm9pZCBzZXR1cFBPU1Qo KTsKKyAgICB2b2lkIHNldHVwUFVUKCk7CiAgICAgdm9pZCBzZXR1cFNlbmREYXRhKGJvb2wgZm9y UHV0TWV0aG9kKTsKIAogICAgIC8vIFByb2Nlc3NpbmcgZm9yIERpZFJlY2VpdmVSZXNwb25zZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL05ldHdvcmtT dG9yYWdlU2Vzc2lvbkN1cmwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9j dXJsL05ldHdvcmtTdG9yYWdlU2Vzc2lvbkN1cmwuY3BwCmluZGV4IDEyYmQyNmQyMGJlMC4uNzA3 NzQ4NDM4OTNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1 cmwvTmV0d29ya1N0b3JhZ2VTZXNzaW9uQ3VybC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9jdXJsL05ldHdvcmtTdG9yYWdlU2Vzc2lvbkN1cmwuY3BwCkBAIC05NSwx MSArOTUsMTIgQEAgQ29va2llSmFyREImIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbjo6Y29va2llRGF0 YWJhc2UoKSBjb25zdAogICAgIHJldHVybiBtX2Nvb2tpZURhdGFiYXNlOwogfQogCi12b2lkIE5l dHdvcmtTdG9yYWdlU2Vzc2lvbjo6c2V0Q29va2llc0Zyb21ET00oY29uc3QgVVJMJiBmaXJzdFBh cnR5LCBjb25zdCBTYW1lU2l0ZUluZm8mLCBjb25zdCBVUkwmIHVybCwgT3B0aW9uYWw8RnJhbWVJ ZGVudGlmaWVyPiBmcmFtZUlELCBPcHRpb25hbDxQYWdlSWRlbnRpZmllcj4gcGFnZUlELCBTaG91 bGRBc2tJVFAsIGNvbnN0IFN0cmluZyYgdmFsdWUsIFNob3VsZFJlbGF4VGhpcmRQYXJ0eUNvb2tp ZUJsb2NraW5nIHNob3VsZFJlbGF4VGhpcmRQYXJ0eUNvb2tpZUJsb2NraW5nKSBjb25zdAordm9p ZCBOZXR3b3JrU3RvcmFnZVNlc3Npb246OnNldENvb2tpZXNGcm9tRE9NKGNvbnN0IFVSTCYgZmly c3RQYXJ0eSwgY29uc3QgU2FtZVNpdGVJbmZvJiwgY29uc3QgVVJMJiB1cmwsIE9wdGlvbmFsPEZy YW1lSWRlbnRpZmllcj4sIE9wdGlvbmFsPFBhZ2VJZGVudGlmaWVyPiBwYWdlSUQsIFNob3VsZEFz a0lUUCwgY29uc3QgU3RyaW5nJiB2YWx1ZSwgU2hvdWxkUmVsYXhUaGlyZFBhcnR5Q29va2llQmxv Y2tpbmcpIGNvbnN0CiB7CiAjaWYgRU5BQkxFKFJFU09VUkNFX0xPQURfU1RBVElTVElDUykKICAg ICBPcHRpb25hbDxTZWNvbmRzPiBjYXBwZWRMaWZldGltZSA9IGNsaWVudFNpZGVDb29raWVDYXAo UmVnaXN0cmFibGVEb21haW4geyBmaXJzdFBhcnR5IH0sIHBhZ2VJRCk7CiAjZWxzZQorICAgIFVO VVNFRF9QQVJBTShwYWdlSUQpOwogICAgIE9wdGlvbmFsPFNlY29uZHM+IGNhcHBlZExpZmV0aW1l ID0gV1RGOjpudWxsb3B0OwogI2VuZGlmCiAgICAgY29va2llRGF0YWJhc2UoKS5zZXRDb29raWUo Zmlyc3RQYXJ0eSwgdXJsLCB2YWx1ZSwgQ29va2llSmFyREI6OlNvdXJjZTo6U2NyaXB0LCBjYXBw ZWRMaWZldGltZSk7DQo=