224714 2021-04-16 22:21:08 -0700 [clang 11] Remove warning when converting WebCore::maxValueForCssLength from int to float 2022-06-30 16:57:56 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 204834 1 basuke basuke basuke cdumez esprehn+autocc ews-watchlist glenn gyuyoung.kim macpherson menard pnormand webkit-bug-importer oldest_to_newest 1751390 0 basuke 2021-04-16 22:21:08 -0700 In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-3a52ce78-136.cpp:8: In file included from WebCore/DerivedSources\StyleBuilderGenerated.cpp:10: ../../Source/WebCore/style\StyleBuilderConverter.h:1215:97: warning: implicit conversion from 'const int' to 'float' changes value from 33554429 to 33554428 [-Wimplicit-const-int-float-conversion] wordSpacing = Length(clampTo<float>(primitiveValue.doubleValue(), minValueForCssLength, maxValueForCssLength), LengthType::Percent); ~~~~~~~ ^~~~~~~~~~~~~~~~~~~~ 1 warning generated. 1751393 1 426323 basuke 2021-04-16 22:34:06 -0700 Created attachment 426323 PATCH 1751439 2 426340 basuke 2021-04-17 11:43:51 -0700 Created attachment 426340 PATCH 1751442 3 426340 cdumez 2021-04-17 12:00:42 -0700 Comment on attachment 426340 PATCH R=me assuming the boys are happy 1751449 4 basuke 2021-04-17 12:45:55 -0700 (In reply to Chris Dumez from comment #3) > Comment on attachment 426340 [details] > PATCH > > R=me assuming the boys are happy Thanks! 1751458 5 ews-feeder 2021-04-17 13:16:29 -0700 Committed r276205 (236687@main): <https://commits.webkit.org/236687@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426340. 1753929 6 webkit-bug-importer 2021-04-24 15:07:27 -0700 <rdar://problem/77110096> 1879600 7 bfulgham 2022-06-30 16:57:56 -0700 *** Bug 213972 has been marked as a duplicate of this bug. *** 426323 2021-04-16 22:34:06 -0700 2021-04-17 11:43:51 -0700 PATCH test.diff text/plain 2040 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyOGIyYWMyM2Q1ODYuLjI3MWY4NWY5NzI1MyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDIyIEBACisyMDIxLTA0LTE2ICBCYXN1a2UgU3V6dWtpICA8YmFzdWtlLnN1enVraUBz b255LmNvbT4KKworICAgICAgICBbY2xhbmcgMTFdIFJlbW92ZSB3YXJuaW5nIG9uIFN0eWxlQnVp bGRlckNvbnZlcnRlci5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjQ3MTQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBPbiBjbGFuZyAxMSwgdGhlIGNvbnZlcnNpb24gZnJvbSBjb25zdCBpbnQgV2ViQ29y ZTo6bWF4VmFsdWVGb3JDc3NMZW5ndGggKD0gMzM1NTQ0MjkpIHRvCisgICAgICAgIGZsb2F0IGdl bmVyYXRlcyBjb252ZXJzaW9uIHdhcm5pbmc6IAorICAgICAgICA+IHdhcm5pbmc6IGltcGxpY2l0 IGNvbnZlcnNpb24gZnJvbSAnY29uc3QgaW50JyB0byAnZmxvYXQnIGNoYW5nZXMgdmFsdWUgZnJv bSAzMzU1NDQyOSB0byAzMzU1NDQyOAorCisgICAgICAgIENoYW5naW5nIHRoZSB0YXJnZXQgdHlw ZSBmcm9tIGZsb2F0IHRvIGRvdWJsZSB3b3JrcyBmb3IgdGhpcy4gTGVuZ3RoIGNvbnN0cnVjdG9y IGFjY2VwdCBkb3VibGUKKyAgICAgICAgc28gdGhhdCB0aGVyZSdzIG5vIGRyYXdiYWNrIHdpdGgg dGhpcyBjaGFuZ2UuCisKKyAgICAgICAgTm8gdGVzdCBiZWNhdXNlIGl0J3MgY29tcGlsZXIgYmVo YXZpb3IuCisKKyAgICAgICAgKiBzdHlsZS9TdHlsZUJ1aWxkZXJDb252ZXJ0ZXIuaDoKKyAgICAg ICAgKFdlYkNvcmU6OlN0eWxlOjpCdWlsZGVyQ29udmVydGVyOjpjb252ZXJ0V29yZFNwYWNpbmcp OgorCiAyMDIxLTA0LTE2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAg ICAgICAgIFBlcmZvcm0gcG9ydCBibG9ja2luZyBlYXJsaWVyIGluIHRoZSBsb2FkCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZUJ1aWxkZXJDb252ZXJ0ZXIuaCBiL1NvdXJj ZS9XZWJDb3JlL3N0eWxlL1N0eWxlQnVpbGRlckNvbnZlcnRlci5oCmluZGV4IGNhMDFlMzY1OWQw Zi4uNTNmNzhiODhmMzk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZUJ1 aWxkZXJDb252ZXJ0ZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZUJ1aWxkZXJD b252ZXJ0ZXIuaApAQCAtMTIxMiw3ICsxMjEyLDcgQEAgaW5saW5lIE9wdGlvbmFsPExlbmd0aD4g QnVpbGRlckNvbnZlcnRlcjo6Y29udmVydFdvcmRTcGFjaW5nKEJ1aWxkZXJTdGF0ZSYgYnVpbGQK ICAgICBlbHNlIGlmIChwcmltaXRpdmVWYWx1ZS5pc0xlbmd0aCgpKQogICAgICAgICB3b3JkU3Bh Y2luZyA9IHByaW1pdGl2ZVZhbHVlLmNvbXB1dGVMZW5ndGg8TGVuZ3RoPihjc3N0b0xlbmd0aENv bnZlcnNpb25EYXRhV2l0aFRleHRab29tRmFjdG9yKGJ1aWxkZXJTdGF0ZSkpOwogICAgIGVsc2Ug aWYgKHByaW1pdGl2ZVZhbHVlLmlzUGVyY2VudGFnZSgpKQotICAgICAgICB3b3JkU3BhY2luZyA9 IExlbmd0aChjbGFtcFRvPGZsb2F0PihwcmltaXRpdmVWYWx1ZS5kb3VibGVWYWx1ZSgpLCBtaW5W YWx1ZUZvckNzc0xlbmd0aCwgbWF4VmFsdWVGb3JDc3NMZW5ndGgpLCBMZW5ndGhUeXBlOjpQZXJj ZW50KTsKKyAgICAgICAgd29yZFNwYWNpbmcgPSBMZW5ndGgoY2xhbXBUbzxkb3VibGU+KHByaW1p dGl2ZVZhbHVlLmRvdWJsZVZhbHVlKCksIG1pblZhbHVlRm9yQ3NzTGVuZ3RoLCBtYXhWYWx1ZUZv ckNzc0xlbmd0aCksIExlbmd0aFR5cGU6OlBlcmNlbnQpOwogICAgIGVsc2UgaWYgKHByaW1pdGl2 ZVZhbHVlLmlzTnVtYmVyKCkpCiAgICAgICAgIHdvcmRTcGFjaW5nID0gTGVuZ3RoKHByaW1pdGl2 ZVZhbHVlLmRvdWJsZVZhbHVlKCksIExlbmd0aFR5cGU6OkZpeGVkKTsKIA0K 426340 2021-04-17 11:43:51 -0700 2021-04-17 13:16:30 -0700 PATCH test.diff text/plain 2902 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyOGIyYWMyM2Q1ODYuLjg5YjQ1NTk1ZDNlNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDIyIEBACisyMDIxLTA0LTE2ICBCYXN1a2UgU3V6dWtpICA8YmFzdWtlLnN1enVraUBz b255LmNvbT4KKworICAgICAgICBbY2xhbmcgMTFdIFJlbW92ZSB3YXJuaW5nIHdoZW4gY29udmVy dGluZyBXZWJDb3JlOjptYXhWYWx1ZUZvckNzc0xlbmd0aCBmcm9tIGludCB0byBmbG9hdAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NzE0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMgRHVtZXouCisKKyAgICAgICAgT24gY2xhbmcgMTEsIHRo ZSBjb252ZXJzaW9uIGZyb20gY29uc3QgaW50IFdlYkNvcmU6Om1heFZhbHVlRm9yQ3NzTGVuZ3Ro ICg9IDMzNTU0NDI5KSB0bworICAgICAgICBmbG9hdCBnZW5lcmF0ZXMgY29udmVyc2lvbiB3YXJu aW5nOiAKKyAgICAgICAgPiB3YXJuaW5nOiBpbXBsaWNpdCBjb252ZXJzaW9uIGZyb20gJ2NvbnN0 IGludCcgdG8gJ2Zsb2F0JyBjaGFuZ2VzIHZhbHVlIGZyb20gMzM1NTQ0MjkgdG8gMzM1NTQ0MjgK KworICAgICAgICBDaGFuZ2luZyB0aGUgdGFyZ2V0IHR5cGUgZnJvbSBmbG9hdCB0byBkb3VibGUg d29ya3MgZm9yIHRoaXMuIExlbmd0aCBjb25zdHJ1Y3RvciBhY2NlcHQgZG91YmxlCisgICAgICAg IHNvIHRoYXQgdGhlcmUncyBubyBkcmF3YmFjayB3aXRoIHRoaXMgY2hhbmdlLgorCisgICAgICAg IE5vIHRlc3QgYmVjYXVzZSBpdCdzIGNvbXBpbGVyIGJlaGF2aW9yLgorCisgICAgICAgICogc3R5 bGUvU3R5bGVCdWlsZGVyQ29udmVydGVyLmg6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZTo6QnVp bGRlckNvbnZlcnRlcjo6Y29udmVydFdvcmRTcGFjaW5nKToKKwogMjAyMS0wNC0xNiAgQnJlbnQg RnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBQZXJmb3JtIHBvcnQgYmxv Y2tpbmcgZWFybGllciBpbiB0aGUgbG9hZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3Nz L0NTU1ByaW1pdGl2ZVZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVW YWx1ZS5jcHAKaW5kZXggMWIyMTJlYWI2ZTA1Li4xZjZiNDRkNWI4YWMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlLmNwcApAQCAtNTQyLDcgKzU0Miw3IEBAIHRlbXBsYXRl PD4gdW5zaWduZWQgQ1NTUHJpbWl0aXZlVmFsdWU6OmNvbXB1dGVMZW5ndGgoY29uc3QgQ1NTVG9M ZW5ndGhDb252ZXJzaW9uCiAKIHRlbXBsYXRlPD4gTGVuZ3RoIENTU1ByaW1pdGl2ZVZhbHVlOjpj b21wdXRlTGVuZ3RoKGNvbnN0IENTU1RvTGVuZ3RoQ29udmVyc2lvbkRhdGEmIGNvbnZlcnNpb25E YXRhKSBjb25zdAogewotICAgIHJldHVybiBMZW5ndGgoY2xhbXBUbzxmbG9hdD4oY29tcHV0ZUxl bmd0aERvdWJsZShjb252ZXJzaW9uRGF0YSksIG1pblZhbHVlRm9yQ3NzTGVuZ3RoLCBtYXhWYWx1 ZUZvckNzc0xlbmd0aCksIExlbmd0aFR5cGU6OkZpeGVkKTsKKyAgICByZXR1cm4gTGVuZ3RoKGNs YW1wVG88ZG91YmxlPihjb21wdXRlTGVuZ3RoRG91YmxlKGNvbnZlcnNpb25EYXRhKSwgbWluVmFs dWVGb3JDc3NMZW5ndGgsIG1heFZhbHVlRm9yQ3NzTGVuZ3RoKSwgTGVuZ3RoVHlwZTo6Rml4ZWQp OwogfQogCiB0ZW1wbGF0ZTw+IHNob3J0IENTU1ByaW1pdGl2ZVZhbHVlOjpjb21wdXRlTGVuZ3Ro KGNvbnN0IENTU1RvTGVuZ3RoQ29udmVyc2lvbkRhdGEmIGNvbnZlcnNpb25EYXRhKSBjb25zdApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVCdWlsZGVyQ29udmVydGVyLmgg Yi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZUJ1aWxkZXJDb252ZXJ0ZXIuaAppbmRleCBjYTAx ZTM2NTlkMGYuLjUzZjc4Yjg4ZjM5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3R5bGUv U3R5bGVCdWlsZGVyQ29udmVydGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVC dWlsZGVyQ29udmVydGVyLmgKQEAgLTEyMTIsNyArMTIxMiw3IEBAIGlubGluZSBPcHRpb25hbDxM ZW5ndGg+IEJ1aWxkZXJDb252ZXJ0ZXI6OmNvbnZlcnRXb3JkU3BhY2luZyhCdWlsZGVyU3RhdGUm IGJ1aWxkCiAgICAgZWxzZSBpZiAocHJpbWl0aXZlVmFsdWUuaXNMZW5ndGgoKSkKICAgICAgICAg d29yZFNwYWNpbmcgPSBwcmltaXRpdmVWYWx1ZS5jb21wdXRlTGVuZ3RoPExlbmd0aD4oY3NzdG9M ZW5ndGhDb252ZXJzaW9uRGF0YVdpdGhUZXh0Wm9vbUZhY3RvcihidWlsZGVyU3RhdGUpKTsKICAg ICBlbHNlIGlmIChwcmltaXRpdmVWYWx1ZS5pc1BlcmNlbnRhZ2UoKSkKLSAgICAgICAgd29yZFNw YWNpbmcgPSBMZW5ndGgoY2xhbXBUbzxmbG9hdD4ocHJpbWl0aXZlVmFsdWUuZG91YmxlVmFsdWUo KSwgbWluVmFsdWVGb3JDc3NMZW5ndGgsIG1heFZhbHVlRm9yQ3NzTGVuZ3RoKSwgTGVuZ3RoVHlw ZTo6UGVyY2VudCk7CisgICAgICAgIHdvcmRTcGFjaW5nID0gTGVuZ3RoKGNsYW1wVG88ZG91Ymxl PihwcmltaXRpdmVWYWx1ZS5kb3VibGVWYWx1ZSgpLCBtaW5WYWx1ZUZvckNzc0xlbmd0aCwgbWF4 VmFsdWVGb3JDc3NMZW5ndGgpLCBMZW5ndGhUeXBlOjpQZXJjZW50KTsKICAgICBlbHNlIGlmIChw cmltaXRpdmVWYWx1ZS5pc051bWJlcigpKQogICAgICAgICB3b3JkU3BhY2luZyA9IExlbmd0aChw cmltaXRpdmVWYWx1ZS5kb3VibGVWYWx1ZSgpLCBMZW5ndGhUeXBlOjpGaXhlZCk7CiANCg==