224710 2021-04-16 20:35:50 -0700 REGRESSION(r276164) [GTK] WKPreferencesDefaults API test is failing 2021-04-24 15:08:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224629 InRadar P2 Normal --- 1 lmoura lmoura achristensen bugs-noreply webkit-bug-importer oldest_to_newest 1751379 0 lmoura 2021-04-16 20:35:50 -0700 REGRESSION(r276164) [GTK] WKPreferencesDefaults API test is failing 1751380 1 426317 lmoura 2021-04-16 20:36:38 -0700 Created attachment 426317 Patch 1751384 2 426317 achristensen 2021-04-16 21:01:19 -0700 Comment on attachment 426317 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426317&action=review > Tools/TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:-77 > - EXPECT_FALSE(WKPreferencesGetOfflineWebApplicationCacheEnabled(preference)); Ah, yes. I was wondering how I changed behavior, but I actually just changed the expectations to match the Cocoa expectations. This changes the expectations back. As mentioned in the original bug, you should probably have a discussion of how/when you want to disable it. 1751388 3 ews-feeder 2021-04-16 22:04:07 -0700 Committed r276195 (236677@main): <https://commits.webkit.org/236677@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426317. 1753936 4 webkit-bug-importer 2021-04-24 15:08:17 -0700 <rdar://problem/77110106> 426317 2021-04-16 20:36:38 -0700 2021-04-16 22:04:08 -0700 Patch bug-224710-20210417003637.patch text/plain 4258 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MTg3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDdiNjAzZGVhMDAwM2E2ODFhY2U5ZWIxMGY3YjcwM2Mx YjdkMDU1Zi4uODY3NjBhZjUxMGRjYmFmYmU2ODZhYTg3ZDBjYjQwNmNjNmYwOTY4MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIxLTA0LTE2ICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjI3NjE2NCkgW0dUS10gV0tQcmVmZXJlbmNlc0RlZmF1bHRzIEFQSSB0 ZXN0IGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyNDcxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFzIG9mIHIyNzYxNjQsIE1hYy9pT1MgZGlzYWJsZWQgYXBwbGljYXRpb24gY2FjaGUg YnkgZGVmYXVsdCBidXQgb3RoZXIKKyAgICAgICAgcG9ydHMgYXJlIHN0aWxsIGVuYWJsaW5nIGl0 LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvV0tQcmVmZXJlbmNlcy5j cHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKTogQWRkIG1pc3NpbmcgV1BFIGd1YXJk IGFuZCB0ZXN0IGFnYWluc3QgZXhwZWN0ZWQKKyAgICAgICAgcG9ydCB2YWx1ZSBpbnN0ZWFkIG9m IGVuZm9yY2luZyBhIHNpbmdsZSB2YWx1ZSBmb3IgZXZlcnkgcG9ydC4KKyAgICAgICAgKiBUZXN0 V2ViS2l0QVBJL2dsaWIvVGVzdEV4cGVjdGF0aW9ucy5qc29uOiBSZW1vdmUgV1BFIGV4cGVjdGVk CisgICAgICAgIGZhaWx1cmUuCisKIDIwMjEtMDQtMTYgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFu QGFwcGxlLmNvbT4KIAogICAgICAgICBQYXNzIGNyZWRlbnRpYWwgbmFtZSB0byB0aGUgV2ViQXV0 aG4gVUkgZHVyaW5nIHJlZ2lzdHJhdGlvbgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXQvV0tQcmVmZXJlbmNlcy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdC9XS1ByZWZlcmVuY2VzLmNwcAppbmRleCA4ZDViMzY4MTA1YWJhNjMxMGQ2ODI0 YmQ3NGJjYjdhYTUzNjcyYTE3Li5kNWU5M2VmMjRmMDgyYmM2NTkwYzQzMzIwZTgyYzA5MWQ1NzUy ODA5IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9XS1ByZWZl cmVuY2VzLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9XS1ByZWZl cmVuY2VzLmNwcApAQCAtNDQsNyArNDQsNyBAQCBURVNUKFdlYktpdCwgV0tQcmVmZXJlbmNlc0Jh c2ljKQogCiBURVNUKFdlYktpdCwgV0tQcmVmZXJlbmNlc0RlZmF1bHRzKQogewotI2lmIFBMQVRG T1JNKEdUSykgfHwgUExBVEZPUk0oUExBWVNUQVRJT04pCisjaWYgUExBVEZPUk0oR1RLKSB8fCBQ TEFURk9STShQTEFZU1RBVElPTikgfHwgUExBVEZPUk0oV1BFKQogICAgIHN0YXRpYyBjb25zdCBj aGFyKiBleHBlY3RlZFN0YW5kYXJkRm9udEZhbWlseSA9ICJUaW1lcyI7CiAgICAgc3RhdGljIGNv bnN0IGNoYXIqIGV4cGVjdGVkRml4ZWRGb250RmFtaWx5ID0gIkNvdXJpZXIgTmV3IjsKICAgICBz dGF0aWMgY29uc3QgY2hhciogZXhwZWN0ZWRTZXJpZkZvbnRGYW1pbHkgPSAiVGltZXMiOwpAQCAt NTIsNiArNTIsNyBAQCBURVNUKFdlYktpdCwgV0tQcmVmZXJlbmNlc0RlZmF1bHRzKQogICAgIHN0 YXRpYyBjb25zdCBjaGFyKiBleHBlY3RlZEN1cnNpdmVGb250RmFtaWx5ID0gIkNvbWljIFNhbnMg TVMiOwogICAgIHN0YXRpYyBjb25zdCBjaGFyKiBleHBlY3RlZEZhbnRhc3lGb250RmFtaWx5ID0g IkltcGFjdCI7CiAgICAgc3RhdGljIGNvbnN0IGNoYXIqIGV4cGVjdGVkUGljdG9ncmFwaEZvbnRG YW1pbHkgPSAiVGltZXMiOworICAgIGJvb2wgZXhwZWN0ZWRBcHBsaWNhdGlvbkNhY2hlRW5hYmxl ZCA9IHRydWU7CiAjZWxpZiBXS19IQVZFX0NfU1BJCiAgICAgc3RhdGljIGNvbnN0IGNoYXIqIGV4 cGVjdGVkU3RhbmRhcmRGb250RmFtaWx5ID0gIlRpbWVzIjsKICAgICBzdGF0aWMgY29uc3QgY2hh ciogZXhwZWN0ZWRGaXhlZEZvbnRGYW1pbHkgPSAiQ291cmllciI7CkBAIC02MCw2ICs2MSw3IEBA IFRFU1QoV2ViS2l0LCBXS1ByZWZlcmVuY2VzRGVmYXVsdHMpCiAgICAgc3RhdGljIGNvbnN0IGNo YXIqIGV4cGVjdGVkQ3Vyc2l2ZUZvbnRGYW1pbHkgPSAiQXBwbGUgQ2hhbmNlcnkiOwogICAgIHN0 YXRpYyBjb25zdCBjaGFyKiBleHBlY3RlZEZhbnRhc3lGb250RmFtaWx5ID0gIlBhcHlydXMiOwog ICAgIHN0YXRpYyBjb25zdCBjaGFyKiBleHBlY3RlZFBpY3RvZ3JhcGhGb250RmFtaWx5ID0gIkFw cGxlIENvbG9yIEVtb2ppIjsKKyAgICBib29sIGV4cGVjdGVkQXBwbGljYXRpb25DYWNoZUVuYWJs ZWQgPSBmYWxzZTsKICNlbGlmIFBMQVRGT1JNKElPU19GQU1JTFkpCiAgICAgc3RhdGljIGNvbnN0 IGNoYXIqIGV4cGVjdGVkU3RhbmRhcmRGb250RmFtaWx5ID0gIlRpbWVzIjsKICAgICBzdGF0aWMg Y29uc3QgY2hhciogZXhwZWN0ZWRGaXhlZEZvbnRGYW1pbHkgPSAiQ291cmllciI7CkBAIC02OCwx MyArNzAsMTQgQEAgVEVTVChXZWJLaXQsIFdLUHJlZmVyZW5jZXNEZWZhdWx0cykKICAgICBzdGF0 aWMgY29uc3QgY2hhciogZXhwZWN0ZWRDdXJzaXZlRm9udEZhbWlseSA9ICJTbmVsbCBSb3VuZGhh bmQiOwogICAgIHN0YXRpYyBjb25zdCBjaGFyKiBleHBlY3RlZEZhbnRhc3lGb250RmFtaWx5ID0g IlBhcHlydXMiOwogICAgIHN0YXRpYyBjb25zdCBjaGFyKiBleHBlY3RlZFBpY3RvZ3JhcGhGb250 RmFtaWx5ID0gIkFwcGxlQ29sb3JFbW9qaSI7CisgICAgYm9vbCBleHBlY3RlZEFwcGxpY2F0aW9u Q2FjaGVFbmFibGVkID0gZmFsc2U7CiAjZW5kaWYKIAogICAgIFdLUHJlZmVyZW5jZXNSZWYgcHJl ZmVyZW5jZSA9IFdLUHJlZmVyZW5jZXNDcmVhdGUoKTsKIAogICAgIEVYUEVDVF9UUlVFKFdLUHJl ZmVyZW5jZXNHZXRKYXZhU2NyaXB0RW5hYmxlZChwcmVmZXJlbmNlKSk7CiAgICAgRVhQRUNUX1RS VUUoV0tQcmVmZXJlbmNlc0dldExvYWRzSW1hZ2VzQXV0b21hdGljYWxseShwcmVmZXJlbmNlKSk7 Ci0gICAgRVhQRUNUX0ZBTFNFKFdLUHJlZmVyZW5jZXNHZXRPZmZsaW5lV2ViQXBwbGljYXRpb25D YWNoZUVuYWJsZWQocHJlZmVyZW5jZSkpOworICAgIEVYUEVDVF9FUShleHBlY3RlZEFwcGxpY2F0 aW9uQ2FjaGVFbmFibGVkLCBXS1ByZWZlcmVuY2VzR2V0T2ZmbGluZVdlYkFwcGxpY2F0aW9uQ2Fj aGVFbmFibGVkKHByZWZlcmVuY2UpKTsKICAgICBFWFBFQ1RfVFJVRShXS1ByZWZlcmVuY2VzR2V0 TG9jYWxTdG9yYWdlRW5hYmxlZChwcmVmZXJlbmNlKSk7CiAgICAgRVhQRUNUX1RSVUUoV0tQcmVm ZXJlbmNlc0dldFhTU0F1ZGl0b3JFbmFibGVkKHByZWZlcmVuY2UpKTsKICAgICBFWFBFQ1RfRkFM U0UoV0tQcmVmZXJlbmNlc0dldEZyYW1lRmxhdHRlbmluZ0VuYWJsZWQocHJlZmVyZW5jZSkpOwpk aWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMuanNv biBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvZ2xpYi9UZXN0RXhwZWN0YXRpb25zLmpzb24KaW5kZXgg OGMwNTlmMThmOWMwY2ZmY2ZjYmY2MjNiYWU3MmQzZDg2YTE0ZTE0NS4uODg1NmVlZTQ3NmUwNWYy YmQ1ZTg5NzRmOWY1NGM2MDg4MzczNTM1MSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMuanNvbgorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL2ds aWIvVGVzdEV4cGVjdGF0aW9ucy5qc29uCkBAIC0xOTksOSArMTk5LDYgQEAKICAgICAgICAgICAg ICJXZWJLaXQuVGVybWluYXRlVHdpY2UiOiB7CiAgICAgICAgICAgICAgICAgImV4cGVjdGVkIjog eyJndGsiOiB7InN0YXR1cyI6IFsiU0tJUCJdLCAiYnVnIjogIndlYmtpdC5vcmcvYi8xMjE5NzAi fX0KICAgICAgICAgICAgIH0sCi0gICAgICAgICAgICAiV2ViS2l0LldLUHJlZmVyZW5jZXNEZWZh dWx0cyI6IHsKLSAgICAgICAgICAgICAgICAiZXhwZWN0ZWQiOiB7IndwZSI6IHsic3RhdHVzIjog WyJGQUlMIl19fQotICAgICAgICAgICAgfSwKICAgICAgICAgICAgICJXZWJLaXQuSGl0VGVzdFJl c3VsdE5vZGVIYW5kbGUiOiB7CiAgICAgICAgICAgICAgICAgImV4cGVjdGVkIjogeyJ3cGUiOiB7 InN0YXR1cyI6IFsiVElNRU9VVCJdfX0KICAgICAgICAgICAgIH0sCg==