224681 2021-04-16 10:54:58 -0700 More changes to support the TerminationException. 2021-04-19 10:00:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller mark.lam msaboff saam tuomas.webkit tzagallo webkit-bug-importer oldest_to_newest 1751153 0 mark.lam 2021-04-16 10:54:58 -0700 rdar://76698113 1751162 1 426248 mark.lam 2021-04-16 11:08:47 -0700 Created attachment 426248 proposed patch. 1751203 2 mark.lam 2021-04-16 13:00:10 -0700 Thanks for the review. Landed in r276162: <http://trac.webkit.org/r276162>. 1751687 3 tuomas.webkit 2021-04-18 23:25:02 -0700 Debug -O3 builds seem to require #include "VMTrapsInlines.h" in JSObject.h 1751839 4 mark.lam 2021-04-19 10:00:07 -0700 (In reply to Tuomas Karkkainen from comment #3) > Debug -O3 builds seem to require #include "VMTrapsInlines.h" in JSObject.h Build fix landed in r276259: <http://trac.webkit.org/r276259>. 426248 2021-04-16 11:08:47 -0700 2021-04-16 12:54:37 -0700 proposed patch. bug-224681.patch text/plain 2756 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc2MTQ0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDIxLTA0LTE2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBN b3JlIGNoYW5nZXMgdG8gc3VwcG9ydCB0aGUgVGVybWluYXRpb25FeGNlcHRpb24uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ2ODEKKyAgICAgICAg cmRhcjovLzc2Njk4MTEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHA6CisgICAgICAgIChKU0M6Oklu dGVycHJldGVyOjpleGVjdXRlUHJvZ3JhbSk6CisgICAgICAgIC0gUHJvZ3JhbUV4ZWN1dGFibGU6 OmluaXRpYWxpemVHbG9iYWxQcm9wZXJ0aWVzKCkgY2FuIHRocm93IHRoZSBUZXJtaW5hdGlvbkV4 Y2VwdGlvbi4KKyAgICAgICAgICBBZGQgaGFuZGxpbmcgZm9yIHRoYXQuCisKKyAgICAgICAgKiBy dW50aW1lL0pTT2JqZWN0LmNwcDoKKyAgICAgICAgKEpTQzo6SlNPYmplY3Q6OmRlZmluZU93bklu ZGV4ZWRQcm9wZXJ0eSk6CisgICAgICAgIC0gSlNPYmplY3Q6OmRlZmluZU93bkluZGV4ZWRQcm9w ZXJ0eSgpIGhhcyBhIGJsb2Igb2YgYXNzZXJ0aW9uIGNvZGUgdGhhdCBpdCB2ZXJpZnlpbmcKKyAg ICAgICAgICB0aGF0IGdldE93blByb3BlcnR5RGVzY3JpcHRvcigpIHNob3VsZCBzdWNjZWVkIHdp dGhvdXQgdGhyb3dpbmcgYW55IGV4Y2VwdGlvbnMgaWYKKyAgICAgICAgICB0aGUgZmFzdCBwYXRo IGlzIGFsbG93ZWQuICBIb3dldmVyLCB0aGlzIGlzIGFzc2VydGlvbiBpcyBvbmx5IHRydWUgaWYg dGhlcmUgaXNuJ3QKKyAgICAgICAgICBhIHRlcm1pbmF0aW9uIGJlaW5nIHJlcXVlc3RlZC4gIFNv LCB1c2UgdGhlIERlZmVyVGVybWluYXRpb24gc2NvcGUgdG8gYWxsb3cgdGhpcworICAgICAgICAg IGFzc2VydGlvbiB0byBiZSB0ZXN0ZWQgd2l0aG91dCB0aGUgY29tcGxpY2F0aW9uIG9mIGEgVGVy bWluYXRpb25FeGNlcHRpb24uCisKIDIwMjEtMDQtMTYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBw bGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeCBmb3IgRGVidWcgLU8zIGFmdGVyIHIyNzYwNjku CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnBy ZXRlci5jcHAJKHJldmlzaW9uIDI3NjEyMSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRl cnByZXRlci9JbnRlcnByZXRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc5Nyw3ICs3OTcsOCBA QCBmYWlsZWRKU09OUDoKIAogICAgIC8vIENvbXBpbGUgc291cmNlIHRvIGJ5dGVjb2RlIGlmIG5l Y2Vzc2FyeToKICAgICBKU09iamVjdCogZXJyb3IgPSBwcm9ncmFtLT5pbml0aWFsaXplR2xvYmFs UHJvcGVydGllcyh2bSwgZ2xvYmFsT2JqZWN0LCBzY29wZSk7Ci0gICAgRVhDRVBUSU9OX0FTU0VS VCghdGhyb3dTY29wZS5leGNlcHRpb24oKSB8fCAhZXJyb3IpOworICAgIEVYQ0VQVElPTl9BU1NF UlQoIXRocm93U2NvcGUuZXhjZXB0aW9uKCkgfHwgIWVycm9yIHx8IHZtLmlzVGVybWluYXRpb25F eGNlcHRpb24odGhyb3dTY29wZS5leGNlcHRpb24oKSkpOworICAgIFJFVFVSTl9JRl9FWENFUFRJ T04odGhyb3dTY29wZSwgY2hlY2tlZFJldHVybih0aHJvd1Njb3BlLmV4Y2VwdGlvbigpKSk7CiAg ICAgaWYgKFVOTElLRUxZKGVycm9yKSkKICAgICAgICAgcmV0dXJuIGNoZWNrZWRSZXR1cm4odGhy b3dFeGNlcHRpb24oZ2xvYmFsT2JqZWN0LCB0aHJvd1Njb3BlLCBlcnJvcikpOwogCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCShyZXZpc2lvbiAyNzYx MjEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTI2MjUsNiArMjYyNSw3IEBAIGJvb2wgSlNPYmplY3Q6OmRlZmluZU93bklu ZGV4ZWRQcm9wZXJ0eSgKIAogI2lmIEFTU0VSVF9FTkFCTEVECiAgICAgICAgIGlmIChjYW5HZXRJ bmRleFF1aWNrbHkoaW5kZXgpICYmIGNhbkRvRmFzdFB1dERpcmVjdEluZGV4KHZtLCB0aGlzKSkg eworICAgICAgICAgICAgRGVmZXJUZXJtaW5hdGlvbiBkZWZlclNjb3BlKHZtKTsKICAgICAgICAg ICAgIFByb3BlcnR5RGVzY3JpcHRvciBjdXJyZW50RGVzY3JpcHRvcjsKICAgICAgICAgICAgIEFT U0VSVChnZXRPd25Qcm9wZXJ0eURlc2NyaXB0b3IoZ2xvYmFsT2JqZWN0LCBJZGVudGlmaWVyOjpm cm9tKHZtLCBpbmRleCksIGN1cnJlbnREZXNjcmlwdG9yKSk7CiAgICAgICAgICAgICBzY29wZS5h c3NlcnROb0V4Y2VwdGlvbigpOwo=