22468 2008-11-24 14:51:15 -0800 Coding style: config.h should only be included in implementation files, not in header 2008-11-27 17:45:13 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jchaffraix webkit-unassigned oldest_to_newest 100071 0 jchaffraix 2008-11-24 14:51:15 -0800 See https://bugs.webkit.org/show_bug.cgi?id=22441#c7 for Darin's explanation on that subject. 100318 1 25509 jchaffraix 2008-11-25 16:01:50 -0800 Created attachment 25509 Proposed addition: mostly made for discussion & enhancement 100349 2 25509 eric 2008-11-25 17:49:35 -0800 Comment on attachment 25509 Proposed addition: mostly made for discussion & enhancement I'm not sure it's clear to me from reading what an "implementation" file is. Maybe (.cpp, .c, .mm, etc.) as an aside would help. This sentence is backwards: This guarantees that each header's completeness is tested, +to make sure it can be compiled without requiring any other header files be +included first. "This assures that each header can be compiled without requiring any other header included first." or similar, no need to state "completeness" and then define it. An extra wrong example of HTMLDivElement.h might be helpful. Having HTMLDivElement.cpp unsorted might also be useful. :) Otherwise looks fine. This is a useful change to the style guide. 100451 3 25540 jchaffraix 2008-11-26 14:41:54 -0800 Created attachment 25540 Updated proposition: add one more example, explains a bit what an implementation file is 100455 4 25540 eric 2008-11-26 14:56:56 -0800 Comment on attachment 25540 Updated proposition: add one more example, explains a bit what an implementation file is Looks good. Thanks! 100565 5 jchaffraix 2008-11-27 17:45:13 -0800 Landed in r38824. 25509 2008-11-25 16:01:50 -0800 2008-11-26 14:41:54 -0800 Proposed addition: mostly made for discussion & enhancement CodingStyleConfig_h.diff text/plain 2445 jchaffraix SW5kZXg6IFdlYktpdFNpdGUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFNpdGUvQ2hh bmdlTG9nCShyZXZpc2lvbiAzODc1OSkKKysrIFdlYktpdFNpdGUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTEtMjUgIEp1bGllbiBDaGFmZnJhaXggIDxq Y2hhZmZyYWl4QHBsZXlvLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBCdWcgMjI0Njg6IENvZGluZyBzdHlsZTogY29uZmlnLmggc2hvdWxkIG9u bHkgYmUgaW5jbHVkZWQgaW4gaW1wbGVtZW50YXRpb24gZmlsZXMsIG5vdCBpbiBoZWFkZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDY4CisKKyAg ICAgICAgQ2xhcmlmaWVkIHRoZSBydWxlcyBhYm91dCBjb25maWcuaCBpbmNsdWRlIGFuZCBhZGRl ZCBhIG5ldyBleGFtcGxlIHRvIGlsbHVzdHJhdGUgaXQuCisKKyAgICAgICAgKiBjb2RpbmcvY29k aW5nLXN0eWxlLmh0bWw6CisKIDIwMDgtMTEtMjUgIEphY2sgV29vdHRlbiAgPGphY2t3b290dG9u QGdtYWlsLmNvbT4KIAogICAgICAgICBCdWcgMjAxMjU6IGh0dHA6Ly93ZWJraXQub3JnLyBtaXNz aW5nIGxpbmsgdG8ga2V5IGRvY3VtZW50YXRpb24gZm9yIG5ldyBkZXZlbG9wZXJzLgpJbmRleDog V2ViS2l0U2l0ZS9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 U2l0ZS9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwJKHJldmlzaW9uIDM4NzI4KQorKysgV2ViS2l0 U2l0ZS9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTU5OCwxNyAr NTk4LDM5IEBAIEltYWdlICpTVkdTdHlsZWRFbGVtZW50Ojpkb1NvbWV0aGluZyhQYWkKIAogPG9s PgogCi08bGk+QWxsIGZpbGVzIG11c3QgI2luY2x1ZGUgImNvbmZpZy5oIiBmaXJzdC4KKzxsaT5B bGwgaW1wbGVtZW50YXRpb24gZmlsZXMgbXVzdCAjaW5jbHVkZSAiY29uZmlnLmgiIGZpcnN0LiBI ZWFkZXIgZmlsZXMKK3Nob3VsZCBuZXZlciBpbmNsdWRlICJjb25maWcuaCIuCiAKLTxsaT5BbGwg ZmlsZXMgbXVzdCAjaW5jbHVkZSB0aGUgcHJpbWFyeSBoZWFkZXIgc2Vjb25kLCBqdXN0IGFmdGVy ICJjb25maWcuaCIuCi1TbyBmb3IgZXhhbXBsZSwgTm9kZS5jcHAgc2hvdWxkIGluY2x1ZGUgTm9k ZS5oIGZpcnN0LCBiZWZvcmUgb3RoZXIgZmlsZXMuCi1UaGlzIGd1YXJhbnRlZXMgdGhhdCBlYWNo IGhlYWRlcidzIGNvbXBsZXRlbmVzcyBpcyB0ZXN0ZWQsIHRvIG1ha2Ugc3VyZSBpdAotY2FuIGJl IGNvbXBpbGVkIHdpdGhvdXQgcmVxdWlyaW5nIGFueSBvdGhlciBoZWFkZXIgZmlsZXMgYmUgaW5j bHVkZWQgZmlyc3QuCis8bGk+QWxsIGltcGxlbWVudGF0aW9uIGZpbGVzIG11c3QgI2luY2x1ZGUg dGhlIHByaW1hcnkgaGVhZGVyIHNlY29uZCwKK2p1c3QgYWZ0ZXIgImNvbmZpZy5oIi4gU28gZm9y IGV4YW1wbGUsIE5vZGUuY3BwIHNob3VsZCBpbmNsdWRlIE5vZGUuaCBmaXJzdCwKK2JlZm9yZSBv dGhlciBmaWxlcy4gVGhpcyBndWFyYW50ZWVzIHRoYXQgZWFjaCBoZWFkZXIncyBjb21wbGV0ZW5l c3MgaXMgdGVzdGVkLAordG8gbWFrZSBzdXJlIGl0IGNhbiBiZSBjb21waWxlZCB3aXRob3V0IHJl cXVpcmluZyBhbnkgb3RoZXIgaGVhZGVyIGZpbGVzIGJlCitpbmNsdWRlZCBmaXJzdC4KIAogPGxp Pk90aGVyICNpbmNsdWRlIHN0YXRlbWVudHMgc2hvdWxkIGJlIGluIHNvcnRlZCBvcmRlciAoY2Fz ZSBzZW5zaXRpdmUsIGFzCiBkb25lIGJ5IHRoZSBjb21tYW5kLWxpbmUgc29ydCB0b29sIG9yIHRo ZSBYY29kZSBzb3J0IHNlbGVjdGlvbiBjb21tYW5kKS4KIERvbid0IGJvdGhlciB0byBvcmdhbml6 ZSB0aGVtIGluIGEgbG9naWNhbCBvcmRlci4KIAorPGg0IGNsYXNzPSJyaWdodCI+UmlnaHQ6PC9o ND4KKzxwcmUgY2xhc3M9ImNvZGUiPgorLy8gSFRNTERpdkVsZW1lbnQuY3BwCisjaW5jbHVkZSAi Y29uZmlnLmgiCisjaW5jbHVkZSAiSFRNTERpdkVsZW1lbnQuaCIKKworI2luY2x1ZGUgIkF0dHJp YnV0ZS5oIgorI2luY2x1ZGUgIkhUTUxFbGVtZW50LmgiCisjaW5jbHVkZSAiUXVhbGlmaWVkTmFt ZS5oIgorPC9wcmU+CisKKzxoNCBjbGFzcz0id3JvbmciPldyb25nOjwvaDQ+Cis8cHJlIGNsYXNz PSJjb2RlIj4KKy8vIEhUTUxEaXZFbGVtZW50LmNwcAorI2luY2x1ZGUgIkF0dHJpYnV0ZS5oIgor I2luY2x1ZGUgIkhUTUxEaXZFbGVtZW50LmgiCisjaW5jbHVkZSAiSFRNTEVsZW1lbnQuaCIKKyNp bmNsdWRlICJRdWFsaWZpZWROYW1lLmgiCis8L3ByZT4KKwogPC9vbD4KIAogPD9waHAK 25540 2008-11-26 14:41:54 -0800 2008-11-26 14:56:56 -0800 Updated proposition: add one more example, explains a bit what an implementation file is CodingStyleConfig_h-updated.diff text/plain 3166 jchaffraix SW5kZXg6IFdlYktpdFNpdGUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFNpdGUvQ2hh bmdlTG9nCShyZXZpc2lvbiAzODc4NykKKysrIFdlYktpdFNpdGUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMTEtMjUgIEp1bGllbiBDaGFmZnJhaXggIDxq Y2hhZmZyYWl4QHBsZXlvLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBCdWcgMjI0Njg6IENvZGluZyBzdHlsZTogY29uZmlnLmggc2hvdWxkIG9u bHkgYmUgaW5jbHVkZWQgaW4gaW1wbGVtZW50YXRpb24gZmlsZXMsIG5vdCBpbiBoZWFkZXIKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDY4CisKKyAg ICAgICAgQ2xhcmlmaWVkIHRoZSBydWxlcyBhYm91dCBjb25maWcuaCBpbmNsdXNpb24gYW5kIGFk ZGVkIDIgbmV3IGV4YW1wbGVzIHRvIGlsbHVzdHJhdGUgaXQuIEFsc28KKyAgICAgICAgYWRkZWQg YW4gZXhwbGFuYXRpb24gYWJvdXQgdGhlIGltcGxlbWVudGF0aW9uIGZpbGVzLgorCisgICAgICAg ICogY29kaW5nL2NvZGluZy1zdHlsZS5odG1sOgorCiAyMDA4LTExLTI1ICBEZWFuIEphY2tzb24g IDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSBuZXcgd29yay1pbi1wcm9ncmVzcyBw cm9wb3NhbCBmb3IgcG9pbnRlci1ldmVudHMgaW4KSW5kZXg6IFdlYktpdFNpdGUvY29kaW5nL2Nv ZGluZy1zdHlsZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFNpdGUvY29kaW5nL2NvZGluZy1z dHlsZS5odG1sCShyZXZpc2lvbiAzODc4NykKKysrIFdlYktpdFNpdGUvY29kaW5nL2NvZGluZy1z dHlsZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC02OSw3ICs2OSw3IEBAIGNsYXNzIERvY3VtZW50 IHsKIDwvcHJlPgogPC9saT4KIAotPGxpPkluIGFuIGltcGxlbWVudGF0aW9uIGZpbGUsIGNvZGUg aW5zaWRlIGEgbmFtZXNwYWNlIHNob3VsZCA8ZW0+bm90PC9lbT4gYmUgaW5kZW50ZWQuCis8bGk+ SW4gYW4gaW1wbGVtZW50YXRpb24gZmlsZSAoZmlsZXMgd2l0aCB0aGUgZXh0ZW5zaW9ucyAuY3Bw LCAuYywgLm1tKSwgY29kZSBpbnNpZGUgYSBuYW1lc3BhY2Ugc2hvdWxkIDxlbT5ub3Q8L2VtPiBi ZSBpbmRlbnRlZC4KIDxoNCBjbGFzcz0icmlnaHQiPlJpZ2h0OjwvaDQ+CiA8cHJlIGNsYXNzPSJj b2RlIj4KIC8vIERvY3VtZW50LmNwcApAQCAtNTk4LDE3ICs1OTgsNTggQEAgSW1hZ2UgKlNWR1N0 eWxlZEVsZW1lbnQ6OmRvU29tZXRoaW5nKFBhaQogCiA8b2w+CiAKLTxsaT5BbGwgZmlsZXMgbXVz dCAjaW5jbHVkZSAiY29uZmlnLmgiIGZpcnN0LgorPGxpPkFsbCBpbXBsZW1lbnRhdGlvbiBmaWxl cyBtdXN0ICNpbmNsdWRlICJjb25maWcuaCIgZmlyc3QuIEhlYWRlcgorZmlsZXMgc2hvdWxkIG5l dmVyIGluY2x1ZGUgImNvbmZpZy5oIi4KIAotPGxpPkFsbCBmaWxlcyBtdXN0ICNpbmNsdWRlIHRo ZSBwcmltYXJ5IGhlYWRlciBzZWNvbmQsIGp1c3QgYWZ0ZXIgImNvbmZpZy5oIi4KLVNvIGZvciBl eGFtcGxlLCBOb2RlLmNwcCBzaG91bGQgaW5jbHVkZSBOb2RlLmggZmlyc3QsIGJlZm9yZSBvdGhl ciBmaWxlcy4KLVRoaXMgZ3VhcmFudGVlcyB0aGF0IGVhY2ggaGVhZGVyJ3MgY29tcGxldGVuZXNz IGlzIHRlc3RlZCwgdG8gbWFrZSBzdXJlIGl0Ci1jYW4gYmUgY29tcGlsZWQgd2l0aG91dCByZXF1 aXJpbmcgYW55IG90aGVyIGhlYWRlciBmaWxlcyBiZSBpbmNsdWRlZCBmaXJzdC4KKzxoNCBjbGFz cz0icmlnaHQiPlJpZ2h0OjwvaDQ+Cis8cHJlIGNsYXNzPSJjb2RlIj4KKy8vIFJlbmRlckxheWVy LmgKKyNpbmNsdWRlICJOb2RlLmgiCisjaW5jbHVkZSAiUmVuZGVyT2JqZWN0LmgiCisjaW5jbHVk ZSAiUmVuZGVyVmlldy5oIgorPC9wcmU+CisKKzxoNCBjbGFzcz0id3JvbmciPldyb25nOjwvaDQ+ Cis8cHJlIGNsYXNzPSJjb2RlIj4KKy8vIFJlbmRlckxheWVyLmgKKyNpbmNsdWRlICJjb25maWcu aCIKKworI2luY2x1ZGUgIlJlbmRlck9iamVjdC5oIgorI2luY2x1ZGUgIlJlbmRlclZpZXcuaCIK KyNpbmNsdWRlICJOb2RlLmgiCis8L3ByZT4KKworPGxpPkFsbCBpbXBsZW1lbnRhdGlvbiBmaWxl cyBtdXN0ICNpbmNsdWRlIHRoZSBwcmltYXJ5IGhlYWRlciBzZWNvbmQsCitqdXN0IGFmdGVyICJj b25maWcuaCIuIFNvIGZvciBleGFtcGxlLCBOb2RlLmNwcCBzaG91bGQgaW5jbHVkZSBOb2RlLmgg Zmlyc3QsCitiZWZvcmUgb3RoZXIgZmlsZXMuIFRoaXMgZ3VhcmFudGVlcyB0aGF0IGVhY2ggaGVh ZGVyJ3MgY29tcGxldGVuZXNzIGlzIHRlc3RlZC4KK1RoaXMgYWxzbyBhc3N1cmVzIHRoYXQgZWFj aCBoZWFkZXIgY2FuIGJlIGNvbXBpbGVkIHdpdGhvdXQgcmVxdWlyaW5nIGFueSBvdGhlcgoraGVh ZGVyIGZpbGVzIGJlIGluY2x1ZGVkIGZpcnN0LgogCiA8bGk+T3RoZXIgI2luY2x1ZGUgc3RhdGVt ZW50cyBzaG91bGQgYmUgaW4gc29ydGVkIG9yZGVyIChjYXNlIHNlbnNpdGl2ZSwgYXMKIGRvbmUg YnkgdGhlIGNvbW1hbmQtbGluZSBzb3J0IHRvb2wgb3IgdGhlIFhjb2RlIHNvcnQgc2VsZWN0aW9u IGNvbW1hbmQpLgogRG9uJ3QgYm90aGVyIHRvIG9yZ2FuaXplIHRoZW0gaW4gYSBsb2dpY2FsIG9y ZGVyLgogCis8aDQgY2xhc3M9InJpZ2h0Ij5SaWdodDo8L2g0PgorPHByZSBjbGFzcz0iY29kZSI+ CisvLyBIVE1MRGl2RWxlbWVudC5jcHAKKyNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRlICJI VE1MRGl2RWxlbWVudC5oIgorCisjaW5jbHVkZSAiQXR0cmlidXRlLmgiCisjaW5jbHVkZSAiSFRN TEVsZW1lbnQuaCIKKyNpbmNsdWRlICJRdWFsaWZpZWROYW1lLmgiCisKKzwvcHJlPgorCis8aDQg Y2xhc3M9Indyb25nIj5Xcm9uZzo8L2g0PgorPHByZSBjbGFzcz0iY29kZSI+CisvLyBIVE1MRGl2 RWxlbWVudC5jcHAKKyNpbmNsdWRlICJIVE1MRWxlbWVudC5oIgorI2luY2x1ZGUgIkhUTUxEaXZF bGVtZW50LmgiCisjaW5jbHVkZSAiUXVhbGlmaWVkTmFtZS5oIgorI2luY2x1ZGUgIkF0dHJpYnV0 ZS5oIgorPC9wcmU+CisKIDwvb2w+CiAKIDw/cGhwCg==