224672 2021-04-16 07:09:06 -0700 Make RealtimeIncomingAudioSourceCocoa preallocate audio buffer 2021-04-24 15:05:17 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1751060 0 youennf 2021-04-16 07:09:06 -0700 Make RealtimeIncomingAudioSourceCocoa preallocate audio buffer 1751065 1 426223 youennf 2021-04-16 07:27:17 -0700 Created attachment 426223 Patch 1751349 2 426223 eric.carlson 2021-04-16 18:02:57 -0700 Comment on attachment 426223 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426223&action=review > Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:66 > + , m_numberOfChannels(1) One channel is the most common configuration? > Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:76 > + if (sampleRate != m_sampleRate) > + return; > + Why do we bail if the sample rate changes, but not the number of channels? You can remove the sample rate check in `if (!m_audioBufferList || m_sampleRate != sampleRate || m_numberOfChannels != numberOfChannels)` 1751716 3 426223 youennf 2021-04-19 02:49:17 -0700 Comment on attachment 426223 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426223&action=review >> Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:66 >> + , m_numberOfChannels(1) > > One channel is the most common configuration? Yes, as of now, codecs usually encode in mono. I guess we could try to improve for stereo in the future. >> Source/WebCore/platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:76 >> + > > Why do we bail if the sample rate changes, but not the number of channels? > > You can remove the sample rate check in `if (!m_audioBufferList || m_sampleRate != sampleRate || m_numberOfChannels != numberOfChannels)` LibWebRTC initially sends 16KHz data a few times before switching to 48KHz, not sure why. I will remove below sample check. 1751718 4 426403 youennf 2021-04-19 02:52:52 -0700 Created attachment 426403 Patch for landing 1751723 5 ews-feeder 2021-04-19 03:29:04 -0700 Committed r276245 (236727@main): <https://commits.webkit.org/236727@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426403. 1753911 6 webkit-bug-importer 2021-04-24 15:05:17 -0700 <rdar://problem/77110055> 426223 2021-04-16 07:27:17 -0700 2021-04-19 02:52:48 -0700 Patch bug-224672-20210416162716.patch text/plain 3134 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzRkZDg5ZDQ1NDUwY2Mw Y2VlZjAxN2Q4NTMxZDhhYjU1NWEyY2E4NC4uMTE0ODg0OTcxOWY3NDMyMjk0OTFiNDhjZmYxOTBi MmEwZDllZDA2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA0LTE2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFJlYWx0aW1lSW5j b21pbmdBdWRpb1NvdXJjZUNvY29hIHByZWFsbG9jYXRlIGF1ZGlvIGJ1ZmZlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NjcyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zdGVhZCBvZiBhbGxvY2F0 aW5nIHRoZSBidWZmZXIgb24gdmFsaWQgZGF0YSwgd2Ugd2FpdCBmb3IgZGF0YSB0byBiZSBvZiB0 aGUgY29ycmVjdCBzYW1wbGUgcmF0ZS4KKyAgICAgICAgV2UgcHJlYWxsb2NhdGUgdGhlIGJ1ZmZl ciBhY2NvcmRpbmdseSBpbiBjb25zdHJ1Y3RvciB0byBhdm9pZCBhbGxvY2F0aW9uIGluIHRoZSB3 ZWJydGMgYXVkaW8gdGhyZWFkLgorICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgor CisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lSW5jb21pbmdBdWRp b1NvdXJjZUNvY29hLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lSW5jb21pbmdBdWRp b1NvdXJjZUNvY29hOjpSZWFsdGltZUluY29taW5nQXVkaW9Tb3VyY2VDb2NvYSk6CisgICAgICAg IChXZWJDb3JlOjpSZWFsdGltZUluY29taW5nQXVkaW9Tb3VyY2VDb2NvYTo6T25EYXRhKToKKwog MjAyMS0wNC0xNiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAg TW92ZSBmcm9tIFJlY3Vyc2l2ZUxvY2sgdG8gTG9jayBpbiBSZWFsdGltZU1lZGlhU291cmNlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRp bWVJbmNvbWluZ0F1ZGlvU291cmNlQ29jb2EuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNvY29hLmNwcAppbmRl eCA1ZTBiMDI5ODAwZjNiYzhjZTIyZTAxNzBlZjUzMGY5NDE4MjY0NGM2Li45MTFkZDU5NDM4MzZi OTcyZjVhZWU0OWMzZDA3MTg1ZTk5NjAxNGM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlQ29jb2Eu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9SZWFsdGlt ZUluY29taW5nQXVkaW9Tb3VyY2VDb2NvYS5jcHAKQEAgLTUzLDExICs1Myw2IEBAIFJlZjxSZWFs dGltZUluY29taW5nQXVkaW9Tb3VyY2VDb2NvYT4gUmVhbHRpbWVJbmNvbWluZ0F1ZGlvU291cmNl Q29jb2E6OmNyZWF0ZShyCiAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgUmVhbHRpbWVJbmNvbWlu Z0F1ZGlvU291cmNlQ29jb2EoV1RGTW92ZShhdWRpb1RyYWNrKSwgV1RGTW92ZShhdWRpb1RyYWNr SWQpKSk7CiB9CiAKLVJlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNvY29hOjpSZWFsdGltZUlu Y29taW5nQXVkaW9Tb3VyY2VDb2NvYShydGM6OnNjb3BlZF9yZWZwdHI8d2VicnRjOjpBdWRpb1Ry YWNrSW50ZXJmYWNlPiYmIGF1ZGlvVHJhY2ssIFN0cmluZyYmIGF1ZGlvVHJhY2tJZCkKLSAgICA6 IFJlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZShXVEZNb3ZlKGF1ZGlvVHJhY2spLCBXVEZNb3Zl KGF1ZGlvVHJhY2tJZCkpCi17Ci19Ci0KIHN0YXRpYyBpbmxpbmUgQXVkaW9TdHJlYW1CYXNpY0Rl c2NyaXB0aW9uIHN0cmVhbURlc2NyaXB0aW9uKHNpemVfdCBzYW1wbGVSYXRlLCBzaXplX3QgY2hh bm5lbENvdW50KQogewogICAgIEF1ZGlvU3RyZWFtQmFzaWNEZXNjcmlwdGlvbiBzdHJlYW1Gb3Jt YXQ7CkBAIC02NSw4ICs2MCwyMCBAQCBzdGF0aWMgaW5saW5lIEF1ZGlvU3RyZWFtQmFzaWNEZXNj cmlwdGlvbiBzdHJlYW1EZXNjcmlwdGlvbihzaXplX3Qgc2FtcGxlUmF0ZSwgcwogICAgIHJldHVy biBzdHJlYW1Gb3JtYXQ7CiB9CiAKK1JlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNvY29hOjpS ZWFsdGltZUluY29taW5nQXVkaW9Tb3VyY2VDb2NvYShydGM6OnNjb3BlZF9yZWZwdHI8d2VicnRj OjpBdWRpb1RyYWNrSW50ZXJmYWNlPiYmIGF1ZGlvVHJhY2ssIFN0cmluZyYmIGF1ZGlvVHJhY2tJ ZCkKKyAgICA6IFJlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZShXVEZNb3ZlKGF1ZGlvVHJhY2sp LCBXVEZNb3ZlKGF1ZGlvVHJhY2tJZCkpCisgICAgLCBtX3NhbXBsZVJhdGUoTGliV2ViUlRDQXVk aW9Gb3JtYXQ6OnNhbXBsZVJhdGUpCisgICAgLCBtX251bWJlck9mQ2hhbm5lbHMoMSkKKyAgICAs IG1fc3RyZWFtRGVzY3JpcHRpb24oc3RyZWFtRGVzY3JpcHRpb24obV9zYW1wbGVSYXRlLCBtX251 bWJlck9mQ2hhbm5lbHMpKQorICAgICwgbV9hdWRpb0J1ZmZlckxpc3QobWFrZVVuaXF1ZTxXZWJB dWRpb0J1ZmZlckxpc3Q+KG1fc3RyZWFtRGVzY3JpcHRpb24pKQoreworfQorCiB2b2lkIFJlYWx0 aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNvY29hOjpPbkRhdGEoY29uc3Qgdm9pZCogYXVkaW9EYXRh LCBpbnQgYml0c1BlclNhbXBsZSwgaW50IHNhbXBsZVJhdGUsIHNpemVfdCBudW1iZXJPZkNoYW5u ZWxzLCBzaXplX3QgbnVtYmVyT2ZGcmFtZXMpCiB7CisgICAgaWYgKHNhbXBsZVJhdGUgIT0gbV9z YW1wbGVSYXRlKQorICAgICAgICByZXR1cm47CisKICNpZiAhUkVMRUFTRV9MT0dfRElTQUJMRUQK ICAgICBpZiAoISgrK21fY2h1bmtzUmVjZWl2ZWQgJSAyMDApKSB7CiAgICAgICAgIGNhbGxPbk1h aW5UaHJlYWQoW2lkZW50aWZpZXIgPSBMT0dJREVOVElGSUVSLCB0aGlzLCBwcm90ZWN0ZWRUaGlz ID0gbWFrZVJlZigqdGhpcyksIGNodW5rc1JlY2VpdmVkID0gbV9jaHVua3NSZWNlaXZlZF0gewo= 426403 2021-04-19 02:52:52 -0700 2021-04-19 03:29:05 -0700 Patch for landing bug-224672-20210419115250.patch text/plain 3817 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzJkNmM1MjNlZDg1NzA5 ZTJlYjBiOWE1Njc5M2I2MzIyNWJjOTY4Mi4uM2UwMzY5NTkzM2EwMGExYzljZGIzZDVhYmY1NGM0 M2MxY2YzMGJkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA0LTE5ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIFJlYWx0aW1lSW5j b21pbmdBdWRpb1NvdXJjZUNvY29hIHByZWFsbG9jYXRlIGF1ZGlvIGJ1ZmZlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NjcyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgRXJpYyBDYXJsc29uLgorCisgICAgICAgIEluc3RlYWQgb2YgYWxsb2NhdGlu ZyB0aGUgYnVmZmVyIG9uIHZhbGlkIGRhdGEsIHdlIHdhaXQgZm9yIGRhdGEgdG8gYmUgb2YgdGhl IGNvcnJlY3Qgc2FtcGxlIHJhdGUuCisgICAgICAgIFdlIHByZWFsbG9jYXRlIHRoZSBidWZmZXIg YWNjb3JkaW5nbHkgaW4gY29uc3RydWN0b3IgdG8gYXZvaWQgYWxsb2NhdGlvbiBpbiB0aGUgd2Vi cnRjIGF1ZGlvIHRocmVhZC4KKyAgICAgICAgRGVmYXVsdCBpcyAxIGNoYW5uZWwgc2luY2UgbW9u byBpcyB3aGF0IHdlYnJ0YyBlbmNvZGVycyBtb3N0bHkgZG8gdGhlc2UgZGF5cy4KKyAgICAgICAg Q292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3Ry ZWFtL21hYy9SZWFsdGltZUluY29taW5nQXVkaW9Tb3VyY2VDb2NvYS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZWFsdGltZUluY29taW5nQXVkaW9Tb3VyY2VDb2NvYTo6UmVhbHRpbWVJbmNvbWlu Z0F1ZGlvU291cmNlQ29jb2EpOgorICAgICAgICAoV2ViQ29yZTo6UmVhbHRpbWVJbmNvbWluZ0F1 ZGlvU291cmNlQ29jb2E6Ok9uRGF0YSk6CisKIDIwMjEtMDQtMTggIFlvdWVubiBGYWJsZXQgIDx5 b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIHRvcH5uYXYgdG8gbm90IHNhbWUtb3JpZ2luIGlm cmFtZSBibG9iIHVybCBpcyB3cm9uZ2x5IGdyYW50ZWQgdG9wJ3Mgb3JpZ2luCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVJbmNvbWlu Z0F1ZGlvU291cmNlQ29jb2EuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJl YW0vbWFjL1JlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNvY29hLmNwcAppbmRleCA1ZTBiMDI5 ODAwZjNiYzhjZTIyZTAxNzBlZjUzMGY5NDE4MjY0NGM2Li4zYmRhNTk0YjlmYThjMDk3YzU4N2E0 ZTgwYjE1NWVkNzVlOTgxZTM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t ZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlQ29jb2EuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9SZWFsdGltZUluY29taW5n QXVkaW9Tb3VyY2VDb2NvYS5jcHAKQEAgLTUzLDExICs1Myw2IEBAIFJlZjxSZWFsdGltZUluY29t aW5nQXVkaW9Tb3VyY2VDb2NvYT4gUmVhbHRpbWVJbmNvbWluZ0F1ZGlvU291cmNlQ29jb2E6OmNy ZWF0ZShyCiAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcgUmVhbHRpbWVJbmNvbWluZ0F1ZGlvU291 cmNlQ29jb2EoV1RGTW92ZShhdWRpb1RyYWNrKSwgV1RGTW92ZShhdWRpb1RyYWNrSWQpKSk7CiB9 CiAKLVJlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNvY29hOjpSZWFsdGltZUluY29taW5nQXVk aW9Tb3VyY2VDb2NvYShydGM6OnNjb3BlZF9yZWZwdHI8d2VicnRjOjpBdWRpb1RyYWNrSW50ZXJm YWNlPiYmIGF1ZGlvVHJhY2ssIFN0cmluZyYmIGF1ZGlvVHJhY2tJZCkKLSAgICA6IFJlYWx0aW1l SW5jb21pbmdBdWRpb1NvdXJjZShXVEZNb3ZlKGF1ZGlvVHJhY2spLCBXVEZNb3ZlKGF1ZGlvVHJh Y2tJZCkpCi17Ci19Ci0KIHN0YXRpYyBpbmxpbmUgQXVkaW9TdHJlYW1CYXNpY0Rlc2NyaXB0aW9u IHN0cmVhbURlc2NyaXB0aW9uKHNpemVfdCBzYW1wbGVSYXRlLCBzaXplX3QgY2hhbm5lbENvdW50 KQogewogICAgIEF1ZGlvU3RyZWFtQmFzaWNEZXNjcmlwdGlvbiBzdHJlYW1Gb3JtYXQ7CkBAIC02 NSw4ICs2MCwyMCBAQCBzdGF0aWMgaW5saW5lIEF1ZGlvU3RyZWFtQmFzaWNEZXNjcmlwdGlvbiBz dHJlYW1EZXNjcmlwdGlvbihzaXplX3Qgc2FtcGxlUmF0ZSwgcwogICAgIHJldHVybiBzdHJlYW1G b3JtYXQ7CiB9CiAKK1JlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNvY29hOjpSZWFsdGltZUlu Y29taW5nQXVkaW9Tb3VyY2VDb2NvYShydGM6OnNjb3BlZF9yZWZwdHI8d2VicnRjOjpBdWRpb1Ry YWNrSW50ZXJmYWNlPiYmIGF1ZGlvVHJhY2ssIFN0cmluZyYmIGF1ZGlvVHJhY2tJZCkKKyAgICA6 IFJlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZShXVEZNb3ZlKGF1ZGlvVHJhY2spLCBXVEZNb3Zl KGF1ZGlvVHJhY2tJZCkpCisgICAgLCBtX3NhbXBsZVJhdGUoTGliV2ViUlRDQXVkaW9Gb3JtYXQ6 OnNhbXBsZVJhdGUpCisgICAgLCBtX251bWJlck9mQ2hhbm5lbHMoMSkKKyAgICAsIG1fc3RyZWFt RGVzY3JpcHRpb24oc3RyZWFtRGVzY3JpcHRpb24obV9zYW1wbGVSYXRlLCBtX251bWJlck9mQ2hh bm5lbHMpKQorICAgICwgbV9hdWRpb0J1ZmZlckxpc3QobWFrZVVuaXF1ZTxXZWJBdWRpb0J1ZmZl ckxpc3Q+KG1fc3RyZWFtRGVzY3JpcHRpb24pKQoreworfQorCiB2b2lkIFJlYWx0aW1lSW5jb21p bmdBdWRpb1NvdXJjZUNvY29hOjpPbkRhdGEoY29uc3Qgdm9pZCogYXVkaW9EYXRhLCBpbnQgYml0 c1BlclNhbXBsZSwgaW50IHNhbXBsZVJhdGUsIHNpemVfdCBudW1iZXJPZkNoYW5uZWxzLCBzaXpl X3QgbnVtYmVyT2ZGcmFtZXMpCiB7CisgICAgaWYgKHNhbXBsZVJhdGUgIT0gbV9zYW1wbGVSYXRl KQorICAgICAgICByZXR1cm47CisKICNpZiAhUkVMRUFTRV9MT0dfRElTQUJMRUQKICAgICBpZiAo ISgrK21fY2h1bmtzUmVjZWl2ZWQgJSAyMDApKSB7CiAgICAgICAgIGNhbGxPbk1haW5UaHJlYWQo W2lkZW50aWZpZXIgPSBMT0dJREVOVElGSUVSLCB0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJl ZigqdGhpcyksIGNodW5rc1JlY2VpdmVkID0gbV9jaHVua3NSZWNlaXZlZF0gewpAQCAtNzUsNyAr ODIsNyBAQCB2b2lkIFJlYWx0aW1lSW5jb21pbmdBdWRpb1NvdXJjZUNvY29hOjpPbkRhdGEoY29u c3Qgdm9pZCogYXVkaW9EYXRhLCBpbnQgYml0c1BlcgogICAgIH0KICNlbmRpZgogCi0gICAgaWYg KCFtX2F1ZGlvQnVmZmVyTGlzdCB8fCBtX3NhbXBsZVJhdGUgIT0gc2FtcGxlUmF0ZSB8fCBtX251 bWJlck9mQ2hhbm5lbHMgIT0gbnVtYmVyT2ZDaGFubmVscykgeworICAgIGlmICghbV9hdWRpb0J1 ZmZlckxpc3QgfHwgbV9udW1iZXJPZkNoYW5uZWxzICE9IG51bWJlck9mQ2hhbm5lbHMpIHsKICAg ICAgICAgY2FsbE9uTWFpblRocmVhZChbaWRlbnRpZmllciA9IExPR0lERU5USUZJRVIsIHRoaXMs IHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgc2FtcGxlUmF0ZSwgbnVtYmVyT2ZDaGFu bmVsc10gewogICAgICAgICAgICAgQUxXQVlTX0xPR19JRihsb2dnZXJQdHIoKSwgaWRlbnRpZmll ciwgIm5ldyBhdWRpbyBidWZmZXIgbGlzdCBmb3Igc2FtcGxlUmF0ZSAiLCBzYW1wbGVSYXRlLCAi IGFuZCAiLCBudW1iZXJPZkNoYW5uZWxzLCAiIGNoYW5uZWwocykiKTsKICAgICAgICAgfSk7Cg==