224666 2021-04-16 05:35:17 -0700 [ews] Improve step description when layout-tests step is skipped 2021-04-24 15:09:41 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224373 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1751033 0 aakash_jain 2021-04-16 05:35:17 -0700 Improve step description when layout-tests step is skipped in EWS. Currently it says: "layout-tests (skipped)", it should instead say something like: "Skipped layout-tests" or "Skipped layout-tests in fast-cq mode". 1751034 1 426211 aakash_jain 2021-04-16 05:36:21 -0700 Created attachment 426211 fast-cq-patch 1751098 2 ews-feeder 2021-04-16 09:15:26 -0700 Committed r276139 (236633@main): <https://commits.webkit.org/236633@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426211. 1753949 3 webkit-bug-importer 2021-04-24 15:09:41 -0700 <rdar://problem/77110127> 426211 2021-04-16 05:36:21 -0700 2021-04-16 09:15:26 -0700 fast-cq-patch bug-224666-20210416083620.patch text/plain 3040 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NjEzMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTA0LTE2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBJbXByb3ZlIHN0ZXAgZGVzY3JpcHRpb24gd2hlbiBsYXlvdXQt dGVzdHMgc3RlcCBpcyBza2lwcGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjQ2NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIENJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChS dW5XZWJLaXRUZXN0cy5nZXRSZXN1bHRTdW1tYXJ5KToKKyAgICAgICAgKiBDSVN1cHBvcnQvZXdz LWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBVcGRhdGVkIHVuaXQtdGVzdHMuCisKIDIwMjEtMDQt MTYgIE1hbnVlbCBSZWdvIENhc2Fzbm92YXMgIDxyZWdvQGlnYWxpYS5jb20+CiAKICAgICAgICAg QXZvaWQgY29udmVydGluZyBIVE1MIGNoYXJzIGluIF9XM0NUZXN0Q29udmVydGVyCkluZGV4OiBU b29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJ U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI3NjEzMykKKysrIFRvb2xzL0NJ U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTIyNzAsNiArMjI3 MCwxMCBAQCBjbGFzcyBSdW5XZWJLaXRUZXN0cyhzaGVsbC5UZXN0KToKICAgICAgICAgaWYgc2Vs Zi5yZXN1bHRzICE9IFNVQ0NFU1MgYW5kIHNlbGYuaW5jb3JyZWN0TGF5b3V0TGluZXM6CiAgICAg ICAgICAgICBzdGF0dXMgPSAnICcuam9pbihzZWxmLmluY29ycmVjdExheW91dExpbmVzKQogICAg ICAgICAgICAgcmV0dXJuIHsnc3RlcCc6IHN0YXR1c30KKyAgICAgICAgaWYgc2VsZi5yZXN1bHRz ID09IFNLSVBQRUQ6CisgICAgICAgICAgICBpZiBzZWxmLmdldFByb3BlcnR5KCdmYXN0X2NvbW1p dF9xdWV1ZScpOgorICAgICAgICAgICAgICAgIHJldHVybiB7J3N0ZXAnOiAnU2tpcHBlZCBsYXlv dXQtdGVzdHMgaW4gZmFzdC1jcSBtb2RlJ30KKyAgICAgICAgICAgIHJldHVybiB7J3N0ZXAnOiAn U2tpcHBlZCBsYXlvdXQtdGVzdHMnfQogCiAgICAgICAgIHJldHVybiBzdXBlcihSdW5XZWJLaXRU ZXN0cywgc2VsZikuZ2V0UmVzdWx0U3VtbWFyeSgpCiAKSW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9l d3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lTdXBwb3J0 L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjc2MTMzKQorKysgVG9vbHMv Q0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAt MTcyMSw3ICsxNzIxLDcgQEAgdHMiLCJ2ZXJzaW9uIjo0LCJudW1fcGFzc2VzIjo0MjE1OCwicGl4 ZQogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdmdWxsUGxhdGZvcm0nLCAnbWFjJykKICAgICAg ICAgc2VsZi5zZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlvbicsICdkZWJ1ZycpCiAgICAgICAgIHNl bGYuc2V0UHJvcGVydHkoJ2Zhc3RfY29tbWl0X3F1ZXVlJywgVHJ1ZSkKLSAgICAgICAgc2VsZi5l eHBlY3RPdXRjb21lKHJlc3VsdD1TS0lQUEVELCBzdGF0ZV9zdHJpbmc9J2xheW91dC10ZXN0cyAo c2tpcHBlZCknKQorICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PVNLSVBQRUQsIHN0 YXRlX3N0cmluZz0nU2tpcHBlZCBsYXlvdXQtdGVzdHMgaW4gZmFzdC1jcSBtb2RlJykKICAgICAg ICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKICAgICBkZWYgdGVzdF9za2lwX2Zvcl9tYWNfd2sy X3Bhc3NlZF9wYXRjaF9vbl9jb21taXRfcXVldWUoc2VsZik6CkBAIC0xNzMxLDcgKzE3MzEsNyBA QCB0cyIsInZlcnNpb24iOjQsIm51bV9wYXNzZXMiOjQyMTU4LCJwaXhlCiAgICAgICAgIHNlbGYu c2V0UHJvcGVydHkoJ2Z1bGxQbGF0Zm9ybScsICdtYWMnKQogICAgICAgICBzZWxmLnNldFByb3Bl cnR5KCdjb25maWd1cmF0aW9uJywgJ2RlYnVnJykKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgn cGFzc2VkX21hY193azInLCBUcnVlKQotICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0 PVNLSVBQRUQsIHN0YXRlX3N0cmluZz0nbGF5b3V0LXRlc3RzIChza2lwcGVkKScpCisgICAgICAg IHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U0tJUFBFRCwgc3RhdGVfc3RyaW5nPSdTa2lwcGVk IGxheW91dC10ZXN0cycpCiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQogCiAgICAgZGVm IHRlc3RfcGFyc2VfcmVzdWx0c19qc29uX3JlZ3Jlc3Npb24oc2VsZik6CkBAIC0yMjYwLDcgKzIy NjAsNyBAQCBjbGFzcyBUZXN0UnVuV2ViS2l0MVRlc3RzKEJ1aWxkU3RlcE1peGluCiAgICAgICAg IHNlbGYuc2V0UHJvcGVydHkoJ2Z1bGxQbGF0Zm9ybScsICdtYWMnKQogICAgICAgICBzZWxmLnNl dFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ2RlYnVnJykKICAgICAgICAgc2VsZi5zZXRQcm9w ZXJ0eSgnZmFzdF9jb21taXRfcXVldWUnLCBUcnVlKQotICAgICAgICBzZWxmLmV4cGVjdE91dGNv bWUocmVzdWx0PVNLSVBQRUQsIHN0YXRlX3N0cmluZz0nbGF5b3V0LXRlc3RzIChza2lwcGVkKScp CisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U0tJUFBFRCwgc3RhdGVfc3RyaW5n PSdTa2lwcGVkIGxheW91dC10ZXN0cyBpbiBmYXN0LWNxIG1vZGUnKQogICAgICAgICByZXR1cm4g c2VsZi5ydW5TdGVwKCkKIAogCg==