22465 2008-11-24 13:20:01 -0800 Define KURL::copy() and use it in WorkerThread.cpp 2008-11-24 22:51:49 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd abarth sam oldest_to_newest 100035 0 fishd 2008-11-24 13:20:01 -0800 Define KURL::copy() and use it in WorkerThread.cpp It would be handy to have a "deep copy" function on KURL to avoid re-parsing when passing a KURL to a background thread. 100083 1 25456 fishd 2008-11-24 15:25:10 -0800 Created attachment 25456 v1 patch 100154 2 25456 ggaren 2008-11-24 22:14:31 -0800 Comment on attachment 25456 v1 patch "deepCopy" might be a better name for conveying that you shouldn't call this function if you don't mean it. Then you can remove this part of you comment, too: // Makes a deep copy. r=me 100156 3 abarth 2008-11-24 22:19:26 -0800 There is some value in being consistent with other classes. Should we change SecurityOrigin::copy to be deepCopy as well? 100159 4 fishd 2008-11-24 22:31:03 -0800 What about String::copy()? I was just replicating that. Notice that my comments are very similar to the comments above String::copy()! Should we change them all? 100161 5 fishd 2008-11-24 22:48:32 -0800 http://trac.webkit.org/changeset/38746 Per discussion on #webkit, I'm going to file a follow-up bug to consider renaming all of these 'copy' methods to 'deepCopy'. 100163 6 fishd 2008-11-24 22:51:49 -0800 Please see https://bugs.webkit.org/show_bug.cgi?id=22479 for the follow-up bug. 25456 2008-11-24 15:25:10 -0800 2008-11-24 22:14:31 -0800 v1 patch kurl_copy_1.diff text/plain 2282 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4NzMw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMTEt MjQgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjI0NjUKKyAgICAgICAgRGVmaW5lIEtVUkw6OmNvcHkoKSBhbmQgdXNl IGl0IGluIFdvcmtlclRocmVhZC5jcHAKKworICAgICAgICAqIGRvbS9Xb3JrZXJUaHJlYWQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyVGhyZWFkOjpXb3JrZXJUaHJlYWQpOgorICAgICAg ICAqIHBsYXRmb3JtL0tVUkwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6S1VSTDo6Y29weSk6Cisg ICAgICAgICogcGxhdGZvcm0vS1VSTC5oOgorCiAyMDA4LTExLTI0ICBGaW5udXIgVGhvcmFyaW5z c29uICA8ZmlubnVyLndlYmtpdEBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCkluZGV4OiBkb20vV29ya2VyVGhyZWFkLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBkb20v V29ya2VyVGhyZWFkLmNwcAkocmV2aXNpb24gMzg3MjkpCisrKyBkb20vV29ya2VyVGhyZWFkLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDcsNyArNDcsNyBAQCBQYXNzUmVmUHRyPFdvcmtlclRocmVh ZD4gV29ya2VyVGhyZWFkOjpjCiAKIFdvcmtlclRocmVhZDo6V29ya2VyVGhyZWFkKGNvbnN0IEtV UkwmIHNjcmlwdFVSTCwgY29uc3QgU3RyaW5nJiBzb3VyY2VDb2RlLCBXb3JrZXJNZXNzYWdpbmdQ cm94eSogbWVzc2FnaW5nUHJveHkpCiAgICAgOiBtX3RocmVhZElEKDApCi0gICAgLCBtX3Njcmlw dFVSTChzY3JpcHRVUkwuc3RyaW5nKCkuY29weSgpKQorICAgICwgbV9zY3JpcHRVUkwoc2NyaXB0 VVJMLmNvcHkoKSkKICAgICAsIG1fc291cmNlQ29kZShzb3VyY2VDb2RlLmNvcHkoKSkKICAgICAs IG1fbWVzc2FnaW5nUHJveHkobWVzc2FnaW5nUHJveHkpCiB7CkluZGV4OiBwbGF0Zm9ybS9LVVJM LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBwbGF0Zm9ybS9LVVJMLmNwcAkocmV2aXNpb24gMzg3MjkpCisr KyBwbGF0Zm9ybS9LVVJMLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTEzLDYgKzUxMywxMyBAQCB2 b2lkIEtVUkw6OmluaXQoY29uc3QgS1VSTCYgYmFzZSwgY29uc3QgCiAgICAgfQogfQogCitLVVJM IEtVUkw6OmNvcHkoKSBjb25zdAoreworICAgIEtVUkwgcmVzdWx0ID0gKnRoaXM7CisgICAgcmVz dWx0Lm1fc3RyaW5nID0gcmVzdWx0Lm1fc3RyaW5nLmNvcHkoKTsKKyAgICByZXR1cm4gcmVzdWx0 OworfQorCiBib29sIEtVUkw6Omhhc1BhdGgoKSBjb25zdAogewogICAgIHJldHVybiBtX3BhdGhF bmQgIT0gbV9wb3J0RW5kOwpJbmRleDogcGxhdGZvcm0vS1VSTC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBs YXRmb3JtL0tVUkwuaAkocmV2aXNpb24gMzg3MjkpCisrKyBwbGF0Zm9ybS9LVVJMLmgJKHdvcmtp bmcgY29weSkKQEAgLTkxLDYgKzkxLDExIEBAIHB1YmxpYzoKICAgICAvLyBiYXNlIG9mIG51bGwg b3IgdGhlIGVtcHR5IHN0cmluZyBnaXZlcyB0aGUgc2FtZSByZXN1bHQgYXMgdGhlCiAgICAgLy8g c3RhbmRhcmQgU3RyaW5nIGNvbnN0cnVjdG9yLgogCisgICAgLy8gTWFrZXMgYSBkZWVwIGNvcHku IEhlbHBmdWwgb25seSBpZiB5b3UgbmVlZCB0byB1c2UgYSBLVVJMIG9uIGFub3RoZXIKKyAgICAv LyB0aHJlYWQuICBTaW5jZSB0aGUgdW5kZXJseWluZyBTdHJpbmdJbXBsIG9iamVjdHMgYXJlIGlt bXV0YWJsZSwgdGhlcmUncworICAgIC8vIG5vIG90aGVyIHJlYXNvbiB0byBldmVyIHByZWZlciBj b3B5KCkgb3ZlciBwbGFpbiBvbGQgYXNzaWdubWVudC4KKyAgICBLVVJMIGNvcHkoKSBjb25zdDsK KwogICAgIGJvb2wgaXNOdWxsKCkgY29uc3QgeyByZXR1cm4gbV9zdHJpbmcuaXNOdWxsKCk7IH0K ICAgICBib29sIGlzRW1wdHkoKSBjb25zdCB7IHJldHVybiBtX3N0cmluZy5pc0VtcHR5KCk7IH0K IAo=