224649 2021-04-15 23:15:00 -0700 WebCoreArgumentCoders.h: error: 'WebCore/MediaPlaybackTargetContext.h' file not found since r276107 2021-04-16 01:10:33 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 224469 1 fujii fujii peng.liu6 oldest_to_newest 1750942 0 fujii 2021-04-15 23:15:00 -0700 WebCoreArgumentCoders.h: error: 'WebCore/MediaPlaybackTargetContext.h' file not found since r276107 r276107 (236607@main) > [4971/5700] Building CXX object Source\WebKit\CMakeFiles\WebKit.dir\__\__\WebKit\DerivedSources\RemoteMediaPlayerProxyMessageReceiver.cpp.obj > FAILED: Source/WebKit/CMakeFiles/WebKit.dir/__/__/WebKit/DerivedSources/RemoteMediaPlayerProxyMessageReceiver.cpp.obj > C:\PROGRA~1\LLVM\bin\clang-cl.exe (...) -c WebKit\DerivedSources\RemoteMediaPlayerProxyMessageReceiver.cpp > In file included from WebKit\DerivedSources\RemoteMediaPlayerProxyMessageReceiver.cpp:46: > ..\..\Source\WebKit\Shared\WebCoreArgumentCoders.h(36,10): fatal error: 'WebCore/MediaPlaybackTargetContext.h' file not found > #include <WebCore/MediaPlaybackTargetContext.h> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. 1750944 1 426186 fujii 2021-04-15 23:17:24 -0700 Created attachment 426186 Patch 1750950 2 peng.liu6 2021-04-15 23:25:24 -0700 Thanks for the fix! 1750952 3 fujii 2021-04-15 23:33:34 -0700 This fix isn't enough. More errors. WebKitBuild\Debug\WebKit\DerivedSources\WebPageProxyMessages.h(65): fatal error C1083: Cannot open include file: 'WebCore/MediaPlaybackTargetContext.h': No such file or directory 1750954 4 fujii 2021-04-15 23:43:08 -0700 Umm, <WebCore/MediaPlaybackTargetContext.h> is included from the derived source. Can I revert your r276107? 1750962 5 fujii 2021-04-15 23:56:34 -0700 I'm sorry. It isn't easy to fix the build error. r276120 reverted your r276107. It broke only clean builds. Feel free to ask me try clean builds if you need. 1750978 6 peng.liu6 2021-04-16 01:10:33 -0700 Does it break windows port only? 426186 2021-04-15 23:17:24 -0700 2021-04-15 23:26:59 -0700 Patch bug-224649-20210416151723.patch text/plain 1679 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdjZDVkZDllZGNlNmViY2Ni ZmRmZDUzYzNjYzZkZGUxZGUzOTFlMzEuLjJiZTYxYTY5MjUxZTAzNmRkMDdlYWZhMjEwNWVkMzhj MTFiMzJhNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMDQtMTUgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgV2ViQ29yZUFyZ3Vt ZW50Q29kZXJzLmg6IGVycm9yOiAnV2ViQ29yZS9NZWRpYVBsYXliYWNrVGFyZ2V0Q29udGV4dC5o JyBmaWxlIG5vdCBmb3VuZCBzaW5jZSByMjc2MTA3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ2NDkKKworICAgICAgICBVbnJldmlld2VkIGJ1aWxk IGZpeCBmb3Igbm9uLUNvY29hIHBvcnRzLgorCisgICAgICAgICogU2hhcmVkL1dlYkNvcmVBcmd1 bWVudENvZGVycy5oOiBEb24ndCBpbmNsdWRlIDxXZWJDb3JlL01lZGlhUGxheWJhY2tUYXJnZXRD b250ZXh0Lmg+IHVubGVzcyBFTkFCTEUoV0lSRUxFU1NfUExBWUJBQ0tfVEFSR0VUKS4KKwogMjAy MS0wNC0xNSAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4KIAogICAg ICAgICBDcmFzaFRyYWNlcjogY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50IGF0IGNvbS5hcHBs ZS5XZWJLaXQ6IFdURjo6SGFzaFRhYmxlQ29uc3RJdGVyYXRvcjxXVEY6OlN0cmluZywgV1RGOjpL ZXlWYWx1ZVBhaXI8Li4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJDb3Jl QXJndW1lbnRDb2RlcnMuaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENv ZGVycy5oCmluZGV4IDY0NzZlMzkwYmZjNzc4ZDdlYjdjZGZiM2RjMmFkNTRjMmNlN2ZlNWUuLjdl ZTliZjY3ZTYzZTM4Njg1Njc2YWM2OGY4YThjNzMzNGZjMTBkNzQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5oCisrKyBiL1NvdXJjZS9XZWJL aXQvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5oCkBAIC0zMyw3ICszMyw2IEBACiAjaW5j bHVkZSA8V2ViQ29yZS9JbWFnZURhdGEuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0luZGV4ZWREQi5o PgogI2luY2x1ZGUgPFdlYkNvcmUvSW5wdXRNb2RlLmg+Ci0jaW5jbHVkZSA8V2ViQ29yZS9NZWRp YVBsYXliYWNrVGFyZ2V0Q29udGV4dC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvTWVkaWFTZWxlY3Rp b25PcHRpb24uaD4KICNpbmNsdWRlIDxXZWJDb3JlL05hdGl2ZUltYWdlLmg+CiAjaW5jbHVkZSA8 V2ViQ29yZS9OZXR3b3JrTG9hZE1ldHJpY3MuaD4KQEAgLTc1LDYgKzc0LDEwIEBACiAjaW5jbHVk ZSA8V2ViQ29yZS9HcmFwaGljc1R5cGVzR0wuaD4KICNlbmRpZgogCisjaWYgRU5BQkxFKFdJUkVM RVNTX1BMQVlCQUNLX1RBUkdFVCkKKyNpbmNsdWRlIDxXZWJDb3JlL01lZGlhUGxheWJhY2tUYXJn ZXRDb250ZXh0Lmg+CisjZW5kaWYKKwogI2lmIEVOQUJMRShXRUJYUikKICNpbmNsdWRlIDxXZWJD b3JlL1BsYXRmb3JtWFIuaD4KICNlbmRpZgo=