224648 2021-04-15 23:11:25 -0700 Web Inspector: REGRESSION(?): Graphics: dropping a recording leaves behind a drop zone view 2021-04-16 14:22:09 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224650 https://bugs.webkit.org/show_bug.cgi?id=224678 InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1750941 0 hi 2021-04-15 23:11:25 -0700 # STEPS TO REPRODUCE 1. inspect <https://devinrousso.com/demo/WebKit/canvas.html> 2. select the Canvas 2D 3. drag the preview image and drop it on top of itself # EXPECTED the drop zone disappears and an error appears in the console # ACTUAL the drop zone remains and an error appears in the console 1750946 1 426187 hi 2021-04-15 23:18:56 -0700 Created attachment 426187 Patch 1751238 2 426187 bburg 2021-04-16 14:17:33 -0700 Comment on attachment 426187 Patch r=me I will file a few smaller issues I found in Graphics tab that I saw while testing this out. 1751242 3 webkit-bug-importer 2021-04-16 14:19:02 -0700 <rdar://problem/76778140> 1751243 4 ews-feeder 2021-04-16 14:22:07 -0700 Committed r276170 (236657@main): <https://commits.webkit.org/236657@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426187. 426187 2021-04-15 23:18:56 -0700 2021-04-16 14:22:08 -0700 Patch 224648.diff text/plain 4174 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGFkMTg4MGMwNmRiZC4uYmQ3NWYzODgzMWM1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAyMS0wNC0xNSAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog UkVHUkVTU0lPTig/KTogR3JhcGhpY3M6IGRyb3BwaW5nIGEgcmVjb3JkaW5nIGxlYXZlcyBiZWhp bmQgYSBkcm9wIHpvbmUgdmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI0NjQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0dyYXBoaWNzVGFiQ29udGVudFZpZXcu anM6CisgICAgICAgIChXSS5HcmFwaGljc1RhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5pbml0aWFs TGF5b3V0KToKKyAgICAgICAgSXQgYXBwZWFycyB0aGF0IGl0J3MgcG9zc2libGUgZm9yIHJlLWVu dHJhbmN5IGlzc3VlcyBpbiB0aGUgYFdJLlZpZXdgIHN5c3RlbSBzaW5jZSB0aGUKKyAgICAgICAg YF9kaWRJbml0aWFsTGF5b3V0YCBmbGFnIGlzbid0IHNldCB1bnRpbCBfYWZ0ZXJfIGBpbml0aWFs TGF5b3V0YCByZXR1cm5zLCBtZWFuaW5nIHRoYXQgaWYKKyAgICAgICAgdGhlIGxvZ2ljIGluc2lk ZSBgaW5pdGlhbExheW91dGAgdHJpZ2dlcnMgYSBzeW5jaHJvbm91cyBgbGF5b3V0YCB0aGVuIHRo YXQgc2Vjb25kIGBsYXlvdXRgCisgICAgICAgIHdvbid0IGtub3cgdGhhdCBpdCdzIGFscmVhZHkg aW4gdGhlIG1pZGRsZSBvZiBhbiBgaW5pdGlhbExheW91dGAuIEluIHRoaXMgY2FzZSwgc2hvd2lu ZyB0aGUKKyAgICAgICAgYFdJLkdyYXBoaWNzT3ZlcnZpZXdDb250ZW50Vmlld2AgY2F1c2VzIHRo ZSBuYXZpZ2F0aW9uIHNpZGViYXIgdG8gYmUgc2hvd24sIHdoaWNoIGZvcmNlcyBhCisgICAgICAg IHN5bmNocm9ub3VzIGBsYXlvdXRgIGZyb20gaGFuZGxpbmcgYFdJLlNpZGViYXIuRXZlbnQuV2lk dGhEaWRDaGFuZ2VgLiBGb3Igbm93LCB0aGVyZSdzIG5vCisgICAgICAgICJydXNoIiB0byBzaG93 IHRoZSBgV0kuR3JhcGhpY3NPdmVydmlld0NvbnRlbnRWaWV3YCBzbyB3ZSBkZWxheSBpdCBieSBv bmUgZXZlbnQgbG9vcCB0dXJuLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9DYW52 YXNDb250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLkNhbnZhc0NvbnRlbnRWaWV3LnByb3RvdHlw ZS5pbml0aWFsTGF5b3V0KToKKyAgICAgICAgKFdJLkNhbnZhc0NvbnRlbnRWaWV3LnByb3RvdHlw ZS5kcm9wWm9uZVNob3VsZEFwcGVhckZvckRyYWdFdmVudCk6IERlbGV0ZWQuCisgICAgICAgIChX SS5DYW52YXNDb250ZW50Vmlldy5wcm90b3R5cGUuZHJvcFpvbmVIYW5kbGVEcm9wKTogRGVsZXRl ZC4KKyAgICAgICAgVGhlcmUncyBubyByZWFzb24gdG8gaGF2ZSBhbm90aGVyIGBXSS5Ecm9wWm9u ZVZpZXdgIGhlcmUgc2luY2UgdGhlcmUncyBhbHJlYWR5IG9uZSB0aGF0CisgICAgICAgIGNvdmVy cyB0aGUgZW50aXJlIHRhYi4KKwogMjAyMS0wNC0xMyAgQkogQnVyZyAgPGJidXJnQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBhZGQgc2V0dGluZyB0byBhbGxvdyBpbnNwZWN0 aW5nIFdlYiBJbnNwZWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0NhbnZhc0NvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ2FudmFzQ29udGVudFZpZXcuanMKaW5kZXggNGZhMzg4 N2Y2NzUzLi43ODYxMzBiMmM2N2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NhbnZhc0NvbnRlbnRWaWV3LmpzCkBAIC04 MiwyNCArODIsNiBAQCBXSS5DYW52YXNDb250ZW50VmlldyA9IGNsYXNzIENhbnZhc0NvbnRlbnRW aWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZXcKICAgICAgICAgdGhpcy5yZWZyZXNoUHJldmlldygp OwogICAgIH0KIAotICAgIC8vIERyb3Bab25lVmlldyBkZWxlZ2F0ZQotCi0gICAgZHJvcFpvbmVT aG91bGRBcHBlYXJGb3JEcmFnRXZlbnQoZHJvcFpvbmUsIGV2ZW50KQotICAgIHsKLSAgICAgICAg cmV0dXJuIGV2ZW50LmRhdGFUcmFuc2Zlci50eXBlcy5pbmNsdWRlcygiRmlsZXMiKTsKLSAgICB9 Ci0KLSAgICBkcm9wWm9uZUhhbmRsZURyb3AoZHJvcFpvbmUsIGV2ZW50KQotICAgIHsKLSAgICAg ICAgbGV0IGZpbGVzID0gZXZlbnQuZGF0YVRyYW5zZmVyLmZpbGVzOwotICAgICAgICBpZiAoZmls ZXMubGVuZ3RoICE9PSAxKSB7Ci0gICAgICAgICAgICBJbnNwZWN0b3JGcm9udGVuZEhvc3QuYmVl cCgpOwotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICB9Ci0KLSAgICAgICAgV0kuRmlsZVV0 aWxpdGllcy5yZWFkSlNPTihmaWxlcywgKHJlc3VsdCkgPT4gV0kuY2FudmFzTWFuYWdlci5wcm9j ZXNzSlNPTihyZXN1bHQpKTsKLSAgICB9Ci0KICAgICAvLyBQcm90ZWN0ZWQKIAogICAgIGluaXRp YWxMYXlvdXQoKQpAQCAtMTgzLDEzICsxNjUsNiBAQCBXSS5DYW52YXNDb250ZW50VmlldyA9IGNs YXNzIENhbnZhc0NvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZXcKIAogICAgICAgICBp ZiAoaXNDYXJkKQogICAgICAgICAgICAgdGhpcy5fcmVmcmVzaFBpeGVsU2l6ZSgpOwotCi0gICAg ICAgIGlmICghaXNDYXJkKSB7Ci0gICAgICAgICAgICBsZXQgZHJvcFpvbmVWaWV3ID0gbmV3IFdJ LkRyb3Bab25lVmlldyh0aGlzKTsKLSAgICAgICAgICAgIGRyb3Bab25lVmlldy50ZXh0ID0gV0ku VUlTdHJpbmcoIkltcG9ydCBSZWNvcmRpbmciKTsKLSAgICAgICAgICAgIGRyb3Bab25lVmlldy50 YXJnZXRFbGVtZW50ID0gdGhpcy5lbGVtZW50OwotICAgICAgICAgICAgdGhpcy5hZGRTdWJ2aWV3 KGRyb3Bab25lVmlldyk7Ci0gICAgICAgIH0KICAgICB9CiAKICAgICBsYXlvdXQoKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvR3JhcGhpY3NU YWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0dyYXBoaWNzVGFiQ29udGVudFZpZXcuanMKaW5kZXggYjFiYTczNmNkODFmLi44MWM0N2M1 OWFmMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0dyYXBoaWNzVGFiQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvR3JhcGhpY3NUYWJDb250ZW50Vmlldy5qcwpAQCAtMjAzLDcg KzIwMywxMSBAQCBXSS5HcmFwaGljc1RhYkNvbnRlbnRWaWV3ID0gY2xhc3MgR3JhcGhpY3NUYWJD b250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRCcm93cwogICAgICAgICBzdXBlci5pbml0aWFs TGF5b3V0KCk7CiAKICAgICAgICAgdGhpcy5fb3ZlcnZpZXdDb250ZW50VmlldyA9IG5ldyBXSS5H cmFwaGljc092ZXJ2aWV3Q29udGVudFZpZXc7Ci0gICAgICAgIHRoaXMuY29udGVudEJyb3dzZXIu c2hvd0NvbnRlbnRWaWV3KHRoaXMuX292ZXJ2aWV3Q29udGVudFZpZXcpOworCisgICAgICAgIC8v IEZJWE1FOiA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMjI0NjUwPiAoV2ViIEluc3BlY3RvcjogYXVk aXQgZm9yIHJlLWVudHJhbmN5IGlzc3VlcyB3aXRoIGBpbml0aWFsTGF5b3V0YCBhbmQgYGxheW91 dGApCisgICAgICAgIHNldFRpbWVvdXQoKCkgPT4geworICAgICAgICAgICAgdGhpcy5jb250ZW50 QnJvd3Nlci5zaG93Q29udGVudFZpZXcodGhpcy5fb3ZlcnZpZXdDb250ZW50Vmlldyk7CisgICAg ICAgIH0pOwogCiAgICAgICAgIGxldCBkcm9wWm9uZVZpZXcgPSBuZXcgV0kuRHJvcFpvbmVWaWV3 KHRoaXMpOwogICAgICAgICBkcm9wWm9uZVZpZXcudGV4dCA9IFdJLlVJU3RyaW5nKCJJbXBvcnQg UmVjb3JkaW5nIik7Cg==