224644 2021-04-15 20:47:56 -0700 REGRESSION(r276039) [GTK] Build failures on Ubuntu 18.04 2021-04-15 23:25:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224616 InRadar P2 Normal --- 224646 1 lmoura lmoura bugs-noreply commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1750912 0 lmoura 2021-04-15 20:47:56 -0700 Failed on the Ubuntu LTS 18.04 (due to be deprecated next week) lib/libWebCoreGTK.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-68aea4ac-6.cpp.o):UnifiedSource-68aea4ac-6.cpp:function WebCore::getBackingSet(JSC::JSGlobalObject&, JSC::JSObject&): error: undefined reference to 'JSC::HashMapImpl<JSC::HashMapBucket<JSC::HashMapBucketDataKey> >::finishCreation(JSC::JSGlobalObject*, JSC::VM&)' lib/libWebCoreGTK.a(lib/../Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-68aea4ac-6.cpp.o):UnifiedSource-68aea4ac-6.cpp:function WebCore::getBackingMap(JSC::JSGlobalObject&, JSC::JSObject&): error: undefined reference to 'JSC::HashMapImpl<JSC::HashMapBucket<JSC::HashMapBucketDataKeyValue> >::finishCreation(JSC::JSGlobalObject*, JSC::VM&)' collect2: error: ld returned 1 exit status 1750916 1 426180 lmoura 2021-04-15 21:12:57 -0700 Created attachment 426180 Patch 1750922 2 ews-feeder 2021-04-15 21:44:01 -0700 Committed r276112 (236612@main): <https://commits.webkit.org/236612@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426180. 1750925 3 426180 mark.lam 2021-04-15 21:52:48 -0700 Comment on attachment 426180 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426180&action=review > Source/JavaScriptCore/runtime/JSSet.h:28 > +#include "HashMapImplInlines.h" This is the wrong fix. We should never #include an Inlines.h file from a .h file. Only .cpp or Inlines.h file can #include Inlines.h files. Please revert this and fix this the proper way. 1750926 4 mark.lam 2021-04-15 21:54:31 -0700 I'm going to roll this out right now. 1750928 5 commit-queue 2021-04-15 21:56:15 -0700 Re-opened since this is blocked by bug 224646 1750930 6 webkit-bug-importer 2021-04-15 21:56:22 -0700 <rdar://problem/76742835> 1750934 7 426183 lmoura 2021-04-15 22:13:38 -0700 Created attachment 426183 Patch for landing 1750951 8 ews-feeder 2021-04-15 23:25:37 -0700 Committed r276119 (236616@main): <https://commits.webkit.org/236616@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426183. 426180 2021-04-15 21:12:57 -0700 2021-04-15 22:13:33 -0700 Patch bug-224644-20210416011256.patch text/plain 1177 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 NmJiY2M4ZDNlYWRhYTRlMjg3ZDcyMjlmNjNiMzc4ZWFhNTZiNTYwLi5kM2Y1MWVkMGVhYjkxMTM2 NDA4ZDE0YWRmOGM3ZTU2NGRmMGNkMDkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAyMS0wNC0xNSAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4K KworICAgICAgICBSRUdSRVNTSU9OKHIyNzYwMzkpIFtHVEtdIEJ1aWxkIGZhaWx1cmVzIG9uIFVi dW50dSAxOC4wNAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI0NjQ0CisKKyAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCisKKyAgICAgICAgKiBy dW50aW1lL0pTU2V0Lmg6IFVzZSBIYXNoTWFwSW1wbElubGluZXMgdG8gaW5jbHVkZSB0aGUgYmFz ZQorICAgICAgICBmaW5pc2hDcmVhdGlvbiBpbXBsZW1lbnRhdGlvbi4gU29tZWhvdyBHQ0MgNy41 IHdhc24ndCBwaWNraW5nIGl0IHVwLgorCiAyMDIxLTA0LTE1ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KIAogICAgICAgICBPcHRpbWl6ZSB0aGUgRGVmZXJUZXJtaW5hdGlvbiBzY29w ZSB0byBiZSBtb3JlIGVmZmljaWVudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTU2V0LmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1NldC5o CmluZGV4IGRlNzkzMzA0NTc0NWVkM2ViZjY3MWVlNDQ0MmVjNzg0MzAwYjFmNzQuLmVhOGM1Mzc1 YWE4ZjM4YjI4NmZiNjYyMjAyNTRkNDI0YmFiOTk3ZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL0pTU2V0LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSlNTZXQuaApAQCAtMjUsNyArMjUsNyBAQAogCiAjcHJhZ21hIG9uY2UKIAotI2luY2x1 ZGUgIkhhc2hNYXBJbXBsLmgiCisjaW5jbHVkZSAiSGFzaE1hcEltcGxJbmxpbmVzLmgiCiAjaW5j bHVkZSAiSlNPYmplY3QuaCIKIAogbmFtZXNwYWNlIEpTQyB7Cg== 426183 2021-04-15 22:13:38 -0700 2021-04-15 23:25:38 -0700 Patch for landing bug-224644-20210416021337.patch text/plain 1222 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjUyZTg2NjdiODM1MTFj NmIyMmQ1MjA2OThkYzUxNDMxZjA3OGZmMi4uNjNhYjQxZWNiZjZiYjNiOTEzMDk0YTU2ODFmZTU1 NGMzODZkZjAxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA0LTE1ICBMYXVy byBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI3NjAz OSkgW0dUS10gQnVpbGQgZmFpbHVyZXMgb24gVWJ1bnR1IDE4LjA0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ2NDQKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzc2NzQyODM1PgorCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgorCisgICAg ICAgICogYmluZGluZ3MvanMvSlNET01TZXRMaWtlLmNwcDogQWRkIG1pc3NpbmcgSW5saW5lcyBo ZWFkZXIgYXMKKyAgICAgICAgc3VnZ2VzdGVkIGJ5IE1hcmsuCisKIDIwMjEtMDQtMTUgIERvbiBP bG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAogICAgICAgICBbQ01ha2VdIE9wZW5H TCBsaWJyYXJpZXMgbm90IGxpbmtlZCB3aGVuIEFOR0xFIGlzbid0IHVzZWQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NU2V0TGlrZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU0RPTVNldExpa2UuY3BwCmluZGV4IDFhMmJjMDE0ODAzZjM3Njhl OTI4YjQ4OTZmNjhlODc1MDE2MzAwYTQuLjExMTBmN2M3ZWI3NmI3Mzg4MDIzZmNiMTc2MDU5MThl Y2VlNmVjNDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NU2V0 TGlrZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01TZXRMaWtlLmNw cApAQCAtMjksNiArMjksNyBAQAogI2luY2x1ZGUgIldlYkNvcmVKU0NsaWVudERhdGEuaCIKICNp bmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9DYXRjaFNjb3BlLmg+CiAjaW5jbHVkZSA8SmF2YVNjcmlw dENvcmUvSlNTZXQuaD4KKyNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU1NldElubGluZXMuaD4K IAogbmFtZXNwYWNlIFdlYkNvcmUgewogCg==