224628 2021-04-15 15:48:49 -0700 Move the implementation of -[WKWebView themeColor] into the main WKWebView category 2021-04-22 17:37:19 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh hi kkinnunen thorton webkit-bug-importer oldest_to_newest 1750812 0 wenson_hsieh 2021-04-15 15:48:49 -0700 Silences this (benign) linker error when building WebKit: … CompileC WKStorageAccessAlert.o Ld WebKit ld: warning: method '-themeColor' in category from /Volumes/…/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/UnifiedSource26-mm.o overrides method from class in /Volumes/…/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/UnifiedSource26-mm.o PhaseScriptExecution Check For Weak VTables and Externals PhaseScriptExecution Check For Inappropriate Objective-C Class Names … 1750816 1 426146 wenson_hsieh 2021-04-15 15:51:49 -0700 Created attachment 426146 Patch 1750837 2 ews-feeder 2021-04-15 16:33:05 -0700 Committed r276086 (236598@main): <https://commits.webkit.org/236598@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426146. 1753400 3 ryanhaddad 2021-04-22 17:37:19 -0700 rdar://76729587 426146 2021-04-15 15:51:49 -0700 2021-04-15 16:33:06 -0700 Patch bug-224628-20210415155149.patch text/plain 2017 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MDI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZiZDVhNWMwNmFlODkzY2Rk Y2QzYzQ3MWFiZThkYzYzMmFlZGViMzEuLjZjNDNiYWE3NmMyZTljMzA3OTM0MzQwNWI2YTkyZTdm YjZkY2IzNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDQtMTUgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSB0aGUgaW1wbGVt ZW50YXRpb24gb2YgLVtXS1dlYlZpZXcgdGhlbWVDb2xvcl0gaW50byB0aGUgbWFpbiBXS1dlYlZp ZXcgY2F0ZWdvcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyNDYyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1vdmUgdGhlIGltcGxlbWVudGF0aW9uIG9mIGAtdGhlbWVDb2xvcmAgb3V0IG9mIHRoZSBw cml2YXRlIGNhdGVnb3J5LCBhbmQgaW50byB0aGUgbWFpbiBjYXRlZ29yeSBpbnN0ZWFkIHRvCisg ICAgICAgIHNpbGVuY2UgdGhlIHdhcm5pbmcuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IHRoZW1lQ29sb3JdKToKKwog MjAyMS0wNC0xNSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAg ICAgICBXS0NvbnRlbnRWaWV3IHNob3VsZCBiZWNvbWUgZm9jdXNlZCB3aXRob3V0IHJlcXVpcmlu ZyAtW1dLV2ViVmlldyBjYW5CZWNvbWVGb2N1c2VkXSB0byByZXR1cm4gWUVTCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQppbmRleCA0ODAxMGU0NDQ3 ZGJkNmM2NWZiMTc3N2QwOGRjYmEwMDA2ZmFiZmFlLi42ZGY4YTYwOTM3NWIyMjc1Yjg5ODIyMTQ5 OTg5ZGJmYTk0YTkyZWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv Q29jb2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1dlYlZpZXcubW0KQEAgLTE2NTcsNiArMTY1NywxNCBAQCAtIChXS05hdmlnYXRpb24gKils b2FkRmlsZVJlcXVlc3Q6KE5TVVJMUmVxdWVzdCAqKXJlcXVlc3QgYWxsb3dpbmdSZWFkQWNjZXNz VG9VUgogICAgIHJldHVybiB3cmFwcGVyKF9wYWdlLT5sb2FkRmlsZShVUkwuYWJzb2x1dGVTdHJp bmcsIHJlYWRBY2Nlc3NVUkwuYWJzb2x1dGVTdHJpbmcpKTsKIH0KIAorLSAoQ29jb2FDb2xvciAq KXRoZW1lQ29sb3IKK3sKKyAgICBhdXRvIHRoZW1lQ29sb3IgPSBfcGFnZS0+dGhlbWVDb2xvcigp OworICAgIGlmICghdGhlbWVDb2xvci5pc1ZhbGlkKCkpCisgICAgICAgIHJldHVybiBuaWw7Cisg ICAgcmV0dXJuIFdlYkNvcmU6OnBsYXRmb3JtQ29sb3IodGhlbWVDb2xvcik7Cit9CisKIEBlbmQK IAogI3ByYWdtYSBtYXJrIC0KQEAgLTI5ODIsMTQgKzI5OTAsNiBAQCAtICh2b2lkKV9zZXRDYW5V c2VDcmVkZW50aWFsU3RvcmFnZTooQk9PTCljYW5Vc2VDcmVkZW50aWFsU3RvcmFnZQogICAgIF9w YWdlLT5zZXRDYW5Vc2VDcmVkZW50aWFsU3RvcmFnZShjYW5Vc2VDcmVkZW50aWFsU3RvcmFnZSk7 CiB9CiAKLS0gKENvY29hQ29sb3IgKil0aGVtZUNvbG9yCi17Ci0gICAgYXV0byB0aGVtZUNvbG9y ID0gX3BhZ2UtPnRoZW1lQ29sb3IoKTsKLSAgICBpZiAoIXRoZW1lQ29sb3IuaXNWYWxpZCgpKQot ICAgICAgICByZXR1cm4gbmlsOwotICAgIHJldHVybiBXZWJDb3JlOjpwbGF0Zm9ybUNvbG9yKHRo ZW1lQ29sb3IpOwotfQotCiAtIChDb2NvYUNvbG9yICopX3RoZW1lQ29sb3IKIHsKICAgICByZXR1 cm4gW3NlbGYgdGhlbWVDb2xvcl07Cg==