224620 2021-04-15 13:34:41 -0700 webkitpy classes need not define loads/dumps helpers for pickle 2021-04-15 15:59:38 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 gsnedders gsnedders ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1750756 0 gsnedders 2021-04-15 13:34:41 -0700 These have little advantage versus calling pickle directly (and lack some of the options), and are only used by the tests to ensure certain classes round-trip. 1750757 1 426132 gsnedders 2021-04-15 13:37:51 -0700 Created attachment 426132 Patch 1750807 2 ews-feeder 2021-04-15 15:44:37 -0700 Committed r276081 (236593@main): <https://commits.webkit.org/236593@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426132. 1750824 3 ryanhaddad 2021-04-15 15:59:38 -0700 rdar://76727229 426132 2021-04-15 13:37:51 -0700 2021-04-15 15:44:38 -0700 Patch bug-224620-20210415213749.patch text/plain 6797 gsnedders U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1OTUyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzk1YjliN2YxZWExYTJmYmVkMDkyZGJmZGI3YTljNzM0 MGI0OTkzYy4uY2IzZjlkZmQ4Y2Y1YzY4MDE4MjcwYjlhYTM3YWQ5OGNlZGRkYzM4OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDIxLTA0LTE1ICBTYW0gU25lZGRvbiAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CisKKyAg ICAgICAgd2Via2l0cHkgY2xhc3NlcyBuZWVkIG5vdCBkZWZpbmUgbG9hZHMvZHVtcHMgaGVscGVy cyBmb3IgcGlja2xlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjQ2MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2ZhaWx1cmVz LnB5OgorICAgICAgICAoVGVzdEZhaWx1cmUubG9hZHMpOiBEZWxldGVkLgorICAgICAgICAoVGVz dEZhaWx1cmUuZHVtcHMpOiBEZWxldGVkLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL21vZGVscy90ZXN0X2ZhaWx1cmVzX3VuaXR0ZXN0LnB5OgorICAgICAgICAoVGVz dEZhaWx1cmVzVGVzdC5hc3NlcnRfcGlja2xlX3JvdW5kdHJpcCk6CisgICAgICAgIChUZXN0RmFp bHVyZXNUZXN0LnRlc3RfcGlja2xlX3JvdW5kdHJpcCk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfcmVzdWx0cy5weToKKyAgICAgICAgKFRlc3RS ZXN1bHQubG9hZHMpOiBEZWxldGVkLgorICAgICAgICAoVGVzdFJlc3VsdC5kdW1wcyk6IERlbGV0 ZWQuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3Rf cmVzdWx0c191bml0dGVzdC5weToKKyAgICAgICAgKFRlc3RSZXN1bHRzVGVzdC50ZXN0X3BpY2ts ZV9yb3VuZHRyaXApOgorCiAyMDIxLTA0LTE0ICBLYXRlIENoZW5leSAgPGthdGhlcmluZV9jaGVu ZXlAYXBwbGUuY29tPgogCiAgICAgICAgIFNlcnZpY2Ugd29ya2VyIHNvZnQtdXBkYXRlIGxvYWRz IG5vdCBiZWluZyBtYXJrZWQgYXBwLWJvdW5kCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9mYWlsdXJlcy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2ZhaWx1cmVzLnB5CmluZGV4IDkz MWU1OWJhNjQzOWNlMzkyOTJlZDdmMDhkMDIwYmZhYTU0YjU5MzYuLjc4ZmY0NGJmNDM2MDUxMzBl MzJkODRiZTQ2Y2Q2ODQ0N2I0MjE4YTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2ZhaWx1cmVzLnB5CisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X2ZhaWx1cmVzLnB5CkBAIC0yNywx MyArMjcsNiBAQAogIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBP U1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCiBpbXBvcnQgbG9nZ2luZwotaW1wb3J0IHN5cwot Ci1pZiBzeXMudmVyc2lvbl9pbmZvID4gKDMsIDApOgotICAgIGltcG9ydCBwaWNrbGUKLWVsc2U6 Ci0gICAgaW1wb3J0IGNQaWNrbGUgYXMgcGlja2xlCi0KIAogZnJvbSB3ZWJraXRweS5sYXlvdXRf dGVzdHMubW9kZWxzIGltcG9ydCB0ZXN0X2V4cGVjdGF0aW9ucwogCkBAIC05NCwxMSArODcsNiBA QCBkZWYgZGV0ZXJtaW5lX3Jlc3VsdF90eXBlKGZhaWx1cmVfbGlzdCk6CiBjbGFzcyBUZXN0RmFp bHVyZShvYmplY3QpOgogICAgICIiIkFic3RyYWN0IGJhc2UgY2xhc3MgdGhhdCBkZWZpbmVzIHRo ZSBmYWlsdXJlIGludGVyZmFjZS4iIiIKIAotICAgIEBzdGF0aWNtZXRob2QKLSAgICBkZWYgbG9h ZHMocyk6Ci0gICAgICAgICIiIkNyZWF0ZXMgYSBUZXN0RmFpbHVyZSBvYmplY3QgZnJvbSB0aGUg c3BlY2lmaWVkIHN0cmluZy4iIiIKLSAgICAgICAgcmV0dXJuIHBpY2tsZS5sb2FkcyhzKQotCiAg ICAgZGVmIG1lc3NhZ2Uoc2VsZik6CiAgICAgICAgICIiIlJldHVybnMgYSBzdHJpbmcgZGVzY3Jp YmluZyB0aGUgZmFpbHVyZSBpbiBtb3JlIGRldGFpbC4iIiIKICAgICAgICAgcmFpc2UgTm90SW1w bGVtZW50ZWRFcnJvcgpAQCAtMTEyLDEwICsxMDAsNiBAQCBjbGFzcyBUZXN0RmFpbHVyZShvYmpl Y3QpOgogICAgIGRlZiBfX2hhc2hfXyhzZWxmKToKICAgICAgICAgcmV0dXJuIGhhc2goc2VsZi5f X2NsYXNzX18uX19uYW1lX18pCiAKLSAgICBkZWYgZHVtcHMoc2VsZik6Ci0gICAgICAgICIiIlJl dHVybnMgdGhlIHN0cmluZy9KU09OIHJlcHJlc2VudGF0aW9uIG9mIGEgVGVzdEZhaWx1cmUuIiIi Ci0gICAgICAgIHJldHVybiBwaWNrbGUuZHVtcHMoc2VsZikKLQogICAgIGRlZiBkcml2ZXJfbmVl ZHNfcmVzdGFydChzZWxmKToKICAgICAgICAgIiIiUmV0dXJucyBUcnVlIGlmIHdlIHNob3VsZCBr aWxsIER1bXBSZW5kZXJUcmVlL1dlYktpdFRlc3RSdW5uZXIgYmVmb3JlIHRoZSBuZXh0IHRlc3Qu IiIiCiAgICAgICAgIHJldHVybiBGYWxzZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZmFpbHVyZXNfdW5pdHRlc3QucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9mYWlsdXJlc191bml0 dGVzdC5weQppbmRleCBlZTZjNDNmOTMyZDczNzM4NWQzYzJmY2ZkY2E1ZWZjNzcwMjYwZDU2Li44 MmE4OWQ4ZGQ1ZjlkZjQ0NWNhZjVlMjhjZWI2MmMwYWRmZjY1ZDlkIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9mYWlsdXJlc191bml0 dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMv dGVzdF9mYWlsdXJlc191bml0dGVzdC5weQpAQCAtMzAsMTIgKzMwLDE3IEBAIGltcG9ydCB1bml0 dGVzdAogCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5tb2RlbHMudGVzdF9mYWlsdXJlcyBp bXBvcnQgKgogCit0cnk6CisgICAgaW1wb3J0IGNQaWNrbGUgYXMgcGlja2xlCitleGNlcHQgSW1w b3J0RXJyb3I6CisgICAgaW1wb3J0IHBpY2tsZQorCiAKIGNsYXNzIFRlc3RGYWlsdXJlc1Rlc3Qo dW5pdHRlc3QuVGVzdENhc2UpOgotICAgIGRlZiBhc3NlcnRfbG9hZHMoc2VsZiwgY2xzKToKKyAg ICBkZWYgYXNzZXJ0X3BpY2tsZV9yb3VuZHRyaXAoc2VsZiwgY2xzKToKICAgICAgICAgZmFpbHVy ZV9vYmogPSBjbHMoKQotICAgICAgICBzID0gZmFpbHVyZV9vYmouZHVtcHMoKQotICAgICAgICBu ZXdfZmFpbHVyZV9vYmogPSBUZXN0RmFpbHVyZS5sb2FkcyhzKQorICAgICAgICBzID0gcGlja2xl LmR1bXBzKGZhaWx1cmVfb2JqKSAgIyBtdWx0aXByb2Nlc3NpbmcgdXNlcyB0aGUgZGVmYXVsdCBw cm90b2NvbCB2ZXJzaW9uCisgICAgICAgIG5ld19mYWlsdXJlX29iaiA9IHBpY2tsZS5sb2Fkcyhz KQogICAgICAgICBzZWxmLmFzc2VydElzSW5zdGFuY2UobmV3X2ZhaWx1cmVfb2JqLCBjbHMpCiAK ICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChmYWlsdXJlX29iaiwgbmV3X2ZhaWx1cmVfb2JqKQpA QCAtNTUsOSArNjAsOSBAQCBjbGFzcyBUZXN0RmFpbHVyZXNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNl KToKICAgICAgICAgZmFpbHVyZV9vYmogPSBUZXN0RmFpbHVyZSgpCiAgICAgICAgIHNlbGYuYXNz ZXJ0UmFpc2VzKE5vdEltcGxlbWVudGVkRXJyb3IsIGZhaWx1cmVfb2JqLm1lc3NhZ2UpCiAKLSAg ICBkZWYgdGVzdF9sb2FkcyhzZWxmKToKKyAgICBkZWYgdGVzdF9waWNrbGVfcm91bmR0cmlwKHNl bGYpOgogICAgICAgICBmb3IgYyBpbiBBTExfRkFJTFVSRV9DTEFTU0VTOgotICAgICAgICAgICAg c2VsZi5hc3NlcnRfbG9hZHMoYykKKyAgICAgICAgICAgIHNlbGYuYXNzZXJ0X3BpY2tsZV9yb3Vu ZHRyaXAoYykKIAogICAgIGRlZiB0ZXN0X2FsbF9mYWlsdXJlX2NsYXNzZXMoc2VsZik6CiAgICAg ICAgIGZhaWx1cmVfY2xhc3NlcyA9ICgKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0X3Jlc3VsdHMucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9yZXN1bHRzLnB5CmluZGV4IDY1YzUyMGU3 NmI1ZGNjZWY3ZGIwMjdjOGEyYzA0ZjZiYjU0ZWRkYjQuLjk5MDJhZmFkNmQzOTkwZDgxMzQyNThh MWRhNzc5MGUxODlkNzU4MzAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL21vZGVscy90ZXN0X3Jlc3VsdHMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfcmVzdWx0cy5weQpAQCAtMjYsMjIgKzI2LDEy IEBACiAjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5Z IFdBWSBPVVQgT0YgVEhFIFVTRQogIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQg T0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCi1pbXBvcnQgc3lzCi1pZiBzeXMu dmVyc2lvbl9pbmZvID4gKDMsIDApOgotICAgIGltcG9ydCBwaWNrbGUKLWVsc2U6Ci0gICAgaW1w b3J0IGNQaWNrbGUgYXMgcGlja2xlCi0KIGZyb20gd2Via2l0cHkubGF5b3V0X3Rlc3RzLm1vZGVs cyBpbXBvcnQgdGVzdF9mYWlsdXJlcwogCiAKIGNsYXNzIFRlc3RSZXN1bHQob2JqZWN0KToKICAg ICAiIiJEYXRhIG9iamVjdCBjb250YWluaW5nIHRoZSByZXN1bHRzIG9mIGEgc2luZ2xlIHRlc3Qu IiIiCiAKLSAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIGxvYWRzKHN0cmluZyk6Ci0gICAgICAg IHJldHVybiBwaWNrbGUubG9hZHMoc3RyaW5nKQotCiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIHRl c3RfbmFtZSwgZmFpbHVyZXM9Tm9uZSwgdGVzdF9ydW5fdGltZT1Ob25lLCBoYXNfc3RkZXJyPUZh bHNlLCByZWZ0ZXN0X3R5cGU9Tm9uZSwgcGlkPU5vbmUsIHJlZmVyZW5jZXM9Tm9uZSk6CiAgICAg ICAgIHNlbGYudGVzdF9uYW1lID0gdGVzdF9uYW1lCiAgICAgICAgIHNlbGYuZmFpbHVyZXMgPSBm YWlsdXJlcyBvciBbXQpAQCAtOTEsNiArODEsMyBAQCBjbGFzcyBUZXN0UmVzdWx0KG9iamVjdCk6 CiAgICAgICAgICAgICBpZiB0eXBlKGZhaWx1cmUpIGluIGZhaWx1cmVfY2xhc3NlczoKICAgICAg ICAgICAgICAgICByZXR1cm4gVHJ1ZQogICAgICAgICByZXR1cm4gRmFsc2UKLQotICAgIGRlZiBk dW1wcyhzZWxmKToKLSAgICAgICAgcmV0dXJuIHBpY2tsZS5kdW1wcyhzZWxmKQpkaWZmIC0tZ2l0 IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfcmVzdWx0 c191bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVs cy90ZXN0X3Jlc3VsdHNfdW5pdHRlc3QucHkKaW5kZXggOGQ0NjMxNTkwNTE2NWVlM2U2ZThmMmEz MDVmNGRkNTM2ZjFlMzIwOC4uM2RlNTUzMTNjNDgxODQ3NTE3YTlkNGNiNzVjZTcwMTRjNzE5MzMy ZCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxz L3Rlc3RfcmVzdWx0c191bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9tb2RlbHMvdGVzdF9yZXN1bHRzX3VuaXR0ZXN0LnB5CkBAIC0zMCw2ICszMCwx MSBAQCBpbXBvcnQgdW5pdHRlc3QKIAogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMubW9kZWxz LnRlc3RfcmVzdWx0cyBpbXBvcnQgVGVzdFJlc3VsdAogCit0cnk6CisgICAgaW1wb3J0IGNQaWNr bGUgYXMgcGlja2xlCitleGNlcHQgSW1wb3J0RXJyb3I6CisgICAgaW1wb3J0IHBpY2tsZQorCiAK IGNsYXNzIFRlc3RSZXN1bHRzVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgZGVmIHRlc3Rf ZGVmYXVsdHMoc2VsZik6CkBAIC0zOCwxMiArNDMsMTAgQEAgY2xhc3MgVGVzdFJlc3VsdHNUZXN0 KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChyZXN1bHQuZmFp bHVyZXMsIFtdKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHJlc3VsdC50ZXN0X3J1bl90aW1l LCAwKQogCi0gICAgZGVmIHRlc3RfbG9hZHMoc2VsZik6Ci0gICAgICAgIHJlc3VsdCA9IFRlc3RS ZXN1bHQodGVzdF9uYW1lPSdmb28nLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZhaWx1 cmVzPVtdLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRlc3RfcnVuX3RpbWU9MS4xKQot ICAgICAgICBzID0gcmVzdWx0LmR1bXBzKCkKLSAgICAgICAgbmV3X3Jlc3VsdCA9IFRlc3RSZXN1 bHQubG9hZHMocykKKyAgICBkZWYgdGVzdF9waWNrbGVfcm91bmR0cmlwKHNlbGYpOgorICAgICAg ICByZXN1bHQgPSBUZXN0UmVzdWx0KHRlc3RfbmFtZT0nZm9vJywgZmFpbHVyZXM9W10sIHRlc3Rf cnVuX3RpbWU9MS4xKQorICAgICAgICBzID0gcGlja2xlLmR1bXBzKHJlc3VsdCkgICMgbXVsdGlw cm9jZXNzaW5nIHVzZXMgdGhlIGRlZmF1bHQgcHJvdG9jb2wgdmVyc2lvbgorICAgICAgICBuZXdf cmVzdWx0ID0gcGlja2xlLmxvYWRzKHMpCiAgICAgICAgIHNlbGYuYXNzZXJ0SXNJbnN0YW5jZShu ZXdfcmVzdWx0LCBUZXN0UmVzdWx0KQogCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwobmV3X3Jl c3VsdCwgcmVzdWx0KQo=