22461 2008-11-24 12:20:59 -0800 AccessibilityListBox::doAccessibilityHitTest() signature does not match the base class 2008-11-24 14:33:47 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser webkit-unassigned cfleizach oldest_to_newest 100010 0 simon.fraser 2008-11-24 12:20:59 -0800 AccessibilityListBox has: AccessibilityListBox::doAccessibilityHitTest(const IntPoint&); base class has: AccessibilityRenderObject::doAccessibilityHitTest(const IntPoint&) const; note the different in 'const' which mean that the AccessibilityListBox will not override the base class method. 100064 1 25452 cfleizach 2008-11-24 14:21:57 -0800 Created attachment 25452 patch so AX list box hit test overrides correctly 100065 2 25452 bdakin 2008-11-24 14:26:35 -0800 Comment on attachment 25452 patch so AX list box hit test overrides correctly r=me 100068 3 cfleizach 2008-11-24 14:33:47 -0800 Committed revision 38726. 25452 2008-11-24 14:21:57 -0800 2008-11-24 14:26:35 -0800 patch so AX list box hit test overrides correctly patch.txt text/plain 2924 cfleizach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODcyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMTEtMjQgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBCdWcgMjI0NjE6IEFjY2Vzc2liaWxpdHlMaXN0Qm94Ojpkb0FjY2Vzc2liaWxpdHlIaXRUZXN0 KCkgc2lnbmF0dXJlIGRvZXMgbm90IG1hdGNoIHRoZSBiYXNlIGNsYXNzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ2MQorIAorICAgICAgICBDaGFu Z2luZyBBY2Nlc3NpYmlsaXR5TGlzdEJveCB0byB1c2UgaXRzIHBhcmVudCdzIHNpZ25hdHVyZSBm b3IgaGl0IHRlc3QKKworICAgICAgICAqIHBhZ2UvQWNjZXNzaWJpbGl0eUxpc3RCb3guY3BwOgor ICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eUxpc3RCb3g6OmRvQWNjZXNzaWJpbGl0eUhp dFRlc3QpOgorICAgICAgICAqIHBhZ2UvQWNjZXNzaWJpbGl0eUxpc3RCb3guaDoKKwogMjAwOC0x MS0yNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBG aXggV2luZG93cyBidWlsZDogc2VsZWN0aW9uUmVjdCgpIC0+IHNlbGVjdGlvbkJvdW5kcygpLgpJ bmRleDogV2ViQ29yZS9wYWdlL0FjY2Vzc2liaWxpdHlMaXN0Qm94LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BhZ2UvQWNjZXNzaWJpbGl0eUxpc3RCb3guY3BwCShyZXZpc2lvbiAzODcyNCkK KysrIFdlYkNvcmUvcGFnZS9BY2Nlc3NpYmlsaXR5TGlzdEJveC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE1MCw3ICsxNTAsNyBAQCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBBY2Nlc3NpYmlsaXR5TGlz dEJvCiAgICAgcmV0dXJuIGxpc3RCb3hPYmplY3Q7CiB9CiAKLUFjY2Vzc2liaWxpdHlPYmplY3Qq IEFjY2Vzc2liaWxpdHlMaXN0Qm94Ojpkb0FjY2Vzc2liaWxpdHlIaXRUZXN0KGNvbnN0IEludFBv aW50JiBwb2ludCkKK0FjY2Vzc2liaWxpdHlPYmplY3QqIEFjY2Vzc2liaWxpdHlMaXN0Qm94Ojpk b0FjY2Vzc2liaWxpdHlIaXRUZXN0KGNvbnN0IEludFBvaW50JiBwb2ludCkgY29uc3QKIHsKICAg ICAvLyB0aGUgaW50ZXJuYWwgSFRNTFNlbGVjdEVsZW1lbnQgbWV0aG9kcyBmb3IgcmV0dXJuaW5n IGEgbGlzdGJveCBvcHRpb24gYXQgYSBwb2ludAogICAgIC8vIGlnbm9yZSBvcHRncm91cCBlbGVt ZW50cy4KQEAgLTE2MCwyMCArMTYwLDE4IEBAIEFjY2Vzc2liaWxpdHlPYmplY3QqIEFjY2Vzc2li aWxpdHlMaXN0Qm8KICAgICBOb2RlICplbGVtZW50ID0gbV9yZW5kZXJlci0+ZWxlbWVudCgpOwog ICAgIGlmICghZWxlbWVudCkKICAgICAgICAgcmV0dXJuIDA7Ci0KLSAgICBpZiAoIWhhc0NoaWxk cmVuKCkpCi0gICAgICAgIGFkZENoaWxkcmVuKCk7CiAgICAgCiAgICAgSW50UmVjdCBwYXJlbnRS ZWN0ID0gYm91bmRpbmdCb3hSZWN0KCk7CiAgICAgCi0gICAgdW5zaWduZWQgbGVuZ3RoID0gbV9j aGlsZHJlbi5zaXplKCk7CisgICAgY29uc3QgVmVjdG9yPEhUTUxFbGVtZW50Kj4mIGxpc3RJdGVt cyA9IHN0YXRpY19jYXN0PEhUTUxTZWxlY3RFbGVtZW50Kj4oZWxlbWVudCktPmxpc3RJdGVtcygp OworICAgIHVuc2lnbmVkIGxlbmd0aCA9IGxpc3RJdGVtcy5zaXplKCk7CiAgICAgZm9yICh1bnNp Z25lZCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKSB7CiAgICAgICAgIEludFJlY3QgcmVjdCA9IHN0 YXRpY19jYXN0PFJlbmRlckxpc3RCb3gqPihtX3JlbmRlcmVyKS0+aXRlbUJvdW5kaW5nQm94UmVj dChwYXJlbnRSZWN0LngoKSwgcGFyZW50UmVjdC55KCksIGkpOwogICAgICAgICBpZiAocmVjdC5j b250YWlucyhwb2ludCkpCi0gICAgICAgICAgICByZXR1cm4gbV9jaGlsZHJlbltpXS5nZXQoKTsK KyAgICAgICAgICAgIHJldHVybiBsaXN0Qm94T3B0aW9uQWNjZXNzaWJpbGl0eU9iamVjdChsaXN0 SXRlbXNbaV0pOwogICAgIH0KICAgICAKLSAgICByZXR1cm4gdGhpczsKKyAgICByZXR1cm4gYXhP YmplY3RDYWNoZSgpLT5nZXQobV9yZW5kZXJlcik7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNv cmUKSW5kZXg6IFdlYkNvcmUvcGFnZS9BY2Nlc3NpYmlsaXR5TGlzdEJveC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvcGFnZS9BY2Nlc3NpYmlsaXR5TGlzdEJveC5oCShyZXZpc2lvbiAzODcyNCkK KysrIFdlYkNvcmUvcGFnZS9BY2Nlc3NpYmlsaXR5TGlzdEJveC5oCSh3b3JraW5nIGNvcHkpCkBA IC00Miw3ICs0Miw3IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUGFzc1JlZlB0cjxBY2Nlc3NpYmls aXR5TGlzdEJveD4gY3JlYXRlKFJlbmRlck9iamVjdCopOwogICAgIHZpcnR1YWwgfkFjY2Vzc2li aWxpdHlMaXN0Qm94KCk7CiAgICAgCi0gICAgdmlydHVhbCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBk b0FjY2Vzc2liaWxpdHlIaXRUZXN0KGNvbnN0IEludFBvaW50Jik7CisgICAgdmlydHVhbCBBY2Nl c3NpYmlsaXR5T2JqZWN0KiBkb0FjY2Vzc2liaWxpdHlIaXRUZXN0KGNvbnN0IEludFBvaW50Jikg Y29uc3Q7CiAgICAgdmlydHVhbCBib29sIGlzTGlzdEJveCgpIGNvbnN0IHsgcmV0dXJuIHRydWU7 IH07CiAgICAgCiAgICAgdmlydHVhbCBib29sIGNhblNldEZvY3VzQXR0cmlidXRlKCkgY29uc3Qg eyByZXR1cm4gdHJ1ZTsgfQo=