224608 2021-04-15 08:12:02 -0700 [SOUP] Bring back the call to ResourceResponse::setDeprecatedNetworkLoadMetrics after r276008 2021-04-15 08:35:12 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224541 Gtk P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply oldest_to_newest 1750611 0 cgarcia 2021-04-15 08:12:02 -0700 It turns out it's actually still used by the inspector. I don't want to revert r276008 because it included other fixes, so I'll just fix it in this new bug. 1750614 1 426106 cgarcia 2021-04-15 08:13:39 -0700 Created attachment 426106 Patch 1750621 2 cgarcia 2021-04-15 08:35:12 -0700 Committed r276021 (236573@main): <https://commits.webkit.org/236573@main> 426106 2021-04-15 08:13:39 -0700 2021-04-15 08:19:39 -0700 Patch wk2-fix-inspector-metrics.diff text/plain 2729 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYzg5NjA4NmQ4NmM1Li4wYWI5NmU3ZGM4NTIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTcgQEAKKzIwMjEtMDQtMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtTT1VQXSBCcmluZyBiYWNrIHRoZSBjYWxsIHRvIFJlc291cmNl UmVzcG9uc2U6OnNldERlcHJlY2F0ZWROZXR3b3JrTG9hZE1ldHJpY3MgYWZ0ZXIgcjI3NjAwOAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NjA4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgdHVybnMg b3V0IGl0J3MgYWN0dWFsbHkgc3RpbGwgdXNlZCBieSB0aGUgaW5zcGVjdG9yLiBJIGRvbid0IHdh bnQgdG8gcmV2ZXJ0IHIyNzYwMDggYmVjYXVzZSBpdCBpbmNsdWRlZCBvdGhlcgorICAgICAgICBm aXhlcywgc28gaXQncyBqdXN0IGZpeGVkIGluIHRoaXMgcGF0Y2guCisKKyAgICAgICAgKiBOZXR3 b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtEYXRhVGFza1NvdXAuY3BwOgorICAgICAgICAoV2ViS2l0 OjpOZXR3b3JrRGF0YVRhc2tTb3VwOjpkaWRTZW5kUmVxdWVzdCk6CisgICAgICAgIChXZWJLaXQ6 Ok5ldHdvcmtEYXRhVGFza1NvdXA6OmRpc3BhdGNoRGlkUmVjZWl2ZVJlc3BvbnNlKToKKwogMjAy MS0wNC0xNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW1NPVVBdIEFkZCBzdXBwb3J0IGZvciAibmV4dEhvcFByb3RvY29sIiBmb3IgUmVzb3Vy Y2UgVGltaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3NvdXAv TmV0d29ya0RhdGFUYXNrU291cC5jcHAgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3Nv dXAvTmV0d29ya0RhdGFUYXNrU291cC5jcHAKaW5kZXggZjJhODg2NjhkNGMxLi40ZDlkOTAwODJm MTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3Jr RGF0YVRhc2tTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3NvdXAv TmV0d29ya0RhdGFUYXNrU291cC5jcHAKQEAgLTQwNCw2ICs0MDQsOSBAQCB2b2lkIE5ldHdvcmtE YXRhVGFza1NvdXA6OmRpZFNlbmRSZXF1ZXN0KEdSZWZQdHI8R0lucHV0U3RyZWFtPiYmIGlucHV0 U3RyZWFtKQogICAgICAgICBtX2lucHV0U3RyZWFtID0gV1RGTW92ZShpbnB1dFN0cmVhbSk7CiAK ICAgICBtX25ldHdvcmtMb2FkTWV0cmljcy5yZXNwb25zZVN0YXJ0ID0gTW9ub3RvbmljVGltZTo6 bm93KCkuc2Vjb25kc1NpbmNlRXBvY2goKSAtIG1fbmV0d29ya0xvYWRNZXRyaWNzLmZldGNoU3Rh cnQ7CisKKyAgICAvLyBGSVhNRTogVGhpcyBjYW5ub3QgYmUgZWxpbWluYXRlZCB1bnRpbCBvdGhl ciBjb2RlIG5vIGxvbmdlciByZWxpZXMgb24gUmVzb3VyY2VSZXNwb25zZSdzIE5ldHdvcmtMb2Fk TWV0cmljcy4KKyAgICBtX3Jlc3BvbnNlLnNldERlcHJlY2F0ZWROZXR3b3JrTG9hZE1ldHJpY3Mo Qm94PE5ldHdvcmtMb2FkTWV0cmljcz46OmNyZWF0ZShtX25ldHdvcmtMb2FkTWV0cmljcykpOwog ICAgIGRpc3BhdGNoRGlkUmVjZWl2ZVJlc3BvbnNlKCk7CiB9CiAKQEAgLTQxMSwxNiArNDE0LDYg QEAgdm9pZCBOZXR3b3JrRGF0YVRhc2tTb3VwOjpkaXNwYXRjaERpZFJlY2VpdmVSZXNwb25zZSgp CiB7CiAgICAgQVNTRVJUKCFtX3Jlc3BvbnNlLmlzTnVsbCgpKTsKIAotICAgIEJveDxOZXR3b3Jr TG9hZE1ldHJpY3M+IHRpbWluZyA9IEJveDxOZXR3b3JrTG9hZE1ldHJpY3M+OjpjcmVhdGUoKTsK LSAgICB0aW1pbmctPnJlc3BvbnNlU3RhcnQgPSBtX25ldHdvcmtMb2FkTWV0cmljcy5yZXNwb25z ZVN0YXJ0OwotICAgIHRpbWluZy0+ZG9tYWluTG9va3VwU3RhcnQgPSBtX25ldHdvcmtMb2FkTWV0 cmljcy5kb21haW5Mb29rdXBTdGFydDsKLSAgICB0aW1pbmctPmRvbWFpbkxvb2t1cEVuZCA9IG1f bmV0d29ya0xvYWRNZXRyaWNzLmRvbWFpbkxvb2t1cEVuZDsKLSAgICB0aW1pbmctPmNvbm5lY3RT dGFydCA9IG1fbmV0d29ya0xvYWRNZXRyaWNzLmNvbm5lY3RTdGFydDsKLSAgICB0aW1pbmctPnNl Y3VyZUNvbm5lY3Rpb25TdGFydCA9IG1fbmV0d29ya0xvYWRNZXRyaWNzLnNlY3VyZUNvbm5lY3Rp b25TdGFydDsKLSAgICB0aW1pbmctPmNvbm5lY3RFbmQgPSBtX25ldHdvcmtMb2FkTWV0cmljcy5j b25uZWN0RW5kOwotICAgIHRpbWluZy0+cmVxdWVzdFN0YXJ0ID0gbV9uZXR3b3JrTG9hZE1ldHJp Y3MucmVxdWVzdFN0YXJ0OwotICAgIHRpbWluZy0+cmVzcG9uc2VTdGFydCA9IG1fbmV0d29ya0xv YWRNZXRyaWNzLnJlc3BvbnNlU3RhcnQ7Ci0KICAgICBkaWRSZWNlaXZlUmVzcG9uc2UoUmVzb3Vy Y2VSZXNwb25zZShtX3Jlc3BvbnNlKSwgTmVnb3RpYXRlZExlZ2FjeVRMUzo6Tm8sIFt0aGlzLCBw cm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyldKFBvbGljeUFjdGlvbiBwb2xpY3lBY3Rpb24p IHsKICAgICAgICAgaWYgKG1fc3RhdGUgPT0gU3RhdGU6OkNhbmNlbGluZyB8fCBtX3N0YXRlID09 IFN0YXRlOjpDb21wbGV0ZWQpIHsKICAgICAgICAgICAgIGNsZWFyUmVxdWVzdCgpOwo=