224602 2021-04-15 05:29:19 -0700 MacCatalyst ANGLE is linked with @loader_path/../../../libANGLE-shared.dylib 2021-04-20 14:45:31 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224785 InRadar P2 Normal --- 224603 224605 1 kkinnunen achristensen achristensen ap dino ews-watchlist graouts kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1750577 0 kkinnunen 2021-04-15 05:29:19 -0700 MacCatalyst ANGLE is linked with @loader_path/../../../libANGLE-shared.dylib The path may be wrong. The use of @loader_path is probably wrong. ld: warning: invalid -install_name (@loader_path/../../../libANGLE-shared.dylib) in dependent dylib (/Users/kkinnunen/Build/Debug-maccatalyst/libANGLE-shared.dylib). Dylibs/frameworks which might go in dyld shared cache cannot link with dylib that uses @rpath, @loader_path, 1750578 1 kkinnunen 2021-04-15 05:30:07 -0700 <rdar://76602857> 1752310 2 achristensen 2021-04-20 09:56:56 -0700 DYLIB_INSTALL_NAME_BASE is probably wrong when WK_ALTERNATE_FRAMEWORKS_DIR is used. 1752311 3 achristensen 2021-04-20 09:59:44 -0700 I'm planning to fix this this afternoon. 1752313 4 426562 achristensen 2021-04-20 10:01:40 -0700 Created attachment 426562 Patch 1752314 5 ews-watchlist 2021-04-20 10:02:32 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1752338 6 426562 kkinnunen 2021-04-20 11:05:38 -0700 Comment on attachment 426562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426562&action=review > Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:28 > DYLIB_INSTALL_NAME_BASE_WK_RELOCATABLE_FRAMEWORKS_YES = @loader_path/../../../; Out of curiosity, in which this loader_path is correct? 1752370 7 achristensen 2021-04-20 12:14:45 -0700 The use of @loader_path is necessary when we use WK_RELOCATABLE_FRAMEWORKS because we need to be able to relocate them and have dyld still find the dylib relative to the framework. 1752405 8 426562 achristensen 2021-04-20 13:32:21 -0700 Comment on attachment 426562 Patch When building project ANGLE: INSTALL_PATH\=/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks DYLIB_INSTALL_NAME_BASE\=/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/Versions/A/Frameworks When building project ANGLE_iosmac before this change: INSTALL_PATH\=/System/iOSSupport//System/Library/PrivateFrameworks/WebCore.framework/Versions/A/Frameworks DYLIB_INSTALL_NAME_BASE\=@loader_path/../../../ When building project ANGLE_iosmac after this change: INSTALL_PATH\=/System/iOSSupport//System/Library/PrivateFrameworks/WebCore.framework/Versions/A/Frameworks DYLIB_INSTALL_NAME_BASE\=/System/iOSSupport//System/Library/PrivateFrameworks/WebCore.framework/Versions/A/Frameworks This leads me to believe this will fix the problem. 1752412 9 426562 ap 2021-04-20 14:09:30 -0700 Comment on attachment 426562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426562&action=review > Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig:26 > +DYLIB_INSTALL_NAME_BASE_USE_ALTERNATE_FRAMEWORKS_DIR_YES = @(INSTALL_PATH); Looking at other projects, and even at the below line, we are using DYLIB_INSTALL_NAME_BASE for this case, not INSTALL_PATH. There is probably no difference in practice, but let's use the same solution as elsewhere. 1752417 10 achristensen 2021-04-20 14:15:58 -0700 I verified that does the same thing so I'll do it. I also verified that when using relocatable frameworks, DYLIB_INSTALL_NAME_BASE is @loader_path/../../../ so there *should* be no problem there. 1752418 11 426589 achristensen 2021-04-20 14:18:40 -0700 Created attachment 426589 Patch 1752436 12 ews-feeder 2021-04-20 14:45:29 -0700 Committed r276318 (236799@main): <https://commits.webkit.org/236799@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426589. 426562 2021-04-20 10:01:40 -0700 2021-04-20 14:18:38 -0700 Patch bug-224602-20210420100140.patch text/plain 1801 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MjcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggNDRlNWU3NjFjYjk0NjU2YWQ1MTZkN2ZmM2Q2ZjQyZmE4NmQ3YjRiYy4uNWQ2MmM2NDZhMmI1 ZTQ4M2YxNGQ5YzNmNDVjNDk0MTAwOTRkM2I1OCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA0LTIwICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlz dGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTWFjQ2F0YWx5c3QgQU5HTEUgaXMgbGlua2Vk IHdpdGggQGxvYWRlcl9wYXRoLy4uLy4uLy4uL2xpYkFOR0xFLXNoYXJlZC5keWxpYgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NjAyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9u cy9BTkdMRS1keW5hbWljLnhjY29uZmlnOgorCiAyMDIxLTA0LTE2ICBLeWxlIFBpZGRpbmd0b24g IDxrcGlkZGluZ3RvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWV0YWwtQU5HTEU6IFNoYXJlZCBt ZW1vcnkgdGV4dHVyZSB0ZXN0cyBmYWlsaW5nIGluIGlPUyBTaW11bGF0b3IKZGlmZiAtLWdpdCBh L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRpb25zL0FOR0xFLWR5bmFtaWMueGNj b25maWcgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9Db25maWd1cmF0aW9ucy9BTkdMRS1keW5h bWljLnhjY29uZmlnCmluZGV4IDcxMDU1YTY0ZTNmMzk0NWMxNTg5OTFmMDRmMTVjMTBjMzlkNzA2 OWEuLjY5NmIxMWY3ZTZiOGJlNDY1YTI3ZTIyYTA3ZDkzYTQxOTg2OGE5MjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRpb25zL0FOR0xFLWR5bmFtaWMueGNj b25maWcKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ29uZmlndXJhdGlvbnMvQU5HTEUt ZHluYW1pYy54Y2NvbmZpZwpAQCAtMjMsNyArMjMsNyBAQCBJTlNUQUxMX1BBVEhfVVNFX0FMVEVS TkFURV9GUkFNRVdPUktTX0RJUl9ZRVMgPSAkKFdLX0FMVEVSTkFURV9GUkFNRVdPUktTX0RJUikv JAogCiBEWUxJQl9JTlNUQUxMX05BTUVfQkFTRVtzZGs9bWFjb3N4Kl0gPSAkKERZTElCX0lOU1RB TExfTkFNRV9CQVNFX1VTRV9BTFRFUk5BVEVfRlJBTUVXT1JLU19ESVJfJChXS19VU0VfQUxURVJO QVRFX0ZSQU1FV09SS1NfRElSKSk7CiBEWUxJQl9JTlNUQUxMX05BTUVfQkFTRV9VU0VfQUxURVJO QVRFX0ZSQU1FV09SS1NfRElSX05PID0gJChEWUxJQl9JTlNUQUxMX05BTUVfQkFTRV9XS19SRUxP Q0FUQUJMRV9GUkFNRVdPUktTXyQoV0tfUkVMT0NBVEFCTEVfRlJBTUVXT1JLUykpOwotRFlMSUJf SU5TVEFMTF9OQU1FX0JBU0VfVVNFX0FMVEVSTkFURV9GUkFNRVdPUktTX0RJUl9ZRVMgPSBAbG9h ZGVyX3BhdGgvLi4vLi4vLi4vOworRFlMSUJfSU5TVEFMTF9OQU1FX0JBU0VfVVNFX0FMVEVSTkFU RV9GUkFNRVdPUktTX0RJUl9ZRVMgPSBAKElOU1RBTExfUEFUSCk7CiBEWUxJQl9JTlNUQUxMX05B TUVfQkFTRV9XS19SRUxPQ0FUQUJMRV9GUkFNRVdPUktTXyA9ICQoRFlMSUJfSU5TVEFMTF9OQU1F X0JBU0UpOwogRFlMSUJfSU5TVEFMTF9OQU1FX0JBU0VfV0tfUkVMT0NBVEFCTEVfRlJBTUVXT1JL U19ZRVMgPSBAbG9hZGVyX3BhdGgvLi4vLi4vLi4vOwogCg== 426589 2021-04-20 14:18:40 -0700 2021-04-20 14:45:30 -0700 Patch bug-224602-20210420141839.patch text/plain 1826 achristensen U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MzE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggZGZjMTk5NWU1ZGNmMmUwODliZDlmNDM5NTdkYzdhNzk5MmY5NTNmNS4uMTljZWM3MWRkZTdl ZTlmYjBlODUzMzRhODVlNDM5NzVhYzc5NjQzZCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTA0LTIwICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlz dGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTWFjQ2F0YWx5c3QgQU5HTEUgaXMgbGlua2Vk IHdpdGggQGxvYWRlcl9wYXRoLy4uLy4uLy4uL2xpYkFOR0xFLXNoYXJlZC5keWxpYgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NjAyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KKworICAgICAgICAqIENvbmZpZ3Vy YXRpb25zL0FOR0xFLWR5bmFtaWMueGNjb25maWc6CisKIDIwMjEtMDQtMTkgIEFsZXggQ2hyaXN0 ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBBTkdMRSBk eWxpYiBpbnRvIFdLX09WRVJSSURFX0ZSQU1FV09SS1NfRElSIGluIGJ1aWxkcyB0aGF0IHVzZSBp dApkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ29uZmlndXJhdGlvbnMvQU5H TEUtZHluYW1pYy54Y2NvbmZpZyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NvbmZpZ3VyYXRp b25zL0FOR0xFLWR5bmFtaWMueGNjb25maWcKaW5kZXggMzc3ZTdjM2VjYzk0ZjU2YjU1YzNiYzI2 MWJlYTQ4MGFkMjcyMWIwMi4uMTNhOTNjOGY1ZDgwNWE0ZmIwNGI4YjU4ZTBkNzk2MTgyODE3MzM2 MyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ29uZmlndXJhdGlvbnMvQU5H TEUtZHluYW1pYy54Y2NvbmZpZworKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9Db25maWd1 cmF0aW9ucy9BTkdMRS1keW5hbWljLnhjY29uZmlnCkBAIC0yNSw3ICsyNSw3IEBAIElOU1RBTExf UEFUSF9VU0VfQUxURVJOQVRFX0ZSQU1FV09SS1NfRElSX1lFUyA9ICQoV0tfQUxURVJOQVRFX0ZS QU1FV09SS1NfRElSKS8kCiAKIERZTElCX0lOU1RBTExfTkFNRV9CQVNFW3Nkaz1tYWNvc3gqXSA9 ICQoRFlMSUJfSU5TVEFMTF9OQU1FX0JBU0VfVVNFX0FMVEVSTkFURV9GUkFNRVdPUktTX0RJUl8k KFdLX1VTRV9BTFRFUk5BVEVfRlJBTUVXT1JLU19ESVIpKTsKIERZTElCX0lOU1RBTExfTkFNRV9C QVNFX1VTRV9BTFRFUk5BVEVfRlJBTUVXT1JLU19ESVJfTk8gPSAkKERZTElCX0lOU1RBTExfTkFN RV9CQVNFX1dLX1JFTE9DQVRBQkxFX0ZSQU1FV09SS1NfJChXS19SRUxPQ0FUQUJMRV9GUkFNRVdP UktTKSk7Ci1EWUxJQl9JTlNUQUxMX05BTUVfQkFTRV9VU0VfQUxURVJOQVRFX0ZSQU1FV09SS1Nf RElSX1lFUyA9IEBsb2FkZXJfcGF0aC8uLi8uLi8uLi87CitEWUxJQl9JTlNUQUxMX05BTUVfQkFT RV9VU0VfQUxURVJOQVRFX0ZSQU1FV09SS1NfRElSX1lFUyA9IEAoRFlMSUJfSU5TVEFMTF9OQU1F X0JBU0UpOwogRFlMSUJfSU5TVEFMTF9OQU1FX0JBU0VfV0tfUkVMT0NBVEFCTEVfRlJBTUVXT1JL U18gPSAkKERZTElCX0lOU1RBTExfTkFNRV9CQVNFKTsKIERZTElCX0lOU1RBTExfTkFNRV9CQVNF X1dLX1JFTE9DQVRBQkxFX0ZSQU1FV09SS1NfWUVTID0gQGxvYWRlcl9wYXRoLy4uLy4uLy4uLzsK IAo=