224592 2021-04-14 22:29:23 -0700 Add missing exception check in operationGetPrivateNameOptimize(). 2021-04-14 22:54:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1750484 0 mark.lam 2021-04-14 22:29:23 -0700 rdar://76645873 1750486 1 426075 mark.lam 2021-04-14 22:39:01 -0700 Created attachment 426075 proposed patch. 1750489 2 426075 ysuzuki 2021-04-14 22:45:48 -0700 Comment on attachment 426075 proposed patch. r=me 1750490 3 426075 ysuzuki 2021-04-14 22:46:12 -0700 Comment on attachment 426075 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=426075&action=review > Source/JavaScriptCore/jit/JITOperations.cpp:2407 > + EXCEPTION_ASSERT(!scope.exception() || vm.isTerminationException(scope.exception())); We discussed and left this assertion for documentation purpose. 1750491 4 mark.lam 2021-04-14 22:54:28 -0700 Thanks for the review. Landed in r276000: <http://trac.webkit.org/r276000>. 426075 2021-04-14 22:39:01 -0700 2021-04-14 22:45:48 -0700 proposed patch. bug-224592.patch text/plain 2854 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzU5OTgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDIxLTA0LTE0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgbWlzc2luZyBleGNlcHRpb24gY2hlY2sgaW4gb3BlcmF0aW9uR2V0 UHJpdmF0ZU5hbWVPcHRpbWl6ZSgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjI0NTkyCisgICAgICAgIHJkYXI6Ly83NjY0NTg3MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL3N1cHByZXNz LVRlcm1pbmF0aW9uRXhjZXB0aW9uLWluLW9wZXJhdGlvbkdldFByaXZhdGVOYW1lT3B0aW1pemUu anM6IEFkZGVkLgorCiAyMDIxLTA0LTE0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4K IAogICAgICAgICBEZWZlciBUZXJtaW5hdGlvbkV4Y2VwdGlvbnMgd2hlbiBldmFsdWF0aW5nIEFT U0VSVCBpbiBIYXNoTWFwSW1sOjphZGROb3JtYWxpemVkKCkuCkluZGV4OiBKU1Rlc3RzL3N0cmVz cy9zdXBwcmVzcy1UZXJtaW5hdGlvbkV4Y2VwdGlvbi1pbi1vcGVyYXRpb25HZXRQcml2YXRlTmFt ZU9wdGltaXplLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3N1cHByZXNzLVRlcm1p bmF0aW9uRXhjZXB0aW9uLWluLW9wZXJhdGlvbkdldFByaXZhdGVOYW1lT3B0aW1pemUuanMJKG5v bmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3Mvc3VwcHJlc3MtVGVybWluYXRpb25FeGNlcHRp b24taW4tb3BlcmF0aW9uR2V0UHJpdmF0ZU5hbWVPcHRpbWl6ZS5qcwkod29ya2luZyBjb3B5KQpA QCAtMCwwICsxLDE2IEBACisvL0AgcnVuRGVmYXVsdCgiLS13YXRjaGRvZz0xMDAiLCAiLS13YXRj aGRvZy1leGNlcHRpb24tb2siKQorCitjbGFzcyBGb28geworICAjeDsKKyAgY29uc3RydWN0b3Io KSB7CisgICAgZ2MoKTsKKyAgICB0cnkgeworICAgICAgT2JqZWN0LiN4KCk7CisgICAgfSBjYXRj aCAoZSkgeworICAgIH0KKyAgfQorfQorCit3aGlsZSgxKSB7CisgIG5ldyBGb28oKTsKK30KSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc1OTcxKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisy MDIxLTA0LTE0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQg bWlzc2luZyBleGNlcHRpb24gY2hlY2sgaW4gb3BlcmF0aW9uR2V0UHJpdmF0ZU5hbWVPcHRpbWl6 ZSgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0 NTkyCisgICAgICAgIHJkYXI6Ly83NjY0NTg3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRob3VnaCB0aGUgZmllbGROYW1lVmFsdWUudG9Qcm9wZXJ0 eUtleSgpIGNhbGwgaW4gb3BlcmF0aW9uR2V0UHJpdmF0ZU5hbWVPcHRpbWl6ZSgpCisgICAgICAg IHdvdWxkIG5vdCBub3JtYWxseSB0aHJvdyBhbiBleGNlcHRpb24sIGl0IHN0aWxsIGNhbiB0aHJv dyBhIFRlcm1pbmF0aW9uRXhjZXB0aW9uCisgICAgICAgIGJlY2F1c2UgaXQgY29udGFpbnMgUkVU VVJOX0lGX0VYQ0VQVElPTiBjaGVja3MuCisKKyAgICAgICAgKiBqaXQvSklUT3BlcmF0aW9ucy5j cHA6CisKIDIwMjEtMDQtMTQgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAg ICAgIEFwcGx5IERlZmVyVGVybWluYXRpb24gaW4gc29tZSB1dGlsaXR5IGZ1bmN0aW9ucyBpbiB0 aGUganNjIHNoZWxsLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRPcGVyYXRp b25zLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0pJVE9wZXJh dGlvbnMuY3BwCShyZXZpc2lvbiAyNzU5NjcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0pJVE9wZXJhdGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDA0LDcgKzI0MDQsOCBAQCBK U0NfREVGSU5FX0pJVF9PUEVSQVRJT04ob3BlcmF0aW9uR2V0UHJpCiAKICAgICBpZiAoYmFzZVZh bHVlLmlzT2JqZWN0KCkpIHsKICAgICAgICAgY29uc3QgSWRlbnRpZmllciBmaWVsZE5hbWUgPSBm aWVsZE5hbWVWYWx1ZS50b1Byb3BlcnR5S2V5KGdsb2JhbE9iamVjdCk7Ci0gICAgICAgIEVYQ0VQ VElPTl9BU1NFUlQoIXNjb3BlLmV4Y2VwdGlvbigpKTsKKyAgICAgICAgRVhDRVBUSU9OX0FTU0VS VCghc2NvcGUuZXhjZXB0aW9uKCkgfHwgdm0uaXNUZXJtaW5hdGlvbkV4Y2VwdGlvbihzY29wZS5l eGNlcHRpb24oKSkpOworICAgICAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCBlbmNvZGVk SlNWYWx1ZSgpKTsKICAgICAgICAgQVNTRVJUKGZpZWxkTmFtZS5pc1N5bWJvbCgpKTsKIAogICAg ICAgICBKU09iamVjdCogYmFzZSA9IGpzQ2FzdDxKU09iamVjdCo+KGJhc2VWYWx1ZS5hc0NlbGwo KSk7Cg==