224587 2021-04-14 16:31:46 -0700 Crash in ReplaceSelectionCommand::mergeEndIfNeeded() 2021-04-15 15:34:42 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 julian_a_gonzalez webkit-unassigned ews-watchlist mifenton rniwa wenson_hsieh oldest_to_newest 1750405 0 julian_a_gonzalez 2021-04-14 16:31:46 -0700 e.g. #0 0x7a80b00f1 in WebCore::Node::parentNode() const+0x21 #1 0x7abb28ecd in WebCore::CompositeEditCommand::insertNodeBefore(WTF::Ref<WebCore::Node, WTF::RawPtrTraits<WebCore::Node> >&&, WebCore::Node&, WebCore::ShouldAssumeContentIsAlwaysEditable)+0xbd #2 0x7abc158cf in WebCore::ReplaceSelectionCommand::mergeEndIfNeeded()+0x36f #3 0x7abc18fb9 in WebCore::ReplaceSelectionCommand::doApply()+0x2f29 #4 0x7abb132d6 in WebCore::CompositeEditCommand::apply()+0x216 #5 0x7abbd77a9 in WebCore::executeInsertFragment(WebCore::Frame&, WTF::Ref<WebCore::DocumentFragment, WTF::RawPtrTraits<WebCore::DocumentFragment> >&&)+0x159 #6 0x7abbd7ac0 in WebCore::executeInsertNode(WebCore::Frame&, WTF::Ref<WebCore::Node, WTF::RawPtrTraits<WebCore::Node> >&&)+0x160 <rdar://problem/75220536> 1750416 1 426062 julian_a_gonzalez 2021-04-14 16:58:03 -0700 Created attachment 426062 Patch 1750449 2 426069 julian_a_gonzalez 2021-04-14 19:27:38 -0700 Created attachment 426069 Patch 1750459 3 426069 rniwa 2021-04-14 20:14:08 -0700 Comment on attachment 426069 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426069&action=review > Source/WebCore/editing/ReplaceSelectionCommand.cpp:984 > + if (startOfInsertedContent.isNull() || endOfInsertedContent.isNull()) Can we add this assertion here? ASSERT(startOfInsertedContent.isNull() == endOfInsertedContent.isNull()); 1750674 4 julian_a_gonzalez 2021-04-15 10:58:23 -0700 (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 426069 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426069&action=review > > > Source/WebCore/editing/ReplaceSelectionCommand.cpp:984 > > + if (startOfInsertedContent.isNull() || endOfInsertedContent.isNull()) > > Can we add this assertion here? > ASSERT(startOfInsertedContent.isNull() == endOfInsertedContent.isNull()); Above the if? (i.e. unconditionally?) 1750771 5 426135 julian_a_gonzalez 2021-04-15 14:06:52 -0700 Created attachment 426135 Patch 1750802 6 ews-feeder 2021-04-15 15:34:40 -0700 Committed r276078 (236591@main): <https://commits.webkit.org/236591@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426135. 426062 2021-04-14 16:58:03 -0700 2021-04-14 19:27:36 -0700 Patch bug-224587-20210414165802.patch text/plain 4412 julian_a_gonzalez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1ODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzEzYzE3ODk0NzVjYjUw NWI5MDEyN2M4Zjk5MDZkYWY4YTZlOGZhZi4uN2MxNDZjNTJjNzc3NWYwMDNiMmRiYzI4NTA0ZTQ2 ZmY0YmRiZjcwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA0LTE0ICBKdWxp YW4gR29uemFsZXogIDxqdWxpYW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jh c2ggaW4gUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQ6Om1lcmdlRW5kSWZOZWVkZWQoKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NTg3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0dXJuIGVhcmx5IGlu IG1lcmdlRW5kSWZOZWVkZWQoKSBpZiBzdGFydE9mUGFyYWdyYXBoVG9Nb3ZlIGlzIG51bGwuCisK KyAgICAgICAgVGVzdDogZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWhvcml6b250YWwtcnVsZS13 aXRoLXN0eWxlLWNyYXNoLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvUmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQ6 Om1lcmdlRW5kSWZOZWVkZWQpOgorCiAyMDIxLTA0LTEyICBBZGEgQ2hhbiAgPGFkYS5jaGFuQGFw cGxlLmNvbT4KIAogICAgICAgICBJbml0aWFsIGltcGxlbWVudGF0aW9uIG9mIFdlYkNocm9tZUNs aWVudDo6ZW51bWVyYXRlSW1tZXJzaXZlWFJEZXZpY2VzKCkgYW5kIFhSRGV2aWNlUHJveHkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQu Y3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAK aW5kZXggNzYyNzYyNTdlY2VkYTQwYmUzODVmN2UzODhmZmIwZWE2NTFlNWYyZC4uOGQ1YjdkZDU0 MGM2NzQ1Yzc1MzMwZmYyMzVhYjU1YmI3YTNmZjQ3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAKQEAgLTk4OSw2ICs5ODksOCBA QCB2b2lkIFJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjptZXJnZUVuZElmTmVlZGVkKCkKICAgICAK ICAgICBWaXNpYmxlUG9zaXRpb24gZGVzdGluYXRpb24gPSBtZXJnZUZvcndhcmQgPyBlbmRPZklu c2VydGVkQ29udGVudC5uZXh0KCkgOiBlbmRPZkluc2VydGVkQ29udGVudDsKICAgICBWaXNpYmxl UG9zaXRpb24gc3RhcnRPZlBhcmFncmFwaFRvTW92ZSA9IG1lcmdlRm9yd2FyZCA/IHN0YXJ0T2ZQ YXJhZ3JhcGgoZW5kT2ZJbnNlcnRlZENvbnRlbnQpIDogZW5kT2ZJbnNlcnRlZENvbnRlbnQubmV4 dCgpOworICAgIGlmIChzdGFydE9mUGFyYWdyYXBoVG9Nb3ZlLmlzTnVsbCgpKQorICAgICAgICBy ZXR1cm47CiAgICAKICAgICAvLyBNZXJnaW5nIGZvcndhcmQgY291bGQgcmVzdWx0IGluIGRlbGV0 aW5nIHRoZSBkZXN0aW5hdGlvbiBhbmNob3Igbm9kZS4KICAgICAvLyBUbyBhdm9pZCB0aGlzLCB3 ZSBhZGQgYSBwbGFjZWhvbGRlciBub2RlIGJlZm9yZSB0aGUgc3RhcnQgb2YgdGhlIHBhcmFncmFw aC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwppbmRleCA1Yjg1YWRiZDVkM2ZiY2E3NTgwZTc1NTU0YThhOTQ1YWFlNThhZTEyLi43NDBm N2QyMmYzMDgxMzQwMTY0MWU1NzdjOWUyY2MzZTEwODVhM2MwIDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMjEtMDQtMTQgIEp1bGlhbiBHb256YWxleiAgPGp1bGlhbl9hX2dvbnphbGV6QGFwcGxl LmNvbT4KKworICAgICAgICBDcmFzaCBpbiBSZXBsYWNlU2VsZWN0aW9uQ29tbWFuZDo6bWVyZ2VF bmRJZk5lZWRlZCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjQ1ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGQgYSB0ZXN0IHRvIGNhdGNoIHRoZSBlZGl0aW5nIGNyYXNoIGZpeGVkIGhlcmU7IHRo YW5rcyB0byBUdW9tYXMgS2Fya2thaW5lbgorICAgICAgICBmb3IgaXRzIGJhc2ljIHN0cnVjdHVy ZSBhbmQgUnlvc3VrZSBOaXdhIGZvciBzb21lIGZpeGVzLgorCisgICAgICAgICogZWRpdGluZy9p bnNlcnRpbmcvaW5zZXJ0LWhvcml6b250YWwtcnVsZS13aXRoLXN0eWxlLWNyYXNoLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWhvcml6b250 YWwtcnVsZS13aXRoLXN0eWxlLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDIxLTA0LTEyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDog JmxheW91dFN0YXRlKCkuZXN0YWJsaXNoZWRGb3JtYXR0aW5nU3RhdGUobGF5b3V0Qm94LmZvcm1h dHRpbmdDb250ZXh0Um9vdCgpKSA9PSB0aGlzIGluIFdlYkNvcmU6OkxheW91dDo6Rm9ybWF0dGlu Z1N0YXRlOjpib3hHZW9tZXRyeQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNl cnRpbmcvaW5zZXJ0LWhvcml6b250YWwtcnVsZS13aXRoLXN0eWxlLWNyYXNoLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jpem9udGFsLXJ1bGUt d2l0aC1zdHlsZS1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uY2Q0N2QzNGU5Y2RhNjBk YzZhZjNkMDgxYWJiYmYzZDRkYjM5MGFmNQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jpem9udGFsLXJ1bGUtd2l0aC1zdHlsZS1jcmFz aC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vz IG5vdCBjcmFzaC4gUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRp bmcvaW5zZXJ0LWhvcml6b250YWwtcnVsZS13aXRoLXN0eWxlLWNyYXNoLmh0bWwgYi9MYXlvdXRU ZXN0cy9lZGl0aW5nL2luc2VydGluZy9pbnNlcnQtaG9yaXpvbnRhbC1ydWxlLXdpdGgtc3R5bGUt Y3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hMmM0ODI4ZDMyMWMwYzA2NGMzYzEzZGZiYzVjMjM5YWM2 OTc0NTBiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcv aW5zZXJ0LWhvcml6b250YWwtcnVsZS13aXRoLXN0eWxlLWNyYXNoLmh0bWwKQEAgLTAsMCArMSwy NCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHN0eWxlPjwvc3R5bGU+Cis8 dGl0bGU+SW5zZXJ0SFJXaXRoU3R5bGU8L3RpdGxlPgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVz dFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKworb25sb2FkID0gKCkgPT4g eworICAgIGRvY3VtZW50LnN0eWxlU2hlZXRzWzBdLmluc2VydFJ1bGUoYDpub3QoOnJlYWQtb25s eSkgeyBkaXNwbGF5OiBpbmxpbmUtdGFibGU7IH1gKTsKKyAgICBkb2N1bWVudC5zdHlsZVNoZWV0 c1swXS5pbnNlcnRSdWxlKGA6bm90KDpob3N0KSB7IGJvcmRlci10b3A6IDFweCBzb2xpZDsgfWAp OworICAgIGRvY3VtZW50LnN0eWxlU2hlZXRzWzBdLmluc2VydFJ1bGUoYDpsYXN0LW9mLXR5cGUg eyBhbGw6IHVuc2V0OyB9YCk7CisgICAgZG9jdW1lbnQucXVlcnlTZWxlY3RvcigndGl0bGUnKS5h cHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKSk7CisgICAgZG9jdW1lbnQu ZXhlY0NvbW1hbmQoJ1NlbGVjdEFsbCcpOworICAgIGRvY3VtZW50LmRlc2lnbk1vZGUgPSAnb24n OworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRIb3Jpem9udGFsUnVsZScpOworICAg IGRvY3VtZW50LmhlYWQucmVwbGFjZUNoaWxkcmVuKCk7CisgICAgZG9jdW1lbnQuYm9keS50ZXh0 Q29udGVudCA9ICdUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGNyYXNoLiBQQVNTJzsK K307Cis8L3NjcmlwdD4KKzxzY3JpcHQ+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8L2h0bWw+ClwgTm8g bmV3bGluZSBhdCBlbmQgb2YgZmlsZQo= 426069 2021-04-14 19:27:38 -0700 2021-04-15 14:06:50 -0700 Patch bug-224587-20210414192737.patch text/plain 4341 julian_a_gonzalez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1ODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzEzYzE3ODk0NzVjYjUw NWI5MDEyN2M4Zjk5MDZkYWY4YTZlOGZhZi4uMmY3ZTFlODNmZTczZmIxMTZkYmRlOGYyNTEwMjQw ZTYzYjZmYzVjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA0LTE0ICBKdWxp YW4gR29uemFsZXogIDxqdWxpYW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jh c2ggaW4gUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQ6Om1lcmdlRW5kSWZOZWVkZWQoKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NTg3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0dXJuIGVhcmx5IGlu IG1lcmdlRW5kSWZOZWVkZWQoKSBpZiBlaXRoZXIgb2Ygb3VyIFZpc2libGVQb3NpdGlvbnMgYXJl IG51bGwuCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWhvcml6b250 YWwtcnVsZS13aXRoLXN0eWxlLWNyYXNoLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvUmVwbGFj ZVNlbGVjdGlvbkNvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQ6Om1lcmdlRW5kSWZOZWVkZWQpOgorCiAyMDIxLTA0LTEyICBBZGEgQ2hhbiAgPGFk YS5jaGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBJbml0aWFsIGltcGxlbWVudGF0aW9uIG9mIFdl YkNocm9tZUNsaWVudDo6ZW51bWVyYXRlSW1tZXJzaXZlWFJEZXZpY2VzKCkgYW5kIFhSRGV2aWNl UHJveHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29t bWFuZC5jcHAKaW5kZXggNzYyNzYyNTdlY2VkYTQwYmUzODVmN2UzODhmZmIwZWE2NTFlNWYyZC4u YzBkNjcyMDVmODlhZmVmMDEyODljOTUxN2MzY2I5ZjJmZmIwN2M0NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAKQEAgLTk4MCw2 ICs5ODAsOSBAQCB2b2lkIFJlcGxhY2VTZWxlY3Rpb25Db21tYW5kOjptZXJnZUVuZElmTmVlZGVk KCkKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgICAgIHJldHVybjsKICAgICB9 CisKKyAgICBpZiAoc3RhcnRPZkluc2VydGVkQ29udGVudC5pc051bGwoKSB8fCBlbmRPZkluc2Vy dGVkQ29udGVudC5pc051bGwoKSkKKyAgICAgICAgcmV0dXJuOwogICAgIAogICAgIC8vIE1lcmdp bmcgdHdvIHBhcmFncmFwaHMgd2lsbCBkZXN0cm95IHRoZSBtb3ZlZCBvbmUncyBibG9jayBzdHls ZXMuICBBbHdheXMgbW92ZSB0aGUgZW5kIG9mIGluc2VydGVkIGZvcndhcmQgCiAgICAgLy8gdG8g cHJlc2VydmUgdGhlIGJsb2NrIHN0eWxlIG9mIHRoZSBwYXJhZ3JhcGggYWxyZWFkeSBpbiB0aGUg ZG9jdW1lbnQsIHVubGVzcyB0aGUgcGFyYWdyYXBoIHRvIG1vdmUgd291bGQgCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWI4 NWFkYmQ1ZDNmYmNhNzU4MGU3NTU1NGE4YTk0NWFhZTU4YWUxMi4uNzQwZjdkMjJmMzA4MTM0MDE2 NDFlNTc3YzllMmNjM2UxMDg1YTNjMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA0LTE0 ICBKdWxpYW4gR29uemFsZXogIDxqdWxpYW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAg ICAgQ3Jhc2ggaW4gUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQ6Om1lcmdlRW5kSWZOZWVkZWQoKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NTg3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVz dCB0byBjYXRjaCB0aGUgZWRpdGluZyBjcmFzaCBmaXhlZCBoZXJlOyB0aGFua3MgdG8gVHVvbWFz IEthcmtrYWluZW4KKyAgICAgICAgZm9yIGl0cyBiYXNpYyBzdHJ1Y3R1cmUgYW5kIFJ5b3N1a2Ug Tml3YSBmb3Igc29tZSBmaXhlcy4KKworICAgICAgICAqIGVkaXRpbmcvaW5zZXJ0aW5nL2luc2Vy dC1ob3Jpem9udGFsLXJ1bGUtd2l0aC1zdHlsZS1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIGVkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jpem9udGFsLXJ1bGUtd2l0aC1z dHlsZS1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAyMS0wNC0xMiAgWmFsYW4gQnVqdGFzICA8emFs YW5AYXBwbGUuY29tPgogCiAgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6ICZsYXlvdXRTdGF0ZSgp LmVzdGFibGlzaGVkRm9ybWF0dGluZ1N0YXRlKGxheW91dEJveC5mb3JtYXR0aW5nQ29udGV4dFJv b3QoKSkgPT0gdGhpcyBpbiBXZWJDb3JlOjpMYXlvdXQ6OkZvcm1hdHRpbmdTdGF0ZTo6Ym94R2Vv bWV0cnkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1o b3Jpem9udGFsLXJ1bGUtd2l0aC1zdHlsZS1jcmFzaC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9lZGl0aW5nL2luc2VydGluZy9pbnNlcnQtaG9yaXpvbnRhbC1ydWxlLXdpdGgtc3R5bGUtY3Jh c2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmNkNDdkMzRlOWNkYTYwZGM2YWYzZDA4MWFiYmJm M2Q0ZGIzOTBhZjUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2Vy dGluZy9pbnNlcnQtaG9yaXpvbnRhbC1ydWxlLXdpdGgtc3R5bGUtY3Jhc2gtZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEgQEAKK1RoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2guIFBB U1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jp em9udGFsLXJ1bGUtd2l0aC1zdHlsZS1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9p bnNlcnRpbmcvaW5zZXJ0LWhvcml6b250YWwtcnVsZS13aXRoLXN0eWxlLWNyYXNoLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uYTJjNDgyOGQzMjFjMGMwNjRjM2MxM2RmYmM1YzIzOWFjNjk3NDUwYgotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jpem9u dGFsLXJ1bGUtd2l0aC1zdHlsZS1jcmFzaC5odG1sCkBAIC0wLDAgKzEsMjQgQEAKKzwhRE9DVFlQ RSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzdHlsZT48L3N0eWxlPgorPHRpdGxlPkluc2VydEhS V2l0aFN0eWxlPC90aXRsZT4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAg dGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisKK29ubG9hZCA9ICgpID0+IHsKKyAgICBkb2N1bWVu dC5zdHlsZVNoZWV0c1swXS5pbnNlcnRSdWxlKGA6bm90KDpyZWFkLW9ubHkpIHsgZGlzcGxheTog aW5saW5lLXRhYmxlOyB9YCk7CisgICAgZG9jdW1lbnQuc3R5bGVTaGVldHNbMF0uaW5zZXJ0UnVs ZShgOm5vdCg6aG9zdCkgeyBib3JkZXItdG9wOiAxcHggc29saWQ7IH1gKTsKKyAgICBkb2N1bWVu dC5zdHlsZVNoZWV0c1swXS5pbnNlcnRSdWxlKGA6bGFzdC1vZi10eXBlIHsgYWxsOiB1bnNldDsg fWApOworICAgIGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ3RpdGxlJykuYXBwZW5kQ2hpbGQoZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2JykpOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCdT ZWxlY3RBbGwnKTsKKyAgICBkb2N1bWVudC5kZXNpZ25Nb2RlID0gJ29uJzsKKyAgICBkb2N1bWVu dC5leGVjQ29tbWFuZCgnSW5zZXJ0SG9yaXpvbnRhbFJ1bGUnKTsKKyAgICBkb2N1bWVudC5oZWFk LnJlcGxhY2VDaGlsZHJlbigpOworICAgIGRvY3VtZW50LmJvZHkudGV4dENvbnRlbnQgPSAnVGhp cyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjcmFzaC4gUEFTUyc7Cit9OworPC9zY3JpcHQ+ Cis8c2NyaXB0Pjwvc2NyaXB0PgorPC9oZWFkPgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5k IG9mIGZpbGUK 426135 2021-04-15 14:06:52 -0700 2021-04-15 15:34:41 -0700 Patch bug-224587-20210415140652.patch text/plain 4421 julian_a_gonzalez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1ODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzEzYzE3ODk0NzVjYjUw NWI5MDEyN2M4Zjk5MDZkYWY4YTZlOGZhZi4uZmZmOWEwZWQ4MzM0NWM4ZmQ3MTNkMDkzOGNhYWNm MjcyOGI3MmUwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA0LTE1ICBKdWxp YW4gR29uemFsZXogIDxqdWxpYW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jh c2ggaW4gUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQ6Om1lcmdlRW5kSWZOZWVkZWQoKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NTg3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0dXJuIGVhcmx5IGlu IG1lcmdlRW5kSWZOZWVkZWQoKSBpZiBlaXRoZXIgb2Ygb3VyIFZpc2libGVQb3NpdGlvbnMgYXJl IG51bGwuCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWhvcml6b250 YWwtcnVsZS13aXRoLXN0eWxlLWNyYXNoLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvUmVwbGFj ZVNlbGVjdGlvbkNvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQ6Om1lcmdlRW5kSWZOZWVkZWQpOgorCiAyMDIxLTA0LTEyICBBZGEgQ2hhbiAgPGFk YS5jaGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBJbml0aWFsIGltcGxlbWVudGF0aW9uIG9mIFdl YkNocm9tZUNsaWVudDo6ZW51bWVyYXRlSW1tZXJzaXZlWFJEZXZpY2VzKCkgYW5kIFhSRGV2aWNl UHJveHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvUmVwbGFjZVNlbGVjdGlv bkNvbW1hbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29t bWFuZC5jcHAKaW5kZXggNzYyNzYyNTdlY2VkYTQwYmUzODVmN2UzODhmZmIwZWE2NTFlNWYyZC4u ZmUzZmM2YTU5MTE2MDIxMWJlMGQ4ZjhiMjNiMjNjYjBlMjI3MWIzNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9SZXBsYWNlU2VsZWN0aW9uQ29tbWFuZC5jcHAKQEAgLTk4MCw2 ICs5ODAsMTAgQEAgdm9pZCBSZXBsYWNlU2VsZWN0aW9uQ29tbWFuZDo6bWVyZ2VFbmRJZk5lZWRl ZCgpCiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICByZXR1cm47CiAgICAg fQorCisgICAgQVNTRVJUKHN0YXJ0T2ZJbnNlcnRlZENvbnRlbnQuaXNOdWxsKCkgPT0gZW5kT2ZJ bnNlcnRlZENvbnRlbnQuaXNOdWxsKCkpOworICAgIGlmIChzdGFydE9mSW5zZXJ0ZWRDb250ZW50 LmlzTnVsbCgpIHx8IGVuZE9mSW5zZXJ0ZWRDb250ZW50LmlzTnVsbCgpKQorICAgICAgICByZXR1 cm47CiAgICAgCiAgICAgLy8gTWVyZ2luZyB0d28gcGFyYWdyYXBocyB3aWxsIGRlc3Ryb3kgdGhl IG1vdmVkIG9uZSdzIGJsb2NrIHN0eWxlcy4gIEFsd2F5cyBtb3ZlIHRoZSBlbmQgb2YgaW5zZXJ0 ZWQgZm9yd2FyZCAKICAgICAvLyB0byBwcmVzZXJ2ZSB0aGUgYmxvY2sgc3R5bGUgb2YgdGhlIHBh cmFncmFwaCBhbHJlYWR5IGluIHRoZSBkb2N1bWVudCwgdW5sZXNzIHRoZSBwYXJhZ3JhcGggdG8g bW92ZSB3b3VsZCAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCA1Yjg1YWRiZDVkM2ZiY2E3NTgwZTc1NTU0YThhOTQ1YWFlNThh ZTEyLi5kYzNhNjkxMjkwZTk3ZjM3ZjNmYzE3NTI3MmQ3ZmU5NzVmYjdiNWU1IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMjEtMDQtMTUgIEp1bGlhbiBHb256YWxleiAgPGp1bGlhbl9hX2dvbnph bGV6QGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBSZXBsYWNlU2VsZWN0aW9uQ29tbWFu ZDo6bWVyZ2VFbmRJZk5lZWRlZCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjQ1ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgYSB0ZXN0IHRvIGNhdGNoIHRoZSBlZGl0aW5nIGNyYXNoIGZpeGVk IGhlcmU7IHRoYW5rcyB0byBUdW9tYXMgS2Fya2thaW5lbgorICAgICAgICBmb3IgaXRzIGJhc2lj IHN0cnVjdHVyZSBhbmQgUnlvc3VrZSBOaXdhIGZvciBzb21lIGZpeGVzLgorCisgICAgICAgICog ZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LWhvcml6b250YWwtcnVsZS13aXRoLXN0eWxlLWNyYXNo LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0 LWhvcml6b250YWwtcnVsZS13aXRoLXN0eWxlLWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDIxLTA0 LTEyICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9O IEZBSUxFRDogJmxheW91dFN0YXRlKCkuZXN0YWJsaXNoZWRGb3JtYXR0aW5nU3RhdGUobGF5b3V0 Qm94LmZvcm1hdHRpbmdDb250ZXh0Um9vdCgpKSA9PSB0aGlzIGluIFdlYkNvcmU6OkxheW91dDo6 Rm9ybWF0dGluZ1N0YXRlOjpib3hHZW9tZXRyeQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRp dGluZy9pbnNlcnRpbmcvaW5zZXJ0LWhvcml6b250YWwtcnVsZS13aXRoLXN0eWxlLWNyYXNoLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jpem9u dGFsLXJ1bGUtd2l0aC1zdHlsZS1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uY2Q0N2Qz NGU5Y2RhNjBkYzZhZjNkMDgxYWJiYmYzZDRkYjM5MGFmNQotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1ob3Jpem9udGFsLXJ1bGUtd2l0aC1z dHlsZS1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorVGhpcyB0ZXN0IHBhc3NlcyBp ZiBpdCBkb2VzIG5vdCBjcmFzaC4gUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGlu Zy9pbnNlcnRpbmcvaW5zZXJ0LWhvcml6b250YWwtcnVsZS13aXRoLXN0eWxlLWNyYXNoLmh0bWwg Yi9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9pbnNlcnQtaG9yaXpvbnRhbC1ydWxlLXdp dGgtc3R5bGUtY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hMmM0ODI4ZDMyMWMwYzA2NGMzYzEzZGZi YzVjMjM5YWM2OTc0NTBiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9p bnNlcnRpbmcvaW5zZXJ0LWhvcml6b250YWwtcnVsZS13aXRoLXN0eWxlLWNyYXNoLmh0bWwKQEAg LTAsMCArMSwyNCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHN0eWxlPjwv c3R5bGU+Cis8dGl0bGU+SW5zZXJ0SFJXaXRoU3R5bGU8L3RpdGxlPgorPHNjcmlwdD4KK2lmICh3 aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKworb25sb2Fk ID0gKCkgPT4geworICAgIGRvY3VtZW50LnN0eWxlU2hlZXRzWzBdLmluc2VydFJ1bGUoYDpub3Qo OnJlYWQtb25seSkgeyBkaXNwbGF5OiBpbmxpbmUtdGFibGU7IH1gKTsKKyAgICBkb2N1bWVudC5z dHlsZVNoZWV0c1swXS5pbnNlcnRSdWxlKGA6bm90KDpob3N0KSB7IGJvcmRlci10b3A6IDFweCBz b2xpZDsgfWApOworICAgIGRvY3VtZW50LnN0eWxlU2hlZXRzWzBdLmluc2VydFJ1bGUoYDpsYXN0 LW9mLXR5cGUgeyBhbGw6IHVuc2V0OyB9YCk7CisgICAgZG9jdW1lbnQucXVlcnlTZWxlY3Rvcign dGl0bGUnKS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKSk7CisgICAg ZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ1NlbGVjdEFsbCcpOworICAgIGRvY3VtZW50LmRlc2lnbk1v ZGUgPSAnb24nOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRIb3Jpem9udGFsUnVs ZScpOworICAgIGRvY3VtZW50LmhlYWQucmVwbGFjZUNoaWxkcmVuKCk7CisgICAgZG9jdW1lbnQu Ym9keS50ZXh0Q29udGVudCA9ICdUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IGNyYXNo LiBQQVNTJzsKK307Cis8L3NjcmlwdD4KKzxzY3JpcHQ+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8L2h0 bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=