<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>224583</bug_id>
          
          <creation_ts>2021-04-14 16:19:38 -0700</creation_ts>
          <short_desc>Fix WK_EXPORT macro for declspec compilers</short_desc>
          <delta_ts>2021-04-14 19:43:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Basuke Suzuki">basuke</reporter>
          <assigned_to name="Basuke Suzuki">basuke</assigned_to>
          <cc>basuke</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>stephan.szabo</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1750395</commentid>
    <comment_count>0</comment_count>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2021-04-14 16:19:38 -0700</bug_when>
    <thetext>There&apos;re lots of warnings while building WebKit on those which uses declspec.

&gt; WebKit/Headers\WebKit/WKDeclarationSpecifiers.h:38:5: warning: &apos;BUILDING_WebKit&apos; is not defined, evaluates to 0 [-Wundef]
&gt; #if BUILDING_WebKit
&gt;     ^
&gt; 1 warning generated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1750430</commentid>
    <comment_count>1</comment_count>
      <attachid>426064</attachid>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2021-04-14 17:43:21 -0700</bug_when>
    <thetext>Created attachment 426064
PATCH</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1750451</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-04-14 19:42:17 -0700</bug_when>
    <thetext>Committed r275992 (236544@main): &lt;https://commits.webkit.org/236544@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 426064.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1750453</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-04-14 19:43:20 -0700</bug_when>
    <thetext>&lt;rdar://problem/76680054&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>426064</attachid>
            <date>2021-04-14 17:43:21 -0700</date>
            <delta_ts>2021-04-14 19:42:17 -0700</delta_ts>
            <desc>PATCH</desc>
            <filename>bug-224583</filename>
            <type>text/plain</type>
            <size>1564</size>
            <attacher name="Basuke Suzuki">basuke</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu
Z2VMb2cKaW5kZXggZDFkYTNiZTNmY2Y3Li5mOGRhYjdmZjFhYzEgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg
KzEsMTUgQEAKKzIwMjEtMDQtMTQgIEJhc3VrZSBTdXp1a2kgIDxiYXN1a2Uuc3V6dWtpQHNvbnku
Y29tPgorCisgICAgICAgIEZpeCBXS19FWFBPUlQgbWFjcm8gZm9yIGRlY2xzcGVjIGNvbXBpbGVy
cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NTgz
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgZGlz
cGxheXMgd2FybmluZ3Mgd2hlbiBtYWNybyBpcyBub3QgZGVmaW5lZC4gQWN0dWFsbHkgaXQgaXMg
ZGVmaW5lZCBvbmx5IHdoZW4KKyAgICAgICAgaXQgYnVpbGRzIFdlYktpdC4gSXQgc2hvdWxkIGJl
IGRlZmluZWQoQlVJTERJTkdfV2ViS2l0KS4KKworICAgICAgICAqIFNoYXJlZC9BUEkvYy9XS0Rl
Y2xhcmF0aW9uU3BlY2lmaWVycy5oOgorCiAyMDIxLTA0LTEyICBDaHJpcyBEdW1leiAgPGNkdW1l
ekBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBzdXJlIEF1eGlsaWFyeVByb2Nlc3NQcm94eTo6
c2VuZE1lc3NhZ2UoKSBpcyBjYWxsZWQgb24gdGhlIG1haW4gdGhyZWFkCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViS2l0L1NoYXJlZC9BUEkvYy9XS0RlY2xhcmF0aW9uU3BlY2lmaWVycy5oIGIvU291
cmNlL1dlYktpdC9TaGFyZWQvQVBJL2MvV0tEZWNsYXJhdGlvblNwZWNpZmllcnMuaAppbmRleCBk
NWUzMTk4ODU3ZTIuLjczNmNiN2FlMjM3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFy
ZWQvQVBJL2MvV0tEZWNsYXJhdGlvblNwZWNpZmllcnMuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1No
YXJlZC9BUEkvYy9XS0RlY2xhcmF0aW9uU3BlY2lmaWVycy5oCkBAIC0zNSwxMSArMzUsMTEgQEAK
ICNpZiBkZWZpbmVkKFdLX05PX0VYUE9SVCkKICNkZWZpbmUgV0tfRVhQT1JUCiAjZWxpZiBkZWZp
bmVkKFdJTjMyKSB8fCBkZWZpbmVkKF9XSU4zMikgfHwgZGVmaW5lZChfX0NDX0FSTSkgfHwgZGVm
aW5lZChfX0FSTUNDX18pIHx8IChfX2hhc19kZWNsc3BlY19hdHRyaWJ1dGUoZGxsaW1wb3J0KSAm
JiBfX2hhc19kZWNsc3BlY19hdHRyaWJ1dGUoZGxsZXhwb3J0KSkKLSNpZiBCVUlMRElOR19XZWJL
aXQKKyNpZiBkZWZpbmVkKEJVSUxESU5HX1dlYktpdCkKICNkZWZpbmUgV0tfRVhQT1JUIF9fZGVj
bHNwZWMoZGxsZXhwb3J0KQogI2Vsc2UKICNkZWZpbmUgV0tfRVhQT1JUIF9fZGVjbHNwZWMoZGxs
aW1wb3J0KQotI2VuZGlmIC8qIEJVSUxESU5HX1dlYktpdCAqLworI2VuZGlmIC8qIGRlZmluZWQo
QlVJTERJTkdfV2ViS2l0KSAqLwogI2VsaWYgZGVmaW5lZChfX0dOVUNfXykKICNkZWZpbmUgV0tf
RVhQT1JUIF9fYXR0cmlidXRlX18oKHZpc2liaWxpdHkoImRlZmF1bHQiKSkpCiAjZWxzZSAvKiAh
ZGVmaW5lZChXS19OT19FWFBPUlQpICovCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>