224580 2021-04-14 15:35:28 -0700 Allow fast-cq as a prefix for patch name for fast-cq mode on commit-queue 2021-04-16 05:33:12 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=223954 InRadar P2 Normal --- 1 aakash_jain aakash_jain jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1750381 0 aakash_jain 2021-04-14 15:35:28 -0700 Currently the patch name prefix for enabling fast cq mode on commit queue is: '[fast-cq]' (added in https://commits.webkit.org/r275282). However, some users might not remember the exact keyword and use just fast-cq instead. We should allow that variation as well to make it easy for the users. i.e: patch name beginning with fast-cq prefix (e.g.: fast-cq-patch) should also trigger fast-cq mode on Commit Queue. 1750382 1 426054 aakash_jain 2021-04-14 15:37:45 -0700 Created attachment 426054 [fast-cq] Patch 1750598 2 ews-feeder 2021-04-15 06:42:04 -0700 Committed r276020 (236572@main): <https://commits.webkit.org/236572@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426054. 1750599 3 webkit-bug-importer 2021-04-15 06:43:18 -0700 <rdar://problem/76700662> 1751030 4 aakash_jain 2021-04-16 05:33:12 -0700 Restarted EWS to pick up this change. 426054 2021-04-14 15:37:45 -0700 2021-04-15 06:42:05 -0700 [fast-cq] Patch bug-224580-20210414183744.patch text/plain 4082 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3NTk3NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTA0LTE0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBBbGxvdyBmYXN0LWNxIGFzIGEgcHJlZml4IGZvciBwYXRjaCBuYW1lIGZv ciBmYXN0LWNxIG1vZGUgb24gY29tbWl0LXF1ZXVlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ1ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIENJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6Cisg ICAgICAgIChCdWd6aWxsYU1peGluKToKKyAgICAgICAgKEJ1Z3ppbGxhTWl4aW4uX2lzX3BhdGNo X29ic29sZXRlKToKKyAgICAgICAgKiBDSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0 LnB5OiBVcGRhdGVkIHVuaXQtdGVzdC4KKwogMjAyMS0wNC0xNCAgWW91ZW5uIEZhYmxldCAgPHlv dWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIFdLUGFnZVNldCBpbXBsZW1lbnRhdGlv biBhY2NvcmRpbmcgbmV3IE1lZGlhUHJvZHVjZXI6Ok11dGVkU3RhdGUgdmFsdWVzCkluZGV4OiBU b29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJ U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJldmlzaW9uIDI3NTk3NikKKysrIFRvb2xzL0NJ U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTUyOCw5ICs1Mjgs NyBAQCBjbGFzcyBCdWd6aWxsYU1peGluKG9iamVjdCk6CiAgICAgYWRkVVJMcyA9IEZhbHNlCiAg ICAgYnVnX29wZW5fc3RhdHVzZXMgPSBbJ1VOQ09ORklSTUVEJywgJ05FVycsICdBU1NJR05FRCcs ICdSRU9QRU5FRCddCiAgICAgYnVnX2Nsb3NlZF9zdGF0dXNlcyA9IFsnUkVTT0xWRUQnLCAnVkVS SUZJRUQnLCAnQ0xPU0VEJ10KLSAgICByZXZlcnRfcHJlYW1ibGUgPSAncmV2ZXJ0IG9mIHInCi0g ICAgZmFzdF9jcV9wcmVhbWJsZSA9ICdbZmFzdC1jcV0nCi0KKyAgICBmYXN0X2NxX3ByZWFtYmxl cyA9ICgncmV2ZXJ0IG9mIHInLCAnZmFzdC1jcScsICdbZmFzdC1jcV0nKQogICAgIEBkZWZlci5p bmxpbmVDYWxsYmFja3MKICAgICBkZWYgX2FkZFRvTG9nKHNlbGYsIGxvZ05hbWUsIG1lc3NhZ2Up OgogICAgICAgICB0cnk6CkBAIC02MTUsNyArNjEzLDcgQEAgY2xhc3MgQnVnemlsbGFNaXhpbihv YmplY3QpOgogICAgICAgICBwYXRjaF9hdXRob3IgPSBwYXRjaF9qc29uLmdldCgnY3JlYXRvcicp CiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3BhdGNoX2F1dGhvcicsIHBhdGNoX2F1dGhvcikK ICAgICAgICAgcGF0Y2hfdGl0bGUgPSBwYXRjaF9qc29uLmdldCgnc3VtbWFyeScpCi0gICAgICAg IGlmIHBhdGNoX3RpdGxlLmxvd2VyKCkuc3RhcnRzd2l0aCgoc2VsZi5yZXZlcnRfcHJlYW1ibGUs IHNlbGYuZmFzdF9jcV9wcmVhbWJsZSkpOgorICAgICAgICBpZiBwYXRjaF90aXRsZS5sb3dlcigp LnN0YXJ0c3dpdGgoc2VsZi5mYXN0X2NxX3ByZWFtYmxlcyk6CiAgICAgICAgICAgICBzZWxmLnNl dFByb3BlcnR5KCdmYXN0X2NvbW1pdF9xdWV1ZScsIFRydWUpCiAgICAgICAgIGlmIHNlbGYuYWRk VVJMczoKICAgICAgICAgICAgIHNlbGYuYWRkVVJMKCdQYXRjaCBieToge30nLmZvcm1hdChwYXRj aF9hdXRob3IpLCAnJykKSW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5p dHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191 bml0dGVzdC5weQkocmV2aXNpb24gMjc1OTc2KQorKysgVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWls ZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNDEwMCwyMiArNDEwMCwxNSBA QCBjbGFzcyBUZXN0VmFsaWRhdGVQYXRjaChCdWlsZFN0ZXBNaXhpbkFkCiAgICAgICAgIHNlbGYu YXNzZXJ0RXF1YWwoc2VsZi5nZXRQcm9wZXJ0eSgnZmFzdF9jb21taXRfcXVldWUnKSwgTm9uZSwg J2Zhc3RfY29tbWl0X3F1ZXVlIGlzIHVuZXhwZWN0ZWRseSBzZXQnKQogICAgICAgICByZXR1cm4g cmMKIAotICAgIGRlZiB0ZXN0X3JldmVydF9wYXRjaF90cmlnZ2VyX2Zhc3RfY3FfbW9kZShzZWxm KToKLSAgICAgICAgc2VsZi5zZXR1cFN0ZXAoVmFsaWRhdGVQYXRjaCh2ZXJpZnlCdWdDbG9zZWQ9 RmFsc2UpKQotICAgICAgICBWYWxpZGF0ZVBhdGNoLmdldF9wYXRjaF9qc29uID0gbGFtYmRhIHgs IHBhdGNoX2lkOiBzZWxmLmdldF9wYXRjaCh0aXRsZT0nUkVWRVJUIE9GIHIxMjM0NTYnKQotICAg ICAgICBzZWxmLnNldFByb3BlcnR5KCdwYXRjaF9pZCcsICc0MjU4MDYnKQotICAgICAgICBzZWxm LmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0nVmFsaWRhdGVkIHBh dGNoJykKLSAgICAgICAgcmMgPSBzZWxmLnJ1blN0ZXAoKQotICAgICAgICBzZWxmLmFzc2VydEVx dWFsKHNlbGYuZ2V0UHJvcGVydHkoJ2Zhc3RfY29tbWl0X3F1ZXVlJyksIFRydWUsICdmYXN0X2Nv bW1pdF9xdWV1ZSBpcyBub3Qgc2V0JykKLSAgICAgICAgcmV0dXJuIHJjCi0KLSAgICBkZWYgdGVz dF9mYXN0X2NxX3BhdGNoX3RyaWdnZXJfZmFzdF9jcV9tb2RlKHNlbGYpOgotICAgICAgICBzZWxm LnNldHVwU3RlcChWYWxpZGF0ZVBhdGNoKHZlcmlmeUJ1Z0Nsb3NlZD1GYWxzZSkpCi0gICAgICAg IFZhbGlkYXRlUGF0Y2guZ2V0X3BhdGNoX2pzb24gPSBsYW1iZGEgeCwgcGF0Y2hfaWQ6IHNlbGYu Z2V0X3BhdGNoKHRpdGxlPSdbZmFzdC1jcV0gUGF0Y2gnKQotICAgICAgICBzZWxmLnNldFByb3Bl cnR5KCdwYXRjaF9pZCcsICc0MjU4MDYnKQotICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVz dWx0PVNVQ0NFU1MsIHN0YXRlX3N0cmluZz0nVmFsaWRhdGVkIHBhdGNoJykKLSAgICAgICAgcmMg PSBzZWxmLnJ1blN0ZXAoKQotICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHNlbGYuZ2V0UHJvcGVy dHkoJ2Zhc3RfY29tbWl0X3F1ZXVlJyksIFRydWUsICdmYXN0X2NvbW1pdF9xdWV1ZSBpcyBub3Qg c2V0JykKKyAgICBkZWYgdGVzdF9mYXN0X2NxX3BhdGNoZXNfdHJpZ2dlcl9mYXN0X2NxX21vZGUo c2VsZik6CisgICAgICAgIGZhc3RfY3FfcGF0Y2hfdGl0bGVzID0gKCdSRVZFUlQgT0YgcjEyMzQn LCAncmV2ZXJ0IG9mIHIxMjM0JywgJ1tmYXN0LWNxXVBhdGNoJywgJ1tGQVNULWNxXSBwYXRjaCcs ICdmYXN0LWNxLXBhdGNoJywgJ0ZBU1QtQ1EgUGF0Y2gnKQorICAgICAgICBmb3IgZmFzdF9jcV9w YXRjaF90aXRsZSBpbiBmYXN0X2NxX3BhdGNoX3RpdGxlczoKKyAgICAgICAgICAgIHNlbGYuc2V0 dXBTdGVwKFZhbGlkYXRlUGF0Y2godmVyaWZ5QnVnQ2xvc2VkPUZhbHNlKSkKKyAgICAgICAgICAg IFZhbGlkYXRlUGF0Y2guZ2V0X3BhdGNoX2pzb24gPSBsYW1iZGEgeCwgcGF0Y2hfaWQ6IHNlbGYu Z2V0X3BhdGNoKHRpdGxlPWZhc3RfY3FfcGF0Y2hfdGl0bGUpCisgICAgICAgICAgICBzZWxmLnNl dFByb3BlcnR5KCdwYXRjaF9pZCcsICc0MjU4MDYnKQorICAgICAgICAgICAgc2VsZi5leHBlY3RP dXRjb21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J1ZhbGlkYXRlZCBwYXRjaCcpCisg ICAgICAgICAgICByYyA9IHNlbGYucnVuU3RlcCgpCisgICAgICAgICAgICBzZWxmLmFzc2VydEVx dWFsKHNlbGYuZ2V0UHJvcGVydHkoJ2Zhc3RfY29tbWl0X3F1ZXVlJyksIFRydWUsICdmYXN0X2Nv bW1pdF9xdWV1ZSBpcyBub3Qgc2V0LCBwYXRjaCB0aXRsZToge30nLmZvcm1hdChmYXN0X2NxX3Bh dGNoX3RpdGxlKSkKICAgICAgICAgcmV0dXJuIHJjCiAKIAo=