224572 2021-04-14 12:44:16 -0700 Apply DeferTermination in some utility functions in the jsc shell. 2021-04-20 01:22:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1750293 0 mark.lam 2021-04-14 12:44:16 -0700 This is to make sure that these functions don't get in the way of testing with the watchdog. Since these are only test utility functions, just doing the simple thing of using a DeferTermination scope is the right thing to do here. 1750294 1 mark.lam 2021-04-14 12:44:43 -0700 rdar://76646089 1750320 2 426042 mark.lam 2021-04-14 13:47:59 -0700 Created attachment 426042 proposed patch. 1750321 3 426042 ysuzuki 2021-04-14 13:50:15 -0700 Comment on attachment 426042 proposed patch. r=me 1750323 4 426042 mark.lam 2021-04-14 13:52:19 -0700 Comment on attachment 426042 proposed patch. Thanks for the review. 1750356 5 mark.lam 2021-04-14 14:52:50 -0700 Closed the wrong bug: too many browser tabs going at the same time. Sorry. 1750360 6 mark.lam 2021-04-14 14:58:20 -0700 I added the comment in the description above in the ChangeLog before landing. Landed in r275971: <http://trac.webkit.org/r275971>. 426042 2021-04-14 13:47:59 -0700 2021-04-15 02:32:20 -0700 proposed patch. bug-224572.patch text/plain 1864 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc1OTU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDIxLTA0LTE0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB cHBseSBEZWZlclRlcm1pbmF0aW9uIGluIHNvbWUgdXRpbGl0eSBmdW5jdGlvbnMgaW4gdGhlIGpz YyBzaGVsbC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyNDU3MgorICAgICAgICByZGFyOi8vNzY2NDYwODkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGpzYy5jcHA6CisKIDIwMjEtMDQtMTMgIE1hcmsg TGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFRoZSB3YXRjaGRvZyBzaG91bGQg bm90IGZpcmUgd2hlbiBpdCdzIG5vdCBhY3RpdmUuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvanNjLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvanNjLmNwcAko cmV2aXNpb24gMjc1OTQ4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pzYy5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTMxLDYgKzMxLDcgQEAKICNpbmNsdWRlICJDb21waWxlclRpbWluZ1Njb3Bl LmgiCiAjaW5jbHVkZSAiQ29tcGxldGlvbi5oIgogI2luY2x1ZGUgIkNvbmZpZ0ZpbGUuaCIKKyNp bmNsdWRlICJEZWZlclRlcm1pbmF0aW9uLmgiCiAjaW5jbHVkZSAiRGVmZXJyZWRXb3JrVGltZXIu aCIKICNpbmNsdWRlICJEaXNhc3NlbWJsZXIuaCIKICNpbmNsdWRlICJFeGNlcHRpb24uaCIKQEAg LTI1MjIsNiArMjUyMyw3IEBAIEpTQ19ERUZJTkVfSE9TVF9GVU5DVElPTihmdW5jdGlvbkdlbmVy YXQKIHsKICAgICBWTSYgdm0gPSBnbG9iYWxPYmplY3QtPnZtKCk7CiAgICAgSlNMb2NrSG9sZGVy IGxvY2sodm0pOworICAgIERlZmVyVGVybWluYXRpb24gZGVmZXJTY29wZSh2bSk7CiAgICAgYXV0 byBzY29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUodm0pOwogCiAgICAgSGVhcFNuYXBzaG90QnVp bGRlciBzbmFwc2hvdEJ1aWxkZXIodm0uZW5zdXJlSGVhcFByb2ZpbGVyKCkpOwpAQCAtMjUzNyw2 ICsyNTM5LDcgQEAgSlNDX0RFRklORV9IT1NUX0ZVTkNUSU9OKGZ1bmN0aW9uR2VuZXJhdAogewog ICAgIFZNJiB2bSA9IGdsb2JhbE9iamVjdC0+dm0oKTsKICAgICBKU0xvY2tIb2xkZXIgbG9jayh2 bSk7CisgICAgRGVmZXJUZXJtaW5hdGlvbiBkZWZlclNjb3BlKHZtKTsKICAgICBhdXRvIHNjb3Bl ID0gREVDTEFSRV9USFJPV19TQ09QRSh2bSk7CiAgICAgU3RyaW5nIGpzb25TdHJpbmc7CiAgICAg ewpAQCAtMjU4MCw2ICsyNTgzLDcgQEAgSlNDX0RFRklORV9IT1NUX0ZVTkNUSU9OKGZ1bmN0aW9u U3RhcnRTYQogSlNDX0RFRklORV9IT1NUX0ZVTkNUSU9OKGZ1bmN0aW9uU2FtcGxpbmdQcm9maWxl clN0YWNrVHJhY2VzLCAoSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgQ2FsbEZyYW1lKikp CiB7CiAgICAgVk0mIHZtID0gZ2xvYmFsT2JqZWN0LT52bSgpOworICAgIERlZmVyVGVybWluYXRp b24gZGVmZXJTY29wZSh2bSk7CiAgICAgYXV0byBzY29wZSA9IERFQ0xBUkVfVEhST1dfU0NPUEUo dm0pOwogCiAgICAgaWYgKCF2bS5zYW1wbGluZ1Byb2ZpbGVyKCkpCg==