224567 2021-04-14 11:42:15 -0700 REGRESSION(r275948) Wrap sh::ShaderVariable into UniqueRef to fit in HashMap 2021-04-14 15:19:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224381 InRadar P2 Normal --- 1 lmoura lmoura achristensen bugs-noreply dino ews-watchlist graouts kondapallykalyan webkit-bug-importer ysuzuki oldest_to_newest 1750253 0 lmoura 2021-04-14 11:42:15 -0700 REGRESSION(r275948) Wrap sh::ShaderVariable into UniqueRef to fit in HashMap 1750256 1 426025 lmoura 2021-04-14 11:43:07 -0700 Created attachment 426025 [fast-cq] Patch for landing 1750257 2 426025 lmoura 2021-04-14 11:48:10 -0700 Comment on attachment 426025 [fast-cq] Patch for landing Missing cq+ 1750282 3 achristensen 2021-04-14 12:32:10 -0700 Great! Thanks! 1750305 4 ysuzuki 2021-04-14 13:09:39 -0700 NICE 1750372 5 ews-feeder 2021-04-14 15:18:15 -0700 Committed r275976 (236529@main): <https://commits.webkit.org/236529@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426025. 1750374 6 webkit-bug-importer 2021-04-14 15:19:15 -0700 <rdar://problem/76668274> 426025 2021-04-14 11:43:07 -0700 2021-04-14 15:18:16 -0700 [fast-cq] Patch for landing bug-224567-20210414154306.patch text/plain 5985 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1OTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ZjODlmMDgxMjgwMTc0 ODAxNzdlNDc0Zjk0OGVjNWMwOWFjMzQ3Yy4uYWYxOTE1ZDkyM2IwOTk4MDFkMzhhZDVlMmZhN2Nh NTg3NzQ0NzVkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA0LTE0ICBMYXVy byBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI3NTk0 OCkgV3JhcCBzaDo6U2hhZGVyVmFyaWFibGUgaW50byBVbmlxdWVSZWYgdG8gZml0IGluIEhhc2hN YXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDU2 NworCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnNHTE9wZW5HTENvbW1vbi5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpFeHRlbnNpb25zR0xPcGVuR0xDb21tb246OmdldFRyYW5zbGF0ZWRTaGFkZXJTb3Vy Y2VBTkdMRSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29u dGV4dEdMT3BlbkdMLmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBo aWNzQ29udGV4dEdMT3BlbkdMQ29tbW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNz Q29udGV4dEdMT3BlbkdMOjpwcmVjaXNpb25zTWF0Y2ggY29uc3QpOgorICAgICAgICAoV2ViQ29y ZTo6R3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6Om1hcHBlZFN5bWJvbEluU2hhZGVyU291cmNlTWFw KToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dEdMT3BlbkdMOjpvcmlnaW5hbFN5 bWJvbEluU2hhZGVyU291cmNlTWFwKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4 dEdMT3BlbkdMOjptYXBwZWRTeW1ib2xOYW1lKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNz Q29udGV4dEdMT3BlbkdMOjpzaGFkZXJTb3VyY2UpOgorCiAyMDIxLTA0LTE0ICBFcmljIENhcmxz b24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IHRleHQgdHJhY2tz IHRvIHB1cmdlIGN1ZXMgb3V0c2lkZSBvZiB0aGUgYnVmZmVyZWQgcmFuZ2UKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9FeHRlbnNpb25zR0xPcGVu R0xDb21tb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4 dGVuc2lvbnNHTE9wZW5HTENvbW1vbi5jcHAKaW5kZXggMDlkYjg1NDAwMjIxZGY5NzU3ODg4NTlh NGEyODdhYmFhMjRmODI3MS4uNzFmMTJiOTNkZmEwYzZkYzk1YWQ1M2M4YzZiMDJkNDJiYWY3YzA1 YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0V4 dGVuc2lvbnNHTE9wZW5HTENvbW1vbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvb3BlbmdsL0V4dGVuc2lvbnNHTE9wZW5HTENvbW1vbi5jcHAKQEAgLTIwMyw3ICsy MDMsNyBAQCBTdHJpbmcgRXh0ZW5zaW9uc0dMT3BlbkdMQ29tbW9uOjpnZXRUcmFuc2xhdGVkU2hh ZGVyU291cmNlQU5HTEUoUGxhdGZvcm1HTE9iamVjdAogCiAgICAgZm9yIChjb25zdCBzdGQ6OnBh aXI8QU5HTEVTaGFkZXJTeW1ib2xUeXBlLCBzaDo6U2hhZGVyVmFyaWFibGU+JiBwYWlyIDogc3lt Ym9scykgewogICAgICAgICBjb25zdCBzdGQ6OnN0cmluZyYgbmFtZSA9IHBhaXIuc2Vjb25kLm5h bWU7Ci0gICAgICAgIGVudHJ5LnN5bWJvbE1hcChwYWlyLmZpcnN0KS5zZXQoU3RyaW5nKG5hbWUu Y19zdHIoKSwgbmFtZS5sZW5ndGgoKSksIHBhaXIuc2Vjb25kKTsKKyAgICAgICAgZW50cnkuc3lt Ym9sTWFwKHBhaXIuZmlyc3QpLnNldChTdHJpbmcobmFtZS5jX3N0cigpLCBuYW1lLmxlbmd0aCgp KSwgV1RGOjptYWtlVW5pcXVlUmVmV2l0aG91dEZhc3RNYWxsb2NDaGVjazxzaDo6U2hhZGVyVmFy aWFibGU+KHBhaXIuc2Vjb25kKSk7CiAgICAgfQogCiAgICAgaWYgKCFpc1ZhbGlkKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29u dGV4dEdMT3BlbkdMLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wv R3JhcGhpY3NDb250ZXh0R0xPcGVuR0wuaAppbmRleCAxZTA0NDQ5ZWQzZDc3ZjQ0ZDg1OGFmZWVj MjhjZTlkNzE0MzYxYzliLi43MGQzYTJjYWFmNWZmMjI5ZTgyZWU1OTU3OWQ0MDA3MTVhOTZmNmY4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3Jh cGhpY3NDb250ZXh0R0xPcGVuR0wuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0R0xPcGVuR0wuaApAQCAtNTgxLDcgKzU4MSw3IEBA IHByaXZhdGU6CiAjZW5kaWYKIAogI2lmICFVU0UoQU5HTEUpCi0gICAgdHlwZWRlZiBIYXNoTWFw PFN0cmluZywgc2g6OlNoYWRlclZhcmlhYmxlPiBTaGFkZXJTeW1ib2xNYXA7CisgICAgdHlwZWRl ZiBIYXNoTWFwPFN0cmluZywgVW5pcXVlUmVmPHNoOjpTaGFkZXJWYXJpYWJsZT4+IFNoYWRlclN5 bWJvbE1hcDsKIAogICAgIHN0cnVjdCBTaGFkZXJTb3VyY2VFbnRyeSB7CiAgICAgICAgIEdDR0xl bnVtIHR5cGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9v cGVuZ2wvR3JhcGhpY3NDb250ZXh0R0xPcGVuR0xDb21tb24uY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dEdMT3BlbkdMQ29tbW9uLmNw cAppbmRleCBhNzZhYzhiNTc0NzcwMTRmMDhjZjI4YzRjMDkxMmY0OGE4YTg1YWM0Li4xNzZiZTc1 NjIxYTQ5MmVlMzMyODE2YmQ2MmEzZTgwNzIxOWIwYWNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvR3JhcGhpY3NDb250ZXh0R0xPcGVuR0xDb21t b24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFw aGljc0NvbnRleHRHTE9wZW5HTENvbW1vbi5jcHAKQEAgLTMzNywxNCArMzM3LDE0IEBAIGJvb2wg R3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6OnByZWNpc2lvbnNNYXRjaChQbGF0Zm9ybUdMT2JqZWN0 IHZlcnRleFNoYWRlciwgUGxhCiAgICAgSGFzaE1hcDxTdHJpbmcsIHNoOjpHTGVudW0+IHZlcnRl eFN5bWJvbFByZWNpc2lvbk1hcDsKIAogICAgIGZvciAoY29uc3QgYXV0byYgZW50cnkgOiB2ZXJ0 ZXhFbnRyeS51bmlmb3JtTWFwKSB7Ci0gICAgICAgIGNvbnN0IHN0ZDo6c3RyaW5nJiBtYXBwZWRO YW1lID0gZW50cnkudmFsdWUubWFwcGVkTmFtZTsKLSAgICAgICAgdmVydGV4U3ltYm9sUHJlY2lz aW9uTWFwLmFkZChTdHJpbmcobWFwcGVkTmFtZS5jX3N0cigpLCBtYXBwZWROYW1lLmxlbmd0aCgp KSwgZW50cnkudmFsdWUucHJlY2lzaW9uKTsKKyAgICAgICAgY29uc3Qgc3RkOjpzdHJpbmcmIG1h cHBlZE5hbWUgPSBlbnRyeS52YWx1ZS5nZXQoKS5tYXBwZWROYW1lOworICAgICAgICB2ZXJ0ZXhT eW1ib2xQcmVjaXNpb25NYXAuYWRkKFN0cmluZyhtYXBwZWROYW1lLmNfc3RyKCksIG1hcHBlZE5h bWUubGVuZ3RoKCkpLCBlbnRyeS52YWx1ZS5nZXQoKS5wcmVjaXNpb24pOwogICAgIH0KIAogICAg IGZvciAoY29uc3QgYXV0byYgZW50cnkgOiBmcmFnbWVudEVudHJ5LnVuaWZvcm1NYXApIHsKLSAg ICAgICAgY29uc3Qgc3RkOjpzdHJpbmcmIG1hcHBlZE5hbWUgPSBlbnRyeS52YWx1ZS5tYXBwZWRO YW1lOworICAgICAgICBjb25zdCBzdGQ6OnN0cmluZyYgbWFwcGVkTmFtZSA9IGVudHJ5LnZhbHVl LmdldCgpLm1hcHBlZE5hbWU7CiAgICAgICAgIGNvbnN0IGF1dG8mIHZlcnRleFN5bWJvbCA9IHZl cnRleFN5bWJvbFByZWNpc2lvbk1hcC5maW5kKFN0cmluZyhtYXBwZWROYW1lLmNfc3RyKCksIG1h cHBlZE5hbWUubGVuZ3RoKCkpKTsKLSAgICAgICAgaWYgKHZlcnRleFN5bWJvbCAhPSB2ZXJ0ZXhT eW1ib2xQcmVjaXNpb25NYXAuZW5kKCkgJiYgdmVydGV4U3ltYm9sLT52YWx1ZSAhPSBlbnRyeS52 YWx1ZS5wcmVjaXNpb24pCisgICAgICAgIGlmICh2ZXJ0ZXhTeW1ib2wgIT0gdmVydGV4U3ltYm9s UHJlY2lzaW9uTWFwLmVuZCgpICYmIHZlcnRleFN5bWJvbC0+dmFsdWUgIT0gZW50cnkudmFsdWUu Z2V0KCkucHJlY2lzaW9uKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIApAQCAt OTI2LDcgKzkyNiw3IEBAIE9wdGlvbmFsPFN0cmluZz4gR3JhcGhpY3NDb250ZXh0R0xPcGVuR0w6 Om1hcHBlZFN5bWJvbEluU2hhZGVyU291cmNlTWFwKFBsYXRmb3JtCiAgICAgaWYgKHN5bWJvbEVu dHJ5ID09IHN5bWJvbE1hcC5lbmQoKSkKICAgICAgICAgcmV0dXJuIFdURjo6bnVsbG9wdDsKIAot ICAgIGF1dG8mIG1hcHBlZE5hbWUgPSBzeW1ib2xFbnRyeS0+dmFsdWUubWFwcGVkTmFtZTsKKyAg ICBhdXRvJiBtYXBwZWROYW1lID0gc3ltYm9sRW50cnktPnZhbHVlLmdldCgpLm1hcHBlZE5hbWU7 CiAgICAgcmV0dXJuIFN0cmluZyhtYXBwZWROYW1lLmNfc3RyKCksIG1hcHBlZE5hbWUubGVuZ3Ro KCkpOwogfQogCkBAIC05ODEsNyArOTgxLDcgQEAgT3B0aW9uYWw8U3RyaW5nPiBHcmFwaGljc0Nv bnRleHRHTE9wZW5HTDo6b3JpZ2luYWxTeW1ib2xJblNoYWRlclNvdXJjZU1hcChQbGF0Zm8KIAog ICAgIGNvbnN0IGF1dG8mIHN5bWJvbE1hcCA9IHJlc3VsdC0+dmFsdWUuc3ltYm9sTWFwKHN5bWJv bFR5cGUpOwogICAgIGZvciAoY29uc3QgYXV0byYgc3ltYm9sRW50cnkgOiBzeW1ib2xNYXApIHsK LSAgICAgICAgaWYgKG5hbWUgPT0gc3ltYm9sRW50cnkudmFsdWUubWFwcGVkTmFtZS5jX3N0cigp KQorICAgICAgICBpZiAobmFtZSA9PSBzeW1ib2xFbnRyeS52YWx1ZS5nZXQoKS5tYXBwZWROYW1l LmNfc3RyKCkpCiAgICAgICAgICAgICByZXR1cm4gc3ltYm9sRW50cnkua2V5OwogICAgIH0KICAg ICByZXR1cm4gV1RGOjpudWxsb3B0OwpAQCAtMTAzMyw3ICsxMDMzLDcgQEAgU3RyaW5nIEdyYXBo aWNzQ29udGV4dEdMT3BlbkdMOjptYXBwZWRTeW1ib2xOYW1lKFBsYXRmb3JtR0xPYmplY3Qgc2hh ZGVyc1syXSwgc2kKICAgICAgICAgICAgIAogICAgICAgICAgICAgY29uc3QgU2hhZGVyU3ltYm9s TWFwJiBzeW1ib2xNYXAgPSByZXN1bHQtPnZhbHVlLnN5bWJvbE1hcChzdGF0aWNfY2FzdDxlbnVt IEFOR0xFU2hhZGVyU3ltYm9sVHlwZT4oc3ltYm9sVHlwZSkpOwogICAgICAgICAgICAgZm9yIChj b25zdCBhdXRvJiBzeW1ib2xFbnRyeSA6IHN5bWJvbE1hcCkgewotICAgICAgICAgICAgICAgIGlm IChuYW1lID09IHN5bWJvbEVudHJ5LnZhbHVlLm1hcHBlZE5hbWUuY19zdHIoKSkKKyAgICAgICAg ICAgICAgICBpZiAobmFtZSA9PSBzeW1ib2xFbnRyeS52YWx1ZS5nZXQoKS5tYXBwZWROYW1lLmNf c3RyKCkpCiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBzeW1ib2xFbnRyeS5rZXk7CiAgICAg ICAgICAgICB9CiAgICAgICAgIH0KQEAgLTEyNjMsNyArMTI2Myw3IEBAIHZvaWQgR3JhcGhpY3ND b250ZXh0R0xPcGVuR0w6OnNoYWRlclNvdXJjZShQbGF0Zm9ybUdMT2JqZWN0IHNoYWRlciwgY29u c3QgU3RyaW5nCiAKICAgICBlbnRyeS5zb3VyY2UgPSBzdHJpbmc7CiAKLSAgICBtX3NoYWRlclNv dXJjZU1hcC5zZXQoc2hhZGVyLCBlbnRyeSk7CisgICAgbV9zaGFkZXJTb3VyY2VNYXAuc2V0KHNo YWRlciwgV1RGTW92ZShlbnRyeSkpOwogfQogCiB2b2lkIEdyYXBoaWNzQ29udGV4dEdMT3BlbkdM OjpzdGVuY2lsRnVuYyhHQ0dMZW51bSBmdW5jLCBHQ0dMaW50IHJlZiwgR0NHTHVpbnQgbWFzaykK