224548 2021-04-14 08:14:08 -0700 Update WKPageSet implementation according to new MediaProducer::MutedState values 2021-04-14 15:15:58 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ggaren webkit-bug-importer youennf oldest_to_newest 1750107 0 youennf 2021-04-14 08:14:08 -0700 This is a fallout of https://bugs.webkit.org/show_bug.cgi?id=222166. We should probably type safe all enumerations and bit fields defined in MediaProducer as a follow-up 1750109 1 youennf 2021-04-14 08:18:43 -0700 <rdar://76015688> 1750110 2 425981 youennf 2021-04-14 08:19:26 -0700 Created attachment 425981 Patch 1750371 3 ews-feeder 2021-04-14 15:15:56 -0700 Committed r275975 (236528@main): <https://commits.webkit.org/236528@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425981. 425981 2021-04-14 08:19:26 -0700 2021-04-14 15:15:57 -0700 Patch bug-224548-20210414171925.patch text/plain 6846 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1ODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDhlNGRjY2IxNzY3YzJkYmNi Y2ZkZmJlZGYyOGIyYzhjMmU3ZDEzZmEuLmE2N2Y2YTdlNTk3YzI0NmYxMDFhNTdjM2ZmZWYwMzlm YjU4YzBhMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDQtMTQgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBXS1BhZ2VTZXQgaW1w bGVtZW50YXRpb24gYWNjb3JkaW5nIG5ldyBNZWRpYVByb2R1Y2VyOjpNdXRlZFN0YXRlIHZhbHVl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NTQ4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJl ZCBieSBBUEkgdGVzdC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwOgor ICAgICAgICAoV0tQYWdlU2V0TXV0ZWQpOgorICAgICAgICBUcmFuc2xhdGUgV0tNZWRpYU11dGVk U3RhdGUgdG8gV2ViQ29yZTo6TWVkaWFQcm9kdWNlcjo6TXV0ZWRTdGF0ZUZsYWdzIHByb3Blcmx5 LgorCiAyMDIxLTA0LTEzICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K IAogICAgICAgICBbR1N0cmVhbWVyXSBDYXB0dXJlRGV2aWNlIG1vbml0b3IgdXNlZCBmcm9tIFVJ UHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tQYWdl LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHAKaW5kZXggNDNh NzRlZTc4YTBlZmY3OGUwMzhjNGEzY2E1ZjY4MjRmYzVhOWYyMy4uNDU1MDQ0NzgwNmY5NjNhNzBl NTQ0YjEyZGVjZWIxNGQxZjA2N2Q3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL0MvV0tQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9X S1BhZ2UuY3BwCkBAIC0yNzEwLDkgKzI3MTAsMTggQEAgdm9pZCBXS1BhZ2VTZXRNZWRpYVZvbHVt ZShXS1BhZ2VSZWYgcGFnZSwgZmxvYXQgdm9sdW1lKQogICAgIHRvSW1wbChwYWdlKS0+c2V0TWVk aWFWb2x1bWUodm9sdW1lKTsgICAgCiB9CiAKLXZvaWQgV0tQYWdlU2V0TXV0ZWQoV0tQYWdlUmVm IHBhZ2UsIFdLTWVkaWFNdXRlZFN0YXRlIG11dGVkKQordm9pZCBXS1BhZ2VTZXRNdXRlZChXS1Bh Z2VSZWYgcGFnZSwgV0tNZWRpYU11dGVkU3RhdGUgbXV0ZWRTdGF0ZSkKIHsKLSAgICB0b0ltcGwo cGFnZSktPnNldE11dGVkKG11dGVkKTsKKyAgICBXZWJDb3JlOjpNZWRpYVByb2R1Y2VyOjpNdXRl ZFN0YXRlRmxhZ3MgY29yZVN0YXRlID0gV2ViQ29yZTo6TWVkaWFQcm9kdWNlcjo6Tm9uZU11dGVk OworCisgICAgaWYgKG11dGVkU3RhdGUgJiBrV0tNZWRpYUF1ZGlvTXV0ZWQpCisgICAgICAgIGNv cmVTdGF0ZSB8PSBXZWJDb3JlOjpNZWRpYVByb2R1Y2VyOjpBdWRpb0lzTXV0ZWQ7CisgICAgaWYg KG11dGVkU3RhdGUgJiBrV0tNZWRpYUNhcHR1cmVEZXZpY2VzTXV0ZWQpCisgICAgICAgIGNvcmVT dGF0ZSB8PSBXZWJDb3JlOjpNZWRpYVByb2R1Y2VyOjpBdWRpb0FuZFZpZGVvQ2FwdHVyZUlzTXV0 ZWQ7CisgICAgaWYgKG11dGVkU3RhdGUgJiBrV0tNZWRpYVNjcmVlbkNhcHR1cmVNdXRlZCkKKyAg ICAgICAgY29yZVN0YXRlIHw9IFdlYkNvcmU6Ok1lZGlhUHJvZHVjZXI6OlNjcmVlbkNhcHR1cmVJ c011dGVkOworCisgICAgdG9JbXBsKHBhZ2UpLT5zZXRNdXRlZChjb3JlU3RhdGUpOwogfQogCiB2 b2lkIFdLUGFnZVNldE1lZGlhQ2FwdHVyZUVuYWJsZWQoV0tQYWdlUmVmIHBhZ2UsIGJvb2wgZW5h YmxlZCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRl eCBjYTgxMjY5ODNhY2RhMzkxZjIwOGVmZmM2ZWI1MmQwMGIyNTE4YTgyLi5hMTg2MjdiMmMwNDJi M2I5ZWMyYWEwYWFkODNlMDAzOTEwODlhOGRiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cK KysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDQtMTQgIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBXS1BhZ2VTZXQg aW1wbGVtZW50YXRpb24gYWNjb3JkaW5nIG5ldyBNZWRpYVByb2R1Y2VyOjpNdXRlZFN0YXRlIHZh bHVlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0 NTQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBU ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9HZXRVc2VyTWVkaWEubW06CisgICAgICAgIChUZXN0 V2ViS2l0QVBJOjpkb0NhcHR1cmVNdXRlVGVzdCk6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpU RVNUKToKKwogMjAyMS0wNC0xMiAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgTWFrZSBDb21taXQgUXVldWUgcm9idXN0IGJ5IGFkZGluZyBmZXcgZ2l0IGNv bW1hbmRzIHRvIGNsZWFuIHVwIHJlcG9zaXRvcnkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0L0dldFVzZXJNZWRpYS5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0L0dldFVzZXJNZWRpYS5tbQppbmRleCA3NGZhZjc4ZTM5ZDM0ZmJlODEyN2Yw YTNjN2MwMzI4MjYwMzcxNzY0Li45MzI0MmYwMDdhZWNhMzkzNmQxYTdmYTc3ZmI0MWIzZTQwOTE2 MzUxIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9HZXRVc2Vy TWVkaWEubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvR2V0VXNlck1l ZGlhLm1tCkBAIC0zMyw2ICszMyw3IEBACiAjaW1wb3J0ICJUZXN0V0tXZWJWaWV3LmgiCiAjaW1w b3J0ICJVc2VyTWVkaWFDYXB0dXJlVUlEZWxlZ2F0ZS5oIgogI2ltcG9ydCAiV0tXZWJWaWV3Q29u ZmlndXJhdGlvbkV4dHJhcy5oIgorI2ltcG9ydCA8V2ViS2l0L1dLUGFnZVByaXZhdGUuaD4KICNp bXBvcnQgPFdlYktpdC9XS1ByZWZlcmVuY2VzUHJpdmF0ZS5oPgogI2ltcG9ydCA8V2ViS2l0L1dL UHJvY2Vzc1Bvb2xQcml2YXRlLmg+CiAjaW1wb3J0IDxXZWJLaXQvV0tVSURlbGVnYXRlUHJpdmF0 ZS5oPgpAQCAtODMsNiArODQsMTAgQEAgc3RhdGljIGJvb2wgZG9uZTsKIH0KIEBlbmQKIAorQGlu dGVyZmFjZSBXS1dlYlZpZXcgKCkKKy0gKFdLUGFnZVJlZilfcGFnZUZvclRlc3Rpbmc7CitAZW5k CisKIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJIHsKIAogc3RhdGljIFN0cmluZyB3a01lZGlhQ2Fw dHVyZVN0YXRlU3RyaW5nKF9XS01lZGlhQ2FwdHVyZVN0YXRlRGVwcmVjYXRlZCBmbGFncykKQEAg LTEyMyw3ICsxMjgsNyBAQCBib29sIHdhaXRVbnRpbENhcHR1cmVTdGF0ZShXS1dlYlZpZXcgKndl YlZpZXcsIF9XS01lZGlhQ2FwdHVyZVN0YXRlRGVwcmVjYXRlZCBleAogICAgIHJldHVybiBmYWxz ZTsKIH0KIAotVEVTVChXZWJLaXQyLCBDYXB0dXJlTXV0ZSkKK3ZvaWQgZG9DYXB0dXJlTXV0ZVRl c3QoY29uc3QgRnVuY3Rpb248dm9pZChUZXN0V0tXZWJWaWV3KiwgX1dLTWVkaWFNdXRlZFN0YXRl KT4mIHNldFBhZ2VNdXRlZCkKIHsKICAgICBhdXRvIGNvbmZpZ3VyYXRpb24gPSBhZG9wdE5TKFtb V0tXZWJWaWV3Q29uZmlndXJhdGlvbiBhbGxvY10gaW5pdF0pOwogICAgIGF1dG8gcHJvY2Vzc1Bv b2xDb25maWcgPSBhZG9wdE5TKFtbX1dLUHJvY2Vzc1Bvb2xDb25maWd1cmF0aW9uIGFsbG9jXSBp bml0XSk7CkBAIC0xNDAsOSArMTQ1LDkgQEAgVEVTVChXZWJLaXQyLCBDYXB0dXJlTXV0ZSkKICAg ICBbd2ViVmlldyBsb2FkVGVzdFBhZ2VOYW1lZDpAImdldFVzZXJNZWRpYSJdOwogICAgIEVYUEVD VF9UUlVFKHdhaXRVbnRpbENhcHR1cmVTdGF0ZSh3ZWJWaWV3LmdldCgpLCBfV0tNZWRpYUNhcHR1 cmVTdGF0ZURlcHJlY2F0ZWRBY3RpdmVDYW1lcmEpKTsKIAotICAgIFt3ZWJWaWV3IF9zZXRQYWdl TXV0ZWQ6IF9XS01lZGlhQ2FwdHVyZURldmljZXNNdXRlZF07CisgICAgc2V0UGFnZU11dGVkKHdl YlZpZXcuZ2V0KCksIF9XS01lZGlhQ2FwdHVyZURldmljZXNNdXRlZCk7CiAgICAgRVhQRUNUX1RS VUUod2FpdFVudGlsQ2FwdHVyZVN0YXRlKHdlYlZpZXcuZ2V0KCksIF9XS01lZGlhQ2FwdHVyZVN0 YXRlRGVwcmVjYXRlZE11dGVkQ2FtZXJhKSk7Ci0gICAgW3dlYlZpZXcgX3NldFBhZ2VNdXRlZDog X1dLTWVkaWFOb25lTXV0ZWRdOworICAgIHNldFBhZ2VNdXRlZCh3ZWJWaWV3LmdldCgpLCBfV0tN ZWRpYU5vbmVNdXRlZCk7CiAgICAgRVhQRUNUX1RSVUUod2FpdFVudGlsQ2FwdHVyZVN0YXRlKHdl YlZpZXcuZ2V0KCksIF9XS01lZGlhQ2FwdHVyZVN0YXRlRGVwcmVjYXRlZEFjdGl2ZUNhbWVyYSkp OwogCiAgICAgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAInN0b3AoKSJd OwpAQCAtMTUwLDEyICsxNTUsMTIgQEAgVEVTVChXZWJLaXQyLCBDYXB0dXJlTXV0ZSkKIAogICAg IFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJjYXB0dXJlQXVkaW8oKSJd OwogICAgIEVYUEVDVF9UUlVFKHdhaXRVbnRpbENhcHR1cmVTdGF0ZSh3ZWJWaWV3LmdldCgpLCBf V0tNZWRpYUNhcHR1cmVTdGF0ZURlcHJlY2F0ZWRBY3RpdmVNaWNyb3Bob25lKSk7Ci0gICAgW3dl YlZpZXcgX3NldFBhZ2VNdXRlZDogX1dLTWVkaWFDYXB0dXJlRGV2aWNlc011dGVkXTsKKyAgICBz ZXRQYWdlTXV0ZWQod2ViVmlldy5nZXQoKSwgX1dLTWVkaWFDYXB0dXJlRGV2aWNlc011dGVkKTsK ICAgICBFWFBFQ1RfVFJVRSh3YWl0VW50aWxDYXB0dXJlU3RhdGUod2ViVmlldy5nZXQoKSwgX1dL TWVkaWFDYXB0dXJlU3RhdGVEZXByZWNhdGVkTXV0ZWRNaWNyb3Bob25lKSk7Ci0gICAgW3dlYlZp ZXcgX3NldFBhZ2VNdXRlZDogX1dLTWVkaWFOb25lTXV0ZWRdOworICAgIHNldFBhZ2VNdXRlZCh3 ZWJWaWV3LmdldCgpLCBfV0tNZWRpYU5vbmVNdXRlZCk7CiAgICAgRVhQRUNUX1RSVUUod2FpdFVu dGlsQ2FwdHVyZVN0YXRlKHdlYlZpZXcuZ2V0KCksIF9XS01lZGlhQ2FwdHVyZVN0YXRlRGVwcmVj YXRlZEFjdGl2ZU1pY3JvcGhvbmUpKTsKIAotICAgIFt3ZWJWaWV3IF9zZXRQYWdlTXV0ZWQ6IF9X S01lZGlhQ2FwdHVyZURldmljZXNNdXRlZF07CisgICAgc2V0UGFnZU11dGVkKHdlYlZpZXcuZ2V0 KCksIF9XS01lZGlhQ2FwdHVyZURldmljZXNNdXRlZCk7CiAgICAgRVhQRUNUX1RSVUUod2FpdFVu dGlsQ2FwdHVyZVN0YXRlKHdlYlZpZXcuZ2V0KCksIF9XS01lZGlhQ2FwdHVyZVN0YXRlRGVwcmVj YXRlZE11dGVkTWljcm9waG9uZSkpOwogCiAgICAgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5n SmF2YVNjcmlwdDpAInN0b3AoKSJdOwpAQCAtMTYzLDE1ICsxNjgsMjkgQEAgVEVTVChXZWJLaXQy LCBDYXB0dXJlTXV0ZSkKIAogICAgIFt3ZWJWaWV3IHN0cmluZ0J5RXZhbHVhdGluZ0phdmFTY3Jp cHQ6QCJjYXB0dXJlQXVkaW9BbmRWaWRlbygpIl07CiAgICAgRVhQRUNUX1RSVUUod2FpdFVudGls Q2FwdHVyZVN0YXRlKHdlYlZpZXcuZ2V0KCksIF9XS01lZGlhQ2FwdHVyZVN0YXRlRGVwcmVjYXRl ZEFjdGl2ZUNhbWVyYSB8IF9XS01lZGlhQ2FwdHVyZVN0YXRlRGVwcmVjYXRlZEFjdGl2ZU1pY3Jv cGhvbmUpKTsKLSAgICBbd2ViVmlldyBfc2V0UGFnZU11dGVkOiBfV0tNZWRpYUNhcHR1cmVEZXZp Y2VzTXV0ZWRdOworICAgIHNldFBhZ2VNdXRlZCh3ZWJWaWV3LmdldCgpLCBfV0tNZWRpYUNhcHR1 cmVEZXZpY2VzTXV0ZWQpOwogICAgIEVYUEVDVF9UUlVFKHdhaXRVbnRpbENhcHR1cmVTdGF0ZSh3 ZWJWaWV3LmdldCgpLCBfV0tNZWRpYUNhcHR1cmVTdGF0ZURlcHJlY2F0ZWRNdXRlZENhbWVyYSB8 IF9XS01lZGlhQ2FwdHVyZVN0YXRlRGVwcmVjYXRlZE11dGVkTWljcm9waG9uZSkpOwotICAgIFt3 ZWJWaWV3IF9zZXRQYWdlTXV0ZWQ6IF9XS01lZGlhTm9uZU11dGVkXTsKKyAgICBzZXRQYWdlTXV0 ZWQod2ViVmlldy5nZXQoKSwgX1dLTWVkaWFOb25lTXV0ZWQpOwogICAgIEVYUEVDVF9UUlVFKHdh aXRVbnRpbENhcHR1cmVTdGF0ZSh3ZWJWaWV3LmdldCgpLCBfV0tNZWRpYUNhcHR1cmVTdGF0ZURl cHJlY2F0ZWRBY3RpdmVDYW1lcmEgfCBfV0tNZWRpYUNhcHR1cmVTdGF0ZURlcHJlY2F0ZWRBY3Rp dmVNaWNyb3Bob25lKSk7CiAKICAgICBbd2ViVmlldyBzdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2Ny aXB0OkAic3RvcCgpIl07CiAgICAgRVhQRUNUX1RSVUUod2FpdFVudGlsQ2FwdHVyZVN0YXRlKHdl YlZpZXcuZ2V0KCksIF9XS01lZGlhQ2FwdHVyZVN0YXRlRGVwcmVjYXRlZE5vbmUpKTsKIH0KIAor VEVTVChXZWJLaXQyLCBDYXB0dXJlTXV0ZSkKK3sKKyAgICBkb0NhcHR1cmVNdXRlVGVzdChbXShh dXRvKiB3ZWJWaWV3LCBhdXRvIHN0YXRlKSB7CisgICAgICAgIFt3ZWJWaWV3IF9zZXRQYWdlTXV0 ZWQ6IHN0YXRlXTsKKyAgICB9KTsKK30KKworVEVTVChXZWJLaXQyLCBDYXB0dXJlTXV0ZTIpCit7 CisgICAgZG9DYXB0dXJlTXV0ZVRlc3QoW10oYXV0byogd2ViVmlldywgYXV0byBzdGF0ZSkgewor ICAgICAgICBXS1BhZ2VTZXRNdXRlZChbd2ViVmlldyBfcGFnZUZvclRlc3RpbmddLCBzdGF0ZSk7 CisgICAgfSk7Cit9CisKIFRFU1QoV2ViS2l0MiwgQ2FwdHVyZVN0b3ApCiB7CiAgICAgYXV0byBj b25maWd1cmF0aW9uID0gYWRvcHROUyhbW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24gYWxsb2NdIGlu aXRdKTsK