224546 2021-04-14 07:47:01 -0700 [IFC] Incorrect box height when scrollbar takes padding box space 2021-04-16 06:35:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cathiechen zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1750103 0 425979 cathiechen 2021-04-14 07:47:01 -0700 Created attachment 425979 selection-crash.html This issue occurs on the Debug building with LAYOUT_FORMATTING_CONTEXT enabled. The code is updated to commit 80e1bf3d759003a97b3e676d78fca630407fdd35. The test case contains inline-block box and text. The height of body is 35px, but others are 24px. It crashes when select the text. Debug a bit: - During layout, in RenderBlockFlow::layoutInlineChildren, it uses layoutModernLines() to layout lines. The logical height is 35. - During select, in RenderBlockFlow::ensureLineBoxes, it calls complexLineLayout.layoutLineBoxes. The logical height is 24. - Then it fails `ASSERT(didNeedLayout || ceilf(logicalHeight()) == ceilf(oldHeight));` in RenderBlockFlow::ensureLineBoxes. 1750113 1 425983 zalan 2021-04-14 08:20:46 -0700 Created attachment 425983 (another)test case 1750340 2 zalan 2021-04-14 14:36:43 -0700 Actually this is about the reserved space for always-on scrollbars (15px here in MiniBrowser -which explains the 11px diff (15px scrollbar - 4px descent)) 1750345 3 webkit-bug-importer 2021-04-14 14:44:28 -0700 <rdar://problem/76666402> 1750475 4 zalan 2021-04-14 20:55:25 -0700 ok, so this is broken when the padding box can't accommodate the scrollbar. this fixes the vertical aspect of it: - auto verticalSpaceReservedForScrollbar = std::min(replacedOrInlineBlock.height() - replacedOrInlineBlock.paddingBoxHeight(), LayoutUnit(replacedOrInlineBlock.horizontalScrollbarHeight())); + auto paddingBoxHeight = replacedOrInlineBlock.paddingBoxHeight(); + auto horizontalScrollbarHeight = LayoutUnit { replacedOrInlineBlock.horizontalScrollbarHeight() }; + auto verticalSpaceReservedForScrollbar = horizontalScrollbarHeight > paddingBoxHeight ? paddingBoxHeight : std::min(replacedOrInlineBlock.height() - paddingBoxHeight, horizontalScrollbarHeight); will upload the patch tomorrow morning. 1750556 5 426095 zalan 2021-04-15 03:23:11 -0700 Created attachment 426095 Patch 1750641 6 426110 zalan 2021-04-15 09:26:32 -0700 Created attachment 426110 Patch 1751051 7 ews-feeder 2021-04-16 06:35:16 -0700 Committed r276135 (236629@main): <https://commits.webkit.org/236629@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426110. 425979 2021-04-14 07:47:01 -0700 2021-04-14 07:47:01 -0700 selection-crash.html wh.html text/html 558 cathiechen PCFET0NUWVBFIEhUTUw+CjxodG1sPgoKPGhlYWQ+CiAgICA8c3R5bGU+CiAgICAgICAgYm9keSB7 CiAgICAgICAgICAgIGJvcmRlcjogMXB4IHNvbGlkIGJsYWNrOwogICAgICAgIH0KICAgICAgICAu Y29udGFpbiB7CiAgICAgICAgICAgIGRpc3BsYXk6IGlubGluZS1ibG9jazsKICAgICAgICAgICAg b3ZlcmZsb3c6IGF1dG87CiAgICAgICAgICAgIGJvcmRlcjogMTBweCBzb2xpZCBncmVlbjsKICAg ICAgICAgICAgd2lkdGg6MHB4OwogICAgICAgICAgICBoZWlnaHQ6MHB4OwogICAgICAgIH0KCiAg ICAgICAgLmlubmVyQ29udGVudHMgewogICAgICAgICAgICBjb2xvcjogdHJhbnNwYXJlbnQ7CiAg ICAgICAgICAgIGhlaWdodDogMTAwcHg7CiAgICAgICAgICAgIHdpZHRoOiAxMDBweDsKICAgICAg ICB9CgogICAgPC9zdHlsZT4KPC9oZWFkPgoKPGJvZHk+CgoKICAgIDxkaXYgY2xhc3M9ImNvbnRh aW4iPgogICAgICAgIDxkaXYgY2xhc3M9ImlubmVyQ29udGVudHMiPjwvZGl2PgogICAgPC9kaXY+ CiAgICBvdXRzaWRlIGFmdGVyCiAgICA8YnI+Cgo8L2JvZHk+Cgo8L2h0bWw+ 425983 2021-04-14 08:20:46 -0700 2021-04-14 08:20:46 -0700 (another)test case 224546.html text/html 464 zalan PCFET0NUWVBFIEhUTUw+CjxzdHlsZT4KLmNvbnRhaW5lciB7CiAgbWFyZ2luLWxlZnQ6IDEwcHg7 CiAgYmFja2dyb3VuZC1jb2xvcjogYmx1ZTsKICBmbG9hdDogbGVmdDsKfQouaW5saW5lLWJsb2Nr IHsKICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7CiAgb3ZlcmZsb3c6IGF1dG87CiAgYm9yZGVyOiAx MDBweCBzb2xpZCBncmVlbjsKICBoZWlnaHQ6IDBweDsKICB3aWR0aDogMTAwcHg7Cn0KLnNpbXBs ZV9ib3ggewogIHdpZHRoOiA4NnB4OwogIGhlaWdodDogMXB4Owp9Cjwvc3R5bGU+CjxkaXYgY2xh c3M9Y29udGFpbmVyPjxkaXYgY2xhc3M9aW5saW5lLWJsb2NrPjxkaXYgY2xhc3M9c2ltcGxlX2Jv eD48L2Rpdj48L2Rpdj48L2Rpdj4KPGRpdiBjbGFzcz1jb250YWluZXI+PGRpdiBjbGFzcz1pbmxp bmUtYmxvY2s+PC9kaXY+PC9kaXY+ClBBU1MgaWYgdGhlc2UgMiBib3hlcyBoYXZlIHRoZSBzYW1l IGhlaWdodC4= 426095 2021-04-15 03:23:11 -0700 2021-04-15 07:16:29 -0700 Patch bug-224546-20210415032311.patch text/plain 3897 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1NDc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzIyMjhmNGIyNDE3MWI3 MjU0YmJhNzY3YmI5YTU3YTljY2U2ZmExYS4uMzNiNjI0YWMxMDc5Yjc1NGFkM2NkZDAxOTEyNTcz Y2VjZDhlMGNkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA0LTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0lGQ10gSW5jb3JyZWN0IGJv eCBoZWlnaHQgd2hlbiBzY3JvbGxiYXIgdGFrZXMgcGFkZGluZyBib3ggc3BhY2UKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDU0NgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNzY2NjY0MDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV0lQLiBOZWVkcyB0ZXN0IGNhc2UuCisKKyAgICAgICAgKiBsYXlv dXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkxheW91dEludGVncmF0aW9uOjpMaW5lTGF5b3V0Ojp1cGRhdGVMYXlvdXRCb3hE aW1lbnNpb25zKToKKwogMjAyMS0wNC0wNSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIFdlYlNvY2tldENoYW5uZWwgYnVmZmVycyB1c2UgbWVt b3J5IGFmdGVyIGdvaW5nIGlkbGUgKDY0SyB3YXN0ZWQgb24gZmFjZWJvb2suY29tCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25M aW5lTGF5b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJ bnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwCmluZGV4IDc1ZWZkZjRhODNhOWYyMmI4MzE2MDYzZTY5 YjAzYjc4OGZiMTIyZTUuLjMzZmQwNTVlNGExOTNjMGU2ODM2MDBhOTI4ODJiODRhOGQyMzUzMzcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRl Z3JhdGlvbkxpbmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3Jh dGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwCkBAIC0xNDUsMTggKzE0NSwyMSBA QCB2b2lkIExpbmVMYXlvdXQ6OnVwZGF0ZUxheW91dEJveERpbWVuc2lvbnMoY29uc3QgUmVuZGVy Qm94JiByZXBsYWNlZE9ySW5saW5lQmxvYwogCiAgICAgLy8gQWx3YXlzIHVzZSB0aGUgcGh5c2lj YWwgc2l6ZSBoZXJlIGZvciBpbmxpbmUgbGV2ZWwgYm94ZXMgKHRoaXMgaXMgd2hlcmUgdGhlIGxv Z2ljYWwgdnMuIHBoeXNpY2FsIGNvb3JkcyBmbGlwIGhhcHBlbnMpLgogICAgIGF1dG8mIHJlcGxh Y2VkQm94R2VvbWV0cnkgPSBtX2xheW91dFN0YXRlLmVuc3VyZUdlb21ldHJ5Rm9yQm94KHJlcGxh Y2VkQm94KTsKLSAgICAvLyBTY3JvbGxiYXJzIGFyZSBwbGFjZWQgImJldHdlZW4iIHRoZSBib3Jk ZXIgYW5kIHRoZSBwYWRkaW5nIGJveCBhbmQgdGhleSBuZXZlciBzdHJldGNoIHRoZSBib3JkZXIg Ym94LiBUaGV5IG1heSBzaHJpbmsgdGhlIHBhZGRpbmcgYm94IHRob3VnaC4KLSAgICBhdXRvIGhv cml6b250YWxTcGFjZVJlc2VydmVkRm9yU2Nyb2xsYmFyID0gc3RkOjptaW4ocmVwbGFjZWRPcklu bGluZUJsb2NrLndpZHRoKCkgLSByZXBsYWNlZE9ySW5saW5lQmxvY2sucGFkZGluZ0JveFdpZHRo KCksIExheW91dFVuaXQocmVwbGFjZWRPcklubGluZUJsb2NrLnZlcnRpY2FsU2Nyb2xsYmFyV2lk dGgoKSkpOworCisgICAgYXV0byBob3Jpem9udGFsU3BhY2VSZXNlcnZlZEZvclNjcm9sbGJhciA9 IHJlcGxhY2VkT3JJbmxpbmVCbG9jay5wYWRkaW5nQm94UmVjdEluY2x1ZGluZ1Njcm9sbGJhcigp LndpZHRoKCkgLSByZXBsYWNlZE9ySW5saW5lQmxvY2sucGFkZGluZ0JveFdpZHRoKCk7CiAgICAg cmVwbGFjZWRCb3hHZW9tZXRyeS5zZXRIb3Jpem9udGFsU3BhY2VGb3JTY3JvbGxiYXIoaG9yaXpv bnRhbFNwYWNlUmVzZXJ2ZWRGb3JTY3JvbGxiYXIpOwogCi0gICAgYXV0byB2ZXJ0aWNhbFNwYWNl UmVzZXJ2ZWRGb3JTY3JvbGxiYXIgPSBzdGQ6Om1pbihyZXBsYWNlZE9ySW5saW5lQmxvY2suaGVp Z2h0KCkgLSByZXBsYWNlZE9ySW5saW5lQmxvY2sucGFkZGluZ0JveEhlaWdodCgpLCBMYXlvdXRV bml0KHJlcGxhY2VkT3JJbmxpbmVCbG9jay5ob3Jpem9udGFsU2Nyb2xsYmFySGVpZ2h0KCkpKTsK KyAgICBhdXRvIHZlcnRpY2FsU3BhY2VSZXNlcnZlZEZvclNjcm9sbGJhciA9IHJlcGxhY2VkT3JJ bmxpbmVCbG9jay5wYWRkaW5nQm94UmVjdEluY2x1ZGluZ1Njcm9sbGJhcigpLmhlaWdodCgpIC0g cmVwbGFjZWRPcklubGluZUJsb2NrLnBhZGRpbmdCb3hIZWlnaHQoKTsKICAgICByZXBsYWNlZEJv eEdlb21ldHJ5LnNldFZlcnRpY2FsU3BhY2VGb3JTY3JvbGxiYXIodmVydGljYWxTcGFjZVJlc2Vy dmVkRm9yU2Nyb2xsYmFyKTsKIAogICAgIHJlcGxhY2VkQm94R2VvbWV0cnkuc2V0Q29udGVudEJv eFdpZHRoKHJlcGxhY2VkT3JJbmxpbmVCbG9jay5jb250ZW50V2lkdGgoKSk7CiAgICAgcmVwbGFj ZWRCb3hHZW9tZXRyeS5zZXRDb250ZW50Qm94SGVpZ2h0KHJlcGxhY2VkT3JJbmxpbmVCbG9jay5j b250ZW50SGVpZ2h0KCkpOwogCiAgICAgcmVwbGFjZWRCb3hHZW9tZXRyeS5zZXRCb3JkZXIoeyB7 IHJlcGxhY2VkT3JJbmxpbmVCbG9jay5ib3JkZXJMZWZ0KCksIHJlcGxhY2VkT3JJbmxpbmVCbG9j ay5ib3JkZXJSaWdodCgpIH0sIHsgcmVwbGFjZWRPcklubGluZUJsb2NrLmJvcmRlclRvcCgpLCBy ZXBsYWNlZE9ySW5saW5lQmxvY2suYm9yZGVyQm90dG9tKCkgfSB9KTsKLSAgICByZXBsYWNlZEJv eEdlb21ldHJ5LnNldFBhZGRpbmcoTGF5b3V0OjpFZGdlcyB7IHsgcmVwbGFjZWRPcklubGluZUJs b2NrLnBhZGRpbmdMZWZ0KCksIHJlcGxhY2VkT3JJbmxpbmVCbG9jay5wYWRkaW5nUmlnaHQoKSB9 LCB7IHJlcGxhY2VkT3JJbmxpbmVCbG9jay5wYWRkaW5nVG9wKCksIHJlcGxhY2VkT3JJbmxpbmVC bG9jay5wYWRkaW5nQm90dG9tKCkgfSB9KTsKKyAgICAvLyBTY3JvbGxiYXJzIGVhdCBpbnRvIHRo ZSBwYWRkaW5nIGJveCBhcmVhLiBUaGV5IG5ldmVyIHN0cmV0Y2ggdGhlIGJvcmRlciBib3ggYnV0 IHRoZXkgbWF5IHNocmluayB0aGUgcGFkZGluZyBib3guCisgICAgYXV0byBwYWRkaW5nQm90dG9t ID0gcmVwbGFjZWRPcklubGluZUJsb2NrLnBhZGRpbmdCb3R0b20oKSAtIHZlcnRpY2FsU3BhY2VS ZXNlcnZlZEZvclNjcm9sbGJhcjsKKyAgICBhdXRvIHBhZGRpbmdSaWdodCA9IHJlcGxhY2VkT3JJ bmxpbmVCbG9jay5wYWRkaW5nUmlnaHQoKSAtIGhvcml6b250YWxTcGFjZVJlc2VydmVkRm9yU2Ny b2xsYmFyOworICAgIHJlcGxhY2VkQm94R2VvbWV0cnkuc2V0UGFkZGluZyhMYXlvdXQ6OkVkZ2Vz IHsgeyByZXBsYWNlZE9ySW5saW5lQmxvY2sucGFkZGluZ0xlZnQoKSwgcGFkZGluZ1JpZ2h0ICB9 LCB7IHJlcGxhY2VkT3JJbmxpbmVCbG9jay5wYWRkaW5nVG9wKCksIHBhZGRpbmdCb3R0b20gfSB9 KTsKIAogICAgIHJlcGxhY2VkQm94R2VvbWV0cnkuc2V0SG9yaXpvbnRhbE1hcmdpbih7IHJlcGxh Y2VkT3JJbmxpbmVCbG9jay5tYXJnaW5MZWZ0KCksIHJlcGxhY2VkT3JJbmxpbmVCbG9jay5tYXJn aW5SaWdodCgpIH0pOwogICAgIHJlcGxhY2VkQm94R2VvbWV0cnkuc2V0VmVydGljYWxNYXJnaW4o eyByZXBsYWNlZE9ySW5saW5lQmxvY2subWFyZ2luVG9wKCksIHJlcGxhY2VkT3JJbmxpbmVCbG9j ay5tYXJnaW5Cb3R0b20oKSB9KTsK 426110 2021-04-15 09:26:32 -0700 2021-04-16 06:35:17 -0700 Patch bug-224546-20210415092632.patch text/plain 5583 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1OTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzAzNzMzNjlkOGZhMzgy MWZiYmUxYzgzOGIxOGQyNDY3NmMxZjdlZC4uNTUwOWFiNTZmZjQwNzRmNzEyNzUxYmY3M2M2NDU4 NTRhZTIwODAzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA0LTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0lGQ10gSW5jb3JyZWN0IGJv eCBoZWlnaHQgd2hlbiBzY3JvbGxiYXIgdGFrZXMgcGFkZGluZyBib3ggc3BhY2UKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDU0NgorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNzY2NjY0MDI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyB0aGUgY2FzZSB3aGVuIGEgbm9uLW92 ZXJsYXkgc2Nyb2xsYmFyIGNhbid0IGJlIGFjY29tb2RhdGVkIGluIHRoZSBwYWRkaW5nL2NvbnRl bnQgYm94IGFyZWEgKGUuZyA8ZGl2IHN0eWxlPSJoZWlnaHQ6IDEwcHg7IG92ZXJmbG93OiBzY3Jv bGwiPi4uLikKKyAgICAgICAgSW4gdGhlIGxlZ2FjeSByZW5kZXIgdHJlZSB0aGUgbm9uLW92ZXJs YXkgc2Nyb2xsYmFyIHNpemUgaXMgYWxyZWFkeSB0YWtlbiBpbnRvIGFjY291bnQgd2hlbiBjYWxs aW5nIFJlbmRlckJveDo6Y29udGVudFdpZHRoL0hlaWdodCAocGFkZGluZ0JveEhlaWdodC9XaWR0 aCksIHNvCisgICAgICAgIHdlIGp1c3QgaGF2ZSB0byBjaGVjayBob3cgbXVjaCBzcGFjZSB0aGV5 IGFjdHVsbHkgdGFrZSAoY3VycmVudGx5IG1heGltdW0gb2YgMTVweCkuCisKKyAgICAgICAgVGVz dDogZmFzdC9pbmxpbmUtYmxvY2svbm9uLW92ZXJsYXktc2Nyb2xsYmFyLWluY29ycmVjdC1wYWRk aW5nLmh0bWwKKworICAgICAgICAqIGxheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlv bkxpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0SW50ZWdyYXRpb246Okxp bmVMYXlvdXQ6OnVwZGF0ZUxheW91dEJveERpbWVuc2lvbnMpOgorCiAyMDIxLTA0LTE0ICBGcsOp ZMOpcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgogCiAgICAgICAgIENyYXNoIGluIFJlbmRl ckJsb2NrOjphZGRPdmVyZmxvd0Zyb21DaGlsZHJlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5 b3V0LmNwcAppbmRleCA3NWVmZGY0YTgzYTlmMjJiODMxNjA2M2U2OWIwM2I3ODhmYjEyMmU1Li42 ODIwYjBmYWFhNjlkNDU0ZDk5MmJkOWQwZmJiMDdhYTFjMmU1NDdmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdy YXRpb25MaW5lTGF5b3V0LmNwcApAQCAtMTQ1LDExICsxNDUsMTQgQEAgdm9pZCBMaW5lTGF5b3V0 Ojp1cGRhdGVMYXlvdXRCb3hEaW1lbnNpb25zKGNvbnN0IFJlbmRlckJveCYgcmVwbGFjZWRPcklu bGluZUJsb2MKIAogICAgIC8vIEFsd2F5cyB1c2UgdGhlIHBoeXNpY2FsIHNpemUgaGVyZSBmb3Ig aW5saW5lIGxldmVsIGJveGVzICh0aGlzIGlzIHdoZXJlIHRoZSBsb2dpY2FsIHZzLiBwaHlzaWNh bCBjb29yZHMgZmxpcCBoYXBwZW5zKS4KICAgICBhdXRvJiByZXBsYWNlZEJveEdlb21ldHJ5ID0g bV9sYXlvdXRTdGF0ZS5lbnN1cmVHZW9tZXRyeUZvckJveChyZXBsYWNlZEJveCk7Ci0gICAgLy8g U2Nyb2xsYmFycyBhcmUgcGxhY2VkICJiZXR3ZWVuIiB0aGUgYm9yZGVyIGFuZCB0aGUgcGFkZGlu ZyBib3ggYW5kIHRoZXkgbmV2ZXIgc3RyZXRjaCB0aGUgYm9yZGVyIGJveC4gVGhleSBtYXkgc2hy aW5rIHRoZSBwYWRkaW5nIGJveCB0aG91Z2guCi0gICAgYXV0byBob3Jpem9udGFsU3BhY2VSZXNl cnZlZEZvclNjcm9sbGJhciA9IHN0ZDo6bWluKHJlcGxhY2VkT3JJbmxpbmVCbG9jay53aWR0aCgp IC0gcmVwbGFjZWRPcklubGluZUJsb2NrLnBhZGRpbmdCb3hXaWR0aCgpLCBMYXlvdXRVbml0KHJl cGxhY2VkT3JJbmxpbmVCbG9jay52ZXJ0aWNhbFNjcm9sbGJhcldpZHRoKCkpKTsKKworICAgIC8v IFNjcm9sbGJhcnMgZWF0IGludG8gdGhlIHBhZGRpbmcgYm94IGFyZWEuIFRoZXkgbmV2ZXIgc3Ry ZXRjaCB0aGUgYm9yZGVyIGJveCBidXQgdGhleSBtYXkgc2hyaW5rIHRoZSBwYWRkaW5nIGJveC4K KyAgICAvLyBJbiBsZWdhY3kgcmVuZGVyIHRyZWUsIFJlbmRlckJveDo6Y29udGVudFdpZHRoL2Nv bnRlbnRIZWlnaHQgdmFsdWVzIGFyZSBhZGp1c3RlZCB0byBhY2NvbW9kYXRlIHRoZSBzY3JvbGxi YXIgd2lkdGgvaGVpZ2h0LgorICAgIC8vIGUuZy4gPGRpdiBzdHlsZT0id2lkdGg6IDEwcHg7IG92 ZXJmbG93OiBzY3JvbGw7Ij5jb250ZW50PC9kaXY+LCBSZW5kZXJCb3g6OmNvbnRlbnRXaWR0aCgp IHdvbid0IGJlIHJldHVybmluZyB0aGUgdmFsdWUgb2YgMTBweCBidXQgaW5zdGVhZCAwcHggKDEw cHggLSAxNXB4KS4KKyAgICBhdXRvIGhvcml6b250YWxTcGFjZVJlc2VydmVkRm9yU2Nyb2xsYmFy ID0gcmVwbGFjZWRPcklubGluZUJsb2NrLnBhZGRpbmdCb3hSZWN0SW5jbHVkaW5nU2Nyb2xsYmFy KCkud2lkdGgoKSAtIHJlcGxhY2VkT3JJbmxpbmVCbG9jay5wYWRkaW5nQm94V2lkdGgoKTsKICAg ICByZXBsYWNlZEJveEdlb21ldHJ5LnNldEhvcml6b250YWxTcGFjZUZvclNjcm9sbGJhcihob3Jp em9udGFsU3BhY2VSZXNlcnZlZEZvclNjcm9sbGJhcik7CiAKLSAgICBhdXRvIHZlcnRpY2FsU3Bh Y2VSZXNlcnZlZEZvclNjcm9sbGJhciA9IHN0ZDo6bWluKHJlcGxhY2VkT3JJbmxpbmVCbG9jay5o ZWlnaHQoKSAtIHJlcGxhY2VkT3JJbmxpbmVCbG9jay5wYWRkaW5nQm94SGVpZ2h0KCksIExheW91 dFVuaXQocmVwbGFjZWRPcklubGluZUJsb2NrLmhvcml6b250YWxTY3JvbGxiYXJIZWlnaHQoKSkp OworICAgIGF1dG8gdmVydGljYWxTcGFjZVJlc2VydmVkRm9yU2Nyb2xsYmFyID0gcmVwbGFjZWRP cklubGluZUJsb2NrLnBhZGRpbmdCb3hSZWN0SW5jbHVkaW5nU2Nyb2xsYmFyKCkuaGVpZ2h0KCkg LSByZXBsYWNlZE9ySW5saW5lQmxvY2sucGFkZGluZ0JveEhlaWdodCgpOwogICAgIHJlcGxhY2Vk Qm94R2VvbWV0cnkuc2V0VmVydGljYWxTcGFjZUZvclNjcm9sbGJhcih2ZXJ0aWNhbFNwYWNlUmVz ZXJ2ZWRGb3JTY3JvbGxiYXIpOwogCiAgICAgcmVwbGFjZWRCb3hHZW9tZXRyeS5zZXRDb250ZW50 Qm94V2lkdGgocmVwbGFjZWRPcklubGluZUJsb2NrLmNvbnRlbnRXaWR0aCgpKTsKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAx NWMzNDMyY2RkMTcxMGM5YWI1NWFhNGQ0Njk4NmRiZjhiYzFlYjcxLi41OGJlN2ExMDgyYWYyMWQz ZDNhN2ViMWI5MjkxYWMwMTBiMjNmMTMyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDQt MTUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbSUZDXSBJbmNv cnJlY3QgYm94IGhlaWdodCB3aGVuIHNjcm9sbGJhciB0YWtlcyBwYWRkaW5nIGJveCBzcGFjZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NTQ2Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NjY2NjQwMj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvaW5saW5lLWJsb2NrL25vbi1vdmVybGF5 LXNjcm9sbGJhci1pbmNvcnJlY3QtcGFkZGluZy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvaW5saW5lLWJsb2NrL25vbi1vdmVybGF5LXNjcm9sbGJhci1pbmNvcnJlY3QtcGFk ZGluZy5odG1sOiBBZGRlZC4KKwogMjAyMS0wNC0xNCAgRnLDqWTDqXJpYyBXYW5nICA8ZndhbmdA aWdhbGlhLmNvbT4KIAogICAgICAgICBDcmFzaCBpbiBSZW5kZXJCbG9jazo6YWRkT3ZlcmZsb3dG cm9tQ2hpbGRyZW4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaW5saW5lLWJsb2NrL25v bi1vdmVybGF5LXNjcm9sbGJhci1pbmNvcnJlY3QtcGFkZGluZy1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9mYXN0L2lubGluZS1ibG9jay9ub24tb3ZlcmxheS1zY3JvbGxiYXItaW5jb3JyZWN0 LXBhZGRpbmctZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjA4ODM5ZjZiYjI5NmU4ODhkMzExZDhl YTJmMzVmN2ZmODJkZDNmMmQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2lu bGluZS1ibG9jay9ub24tb3ZlcmxheS1zY3JvbGxiYXItaW5jb3JyZWN0LXBhZGRpbmctZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEgQEAKKzIwMApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9p bmxpbmUtYmxvY2svbm9uLW92ZXJsYXktc2Nyb2xsYmFyLWluY29ycmVjdC1wYWRkaW5nLmh0bWwg Yi9MYXlvdXRUZXN0cy9mYXN0L2lubGluZS1ibG9jay9ub24tb3ZlcmxheS1zY3JvbGxiYXItaW5j b3JyZWN0LXBhZGRpbmcuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kNWQ0MTZlOTI5NGQxN2E5YzlmMjFjNDc4 MzQyZGQ5YjA2ZDk4MWE5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9pbmxp bmUtYmxvY2svbm9uLW92ZXJsYXktc2Nyb2xsYmFyLWluY29ycmVjdC1wYWRkaW5nLmh0bWwKQEAg LTAsMCArMSwyNSBAQAorPCFET0NUWVBFIEhUTUw+Cis8c3R5bGU+CisjY29udGFpbmVyIHsKKyAg YmFja2dyb3VuZC1jb2xvcjogYmx1ZTsKKyAgZm9udC1zaXplOiAwcHg7Cit9CisuemVyb19oZWln aHQgeworICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7CisgIG92ZXJmbG93OiBhdXRvOworICBib3Jk ZXI6IDEwMHB4IHNvbGlkIGdyZWVuOworICBoZWlnaHQ6IDBweDsKKyAgd2lkdGg6IDEwMHB4Owor fQorLmNvbnRlbnQgeworICB3aWR0aDogMTAwcHg7CisgIGhlaWdodDogMTAwcHg7Cit9Cis8L3N0 eWxlPgorPGRpdiBpZD1jb250YWluZXI+PGRpdiBjbGFzcz16ZXJvX2hlaWdodD48ZGl2IGNsYXNz PWNvbnRlbnQ+PC9kaXY+PC9kaXY+PC9kaXY+Cis8cHJlIGlkPXJlc3VsdD48L3ByZT4KKzxzY3Jp cHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOwor cmVzdWx0LmlubmVyVGV4dCA9IGNvbnRhaW5lci5vZmZzZXRIZWlnaHQ7Cis8L3NjcmlwdD4K