224541 2021-04-14 04:39:21 -0700 [SOUP] Stop using ResourceResponse::setDeprecatedNetworkLoadMetrics 2021-04-15 08:12:02 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=224608 Gtk P2 Normal --- 1 cgarcia webkit-unassigned aperez bugs-noreply oldest_to_newest 1750075 0 cgarcia 2021-04-14 04:39:21 -0700 We are already providing the metrics via didCompleteWithError() 1750076 1 425970 cgarcia 2021-04-14 04:41:45 -0700 Created attachment 425970 Patch 1750522 2 cgarcia 2021-04-15 01:30:27 -0700 Committed r276008 (236560@main): <https://commits.webkit.org/236560@main> 425970 2021-04-14 04:41:45 -0700 2021-04-14 08:04:40 -0700 Patch wk-deprecated-timing.diff text/plain 5955 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggOTY4Mjg0MGNmOTBhLi44ZDAyMjcyNGRhOTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjQgQEAKKzIwMjEtMDQtMTQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtTT1VQXSBTdG9wIHVzaW5nIFJlc291cmNlUmVzcG9uc2U6OnNl dERlcHJlY2F0ZWROZXR3b3JrTG9hZE1ldHJpY3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDU0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlIGFyZSBhbHJlYWR5IHByb3ZpZGluZyB0aGUgbWV0cmlj cyB2aWEgZGlkQ29tcGxldGVXaXRoRXJyb3IoKS4gQWxzbyBtYWtlIHN1cmUgd2Ugc2V0IGZldGNo U3RhcnQgYW5kIHVzZSBpdAorICAgICAgICBpbnN0ZWFkIG9mIGEgbWVtYmVyLgorCisgICAgICAg ICogTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrRGF0YVRhc2tTb3VwLmNwcDoKKyAgICAgICAg KFdlYktpdDo6TmV0d29ya0RhdGFUYXNrU291cDo6TmV0d29ya0RhdGFUYXNrU291cCk6CisgICAg ICAgIChXZWJLaXQ6Ok5ldHdvcmtEYXRhVGFza1NvdXA6OmRpZFNlbmRSZXF1ZXN0KToKKyAgICAg ICAgKFdlYktpdDo6TmV0d29ya0RhdGFUYXNrU291cDo6ZGlzcGF0Y2hEaWRSZWNlaXZlUmVzcG9u c2UpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrRGF0YVRhc2tTb3VwOjpkaXNwYXRjaERpZENv bXBsZXRlV2l0aEVycm9yKToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya0RhdGFUYXNrU291cDo6 Y29udGludWVIVFRQUmVkaXJlY3Rpb24pOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrRGF0YVRh c2tTb3VwOjpuZXR3b3JrRXZlbnQpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrRGF0YVRhc2tT b3VwOjpkaWRTdGFydFJlcXVlc3QpOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrRGF0YVRhc2tT b3VwOjpkaWRSZXN0YXJ0KToKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtE YXRhVGFza1NvdXAuaDoKKwogMjAyMS0wNC0xMiAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFw ZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdW0dUS10gVXNlIGdfb2JqZWN0X25vdGlm eV9ieV9wc3BlYygpIHdoZW5ldmVyIHBvc3NpYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya0RhdGFUYXNrU291cC5jcHAgYi9Tb3VyY2UvV2Vi S2l0L05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya0RhdGFUYXNrU291cC5jcHAKaW5kZXggYTBh MmEzMGIwOTYwLi5lYjUxOGE0NzdjYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvTmV0d29y a1Byb2Nlc3Mvc291cC9OZXR3b3JrRGF0YVRhc2tTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya0RhdGFUYXNrU291cC5jcHAKQEAgLTY0LDcgKzY0 LDcgQEAgTmV0d29ya0RhdGFUYXNrU291cDo6TmV0d29ya0RhdGFUYXNrU291cChOZXR3b3JrU2Vz c2lvbiYgc2Vzc2lvbiwgTmV0d29ya0RhdGFUYXMKIAogICAgIGF1dG8gcmVxdWVzdCA9IHJlcXVl c3RXaXRoQ3JlZGVudGlhbHM7CiAgICAgaWYgKHJlcXVlc3QudXJsKCkucHJvdG9jb2xJc0luSFRU UEZhbWlseSgpKSB7Ci0gICAgICAgIG1fc3RhcnRUaW1lID0gTW9ub3RvbmljVGltZTo6bm93KCk7 CisgICAgICAgIG1fbmV0d29ya0xvYWRNZXRyaWNzLmZldGNoU3RhcnQgPSBNb25vdG9uaWNUaW1l Ojpub3coKS5zZWNvbmRzU2luY2VFcG9jaCgpOwogICAgICAgICBhdXRvIHVybCA9IHJlcXVlc3Qu dXJsKCk7CiAgICAgICAgIGlmIChtX3N0b3JlZENyZWRlbnRpYWxzUG9saWN5ID09IFN0b3JlZENy ZWRlbnRpYWxzUG9saWN5OjpVc2UpIHsKICAgICAgICAgICAgIG1fdXNlciA9IHVybC51c2VyKCk7 CkBAIC00MDMsNyArNDAzLDcgQEAgdm9pZCBOZXR3b3JrRGF0YVRhc2tTb3VwOjpkaWRTZW5kUmVx dWVzdChHUmVmUHRyPEdJbnB1dFN0cmVhbT4mJiBpbnB1dFN0cmVhbSkKICAgICBlbHNlCiAgICAg ICAgIG1faW5wdXRTdHJlYW0gPSBXVEZNb3ZlKGlucHV0U3RyZWFtKTsKIAotICAgIG1fbmV0d29y a0xvYWRNZXRyaWNzLnJlc3BvbnNlU3RhcnQgPSBNb25vdG9uaWNUaW1lOjpub3coKSAtIG1fc3Rh cnRUaW1lOworICAgIG1fbmV0d29ya0xvYWRNZXRyaWNzLnJlc3BvbnNlU3RhcnQgPSBNb25vdG9u aWNUaW1lOjpub3coKS5zZWNvbmRzU2luY2VFcG9jaCgpIC0gbV9uZXR3b3JrTG9hZE1ldHJpY3Mu ZmV0Y2hTdGFydDsKICAgICBkaXNwYXRjaERpZFJlY2VpdmVSZXNwb25zZSgpOwogfQogCkBAIC00 MjAsOCArNDIwLDYgQEAgdm9pZCBOZXR3b3JrRGF0YVRhc2tTb3VwOjpkaXNwYXRjaERpZFJlY2Vp dmVSZXNwb25zZSgpCiAgICAgdGltaW5nLT5jb25uZWN0RW5kID0gbV9uZXR3b3JrTG9hZE1ldHJp Y3MuY29ubmVjdEVuZDsKICAgICB0aW1pbmctPnJlcXVlc3RTdGFydCA9IG1fbmV0d29ya0xvYWRN ZXRyaWNzLnJlcXVlc3RTdGFydDsKICAgICB0aW1pbmctPnJlc3BvbnNlU3RhcnQgPSBtX25ldHdv cmtMb2FkTWV0cmljcy5yZXNwb25zZVN0YXJ0OwotICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBv bmNlIG5vYm9keSBkZXBlbmRzIG9uIGRlcHJlY2F0ZWROZXR3b3JrTG9hZE1ldHJpY3MuCi0gICAg bV9yZXNwb25zZS5zZXREZXByZWNhdGVkTmV0d29ya0xvYWRNZXRyaWNzKFdURk1vdmUodGltaW5n KSk7CiAKICAgICBkaWRSZWNlaXZlUmVzcG9uc2UoUmVzb3VyY2VSZXNwb25zZShtX3Jlc3BvbnNl KSwgTmVnb3RpYXRlZExlZ2FjeVRMUzo6Tm8sIFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJl ZigqdGhpcyldKFBvbGljeUFjdGlvbiBwb2xpY3lBY3Rpb24pIHsKICAgICAgICAgaWYgKG1fc3Rh dGUgPT0gU3RhdGU6OkNhbmNlbGluZyB8fCBtX3N0YXRlID09IFN0YXRlOjpDb21wbGV0ZWQpIHsK QEAgLTQ1NCw3ICs0NTIsNyBAQCB2b2lkIE5ldHdvcmtEYXRhVGFza1NvdXA6OmRpc3BhdGNoRGlk UmVjZWl2ZVJlc3BvbnNlKCkKIAogdm9pZCBOZXR3b3JrRGF0YVRhc2tTb3VwOjpkaXNwYXRjaERp ZENvbXBsZXRlV2l0aEVycm9yKGNvbnN0IFJlc291cmNlRXJyb3ImIGVycm9yKQogewotICAgIG1f bmV0d29ya0xvYWRNZXRyaWNzLnJlc3BvbnNlRW5kID0gTW9ub3RvbmljVGltZTo6bm93KCkgLSBt X3N0YXJ0VGltZTsKKyAgICBtX25ldHdvcmtMb2FkTWV0cmljcy5yZXNwb25zZUVuZCA9IE1vbm90 b25pY1RpbWU6Om5vdygpLnNlY29uZHNTaW5jZUVwb2NoKCkgLSBtX25ldHdvcmtMb2FkTWV0cmlj cy5mZXRjaFN0YXJ0OwogICAgIG1fbmV0d29ya0xvYWRNZXRyaWNzLm1hcmtDb21wbGV0ZSgpOwog CiAgICAgbV9jbGllbnQtPmRpZENvbXBsZXRlV2l0aEVycm9yKGVycm9yLCBtX25ldHdvcmtMb2Fk TWV0cmljcyk7CkBAIC04MjMsOCArODIxLDggQEAgdm9pZCBOZXR3b3JrRGF0YVRhc2tTb3VwOjpj b250aW51ZUhUVFBSZWRpcmVjdGlvbigpCiAgICAgICAgIGF1dG8gcmVxdWVzdCA9IG5ld1JlcXVl c3Q7CiAgICAgICAgIGlmIChyZXF1ZXN0LnVybCgpLnByb3RvY29sSXNJbkhUVFBGYW1pbHkoKSkg ewogICAgICAgICAgICAgaWYgKGlzQ3Jvc3NPcmlnaW4pIHsKLSAgICAgICAgICAgICAgICBtX3N0 YXJ0VGltZSA9IE1vbm90b25pY1RpbWU6Om5vdygpOwogICAgICAgICAgICAgICAgIG1fbmV0d29y a0xvYWRNZXRyaWNzID0geyB9OworICAgICAgICAgICAgICAgIG1fbmV0d29ya0xvYWRNZXRyaWNz LmZldGNoU3RhcnQgPSBNb25vdG9uaWNUaW1lOjpub3coKS5zZWNvbmRzU2luY2VFcG9jaCgpOwog ICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBhcHBseUF1dGhlbnRpY2F0aW9uVG9SZXF1ZXN0 KHJlcXVlc3QpOwpAQCAtMTE4Niw3ICsxMTg0LDcgQEAgdm9pZCBOZXR3b3JrRGF0YVRhc2tTb3Vw OjpuZXR3b3JrRXZlbnRDYWxsYmFjayhTb3VwTWVzc2FnZSogc291cE1lc3NhZ2UsIEdTb2NrZXQK IAogdm9pZCBOZXR3b3JrRGF0YVRhc2tTb3VwOjpuZXR3b3JrRXZlbnQoR1NvY2tldENsaWVudEV2 ZW50IGV2ZW50LCBHSU9TdHJlYW0qIHN0cmVhbSkKIHsKLSAgICBTZWNvbmRzIGRlbHRhVGltZSA9 IE1vbm90b25pY1RpbWU6Om5vdygpIC0gbV9zdGFydFRpbWU7CisgICAgU2Vjb25kcyBkZWx0YVRp bWUgPSBNb25vdG9uaWNUaW1lOjpub3coKS5zZWNvbmRzU2luY2VFcG9jaCgpIC0gbV9uZXR3b3Jr TG9hZE1ldHJpY3MuZmV0Y2hTdGFydDsKICAgICBzd2l0Y2ggKGV2ZW50KSB7CiAgICAgY2FzZSBH X1NPQ0tFVF9DTElFTlRfUkVTT0xWSU5HOgogICAgICAgICBtX25ldHdvcmtMb2FkTWV0cmljcy5k b21haW5Mb29rdXBTdGFydCA9IGRlbHRhVGltZTsKQEAgLTEyNzcsNyArMTI3NSw3IEBAIHZvaWQg TmV0d29ya0RhdGFUYXNrU291cDo6aHN0c0VuZm9yY2VkKFNvdXBNZXNzYWdlKiBzb3VwTWVzc2Fn ZSwgTmV0d29ya0RhdGFUYXNrCiAKIHZvaWQgTmV0d29ya0RhdGFUYXNrU291cDo6ZGlkU3RhcnRS ZXF1ZXN0KCkKIHsKLSAgICBtX25ldHdvcmtMb2FkTWV0cmljcy5yZXF1ZXN0U3RhcnQgPSBNb25v dG9uaWNUaW1lOjpub3coKSAtIG1fc3RhcnRUaW1lOworICAgIG1fbmV0d29ya0xvYWRNZXRyaWNz LnJlcXVlc3RTdGFydCA9IE1vbm90b25pY1RpbWU6Om5vdygpLnNlY29uZHNTaW5jZUVwb2NoKCkg LSBtX25ldHdvcmtMb2FkTWV0cmljcy5mZXRjaFN0YXJ0OwogfQogCiB2b2lkIE5ldHdvcmtEYXRh VGFza1NvdXA6OnJlc3RhcnRlZENhbGxiYWNrKFNvdXBNZXNzYWdlKiBzb3VwTWVzc2FnZSwgTmV0 d29ya0RhdGFUYXNrU291cCogdGFzaykKQEAgLTEyOTMsOCArMTI5MSw4IEBAIHZvaWQgTmV0d29y a0RhdGFUYXNrU291cDo6cmVzdGFydGVkQ2FsbGJhY2soU291cE1lc3NhZ2UqIHNvdXBNZXNzYWdl LCBOZXR3b3JrRGF0CiAKIHZvaWQgTmV0d29ya0RhdGFUYXNrU291cDo6ZGlkUmVzdGFydCgpCiB7 Ci0gICAgbV9zdGFydFRpbWUgPSBNb25vdG9uaWNUaW1lOjpub3coKTsKICAgICBtX25ldHdvcmtM b2FkTWV0cmljcyA9IHsgfTsKKyAgICBtX25ldHdvcmtMb2FkTWV0cmljcy5mZXRjaFN0YXJ0ID0g TW9ub3RvbmljVGltZTo6bm93KCkuc2Vjb25kc1NpbmNlRXBvY2goKTsKICNpZiAhVVNFKFNPVVAy KQogICAgIG1fY3VycmVudFJlcXVlc3QudXBkYXRlU291cE1lc3NhZ2VCb2R5KG1fc291cE1lc3Nh Z2UuZ2V0KCksIG1fc2Vzc2lvbi0+YmxvYlJlZ2lzdHJ5KCkpOwogI2VuZGlmCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya0RhdGFUYXNrU291cC5o IGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtEYXRhVGFza1NvdXAu aAppbmRleCA1YWM2ZGQzOTViNDkuLjFhOTZmYjA0OTFiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtEYXRhVGFza1NvdXAuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya0RhdGFUYXNrU291cC5oCkBAIC0x ODUsNyArMTg1LDYgQEAgcHJpdmF0ZToKICAgICBHUmVmUHRyPEdPdXRwdXRTdHJlYW0+IG1fZG93 bmxvYWRPdXRwdXRTdHJlYW07CiAgICAgYm9vbCBtX2FsbG93T3ZlcndyaXRlRG93bmxvYWQgeyBm YWxzZSB9OwogICAgIFdlYkNvcmU6Ok5ldHdvcmtMb2FkTWV0cmljcyBtX25ldHdvcmtMb2FkTWV0 cmljczsKLSAgICBNb25vdG9uaWNUaW1lIG1fc3RhcnRUaW1lOwogICAgIGJvb2wgbV9pc0Jsb2Nr aW5nQ29va2llcyB7IGZhbHNlIH07CiAgICAgUnVuTG9vcDo6VGltZXI8TmV0d29ya0RhdGFUYXNr U291cD4gbV90aW1lb3V0U291cmNlOwogfTsK