224539 2021-04-14 03:54:35 -0700 Remove a no longer necessary callOnMainThread in Worker::createRTCRtpScriptTransformer 2021-04-16 01:39:25 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf darin eric.carlson webkit-bug-importer youennf oldest_to_newest 1750069 0 youennf 2021-04-14 03:54:35 -0700 Remove a no longer necessary callOnMainThread in Worker::createRTCRtpScriptTransformer 1750070 1 425968 youennf 2021-04-14 03:55:58 -0700 Created attachment 425968 Patch 1750525 2 webkit-bug-importer 2021-04-15 01:43:37 -0700 <rdar://problem/76691688> 1750637 3 425968 darin 2021-04-15 08:57:03 -0700 Comment on attachment 425968 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425968&action=review > Source/WebCore/ChangeLog:8 > + No chnage of behavior. Spelling error in "change" and I would just leave this out. (The important comment here is the one pointing to DestructionThread::Main below and anything else is a distraction.) 1750657 4 426114 youennf 2021-04-15 10:05:50 -0700 Created attachment 426114 Patch for landing 1750658 5 youennf 2021-04-15 10:06:29 -0700 Thanks for the review. (In reply to Darin Adler from comment #3) > Comment on attachment 425968 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=425968&action=review > > > Source/WebCore/ChangeLog:8 > > + No chnage of behavior. > > Spelling error in "change" and I would just leave this out. (The important > comment here is the one pointing to DestructionThread::Main below and > anything else is a distraction.) Removed it. 1750980 6 ews-feeder 2021-04-16 01:39:24 -0700 Committed r276124 (236620@main): <https://commits.webkit.org/236620@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426114. 425968 2021-04-14 03:55:58 -0700 2021-04-15 10:05:45 -0700 Patch bug-224539-20210414125555.patch text/plain 1597 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1ODcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODcxOWFmNDI5OGMwOGY0 NDE4Yzg1MTE1N2NlZTg2ZGRjOTE1MGRhNy4uODVjOWQ2Nzc1ZjM4NTNlMmYzMzEwMTRjYzQ2NWQ2 MjY1MjVlZTc2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA0LTE0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgYSBubyBsb25n ZXIgbmVjZXNzYXJ5IGNhbGxPbk1haW5UaHJlYWQgaW4gV29ya2VyOjpjcmVhdGVSVENSdHBTY3Jp cHRUcmFuc2Zvcm1lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjI0NTM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgTm8gY2huYWdlIG9mIGJlaGF2aW9yLgorCisgICAgICAgICogd29ya2Vycy9Xb3JrZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyOjpjcmVhdGVSVENSdHBTY3JpcHRUcmFuc2Zv cm1lcik6CisgICAgICAgIFRocmVhZFNhZmVSZWZDb3VudGVkIGFscmVhZHkgaGFuZGxlcyBpdCB3 aXRoIHRoZSBEZXN0cnVjdGlvblRocmVhZDo6TWFpbiBvcHRpb24uCisKIDIwMjEtMDQtMTQgIFlv dWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEJsb2IgVVJMcyBzaG91 bGQgdXNlIGZvciB0aGVpciBvd25lciBvcmlnaW4gZm9yIENTUCBjaGVja3MKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtl cnMvV29ya2VyLmNwcAppbmRleCA2YTRmOTIyN2M0MGY5ODU0NjkzYTY2MjJjYmE3NmE0OTY1YTE2 N2M1Li4yYjFhODE2YWJmNjhkMWYyZGY4YmIwNTJlYWFiOWZkNjUwMTNjYzIyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv d29ya2Vycy9Xb3JrZXIuY3BwCkBAIC0yNTcsNyArMjU3LDYgQEAgdm9pZCBXb3JrZXI6OmNyZWF0 ZVJUQ1J0cFNjcmlwdFRyYW5zZm9ybWVyKFJUQ1J0cFNjcmlwdFRyYW5zZm9ybSYgdHJhbnNmb3Jt LCBNZXMKICAgICBtX2NvbnRleHRQcm94eS5wb3N0VGFza1RvV29ya2VyR2xvYmFsU2NvcGUoW3Ry YW5zZm9ybSA9IG1ha2VSZWYodHJhbnNmb3JtKSwgb3B0aW9ucyA9IFdURk1vdmUob3B0aW9ucyld KGF1dG8mIGNvbnRleHQpIG11dGFibGUgewogICAgICAgICBpZiAoYXV0byB0cmFuc2Zvcm1lciA9 IGRvd25jYXN0PERlZGljYXRlZFdvcmtlckdsb2JhbFNjb3BlPihjb250ZXh0KS5jcmVhdGVSVENS dHBTY3JpcHRUcmFuc2Zvcm1lcihXVEZNb3ZlKG9wdGlvbnMpKSkKICAgICAgICAgICAgIHRyYW5z Zm9ybS0+c2V0VHJhbnNmb3JtZXIoKnRyYW5zZm9ybWVyKTsKLSAgICAgICAgY2FsbE9uTWFpblRo cmVhZChbdHJhbnNmb3JtID0gV1RGTW92ZSh0cmFuc2Zvcm0pXSB7IH0pOwogICAgIH0pOwogCiB9 Cg== 426114 2021-04-15 10:05:50 -0700 2021-04-16 01:39:25 -0700 Patch for landing bug-224539-20210415190548.patch text/plain 1550 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTQ3ZjQ2OWZhYzFiMjIy MTRlMzJhNjAyMjY1ODA2ZDk1NGU3MzVjOC4uZThiYzc2ZTJmZjJiOTc0OTM1ZjIyOTYzMzdhMDQ2 MTBjNzUyZDgyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA0LTE1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgYSBubyBsb25n ZXIgbmVjZXNzYXJ5IGNhbGxPbk1haW5UaHJlYWQgaW4gV29ya2VyOjpjcmVhdGVSVENSdHBTY3Jp cHRUcmFuc2Zvcm1lcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjI0NTM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAg ICAgKiB3b3JrZXJzL1dvcmtlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXI6OmNyZWF0 ZVJUQ1J0cFNjcmlwdFRyYW5zZm9ybWVyKToKKyAgICAgICAgVGhyZWFkU2FmZVJlZkNvdW50ZWQg YWxyZWFkeSBoYW5kbGVzIGl0IHdpdGggdGhlIERlc3RydWN0aW9uVGhyZWFkOjpNYWluIG9wdGlv bi4KKwogMjAyMS0wNC0xNSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAg ICAgICAgVXBkYXRlIFJUQ1NjcmlwdFRyYW5zZm9ybSBjb25zdHJ1Y3RvciB1cCB0byBzcGVjCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS93b3JrZXJzL1dvcmtlci5jcHAKaW5kZXggNmE0ZjkyMjdjNDBmOTg1NDY5M2E2NjIyY2Jh NzZhNDk2NWExNjdjNS4uMmIxYTgxNmFiZjY4ZDFmMmRmOGJiMDUyZWFhYjlmZDY1MDEzY2MyMiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyLmNwcApAQCAtMjU3LDcgKzI1Nyw2IEBAIHZvaWQgV29y a2VyOjpjcmVhdGVSVENSdHBTY3JpcHRUcmFuc2Zvcm1lcihSVENSdHBTY3JpcHRUcmFuc2Zvcm0m IHRyYW5zZm9ybSwgTWVzCiAgICAgbV9jb250ZXh0UHJveHkucG9zdFRhc2tUb1dvcmtlckdsb2Jh bFNjb3BlKFt0cmFuc2Zvcm0gPSBtYWtlUmVmKHRyYW5zZm9ybSksIG9wdGlvbnMgPSBXVEZNb3Zl KG9wdGlvbnMpXShhdXRvJiBjb250ZXh0KSBtdXRhYmxlIHsKICAgICAgICAgaWYgKGF1dG8gdHJh bnNmb3JtZXIgPSBkb3duY2FzdDxEZWRpY2F0ZWRXb3JrZXJHbG9iYWxTY29wZT4oY29udGV4dCku Y3JlYXRlUlRDUnRwU2NyaXB0VHJhbnNmb3JtZXIoV1RGTW92ZShvcHRpb25zKSkpCiAgICAgICAg ICAgICB0cmFuc2Zvcm0tPnNldFRyYW5zZm9ybWVyKCp0cmFuc2Zvcm1lcik7Ci0gICAgICAgIGNh bGxPbk1haW5UaHJlYWQoW3RyYW5zZm9ybSA9IFdURk1vdmUodHJhbnNmb3JtKV0geyB9KTsKICAg ICB9KTsKIAogfQo=