224534 2021-04-14 01:22:19 -0700 [GTK4] Use a while loop in PlatformWebView::dismissAllPopupMenus() 2021-04-14 05:12:40 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply pnormand webkit-bug-importer oldest_to_newest 1750045 0 cgarcia 2021-04-14 01:22:19 -0700 The child might be destroyed during the loop iteration. Using a while loop we ensure we get the next sibling before the current child is destroyed. 1750046 1 425960 cgarcia 2021-04-14 01:25:21 -0700 Created attachment 425960 [fast-cq] Patch 1750058 2 ews-feeder 2021-04-14 03:03:18 -0700 Committed r275940 (236502@main): <https://commits.webkit.org/236502@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425960. 1750060 3 webkit-bug-importer 2021-04-14 03:04:14 -0700 <rdar://problem/76637108> 1750080 4 425960 cgarcia 2021-04-14 05:12:40 -0700 Comment on attachment 425960 [fast-cq] Patch I tried fast-cq because I thought it hadn't landed when I saw the cq-. Clearing flags to avoid more confusion 425960 2021-04-14 01:25:21 -0700 2021-04-14 05:12:40 -0700 [fast-cq] Patch wkgtk4-crash.diff text/plain 1617 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMDQw MTAxMjJiNjYuLjljZjI1NDA3ODYzYiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA0LTE0ICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLNF0gVXNlIGEg d2hpbGUgbG9vcCBpbiBQbGF0Zm9ybVdlYlZpZXc6OmRpc21pc3NBbGxQb3B1cE1lbnVzKCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDUzNAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBjaGlsZCBt aWdodCBiZSBkZXN0cm95ZWQgZHVyaW5nIHRoZSBsb29wIGl0ZXJhdGlvbi4gVXNpbmcgYSB3aGls ZSBsb29wIHdlIGVuc3VyZSB3ZSBnZXQgdGhlIG5leHQgc2libGluZworICAgICAgICBiZWZvcmUg dGhlIGN1cnJlbnQgY2hpbGQgaXMgZGVzdHJveWVkLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1 bm5lci9ndGsvUGxhdGZvcm1XZWJWaWV3R3RrLmNwcDoKKyAgICAgICAgKFdUUjo6UGxhdGZvcm1X ZWJWaWV3OjpkaXNtaXNzQWxsUG9wdXBNZW51cyk6CisKIDIwMjEtMDQtMTEgIENvbW1pdCBRdWV1 ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVy dGluZyByMjc1ODAxLgpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvUGxh dGZvcm1XZWJWaWV3R3RrLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1BsYXRmb3Jt V2ViVmlld0d0ay5jcHAKaW5kZXggZjZlM2I3N2ZiYWNmLi5iOGEwYzMxZmJjMDMgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1BsYXRmb3JtV2ViVmlld0d0ay5jcHAKKysr IGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvUGxhdGZvcm1XZWJWaWV3R3RrLmNwcApAQCAt MjQ4LDkgKzI0OCwxMyBAQCB2b2lkIFBsYXRmb3JtV2ViVmlldzo6ZGlkSW5pdGlhbGl6ZUNsaWVu dHMoKQogdm9pZCBQbGF0Zm9ybVdlYlZpZXc6OmRpc21pc3NBbGxQb3B1cE1lbnVzKCkKIHsKICNp ZiBVU0UoR1RLNCkKLSAgICBmb3IgKGF1dG8qIGNoaWxkID0gZ3RrX3dpZGdldF9nZXRfZmlyc3Rf Y2hpbGQoR1RLX1dJREdFVChtX3ZpZXcpKTsgY2hpbGQ7IGNoaWxkID0gZ3RrX3dpZGdldF9nZXRf bmV4dF9zaWJsaW5nKGNoaWxkKSkgeworICAgIGF1dG8qIGNoaWxkID0gZ3RrX3dpZGdldF9nZXRf Zmlyc3RfY2hpbGQoR1RLX1dJREdFVChtX3ZpZXcpKTsKKyAgICB3aGlsZSAoY2hpbGQpIHsKKyAg ICAgICAgYXV0byogbmV4dCA9IGd0a193aWRnZXRfZ2V0X25leHRfc2libGluZyhjaGlsZCk7CiAg ICAgICAgIGlmIChHVEtfSVNfUE9QT1ZFUihjaGlsZCkpCiAgICAgICAgICAgICBndGtfd2lkZ2V0 X2hpZGUoY2hpbGQpOworCisgICAgICAgIGNoaWxkID0gbmV4dDsKICAgICB9CiAjZWxzZQogICAg IC8vIGd0a19tZW51X3BvcGRvd24gZG9lc24ndCBtb2RpZnkgdGhlIEdMaXN0IG9mIGF0dGFjaGVk IG1lbnVzLCBzbyBpdCBzaG91bGQK