224526 2021-04-13 20:55:17 -0700 Disable hardware JPEG decoding on x86 Mac for WK1 2021-05-05 12:36:27 -0700 1 1 1 Unclassified WebKit Images WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID https://bugs.webkit.org/show_bug.cgi?id=216377 InRadar P2 Normal --- 1 sabouhallawa sabouhallawa sam webkit-bug-importer oldest_to_newest 1749988 0 sabouhallawa 2021-04-13 20:55:17 -0700 Similar to bug 216377, we need to disable hardware JPEG decoding on x86 Mac for WK1 also. Some of the pre-installed apps, which use WK1, have experienced perf regression because of hardware JPEG decoding. WebKit does not own the decision whether an image is worth hardware decoding or not. This decision depends on heuristics which are run by system underlying frameworks. 1749993 1 sabouhallawa 2021-04-13 21:05:00 -0700 <rdar://74939829> 1749994 2 425948 sabouhallawa 2021-04-13 21:09:11 -0700 Created attachment 425948 Patch 1750450 3 425948 sam 2021-04-14 19:40:04 -0700 Comment on attachment 425948 Patch Will this disable it for the whole process? Or just WebKit’s uses? 1750880 4 sabouhallawa 2021-04-15 18:29:08 -0700 I think it will disable if for the whole process. The image decoding happens underneath WebKit. The only way to disable the HW decoding is do this globally. Do you think there will be a problem with doing this? 1751445 5 425948 sam 2021-04-17 12:03:14 -0700 Comment on attachment 425948 Patch You need to do this without effecting the whole process. Loading WebKit should not change the behavior of code / frameworks that happen to be running in the same app. 1751446 6 sam 2021-04-17 12:04:03 -0700 (In reply to Said Abou-Hallawa from comment #4) > I think it will disable if for the whole process. The image decoding happens > underneath WebKit. The only way to disable the HW decoding is do this > globally. Do you think there will be a problem with doing this? Yep. We really can't do that. You will need to ask for API/SPI to disable it on a per-call basis. 1757036 7 sabouhallawa 2021-05-05 12:36:27 -0700 (In reply to Sam Weinig from comment #6) > (In reply to Said Abou-Hallawa from comment #4) > > I think it will disable if for the whole process. The image decoding happens > > underneath WebKit. The only way to disable the HW decoding is do this > > globally. Do you think there will be a problem with doing this? > > Yep. We really can't do that. You will need to ask for API/SPI to disable it > on a per-call basis. I agree. I think the approach of this patch is incorrect. 425948 2021-04-13 21:09:11 -0700 2021-04-17 12:03:14 -0700 Patch bug-224526-20210413210910.patch text/plain 2153 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1ODkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggY2I3MThkZGQ0OWJlNTcwNDBiZjY2M2RlNGFkMGE1OGNlZGM1YmM2Mi4uMWZmNTk0NDMwYmE0 ZmQ2ZjlhZjA1ZTYzM2UzMzA2ODk5YmVjNThiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA0LTEzICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhaWRA YXBwbGUuY29tPgorCisgICAgICAgIERpc2FibGUgaGFyZHdhcmUgSlBFRyBkZWNvZGluZyBvbiB4 ODYgTWFjIGZvciBXSzEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyNDUyNgorICAgICAgICA8cmRhcjovLzc0OTM5ODI5PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvbWUgcHJlLWluc3RhbGxlZCBhcHBz LCB3aGljaCB1c2UgV0sxLCBoYXZlIGV4cGVyaWVuY2VkIGEgbm90aWNlYWJsZSBwZXJmCisgICAg ICAgIHJlZ3Jlc3Npb24gYmVjYXVzZSBvZiBoYXJkd2FyZSBKUEVHIGRlY29kaW5nLgorCisgICAg ICAgIEZvciBub3csIHdlJ3JlIG1pbWlja2luZyB0aGUgV0syIG9mIG5vdCB1c2luZyBoYXJkd2Fy ZSBKUEVHIG9uIHg4NiBNYWNzCisgICAgICAgIGJ5IGNhbGxpbmcgYSBNZWRpYVRvb2xib3ggU1BJ LgorCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IF9j b21tb25Jbml0aWFsaXphdGlvbldpdGhGcmFtZU5hbWU6Z3JvdXBOYW1lOl0pOgorCiAyMDIxLTA0 LTEyICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHNvbWUg aXNzdWVzIGhpZGRlbiBieSB1bmlmaWVkIGJ1aWxkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9X ZWJWaWV3L1dlYlZpZXcubW0KaW5kZXggNWIwZWU4YTNhYzhjMzMzYjZlZTM0NGNkZDljM2I1NTc2 NWMyNmZmMC4uNDFlYWNiMTg3YWM1NTM5YzA1NTdkYzY2NWYyYTQ0ZmY5M2I2OWZhOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCisrKyBiL1Nv dXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQpAQCAtMjMzLDYgKzIzMyw3 IEBACiAjaW1wb3J0IDxXZWJLaXRMZWdhY3kvRE9NUHJpdmF0ZS5oPgogI2ltcG9ydCA8bWFjaC1v L2R5bGQuaD4KICNpbXBvcnQgPG9iamMvcnVudGltZS5oPgorI2ltcG9ydCA8cGFsL2NvY29hL01l ZGlhVG9vbGJveFNvZnRMaW5rLmg+CiAjaW1wb3J0IDxwYWwvc3BpL2NmL0NGTmV0d29ya1NQSS5o PgogI2ltcG9ydCA8cGFsL3NwaS9jZi9DRlV0aWxpdGllc1NQSS5oPgogI2ltcG9ydCA8cGFsL3Nw aS9jZy9Db3JlR3JhcGhpY3NTUEkuaD4KQEAgLTE2NzYsNiArMTY3NywxMSBAQCBzdGF0aWMgdm9p ZCBXZWJLaXRJbml0aWFsaXplR2FtZXBhZFByb3ZpZGVySWZOZWNlc3NhcnkoKQogCiAgICAgV1RG OjpsaXN0ZW5Gb3JMYW5ndWFnZUNoYW5nZU5vdGlmaWNhdGlvbnMoKTsKICNlbmRpZiAvLyBQTEFU Rk9STShNQUMpCisgICAgCisjaWYgSEFWRShGSUdfUEhPVE9fREVDT01QUkVTU0lPTl9TRVRfSEFS RFdBUkVfQ1VUT0ZGKSAmJiAhRU5BQkxFKEhBUkRXQVJFX0pQRUcpCisgICAgaWYgKFBBTDo6aXNN ZWRpYVRvb2xib3hGcmFtZXdvcmtBdmFpbGFibGUoKSAmJiBQQUw6OmNhbkxvYWRfTWVkaWFUb29s Ym94X0ZpZ1Bob3RvRGVjb21wcmVzc2lvblNldEhhcmR3YXJlQ3V0b2ZmKCkpCisgICAgICAgIFBB TDo6c29mdExpbmtNZWRpYVRvb2xib3hGaWdQaG90b0RlY29tcHJlc3Npb25TZXRIYXJkd2FyZUN1 dG9mZihrUEFMRmlnUGhvdG9Db250YWluZXJGb3JtYXRfSkZJRiwgSU5UX01BWCk7CisjZW5kaWYK IH0KIAogLSAoaWQpX2luaXRXaXRoRnJhbWU6KE5TUmVjdClmIGZyYW1lTmFtZTooTlNTdHJpbmcg KilmcmFtZU5hbWUgZ3JvdXBOYW1lOihOU1N0cmluZyAqKWdyb3VwTmFtZQo=