224518 2021-04-13 16:43:44 -0700 Nullptr deref in CompositeEditCommand::isRemovableBlock in DeleteSelectionCommand::removeRedundantBlocks 2021-04-16 17:57:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 iang webkit-unassigned ews-watchlist mifenton rniwa webkit-bug-importer oldest_to_newest 1749932 0 iang 2021-04-13 16:43:44 -0700 removeRedundantBlocks() may run into a null pointer while iterating over the tree, if the tree is unexpectedly modified during the execution of a command. Adding null check to quit this step if a parent node cannot be resolved. 1749933 1 iang 2021-04-13 16:44:14 -0700 <rdar://problem/76264118> 1749940 2 425933 iang 2021-04-13 17:08:43 -0700 Created attachment 425933 Patch 1749966 3 425933 rniwa 2021-04-13 18:26:45 -0700 Comment on attachment 425933 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425933&action=review > Source/WebCore/editing/DeleteSelectionCommand.cpp:869 > + RefPtr<Node> node = makeRefPtr(m_endingPosition.containerNode()); > + RefPtr<Node> rootNode = makeRefPtr(node->rootEditableElement()); Use auto? > Source/WebCore/editing/DeleteSelectionCommand.cpp:871 > + while (node && (node != rootNode)) { We don't usually nest parentheses like this. > Source/WebCore/editing/DeleteSelectionCommand.cpp:877 > - node = m_endingPosition.anchorNode(); > + node = makeRefPtr(m_endingPosition.anchorNode()); No need to call makeRefPtr since node is already of type RefPtr<Node>. > Source/WebCore/editing/DeleteSelectionCommand.cpp:879 > - node = node->parentNode(); > + node = makeRefPtr(node->parentNode()); Ditto. > LayoutTests/editing/execCommand/remove-node-during-command-crash.html:24 > + document.write('PASS') Missing semicolon at the end. Also, can we say that this test passes if WebKit doesn't crash? 1750842 4 426154 iang 2021-04-15 16:49:41 -0700 Created attachment 426154 Patch 1750844 5 iang 2021-04-15 16:53:39 -0700 Tried to add the text to the test body saying the test passes if it doesn't crash but it either would stop the test from reproducing, or would get eaten by the command. Hopefully that is appropriate. 1750848 6 426154 rniwa 2021-04-15 16:56:42 -0700 Comment on attachment 426154 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426154&action=review > Source/WebCore/ChangeLog:3 > + Editing null pointer dereference while resolving command I've just renamed the bug. Please update the title here. It's overly generic. Sorry I didn't notice earlier. > LayoutTests/ChangeLog:3 > + Editing null pointer dereference while resolving command Ditto. > LayoutTests/ChangeLog:8 > + Add regression test. Nit: Add *a* regression test. 1751216 7 426267 iang 2021-04-16 13:35:51 -0700 Created attachment 426267 Patch 1751218 8 rniwa 2021-04-16 13:37:40 -0700 Let's at least wait for the stress EWS to make sure the new test isn't flaky, etc... 1751345 9 ews-feeder 2021-04-16 17:57:30 -0700 Committed r276186 (236668@main): <https://commits.webkit.org/236668@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426267. 425933 2021-04-13 17:08:43 -0700 2021-04-15 16:49:39 -0700 Patch bug-224518-20210413170842.patch text/plain 4429 iang U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1MzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTBjNDViNmMwODM5Y2U1 Y2QxOTAwNDhlMDEwZDNiZTE5YzQyOWE0MC4uNGY2MGQ4NDA3NDY4ZDEwZWYzZTAyNTFhNDQ2ZDAz NTEwZWE0ZTI4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA0LTEzICBJYW4g R2lsYmVydCAgPGlhbmdAYXBwbGUuY29tPgorCisgICAgICAgIEVkaXRpbmcgbnVsbCBwb2ludGVy IGRlcmVmZXJlbmNlIHdoaWxlIHJlc29sdmluZyBjb21tYW5kCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ1MTgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbnVsbCBjaGVjayBpbiBjYXNlIG5vZGUg aXMgcmVtb3ZlZCB3aGlsZSBpdGVyYXRpbmcgb3ZlciB0cmVlLgorCisgICAgICAgIFRlc3Q6IGVk aXRpbmcvZXhlY0NvbW1hbmQvcmVtb3ZlLW5vZGUtZHVyaW5nLWNvbW1hbmQtY3Jhc2guaHRtbAor CisgICAgICAgICogZWRpdGluZy9EZWxldGVTZWxlY3Rpb25Db21tYW5kLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkRlbGV0ZVNlbGVjdGlvbkNvbW1hbmQ6OnJlbW92ZVJlZHVuZGFudEJsb2Nrcyk6 CisKIDIwMjEtMDQtMDEgIFJvYiBCdWlzICA8cmJ1aXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBh c3BlY3QtcmF0aW8gbm90IHJlY29tcHV0ZWQgb24gaG92ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvRGVsZXRlU2VsZWN0aW9uQ29tbWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9lZGl0aW5nL0RlbGV0ZVNlbGVjdGlvbkNvbW1hbmQuY3BwCmluZGV4IGQyMzEwY2QyOGE1MGJl YzlkNGE2ZDA0MjJlZTJmY2YyMThhMjcyY2UuLjY2MjhiNzcwYTI4NzI3MDNlZjAwYmI1Yjg1Yzk3 YzMyNjY2ZTBlZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRGVsZXRlU2Vs ZWN0aW9uQ29tbWFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVTZWxl Y3Rpb25Db21tYW5kLmNwcApAQCAtODY1LDE4ICs4NjUsMTggQEAgU3RyaW5nIERlbGV0ZVNlbGVj dGlvbkNvbW1hbmQ6Om9yaWdpbmFsU3RyaW5nRm9yQXV0b2NvcnJlY3Rpb25BdEJlZ2lubmluZ09m U2VsZWMKIC8vIFRoaXMgbWV0aG9kIHJlbW92ZXMgZGl2IGVsZW1lbnRzIHdpdGggbm8gYXR0cmli dXRlcyB0aGF0IGhhdmUgb25seSBvbmUgY2hpbGQgb3Igbm8gY2hpbGRyZW4gYXQgYWxsLgogdm9p ZCBEZWxldGVTZWxlY3Rpb25Db21tYW5kOjpyZW1vdmVSZWR1bmRhbnRCbG9ja3MoKQogewotICAg IE5vZGUqIG5vZGUgPSBtX2VuZGluZ1Bvc2l0aW9uLmNvbnRhaW5lck5vZGUoKTsKLSAgICBOb2Rl KiByb290Tm9kZSA9IG5vZGUtPnJvb3RFZGl0YWJsZUVsZW1lbnQoKTsKKyAgICBSZWZQdHI8Tm9k ZT4gbm9kZSA9IG1ha2VSZWZQdHIobV9lbmRpbmdQb3NpdGlvbi5jb250YWluZXJOb2RlKCkpOwor ICAgIFJlZlB0cjxOb2RlPiByb290Tm9kZSA9IG1ha2VSZWZQdHIobm9kZS0+cm9vdEVkaXRhYmxl RWxlbWVudCgpKTsKICAgIAotICAgIHdoaWxlIChub2RlICE9IHJvb3ROb2RlKSB7Ci0gICAgICAg IGlmIChpc1JlbW92YWJsZUJsb2NrKG5vZGUpKSB7CisgICAgd2hpbGUgKG5vZGUgJiYgKG5vZGUg IT0gcm9vdE5vZGUpKSB7CisgICAgICAgIGlmIChpc1JlbW92YWJsZUJsb2NrKG5vZGUuZ2V0KCkp KSB7CiAgICAgICAgICAgICBpZiAobm9kZSA9PSBtX2VuZGluZ1Bvc2l0aW9uLmFuY2hvck5vZGUo KSkKICAgICAgICAgICAgICAgICB1cGRhdGVQb3NpdGlvbkZvck5vZGVSZW1vdmFsUHJlc2Vydmlu Z0NoaWxkcmVuKG1fZW5kaW5nUG9zaXRpb24sICpub2RlKTsKICAgICAgICAgICAgIAogICAgICAg ICAgICAgQ29tcG9zaXRlRWRpdENvbW1hbmQ6OnJlbW92ZU5vZGVQcmVzZXJ2aW5nQ2hpbGRyZW4o Km5vZGUpOwotICAgICAgICAgICAgbm9kZSA9IG1fZW5kaW5nUG9zaXRpb24uYW5jaG9yTm9kZSgp OworICAgICAgICAgICAgbm9kZSA9IG1ha2VSZWZQdHIobV9lbmRpbmdQb3NpdGlvbi5hbmNob3JO b2RlKCkpOwogICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgIG5vZGUgPSBub2RlLT5wYXJlbnRO b2RlKCk7CisgICAgICAgICAgICBub2RlID0gbWFrZVJlZlB0cihub2RlLT5wYXJlbnROb2RlKCkp OwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDgwNjY1Zjc4NTE1MDM0ZjE5ZDExOTQxODMyMTA3ZjJhNWJj MTczNTkuLjc0ODA5OWI2ZmQwYmU4ZmM5NDU0MGZmNjYzNDU0Y2M4YmFjNjY5OGUgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAyMS0wNC0xMyAgSWFuIEdpbGJlcnQgIDxpYW5nQGFwcGxlLmNvbT4K KworICAgICAgICBFZGl0aW5nIG51bGwgcG9pbnRlciBkZXJlZmVyZW5jZSB3aGlsZSByZXNvbHZp bmcgY29tbWFuZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjI0NTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBlZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1ub2RlLWR1cmluZy1jb21tYW5kLWNyYXNo LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9leGVjQ29tbWFuZC9yZW1v dmUtbm9kZS1kdXJpbmctY29tbWFuZC1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAyMS0wNC0wMSAg Q2hyaXMgR2FtYnJlbGwgIDxjZ2FtYnJlbGxAYXBwbGUuY29tPgogCiAgICAgICAgIExheW91dFRl c3RzXSBDb252ZXJ0IGh0dHAvdGVzdHMvZG93bmxvYWQgY29udmVydCBQSFAgdG8gUHl0aG9uCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1ub2RlLWR1 cmluZy1jb21tYW5kLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvZXhl Y0NvbW1hbmQvcmVtb3ZlLW5vZGUtZHVyaW5nLWNvbW1hbmQtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjdlZjIyZTlhNDMxYWQwMjcyNzEzYjcxZmRjODc5NDAxNmM4ZWYxMmYKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1ub2Rl LWR1cmluZy1jb21tYW5kLWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1ub2RlLWR1 cmluZy1jb21tYW5kLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5k L3JlbW92ZS1ub2RlLWR1cmluZy1jb21tYW5kLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNGZhMTVi YjdiMDI5NGQ1NGIzZmYxODdhZTM3NzVkYjk2NzE3N2ZjOQotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvcmVtb3ZlLW5vZGUtZHVyaW5nLWNvbW1hbmQt Y3Jhc2guaHRtbApAQCAtMCwwICsxLDI2IEBACis8c3R5bGU+CisgIGJyIHsKKyAgICBjb250ZW50 OiAnJzsKKyAgfQorPC9zdHlsZT4KKzxzY3JpcHQ+CisgIG9ubG9hZCA9ICgpID0+IHsKKyAgICAg IAorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4 dCgpOworICAgICAgICAKKyAgICBkb2N1bWVudC5kZXNpZ25Nb2RlID0gJ29uJzsKKyAgICBkb2N1 bWVudC5leGVjQ29tbWFuZCgnU2VsZWN0QWxsJyk7CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQo J0luc2VydEltYWdlJywgZmFsc2UsICcjJyk7CisgICAgbGV0IGlmcjAgPSBkb2N1bWVudC5jcmVh dGVFbGVtZW50KCdpZnJhbWUnKTsKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGlmcjAp OworICAgIGlmcjAub25sb2FkID0gKCkgPT4geworICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQo J0p1c3RpZnlSaWdodCcpOworICAgIH07CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0luc2Vy dFBhcmFncmFwaCcpOworICAgIGdldFNlbGVjdGlvbigpLmV4dGVuZChkb2N1bWVudC5ib2R5KTsK KyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgnSW5zZXJ0UGFyYWdyYXBoJyk7CisgICAgCisgICAg ZG9jdW1lbnQud3JpdGUoJ1BBU1MnKQorICB9OworPC9zY3JpcHQ+Cg== 426154 2021-04-15 16:49:41 -0700 2021-04-16 13:35:49 -0700 Patch bug-224518-20210415164940.patch text/plain 4251 iang U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWVlNzg5NTRkYjA3YzE5 N2Y3Y2U0ZGNjN2MxM2ZjNTY5ODc1YmFjYi4uZjI2YWJkZDNlNzEyZTRhMTdiMzgyMGY4OTQ3OTZm MmFjNTY4N2JiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA0LTE1ICBJYW4g R2lsYmVydCAgPGlhbmdAYXBwbGUuY29tPgorCisgICAgICAgIEVkaXRpbmcgbnVsbCBwb2ludGVy IGRlcmVmZXJlbmNlIHdoaWxlIHJlc29sdmluZyBjb21tYW5kCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ1MTgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbnVsbCBjaGVjayBpbiBjYXNlIG5vZGUg aXMgcmVtb3ZlZCB3aGlsZSBpdGVyYXRpbmcgb3ZlciB0cmVlLgorCisgICAgICAgIFRlc3Q6IGVk aXRpbmcvZXhlY0NvbW1hbmQvcmVtb3ZlLW5vZGUtZHVyaW5nLWNvbW1hbmQtY3Jhc2guaHRtbAor CisgICAgICAgICogZWRpdGluZy9EZWxldGVTZWxlY3Rpb25Db21tYW5kLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkRlbGV0ZVNlbGVjdGlvbkNvbW1hbmQ6OnJlbW92ZVJlZHVuZGFudEJsb2Nrcyk6 CisKIDIwMjEtMDQtMTUgIElhbiBHaWxiZXJ0ICA8aWFuZ0BhcHBsZS5jb20+CiAKICAgICAgICAg TnVsbCBwb2ludGVyIGRlcmVmZXJlbmNlIG9uIE1lZGlhU3RyZWFtQXVkaW9Tb3VyY2VOb2RlIGRl c3RydWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRGVsZXRlU2VsZWN0 aW9uQ29tbWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0RlbGV0ZVNlbGVjdGlvbkNv bW1hbmQuY3BwCmluZGV4IGQyMzEwY2QyOGE1MGJlYzlkNGE2ZDA0MjJlZTJmY2YyMThhMjcyY2Uu LjVmNzgzZWY0MTY4YzA3NmZhNGQ2ZjdlZmU3NDY4YTcyNDQwOWYyNzAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvRGVsZXRlU2VsZWN0aW9uQ29tbWFuZC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVTZWxlY3Rpb25Db21tYW5kLmNwcApAQCAtODY1LDEx ICs4NjUsMTEgQEAgU3RyaW5nIERlbGV0ZVNlbGVjdGlvbkNvbW1hbmQ6Om9yaWdpbmFsU3RyaW5n Rm9yQXV0b2NvcnJlY3Rpb25BdEJlZ2lubmluZ09mU2VsZWMKIC8vIFRoaXMgbWV0aG9kIHJlbW92 ZXMgZGl2IGVsZW1lbnRzIHdpdGggbm8gYXR0cmlidXRlcyB0aGF0IGhhdmUgb25seSBvbmUgY2hp bGQgb3Igbm8gY2hpbGRyZW4gYXQgYWxsLgogdm9pZCBEZWxldGVTZWxlY3Rpb25Db21tYW5kOjpy ZW1vdmVSZWR1bmRhbnRCbG9ja3MoKQogewotICAgIE5vZGUqIG5vZGUgPSBtX2VuZGluZ1Bvc2l0 aW9uLmNvbnRhaW5lck5vZGUoKTsKLSAgICBOb2RlKiByb290Tm9kZSA9IG5vZGUtPnJvb3RFZGl0 YWJsZUVsZW1lbnQoKTsKKyAgICBhdXRvIG5vZGUgPSBtYWtlUmVmUHRyKG1fZW5kaW5nUG9zaXRp b24uY29udGFpbmVyTm9kZSgpKTsKKyAgICBhdXRvIHJvb3ROb2RlID0gbWFrZVJlZlB0cihub2Rl LT5yb290RWRpdGFibGVFbGVtZW50KCkpOwogICAgCi0gICAgd2hpbGUgKG5vZGUgIT0gcm9vdE5v ZGUpIHsKLSAgICAgICAgaWYgKGlzUmVtb3ZhYmxlQmxvY2sobm9kZSkpIHsKKyAgICB3aGlsZSAo bm9kZSAmJiBub2RlICE9IHJvb3ROb2RlKSB7CisgICAgICAgIGlmIChpc1JlbW92YWJsZUJsb2Nr KG5vZGUuZ2V0KCkpKSB7CiAgICAgICAgICAgICBpZiAobm9kZSA9PSBtX2VuZGluZ1Bvc2l0aW9u LmFuY2hvck5vZGUoKSkKICAgICAgICAgICAgICAgICB1cGRhdGVQb3NpdGlvbkZvck5vZGVSZW1v dmFsUHJlc2VydmluZ0NoaWxkcmVuKG1fZW5kaW5nUG9zaXRpb24sICpub2RlKTsKICAgICAgICAg ICAgIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCmluZGV4IGFhY2RkNDllZWJjOGJmOTdiOGJkOTQ2NDZmZjFkYjJlOGEwNzA0ODkuLjI5 MjM3ZDg2M2UxYWZkNjhlYjc1YWI0OGQ1NmE3YWFlOWNlYzhmYTUgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NSBAQAorMjAyMS0wNC0xNSAgSWFuIEdpbGJlcnQgIDxpYW5nQGFwcGxlLmNvbT4KKworICAgICAg ICBFZGl0aW5nIG51bGwgcG9pbnRlciBkZXJlZmVyZW5jZSB3aGlsZSByZXNvbHZpbmcgY29tbWFu ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NTE4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHJl Z3Jlc3Npb24gdGVzdC4KKworICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1hbmQvcmVtb3ZlLW5v ZGUtZHVyaW5nLWNvbW1hbmQtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBl ZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1ub2RlLWR1cmluZy1jb21tYW5kLWNyYXNoLmh0bWw6 IEFkZGVkLgorCiAyMDIxLTA0LTE1ICBJYW4gR2lsYmVydCAgPGlhbmdAYXBwbGUuY29tPgogCiAg ICAgICAgIE51bGwgcG9pbnRlciBkZXJlZmVyZW5jZSBvbiBNZWRpYVN0cmVhbUF1ZGlvU291cmNl Tm9kZSBkZXN0cnVjdG9yCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21t YW5kL3JlbW92ZS1ub2RlLWR1cmluZy1jb21tYW5kLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvcmVtb3ZlLW5vZGUtZHVyaW5nLWNvbW1hbmQtY3Jh c2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjUwYzhmZTJkODYyNmIxOWQ3MzFmNDlhOTAzZmJm MmEzNjhiZThmMmIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWND b21tYW5kL3JlbW92ZS1ub2RlLWR1cmluZy1jb21tYW5kLWNyYXNoLWV4cGVjdGVkLnR4dApAQCAt MCwwICsxIEBACitUZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5vdCBjcmFzaCBQQVNTCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1ub2RlLWR1cmluZy1j b21tYW5kLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92 ZS1ub2RlLWR1cmluZy1jb21tYW5kLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTQzNTQ0NzEzY2Jj YmY4MDQ3ZDE2YzFkYWMxODcwZWQyZjk2YmIxYgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvcmVtb3ZlLW5vZGUtZHVyaW5nLWNvbW1hbmQtY3Jhc2gu aHRtbApAQCAtMCwwICsxLDI3IEBACis8c3R5bGU+CisgIGJyIHsKKyAgICBjb250ZW50OiAnJzsK KyAgfQorPC9zdHlsZT4KKzxzY3JpcHQ+CisgIG9ubG9hZCA9ICgpID0+IHsKKyAgICAgIAorICAg IGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOwor ICAgICAgICAKKyAgICBkb2N1bWVudC5kZXNpZ25Nb2RlID0gJ29uJzsKKyAgICBkb2N1bWVudC5l eGVjQ29tbWFuZCgnU2VsZWN0QWxsJyk7CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0luc2Vy dEltYWdlJywgZmFsc2UsICcjJyk7CisgICAgbGV0IGlmcjAgPSBkb2N1bWVudC5jcmVhdGVFbGVt ZW50KCdpZnJhbWUnKTsKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGlmcjApOworICAg IGlmcjAub25sb2FkID0gKCkgPT4geworICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0p1c3Rp ZnlSaWdodCcpOworICAgIH07CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0luc2VydFBhcmFn cmFwaCcpOworICAgIGdldFNlbGVjdGlvbigpLmV4dGVuZChkb2N1bWVudC5ib2R5KTsKKyAgICBk b2N1bWVudC5leGVjQ29tbWFuZCgnSW5zZXJ0UGFyYWdyYXBoJyk7CisKKyAgICBkb2N1bWVudC53 cml0ZSgnVGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBub3QgY3Jhc2hcbicpOworICAgIGRvY3VtZW50 LndyaXRlKCdQQVNTJyk7CisgIH07Cis8L3NjcmlwdD4K 426267 2021-04-16 13:35:51 -0700 2021-04-16 17:57:31 -0700 Patch bug-224518-20210416133551.patch text/plain 4332 iang U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2MTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDkxZmY2MzA1NDc0YzZl N2Y5MzAyYzM3MTliOGU0NzA0ZmE0NTlkMS4uMjIwYzU1NTVjZTJkOGJhNjI0MGNhMzI3ZGMyNThi ODFlNTA0MjYxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA0LTE2ICBJYW4g R2lsYmVydCAgPGlhbmdAYXBwbGUuY29tPgorCisgICAgICAgIE51bGxwdHIgZGVyZWYgaW4gQ29t cG9zaXRlRWRpdENvbW1hbmQ6OmlzUmVtb3ZhYmxlQmxvY2sgaW4gRGVsZXRlU2VsZWN0aW9uQ29t bWFuZDo6cmVtb3ZlUmVkdW5kYW50QmxvY2tzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ1MTgKKworICAgICAgICBSZXZpZXdlZCBieSBSeW9zdWtl IE5pd2EuCisKKyAgICAgICAgQWRkIG51bGwgY2hlY2sgaW4gY2FzZSBub2RlIGlzIHJlbW92ZWQg d2hpbGUgaXRlcmF0aW5nIG92ZXIgdHJlZS4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL2V4ZWND b21tYW5kL3JlbW92ZS1ub2RlLWR1cmluZy1jb21tYW5kLWNyYXNoLmh0bWwKKworICAgICAgICAq IGVkaXRpbmcvRGVsZXRlU2VsZWN0aW9uQ29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE ZWxldGVTZWxlY3Rpb25Db21tYW5kOjpyZW1vdmVSZWR1bmRhbnRCbG9ja3MpOgorCiAyMDIxLTA0 LTE2ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLCByZXZlcnRpbmcgcjI3MzczMy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvRGVsZXRlU2VsZWN0aW9uQ29tbWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0 aW5nL0RlbGV0ZVNlbGVjdGlvbkNvbW1hbmQuY3BwCmluZGV4IGQyMzEwY2QyOGE1MGJlYzlkNGE2 ZDA0MjJlZTJmY2YyMThhMjcyY2UuLjVmNzgzZWY0MTY4YzA3NmZhNGQ2ZjdlZmU3NDY4YTcyNDQw OWYyNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRGVsZXRlU2VsZWN0aW9u Q29tbWFuZC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9EZWxldGVTZWxlY3Rpb25D b21tYW5kLmNwcApAQCAtODY1LDExICs4NjUsMTEgQEAgU3RyaW5nIERlbGV0ZVNlbGVjdGlvbkNv bW1hbmQ6Om9yaWdpbmFsU3RyaW5nRm9yQXV0b2NvcnJlY3Rpb25BdEJlZ2lubmluZ09mU2VsZWMK IC8vIFRoaXMgbWV0aG9kIHJlbW92ZXMgZGl2IGVsZW1lbnRzIHdpdGggbm8gYXR0cmlidXRlcyB0 aGF0IGhhdmUgb25seSBvbmUgY2hpbGQgb3Igbm8gY2hpbGRyZW4gYXQgYWxsLgogdm9pZCBEZWxl dGVTZWxlY3Rpb25Db21tYW5kOjpyZW1vdmVSZWR1bmRhbnRCbG9ja3MoKQogewotICAgIE5vZGUq IG5vZGUgPSBtX2VuZGluZ1Bvc2l0aW9uLmNvbnRhaW5lck5vZGUoKTsKLSAgICBOb2RlKiByb290 Tm9kZSA9IG5vZGUtPnJvb3RFZGl0YWJsZUVsZW1lbnQoKTsKKyAgICBhdXRvIG5vZGUgPSBtYWtl UmVmUHRyKG1fZW5kaW5nUG9zaXRpb24uY29udGFpbmVyTm9kZSgpKTsKKyAgICBhdXRvIHJvb3RO b2RlID0gbWFrZVJlZlB0cihub2RlLT5yb290RWRpdGFibGVFbGVtZW50KCkpOwogICAgCi0gICAg d2hpbGUgKG5vZGUgIT0gcm9vdE5vZGUpIHsKLSAgICAgICAgaWYgKGlzUmVtb3ZhYmxlQmxvY2so bm9kZSkpIHsKKyAgICB3aGlsZSAobm9kZSAmJiBub2RlICE9IHJvb3ROb2RlKSB7CisgICAgICAg IGlmIChpc1JlbW92YWJsZUJsb2NrKG5vZGUuZ2V0KCkpKSB7CiAgICAgICAgICAgICBpZiAobm9k ZSA9PSBtX2VuZGluZ1Bvc2l0aW9uLmFuY2hvck5vZGUoKSkKICAgICAgICAgICAgICAgICB1cGRh dGVQb3NpdGlvbkZvck5vZGVSZW1vdmFsUHJlc2VydmluZ0NoaWxkcmVuKG1fZW5kaW5nUG9zaXRp b24sICpub2RlKTsKICAgICAgICAgICAgIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGI1MWUyNDY4ZTVkYjg2M2QwNThkMjhi NmNkNTc0ZmMyZWQwZmQ5MzYuLmZmNTJmMjE1NTNiZDliZDlhMzQ0MDlmMmRlMThjODY1ZDgzZTll ZDcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMS0wNC0xNiAgSWFuIEdpbGJlcnQgIDxpYW5n QGFwcGxlLmNvbT4KKworICAgICAgICBOdWxscHRyIGRlcmVmIGluIENvbXBvc2l0ZUVkaXRDb21t YW5kOjppc1JlbW92YWJsZUJsb2NrIGluIERlbGV0ZVNlbGVjdGlvbkNvbW1hbmQ6OnJlbW92ZVJl ZHVuZGFudEJsb2NrcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjI0NTE4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUnlvc3VrZSBOaXdhLgorCisgICAg ICAgIEFkZCBhIHJlZ3Jlc3Npb24gdGVzdC4KKworICAgICAgICAqIGVkaXRpbmcvZXhlY0NvbW1h bmQvcmVtb3ZlLW5vZGUtZHVyaW5nLWNvbW1hbmQtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBlZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1ub2RlLWR1cmluZy1jb21tYW5k LWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDIxLTA0LTE2ICBUeWxlciBXaWxjb2NrICA8dHdpbGNv Lm9AcHJvdG9ubWFpbC5jb20+CiAKICAgICAgICAgW2Nzcy1jb3VudGVyLXN0eWxlc10gUGFyc2Ug YW5kIGFkZCBmZWF0dXJlIGZsYWcgZm9yIEBjb3VudGVyLXN0eWxlCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1ub2RlLWR1cmluZy1jb21tYW5kLWNy YXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvcmVtb3Zl LW5vZGUtZHVyaW5nLWNvbW1hbmQtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjUwYzhm ZTJkODYyNmIxOWQ3MzFmNDlhOTAzZmJmMmEzNjhiZThmMmIKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1ub2RlLWR1cmluZy1jb21tYW5k LWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitUZXN0IHBhc3NlcyBpZiBpdCBkb2Vz IG5vdCBjcmFzaCBQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21t YW5kL3JlbW92ZS1ub2RlLWR1cmluZy1jb21tYW5kLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9l ZGl0aW5nL2V4ZWNDb21tYW5kL3JlbW92ZS1ub2RlLWR1cmluZy1jb21tYW5kLWNyYXNoLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uOTQzNTQ0NzEzY2JjYmY4MDQ3ZDE2YzFkYWMxODcwZWQyZjk2YmIxYgotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvcmVtb3ZlLW5v ZGUtZHVyaW5nLWNvbW1hbmQtY3Jhc2guaHRtbApAQCAtMCwwICsxLDI3IEBACis8c3R5bGU+Cisg IGJyIHsKKyAgICBjb250ZW50OiAnJzsKKyAgfQorPC9zdHlsZT4KKzxzY3JpcHQ+CisgIG9ubG9h ZCA9ICgpID0+IHsKKyAgICAgIAorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgIHRl c3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgICAgICAKKyAgICBkb2N1bWVudC5kZXNpZ25Nb2Rl ID0gJ29uJzsKKyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgnU2VsZWN0QWxsJyk7CisgICAgZG9j dW1lbnQuZXhlY0NvbW1hbmQoJ0luc2VydEltYWdlJywgZmFsc2UsICcjJyk7CisgICAgbGV0IGlm cjAgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdpZnJhbWUnKTsKKyAgICBkb2N1bWVudC5ib2R5 LmFwcGVuZENoaWxkKGlmcjApOworICAgIGlmcjAub25sb2FkID0gKCkgPT4geworICAgICAgZG9j dW1lbnQuZXhlY0NvbW1hbmQoJ0p1c3RpZnlSaWdodCcpOworICAgIH07CisgICAgZG9jdW1lbnQu ZXhlY0NvbW1hbmQoJ0luc2VydFBhcmFncmFwaCcpOworICAgIGdldFNlbGVjdGlvbigpLmV4dGVu ZChkb2N1bWVudC5ib2R5KTsKKyAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgnSW5zZXJ0UGFyYWdy YXBoJyk7CisKKyAgICBkb2N1bWVudC53cml0ZSgnVGVzdCBwYXNzZXMgaWYgaXQgZG9lcyBub3Qg Y3Jhc2hcbicpOworICAgIGRvY3VtZW50LndyaXRlKCdQQVNTJyk7CisgIH07Cis8L3NjcmlwdD4K