22451 2008-11-24 02:40:04 -0800 There should be a test for the JSC PIC bug that caused the ToT crasher over the weekend. 2008-11-25 17:52:45 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 99925 0 barraclough 2008-11-24 02:40:04 -0800 The bug is caused by an access to a prototype chain being cached, that doesn't check for immediates before dereferencing the passed JSValue*. Write a test case to force a chained access to be cached, then pass it an immediate. Should probably also test the non-chained prototype accesses, at the same time. 99928 1 25421 barraclough 2008-11-24 03:00:36 -0800 Created attachment 25421 A test 99930 2 barraclough 2008-11-24 03:12:08 -0800 Sending LayoutTests/ChangeLog Adding LayoutTests/fast/js/pic/cached-prototype-then-immediate-expected.txt Adding LayoutTests/fast/js/pic/cached-prototype-then-immediate.html Transmitting file data ... Committed revision 38703. 100350 3 25421 eric 2008-11-25 17:52:45 -0800 Comment on attachment 25421 A test Silly bugzilla. Clearing review flag since this landed. 25421 2008-11-24 03:00:36 -0800 2008-11-25 17:52:45 -0800 A test patch.chaintest.txt text/plain 2696 barraclough SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4NzAx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMTEt MjQgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCB0ZXN0IGNhc2VzIHRv IGVuc3VyZSB0aGUgUElDIHRyYW1wb2xpbmVzIGZvciBwcm90b3R5cGUgYW5kIHByb3RvdHlwZSBj aGFpbgorICAgICAgICBhY2Nlc3NlcyBwcm9wZXJseSBjaGVjayBmb3IgSlNJbW1lZGlhdGUgdmFs dWVzLCByYXRoZXIgdGhhbiBzZWdmYXVsdGluZy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NTEKKworICAgICAgICAqIGZhc3QvanMvcGljL2Nh Y2hlZC1wcm90b3R5cGUtdGhlbi1pbW1lZGlhdGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2pzL3BpYy9jYWNoZWQtcHJvdG90eXBlLXRoZW4taW1tZWRpYXRlLmh0bWw6IEFk ZGVkLgorCiAyMDA4LTExLTIxICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBHZW9mZiBHYXJlbi4KSW5kZXg6IGZhc3QvanMvcGljL2Nh Y2hlZC1wcm90b3R5cGUtdGhlbi1pbW1lZGlhdGUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IGZhc3QvanMvcGljL2NhY2hlZC1wcm90b3R5cGUtdGhlbi1pbW1lZGlhdGUtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQorKysgZmFzdC9qcy9waWMvY2FjaGVkLXByb3RvdHlwZS10aGVuLWltbWVk aWF0ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNSBAQAorVGhpcyBwYWdl IHRlc3RzIHdoZXRoZXIgYSBjYWNoZWQgW1twdXRdXSBjb25zdWx0cyBzZXR0ZXJzIGluIHRoZSBw cm90b3R5cGUgY2hhaW4uIElmIHRoZSB0ZXN0IHBhc3NlcywgeW91J2xsIHNlZSB0d28gUEFTUyBt ZXNzYWdlcyBiZWxvdy4KKworUEFTUzogSSBkaWRuJ3Qgc2VnZmF1bHQgb25jZSEKK1BBU1M6IEkg ZGlkbid0IHNlZ2ZhdWx0IG9uY2UhCisKSW5kZXg6IGZhc3QvanMvcGljL2NhY2hlZC1wcm90b3R5 cGUtdGhlbi1pbW1lZGlhdGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBmYXN0L2pzL3BpYy9jYWNoZWQt cHJvdG90eXBlLXRoZW4taW1tZWRpYXRlLmh0bWwJKHJldmlzaW9uIDApCisrKyBmYXN0L2pzL3Bp Yy9jYWNoZWQtcHJvdG90eXBlLXRoZW4taW1tZWRpYXRlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsNTIgQEAKKzxwPlRoaXMgcGFnZSB0ZXN0cyB3aGV0aGVyIGEgY2FjaGVkIFtbcHV0XV0g Y29uc3VsdHMgc2V0dGVycyBpbiB0aGUgcHJvdG90eXBlIGNoYWluLgorSWYgdGhlIHRlc3QgcGFz c2VzLCB5b3UnbGwgc2VlIHR3byBQQVNTIG1lc3NhZ2VzIGJlbG93LjwvcD4KKworPHByZSBpZD0i Y29uc29sZSI+PC9wcmU+CisKKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9s bGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworZnVuY3Rpb24g bG9nKHMpCit7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKS5hcHBlbmRD aGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShzKSk7Cit9CisKKyhmdW5jdGlvbigpIHsKKyAg ICBmdW5jdGlvbiBjYWxsVG9TdHJpbmcoYXJnKQorICAgIHsKKyAgICAgICAgcmV0dXJuIGFyZy50 b1N0cmluZygpOworICAgIH0KKyAgICAKKyAgICAvLyB0b1N0cmluZygpIHdpbGwgaGl0IHRoZSBk aXJlY3QgcHJvdG90eXBlIG9mIHRoaXMgb2JqZWN0LgorICAgIHZhciB2aWN0aW0gPSB7fTsKKyAg ICAKKyAgICBjYWxsVG9TdHJpbmcodmljdGltKTsKKyAgICBjYWxsVG9TdHJpbmcodmljdGltKTsK KyAgICBjYWxsVG9TdHJpbmcodmljdGltKTsKKyAgICBjYWxsVG9TdHJpbmcoMSk7CisgICAgCisg ICAgbG9nKCJQQVNTOiBJIGRpZG4ndCBzZWdmYXVsdCBvbmNlIVxuIik7Cit9KSgpOworCisoZnVu Y3Rpb24oKSB7CisgICAgZnVuY3Rpb24gY2FsbFRvU3RyaW5nKGFyZykKKyAgICB7CisgICAgICAg IHJldHVybiBhcmcudG9TdHJpbmcoKTsKKyAgICB9CisKKyAgICAvLyB0b1N0cmluZygpIHdpbGwg aGF2ZSB0byB3YWxrIGEgcHJvdG90eXBlIGNoYWluIGZvciB0aGlzIG9iamVjdC4KKyAgICBmdW5j dGlvbiBNeU9iamVjdCgpIHt9CisgICAgTXlPYmplY3QucHJvdG90eXBlID0geyBzb21lU3R1ZmY6 IHt9IH07CisgICAgdmFyIHZpY3RpbSA9IG5ldyBNeU9iamVjdCgpOworCisgICAgdmFyIHhTZXR0 ZXJDYWxsZWQgPSBmYWxzZTsKKworICAgIGNhbGxUb1N0cmluZyh2aWN0aW0pOworICAgIGNhbGxU b1N0cmluZyh2aWN0aW0pOworICAgIGNhbGxUb1N0cmluZyh2aWN0aW0pOworICAgIGNhbGxUb1N0 cmluZygxKTsKKworICAgIGxvZygiUEFTUzogSSBkaWRuJ3Qgc2VnZmF1bHQgb25jZSFcbiIpOwor fSkoKTsKKzwvc2NyaXB0Pgo=