224506 2021-04-13 12:51:04 -0700 InlineBox should not hold a reference to RenderObject 2021-04-14 06:58:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan mmaxfield pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1749810 0 zalan 2021-04-13 12:51:04 -0700 The InlineBox/RenderObject relationship is rather complicated (see RenderBox::setInlineBoxWrapper() vs. InlineElementBox::extractLine) and it's easy to delete one without letting the other know. 1749822 1 425905 zalan 2021-04-13 13:01:27 -0700 Created attachment 425905 Patch 1750093 2 ews-feeder 2021-04-14 06:57:21 -0700 Committed r275943 (236505@main): <https://commits.webkit.org/236505@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425905. 1750094 3 webkit-bug-importer 2021-04-14 06:58:15 -0700 <rdar://problem/76643802> 425905 2021-04-13 13:01:27 -0700 2021-04-14 06:57:23 -0700 Patch bug-224506-20210413130127.patch text/plain 7162 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1ODQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmFlMzFjZDRjZTE1ODVh ZjYxNTBmYzM0MzM2ZTEzZWZhMzZkMTEzOS4uYmYxYTNhMjdiMDg2ZDJiOGI0OWZmMThlZTZiNmEy Njg5MmEzZGZiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIxLTA0LTEzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgSW5saW5lQm94IHNob3VsZCBu b3QgaG9sZCBhIHJlZmVyZW5jZSB0byBSZW5kZXJPYmplY3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyNDUwNgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBJbmxpbmVCb3gvUmVuZGVyT2JqZWN0IHJl bGF0aW9uc2hpcCBpcyBzb21ld2hhdCBlcnJvci1wcm9uZSAoc2VlIFJlbmRlckJveDo6c2V0SW5s aW5lQm94V3JhcHBlciB2cy4gSW5saW5lRWxlbWVudEJveDo6ZXh0cmFjdExpbmUpIGFuZCBpdCdz IHJhdGhlciBlYXN5IHRvIGRlbGV0ZSBvbmUgd2l0aG91dCBsZXR0aW5nIHRoZSBvdGhlciBrbm93 LgorCisgICAgICAgICogcmVuZGVyaW5nL0lubGluZUJveC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpJbmxpbmVCb3g6OnNob3dOb2RlVHJlZUZvclRoaXMgY29uc3QpOgorICAgICAgICAoV2ViQ29y ZTo6SW5saW5lQm94OjpzaG93TGluZVRyZWVGb3JUaGlzIGNvbnN0KToKKyAgICAgICAgKFdlYkNv cmU6OklubGluZUJveDo6Y2FyZXRNaW5PZmZzZXQgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6 SW5saW5lQm94OjpjYXJldE1heE9mZnNldCBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpJbmxp bmVCb3g6OmFkanVzdFBvc2l0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6OklubGluZUJveDo6c2Vs ZWN0aW9uU3RhdGUpOgorICAgICAgICAoV2ViQ29yZTo6SW5saW5lQm94OjpjYW5BY2NvbW1vZGF0 ZUVsbGlwc2lzIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OklubGluZUJveDo6bG9jYXRpb25J bmNsdWRpbmdGbGlwcGluZyBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpJbmxpbmVCb3g6OmZs aXBGb3JXcml0aW5nTW9kZSBjb25zdCk6CisgICAgICAgICogcmVuZGVyaW5nL0lubGluZUJveC5o OgorICAgICAgICAoV2ViQ29yZTo6SW5saW5lQm94OjpyZW5kZXJlciBjb25zdCk6CisgICAgICAg IChXZWJDb3JlOjpJbmxpbmVCb3g6OmJveE1vZGVsT2JqZWN0IGNvbnN0KToKKyAgICAgICAgKFdl YkNvcmU6OklubGluZUJveDo6SW5saW5lQm94KToKKwogMjAyMS0wNC0xMiAgQkogQnVyZyAgPGJi dXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBNb2Rlcm5pemUgdXNlcyBvZiBDb25zb2xlQ2xpZW50 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guY3BwCmluZGV4IDkzMjQxZTE2ZGM4NzVl ZTQyNDUzZmVkODAxMzA0ODUzNjQyZTRlNDIuLmNjMDQ1OTk1OWI3Nzk5MjBjYThjNTVkN2RiMzgx MGM1MTAwNmFjNTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVC b3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guY3BwCkBAIC00 MCw3ICs0MCw4IEBAIFdURl9NQUtFX0lTT19BTExPQ0FURURfSU1QTChJbmxpbmVCb3gpOwogCiBz dHJ1Y3QgU2FtZVNpemVBc0lubGluZUJveCB7CiAgICAgdmlydHVhbCB+U2FtZVNpemVBc0lubGlu ZUJveCgpID0gZGVmYXVsdDsKLSAgICB2b2lkKiBhWzRdOworICAgIHZvaWQqIGFbM107CisgICAg V2Vha1B0cjxSZW5kZXJPYmplY3Q+IHI7CiAgICAgRmxvYXRQb2ludCBiOwogICAgIGZsb2F0IGNb Ml07CiAgICAgdW5zaWduZWQgZCA6IDIzOwpAQCAtOTYsMTIgKzk3LDEyIEBAIGNvbnN0IGNoYXIq IElubGluZUJveDo6Ym94TmFtZSgpIGNvbnN0CiAKIHZvaWQgSW5saW5lQm94OjpzaG93Tm9kZVRy ZWVGb3JUaGlzKCkgY29uc3QKIHsKLSAgICBtX3JlbmRlcmVyLnNob3dOb2RlVHJlZUZvclRoaXMo KTsKKyAgICByZW5kZXJlcigpLnNob3dOb2RlVHJlZUZvclRoaXMoKTsKIH0KIAogdm9pZCBJbmxp bmVCb3g6OnNob3dMaW5lVHJlZUZvclRoaXMoKSBjb25zdAogewotICAgIG1fcmVuZGVyZXIuY29u dGFpbmluZ0Jsb2NrKCktPnNob3dMaW5lVHJlZUZvclRoaXMoKTsKKyAgICByZW5kZXJlcigpLmNv bnRhaW5pbmdCbG9jaygpLT5zaG93TGluZVRyZWVGb3JUaGlzKCk7CiB9CiAKIHZvaWQgSW5saW5l Qm94OjpvdXRwdXRMaW5lVHJlZUFuZE1hcmsoVGV4dFN0cmVhbSYgc3RyZWFtLCBjb25zdCBJbmxp bmVCb3gqIG1hcmtlZEJveCwgaW50IGRlcHRoKSBjb25zdApAQCAtMTU3LDEyICsxNTgsMTIgQEAg TGF5b3V0VW5pdCBJbmxpbmVCb3g6OmxpbmVIZWlnaHQoKSBjb25zdAogCiBpbnQgSW5saW5lQm94 OjpjYXJldE1pbk9mZnNldCgpIGNvbnN0IAogeyAKLSAgICByZXR1cm4gbV9yZW5kZXJlci5jYXJl dE1pbk9mZnNldCgpOworICAgIHJldHVybiByZW5kZXJlcigpLmNhcmV0TWluT2Zmc2V0KCk7CiB9 CiAKIGludCBJbmxpbmVCb3g6OmNhcmV0TWF4T2Zmc2V0KCkgY29uc3QgCiB7IAotICAgIHJldHVy biBtX3JlbmRlcmVyLmNhcmV0TWF4T2Zmc2V0KCk7CisgICAgcmV0dXJuIHJlbmRlcmVyKCkuY2Fy ZXRNYXhPZmZzZXQoKTsKIH0KIAogdm9pZCBJbmxpbmVCb3g6OmRpcnR5TGluZUJveGVzKCkKQEAg LTE3NiwxMCArMTc3LDEwIEBAIHZvaWQgSW5saW5lQm94OjphZGp1c3RQb3NpdGlvbihmbG9hdCBk eCwgZmxvYXQgZHkpCiB7CiAgICAgbV90b3BMZWZ0Lm1vdmUoZHgsIGR5KTsKIAotICAgIGlmICht X3JlbmRlcmVyLmlzT3V0T2ZGbG93UG9zaXRpb25lZCgpKQorICAgIGlmIChyZW5kZXJlcigpLmlz T3V0T2ZGbG93UG9zaXRpb25lZCgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAobV9yZW5k ZXJlci5pc1JlcGxhY2VkKCkpCisgICAgaWYgKHJlbmRlcmVyKCkuaXNSZXBsYWNlZCgpKQogICAg ICAgICBkb3duY2FzdDxSZW5kZXJCb3g+KHJlbmRlcmVyKCkpLm1vdmUoTGF5b3V0VW5pdChkeCks IExheW91dFVuaXQoZHkpKTsKIH0KIApAQCAtMjU5LDEzICsyNjAsMTMgQEAgSW5saW5lQm94KiBJ bmxpbmVCb3g6OnByZXZpb3VzTGVhZk9uTGluZUlnbm9yaW5nTGluZUJyZWFrKCkgY29uc3QKIAog UmVuZGVyT2JqZWN0OjpIaWdobGlnaHRTdGF0ZSBJbmxpbmVCb3g6OnNlbGVjdGlvblN0YXRlKCkK IHsKLSAgICByZXR1cm4gbV9yZW5kZXJlci5zZWxlY3Rpb25TdGF0ZSgpOworICAgIHJldHVybiBy ZW5kZXJlcigpLnNlbGVjdGlvblN0YXRlKCk7CiB9CiAKIGJvb2wgSW5saW5lQm94OjpjYW5BY2Nv bW1vZGF0ZUVsbGlwc2lzKGJvb2wgbHRyLCBpbnQgYmxvY2tFZGdlLCBpbnQgZWxsaXBzaXNXaWR0 aCkgY29uc3QKIHsKICAgICAvLyBOb24tcmVwbGFjZWQgZWxlbWVudHMgY2FuIGFsd2F5cyBhY2Nv bW1vZGF0ZSBhbiBlbGxpcHNpcy4KLSAgICBpZiAoIW1fcmVuZGVyZXIuaXNSZXBsYWNlZCgpKQor ICAgIGlmICghcmVuZGVyZXIoKS5pc1JlcGxhY2VkKCkpCiAgICAgICAgIHJldHVybiB0cnVlOwog ICAgIAogICAgIEludFJlY3QgYm94UmVjdChsZWZ0KCksIDAsIG1fbG9naWNhbFdpZHRoLCAxMCk7 CkBAIC0yODksNyArMjkwLDcgQEAgdm9pZCBJbmxpbmVCb3g6OmNsZWFyS25vd25Ub0hhdmVOb092 ZXJmbG93KCkKIAogRmxvYXRQb2ludCBJbmxpbmVCb3g6OmxvY2F0aW9uSW5jbHVkaW5nRmxpcHBp bmcoKSBjb25zdAogewotICAgIGlmICghbV9yZW5kZXJlci5zdHlsZSgpLmlzRmxpcHBlZEJsb2Nr c1dyaXRpbmdNb2RlKCkpCisgICAgaWYgKCFyZW5kZXJlcigpLnN0eWxlKCkuaXNGbGlwcGVkQmxv Y2tzV3JpdGluZ01vZGUoKSkKICAgICAgICAgcmV0dXJuIHRvcExlZnQoKTsKICAgICBSZW5kZXJC bG9ja0Zsb3cmIGJsb2NrID0gcm9vdCgpLmJsb2NrRmxvdygpOwogICAgIGlmIChibG9jay5zdHls ZSgpLmlzSG9yaXpvbnRhbFdyaXRpbmdNb2RlKCkpCkBAIC0yOTksMjggKzMwMCwyOCBAQCBGbG9h dFBvaW50IElubGluZUJveDo6bG9jYXRpb25JbmNsdWRpbmdGbGlwcGluZygpIGNvbnN0CiAKIHZv aWQgSW5saW5lQm94OjpmbGlwRm9yV3JpdGluZ01vZGUoRmxvYXRSZWN0JiByZWN0KSBjb25zdAog ewotICAgIGlmICghbV9yZW5kZXJlci5zdHlsZSgpLmlzRmxpcHBlZEJsb2Nrc1dyaXRpbmdNb2Rl KCkpCisgICAgaWYgKCFyZW5kZXJlcigpLnN0eWxlKCkuaXNGbGlwcGVkQmxvY2tzV3JpdGluZ01v ZGUoKSkKICAgICAgICAgcmV0dXJuOwogICAgIHJvb3QoKS5ibG9ja0Zsb3coKS5mbGlwRm9yV3Jp dGluZ01vZGUocmVjdCk7CiB9CiAKIEZsb2F0UG9pbnQgSW5saW5lQm94OjpmbGlwRm9yV3JpdGlu Z01vZGUoY29uc3QgRmxvYXRQb2ludCYgcG9pbnQpIGNvbnN0CiB7Ci0gICAgaWYgKCFtX3JlbmRl cmVyLnN0eWxlKCkuaXNGbGlwcGVkQmxvY2tzV3JpdGluZ01vZGUoKSkKKyAgICBpZiAoIXJlbmRl cmVyKCkuc3R5bGUoKS5pc0ZsaXBwZWRCbG9ja3NXcml0aW5nTW9kZSgpKQogICAgICAgICByZXR1 cm4gcG9pbnQ7CiAgICAgcmV0dXJuIHJvb3QoKS5ibG9ja0Zsb3coKS5mbGlwRm9yV3JpdGluZ01v ZGUocG9pbnQpOwogfQogCiB2b2lkIElubGluZUJveDo6ZmxpcEZvcldyaXRpbmdNb2RlKExheW91 dFJlY3QmIHJlY3QpIGNvbnN0CiB7Ci0gICAgaWYgKCFtX3JlbmRlcmVyLnN0eWxlKCkuaXNGbGlw cGVkQmxvY2tzV3JpdGluZ01vZGUoKSkKKyAgICBpZiAoIXJlbmRlcmVyKCkuc3R5bGUoKS5pc0Zs aXBwZWRCbG9ja3NXcml0aW5nTW9kZSgpKQogICAgICAgICByZXR1cm47CiAgICAgcm9vdCgpLmJs b2NrRmxvdygpLmZsaXBGb3JXcml0aW5nTW9kZShyZWN0KTsKIH0KIAogTGF5b3V0UG9pbnQgSW5s aW5lQm94OjpmbGlwRm9yV3JpdGluZ01vZGUoY29uc3QgTGF5b3V0UG9pbnQmIHBvaW50KSBjb25z dAogewotICAgIGlmICghbV9yZW5kZXJlci5zdHlsZSgpLmlzRmxpcHBlZEJsb2Nrc1dyaXRpbmdN b2RlKCkpCisgICAgaWYgKCFyZW5kZXJlcigpLnN0eWxlKCkuaXNGbGlwcGVkQmxvY2tzV3JpdGlu Z01vZGUoKSkKICAgICAgICAgcmV0dXJuIHBvaW50OwogICAgIHJldHVybiByb290KCkuYmxvY2tG bG93KCkuZmxpcEZvcldyaXRpbmdNb2RlKHBvaW50KTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVCb3guaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9J bmxpbmVCb3guaAppbmRleCA0ZTU4NTljYWE2YmFiNTlmYTcxYjIwNDY0Mjg2YTA4NDE1ODY1NDRm Li40NTEwOWI4NGNjYjE3NDI2MDU3YWZhM2E3OTMzZTA3NGYxN2E5MGFhIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lQm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL0lubGluZUJveC5oCkBAIC0yNSw2ICsyNSw3IEBACiAjaW5jbHVkZSAiVGV4dEZs YWdzLmgiCiAjaW5jbHVkZSA8d3RmL0lzb01hbGxvYy5oPgogI2luY2x1ZGUgPHd0Zi9UeXBlQ2Fz dHMuaD4KKyNpbmNsdWRlIDx3dGYvV2Vha1B0ci5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK QEAgLTE0MSw3ICsxNDIsNyBAQCBwdWJsaWM6CiAgICAgSW5saW5lQm94KiBwcmV2aW91c0xlYWZP bkxpbmVJZ25vcmluZ0xpbmVCcmVhaygpIGNvbnN0OwogCiAgICAgLy8gRklYTUU6IEhpZGUgdGhp cyBvbmNlIGFsbCBjYWxsZXJzIGFyZSB1c2luZyB0aWdodGVyIHR5cGVzLgotICAgIFJlbmRlck9i amVjdCYgcmVuZGVyZXIoKSBjb25zdCB7IHJldHVybiBtX3JlbmRlcmVyOyB9CisgICAgUmVuZGVy T2JqZWN0JiByZW5kZXJlcigpIGNvbnN0IHsgcmV0dXJuICptX3JlbmRlcmVyOyB9CiAKICAgICBJ bmxpbmVGbG93Qm94KiBwYXJlbnQoKSBjb25zdAogICAgIHsKQEAgLTI0NCw4ICsyNDUsOCBAQCBw dWJsaWM6CiAgICAgLy8gVXNlIHdpdGggY2F1dGlvbiEgVGhlIHR5cGUgaXMgbm90IGNoZWNrZWQh CiAgICAgUmVuZGVyQm94TW9kZWxPYmplY3QqIGJveE1vZGVsT2JqZWN0KCkgY29uc3QKICAgICB7 IAotICAgICAgICBpZiAoIWlzPFJlbmRlclRleHQ+KG1fcmVuZGVyZXIpKQotICAgICAgICAgICAg cmV0dXJuICZkb3duY2FzdDxSZW5kZXJCb3hNb2RlbE9iamVjdD4obV9yZW5kZXJlcik7CisgICAg ICAgIGlmICghaXM8UmVuZGVyVGV4dD4ocmVuZGVyZXIoKSkpCisgICAgICAgICAgICByZXR1cm4g JmRvd25jYXN0PFJlbmRlckJveE1vZGVsT2JqZWN0PihyZW5kZXJlcigpKTsKICAgICAgICAgcmV0 dXJuIG51bGxwdHI7CiAgICAgfQogCkBAIC0yODYsNyArMjg3LDcgQEAgcHJpdmF0ZToKIAogICAg IElubGluZUZsb3dCb3gqIG1fcGFyZW50IHsgbnVsbHB0ciB9OyAvLyBUaGUgYm94IHRoYXQgY29u dGFpbnMgdXMuCiAKLSAgICBSZW5kZXJPYmplY3QmIG1fcmVuZGVyZXI7CisgICAgV2Vha1B0cjxS ZW5kZXJPYmplY3Q+IG1fcmVuZGVyZXI7CiAKIHByaXZhdGU6CiAgICAgZmxvYXQgbV9sb2dpY2Fs V2lkdGggeyAwIH07CkBAIC0zNzMsNyArMzc0LDcgQEAgcHJpdmF0ZToKIAogcHJvdGVjdGVkOgog ICAgIGV4cGxpY2l0IElubGluZUJveChSZW5kZXJPYmplY3QmIHJlbmRlcmVyKQotICAgICAgICA6 IG1fcmVuZGVyZXIocmVuZGVyZXIpCisgICAgICAgIDogbV9yZW5kZXJlcihtYWtlV2Vha1B0cihy ZW5kZXJlcikpCiAgICAgewogICAgIH0KIApAQCAtMzgxLDcgKzM4Miw3IEBAIHByb3RlY3RlZDoK ICAgICAgICAgOiBtX25leHRPbkxpbmUobmV4dCkKICAgICAgICAgLCBtX3ByZXZpb3VzT25MaW5l KHByZXZpb3VzKQogICAgICAgICAsIG1fcGFyZW50KHBhcmVudCkKLSAgICAgICAgLCBtX3JlbmRl cmVyKHJlbmRlcmVyKQorICAgICAgICAsIG1fcmVuZGVyZXIobWFrZVdlYWtQdHIocmVuZGVyZXIp KQogICAgICAgICAsIG1fbG9naWNhbFdpZHRoKGxvZ2ljYWxXaWR0aCkKICAgICAgICAgLCBtX3Rv cExlZnQodG9wTGVmdCkKICAgICAgICAgLCBtX2JpdGZpZWxkcyhmaXJzdExpbmUsIGNvbnN0cnVj dGVkLCBkaXJ0eSwgZXh0cmFjdGVkLCBpc0hvcml6b250YWwpCg==