224500 2021-04-13 12:20:06 -0700 Have HTMLCanvasElement clear its buffer as soon as its script execution context goes away 2022-04-11 07:03:03 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 cdumez cdumez changseok dino esprehn+autocc ews-watchlist ggaren gyuyoung.kim sabouhallawa sam simon.fraser thorton webkit-bug-importer oldest_to_newest 1749785 0 cdumez 2021-04-13 12:20:06 -0700 Have HTMLCanvasElement clear its buffer as soon as its script execution context goes away. We used to do this only in the destructor, which would only get called after GC of the JS wrapper, which may delay release of the ImageBuffer and its memory. 1749789 1 425896 cdumez 2021-04-13 12:21:55 -0700 Created attachment 425896 Patch 1749830 2 425906 cdumez 2021-04-13 13:10:01 -0700 Created attachment 425906 Patch 1749900 3 cdumez 2021-04-13 15:35:31 -0700 This is web-observable. 1782301 4 425906 thorton 2021-08-05 12:05:36 -0700 Comment on attachment 425906 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425906&action=review Additional motivation: https://bugs.webkit.org/show_bug.cgi?id=228747 > Source/WebCore/html/HTMLCanvasElement.cpp:1028 > + setImageBuffer(nullptr); I'm guessing we'd need to slurp some more code from the destructor to fix the assertions. 1782316 5 thorton 2021-08-05 13:02:07 -0700 Reopening because Sam and Chris and I all think we should try this again when we have lots of bake time :) (Also, we already do it for WebGL) 1860274 6 webkit-bug-importer 2022-04-11 07:03:03 -0700 <rdar://problem/91563038> 425896 2021-04-13 12:21:55 -0700 2021-04-13 14:13:24 -0700 Patch bug-224500-20210413122154.patch text/plain 2166 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1ODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjQzODJkZTkzN2FhYmE4 OGVlNTZkNmNiZDJkZGQxM2U0Y2YzYjAzMy4uN2VjNWM3YzQ0MGI4ZjEwMWE3MWM3YTRkODUyN2Zj M2RkN2Y4OWUyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA0LTEzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSGF2ZSBIVE1MQ2FudmFzRWxl bWVudCBjbGVhciBpdHMgYnVmZmVyIGFzIHNvb24gYXMgaXRzIHNjcmlwdCBleGVjdXRpb24gY29u dGV4dCBnb2VzIGF3YXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyNDUwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEhhdmUgSFRNTENhbnZhc0VsZW1lbnQgY2xlYXIgaXRzIGJ1ZmZlciBhcyBzb29uIGFz IGl0cyBzY3JpcHQgZXhlY3V0aW9uIGNvbnRleHQgZ29lcyBhd2F5LgorICAgICAgICBXZSB1c2Vk IHRvIGRvIHRoaXMgb25seSBpbiB0aGUgZGVzdHJ1Y3Rvciwgd2hpY2ggd291bGQgb25seSBnZXQg Y2FsbGVkIGFmdGVyIEdDIG9mIHRoZSBKUworICAgICAgICB3cmFwcGVyLiBUaGlzIHdvdWxkIGRl bGF5IHJlbGVhc2Ugb2YgdGhlIEltYWdlQnVmZmVyIGFuZCBpdHMgbWVtb3J5IHVubmVjZXNzYXJp bHkuCisKKyAgICAgICAgKiBodG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxDYW52YXNFbGVtZW50OjpzdG9wKToKKyAgICAgICAgKiBodG1sL0hUTUxDYW52 YXNFbGVtZW50Lmg6CisKIDIwMjEtMDQtMTMgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjc1ODg5LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAppbmRleCA5Y2U5OWYzNmE3Mzc4 MzEzZDg4MmVhYjdhYjVjZGQ1YmQwMTYzNTExLi40NjE3YzRiNjFkY2M0ODcyZGVlYzcxZDNhOTE3 NjlmYTQ2ZjQyMzIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNF bGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNw cApAQCAtMTAyMyw2ICsxMDIzLDEyIEBAIGJvb2wgSFRNTENhbnZhc0VsZW1lbnQ6OnZpcnR1YWxI YXNQZW5kaW5nQWN0aXZpdHkoKSBjb25zdAogICAgIHJldHVybiBmYWxzZTsKIH0KIAordm9pZCBI VE1MQ2FudmFzRWxlbWVudDo6c3RvcCgpCit7CisgICAgbV9jb250ZXh0ID0gbnVsbHB0cjsgLy8g RW5zdXJlIHRoaXMgZ29lcyBhd2F5IGJlZm9yZSB0aGUgSW1hZ2VCdWZmZXIuCisgICAgc2V0SW1h Z2VCdWZmZXIobnVsbHB0cik7Cit9CisKIHZvaWQgSFRNTENhbnZhc0VsZW1lbnQ6OmV2ZW50TGlz dGVuZXJzRGlkQ2hhbmdlKCkKIHsKICNpZiBFTkFCTEUoV0VCR0wpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxDYW52YXNFbGVtZW50LmgKaW5kZXggMDQyMzI2OGQ2NTBiOWYwZTVkNTdjNDg3MTBjOGRh ZmM3MjJjOTQzMy4uZTVjYjA5YTAwNzUxZGVmMWYxODE5ZmQzMjhjNzM0M2EwZTY0YTQ3OSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuaApAQCAtMTUwLDYgKzE1MCw3IEBA IHByaXZhdGU6CiAgICAgLy8gQWN0aXZlRE9NT2JqZWN0LgogICAgIGNvbnN0IGNoYXIqIGFjdGl2 ZURPTU9iamVjdE5hbWUoKSBjb25zdCBmaW5hbDsKICAgICBib29sIHZpcnR1YWxIYXNQZW5kaW5n QWN0aXZpdHkoKSBjb25zdCBmaW5hbDsKKyAgICB2b2lkIHN0b3AoKSBmaW5hbDsKIAogICAgIC8v IEV2ZW50VGFyZ2V0LgogICAgIHZvaWQgZXZlbnRMaXN0ZW5lcnNEaWRDaGFuZ2UoKSBmaW5hbDsK 425906 2021-04-13 13:10:01 -0700 2021-04-13 15:57:31 -0700 Patch bug-224500-20210413131000.patch text/plain 2091 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1ODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjQzODJkZTkzN2FhYmE4 OGVlNTZkNmNiZDJkZGQxM2U0Y2YzYjAzMy4uN2VjNWM3YzQ0MGI4ZjEwMWE3MWM3YTRkODUyN2Zj M2RkN2Y4OWUyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA0LTEzICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgSGF2ZSBIVE1MQ2FudmFzRWxl bWVudCBjbGVhciBpdHMgYnVmZmVyIGFzIHNvb24gYXMgaXRzIHNjcmlwdCBleGVjdXRpb24gY29u dGV4dCBnb2VzIGF3YXkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyNDUwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEhhdmUgSFRNTENhbnZhc0VsZW1lbnQgY2xlYXIgaXRzIGJ1ZmZlciBhcyBzb29uIGFz IGl0cyBzY3JpcHQgZXhlY3V0aW9uIGNvbnRleHQgZ29lcyBhd2F5LgorICAgICAgICBXZSB1c2Vk IHRvIGRvIHRoaXMgb25seSBpbiB0aGUgZGVzdHJ1Y3Rvciwgd2hpY2ggd291bGQgb25seSBnZXQg Y2FsbGVkIGFmdGVyIEdDIG9mIHRoZSBKUworICAgICAgICB3cmFwcGVyLiBUaGlzIHdvdWxkIGRl bGF5IHJlbGVhc2Ugb2YgdGhlIEltYWdlQnVmZmVyIGFuZCBpdHMgbWVtb3J5IHVubmVjZXNzYXJp bHkuCisKKyAgICAgICAgKiBodG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxDYW52YXNFbGVtZW50OjpzdG9wKToKKyAgICAgICAgKiBodG1sL0hUTUxDYW52 YXNFbGVtZW50Lmg6CisKIDIwMjEtMDQtMTMgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjc1ODg5LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAppbmRleCA5Y2U5OWYzNmE3Mzc4 MzEzZDg4MmVhYjdhYjVjZGQ1YmQwMTYzNTExLi5kY2ViNTgwYTEyMTRiMjRkNmZhZWU5MzNmMWQ4 YzI0N2E1YmNlMmM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNF bGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNw cApAQCAtMTAyMyw2ICsxMDIzLDExIEBAIGJvb2wgSFRNTENhbnZhc0VsZW1lbnQ6OnZpcnR1YWxI YXNQZW5kaW5nQWN0aXZpdHkoKSBjb25zdAogICAgIHJldHVybiBmYWxzZTsKIH0KIAordm9pZCBI VE1MQ2FudmFzRWxlbWVudDo6c3RvcCgpCit7CisgICAgc2V0SW1hZ2VCdWZmZXIobnVsbHB0cik7 Cit9CisKIHZvaWQgSFRNTENhbnZhc0VsZW1lbnQ6OmV2ZW50TGlzdGVuZXJzRGlkQ2hhbmdlKCkK IHsKICNpZiBFTkFCTEUoV0VCR0wpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxDYW52YXNFbGVtZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50 LmgKaW5kZXggMDQyMzI2OGQ2NTBiOWYwZTVkNTdjNDg3MTBjOGRhZmM3MjJjOTQzMy4uZTVjYjA5 YTAwNzUxZGVmMWYxODE5ZmQzMjhjNzM0M2EwZTY0YTQ3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv SFRNTENhbnZhc0VsZW1lbnQuaApAQCAtMTUwLDYgKzE1MCw3IEBAIHByaXZhdGU6CiAgICAgLy8g QWN0aXZlRE9NT2JqZWN0LgogICAgIGNvbnN0IGNoYXIqIGFjdGl2ZURPTU9iamVjdE5hbWUoKSBj b25zdCBmaW5hbDsKICAgICBib29sIHZpcnR1YWxIYXNQZW5kaW5nQWN0aXZpdHkoKSBjb25zdCBm aW5hbDsKKyAgICB2b2lkIHN0b3AoKSBmaW5hbDsKIAogICAgIC8vIEV2ZW50VGFyZ2V0LgogICAg IHZvaWQgZXZlbnRMaXN0ZW5lcnNEaWRDaGFuZ2UoKSBmaW5hbDsK