<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>224497</bug_id>
          
          <creation_ts>2021-04-13 11:29:43 -0700</creation_ts>
          <short_desc>[build.webkit.org] run-javascriptcore-tests should report commit identifier instead of svn revision to results.webkit.org</short_desc>
          <delta_ts>2021-05-12 15:10:53 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>ASSIGNED</bug_status>
          <resolution></resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=222282</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1749761</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2021-04-13 11:29:43 -0700</bug_when>
    <thetext>On build.webkit.org run-javascriptcore-tests should report commit identifier instead of svn revision to results.webkit.org.

Current logic seems to be finding the revision/hash using commitForDirectory() method in https://github.com/WebKit/WebKit/blob/main/Tools/Scripts/VCSUtils.pm#L382. We can update that logic to return commit identifier.

Other options are:
- run-javascriptcore-tests script can accept a parameter named commit-identifier/ref and buildbot can pass that parameter based on &apos;identifier&apos; build property.
- do nothing, when we move build.webkit.org bots to git, run-javascriptcore-tests will start reporting git hash to results.webkit.org</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1752352</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-04-20 11:30:24 -0700</bug_when>
    <thetext>&lt;rdar://problem/76907517&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>