224494 2021-04-13 11:12:26 -0700 The watchdog should not fire when it's not active. 2021-04-13 19:20:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1749751 0 mark.lam 2021-04-13 11:12:26 -0700 This is needed because JSValue::toWTFStringSlowCase() can throw exceptions and do many other VM operations. rdar://76581259 1749752 1 425886 mark.lam 2021-04-13 11:16:23 -0700 Created attachment 425886 proposed patch. 1749755 2 425887 mark.lam 2021-04-13 11:20:22 -0700 Created attachment 425887 proposed patch. 1749883 3 425919 mark.lam 2021-04-13 14:57:09 -0700 Created attachment 425919 proposed patch. 1749889 4 425919 ysuzuki 2021-04-13 15:04:14 -0700 Comment on attachment 425919 proposed patch. r=me too. 1749972 5 mark.lam 2021-04-13 19:17:08 -0700 The mac-AS-debug-wk2 failure is unrelated. 1749973 6 mark.lam 2021-04-13 19:20:14 -0700 Thanks for the reviews. Landed in r275924: <http://trac.webkit.org/r275924>. 425886 2021-04-13 11:16:23 -0700 2021-04-13 11:20:22 -0700 proposed patch. bug-224494.patch text/plain 1864 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc1ODk0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDIxLTA0LTEzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBK U1ZhbHVlOjp0b1dURlN0cmluZ1Nsb3dDYXNlKCkgc2hvdWxkIGhhdmUgYSBWTUVudHJ5U2NvcGUu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ0OTQK KyAgICAgICAgcmRhcjovLzc2NTgxMjU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBuZWVkZWQgYmVjYXVzZSBKU1ZhbHVlOjp0b1dURlN0 cmluZ1Nsb3dDYXNlKCkgY2FuIHRocm93IGV4Y2VwdGlvbnMgYW5kIGRvCisgICAgICAgIG1hbnkg b3RoZXIgVk0gb3BlcmF0aW9ucy4KKworICAgICAgICAqIHJ1bnRpbWUvSlNDSlNWYWx1ZS5jcHA6 CisgICAgICAgIChKU0M6OkpTVmFsdWU6OnRvV1RGU3RyaW5nU2xvd0Nhc2UgY29uc3QpOgorCiAy MDIxLTA0LTEzICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgY2FzdGluZyB0byB1bnNpZ25lZCBsb25nIGxvbmcgdG8gc3VwcHJlc3Mgd2Fy bmluZwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNDSlNWYWx1ZS5j cHAJKHJldmlzaW9uIDI3NTg2NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT Q0pTVmFsdWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xLDcgKzEsNyBAQAogLyoKICAqICBDb3B5 cmlnaHQgKEMpIDE5OTktMjAwMSBIYXJyaSBQb3J0ZW4gKHBvcnRlbkBrZGUub3JnKQogICogIENv cHlyaWdodCAoQykgMjAwMSBQZXRlciBLZWxseSAocG1rQHBvc3QuY29tKQotICogIENvcHlyaWdo dCAoQykgMjAwMy0yMDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqICBDb3B5 cmlnaHQgKEMpIDIwMDMtMjAyMSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgog ICogIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBp dCBhbmQvb3IKICAqICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFy eSBHZW5lcmFsIFB1YmxpYwpAQCAtMzIsNiArMzIsNyBAQAogI2luY2x1ZGUgIk51bWJlck9iamVj dC5oIgogI2luY2x1ZGUgIlBhcnNlSW50LmgiCiAjaW5jbHVkZSAiVHlwZUVycm9yLmgiCisjaW5j bHVkZSAiVk1FbnRyeVNjb3BlLmgiCiAKIG5hbWVzcGFjZSBKU0MgewogCkBAIC01MDcsNiArNTA4 LDggQEAgU3RyaW5nIEpTVmFsdWU6OnRvV1RGU3RyaW5nU2xvd0Nhc2UoSlNHbAogewogICAgIFZN JiB2bSA9IGdsb2JhbE9iamVjdC0+dm0oKTsKICAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9USFJP V19TQ09QRSh2bSk7CisgICAgVk1FbnRyeVNjb3BlIGVudHJ5U2NvcGUodm0sIGdsb2JhbE9iamVj dCk7CisKICAgICBpZiAoaXNJbnQzMigpKQogICAgICAgICByZXR1cm4gdm0ubnVtZXJpY1N0cmlu Z3MuYWRkKGFzSW50MzIoKSk7CiAgICAgaWYgKGlzRG91YmxlKCkpCg== 425887 2021-04-13 11:20:22 -0700 2021-04-13 12:18:29 -0700 proposed patch. bug-224494.patch text/plain 1992 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc1ODk0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDIxLTA0LTEzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBK U1ZhbHVlOjp0b1dURlN0cmluZ1Nsb3dDYXNlKCkgc2hvdWxkIGhhdmUgYSBWTUVudHJ5U2NvcGUu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjQ0OTQK KyAgICAgICAgcmRhcjovLzc2NTgxMjU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBuZWVkZWQgYmVjYXVzZSBKU1ZhbHVlOjp0b1dURlN0 cmluZ1Nsb3dDYXNlKCkgY2FuIHRocm93IGV4Y2VwdGlvbnMgYW5kIGRvCisgICAgICAgIG1hbnkg b3RoZXIgVk0gb3BlcmF0aW9ucy4gIHRvV1RGU3RyaW5nKCkgY2FuIGJlIGNhbGxlZCBieSB2YXJp b3VzIEFQSSBmdW5jdGlvbnMKKyAgICAgICAgYmVmb3JlIHRoZSBWTSBpcyBlbnRlcmVkLiAgSGVu Y2UsIGl0IG5lZWRzIGl0cyBvd24gVk1FbnRyeVNjb3BlLgorCisgICAgICAgICogcnVudGltZS9K U0NKU1ZhbHVlLmNwcDoKKyAgICAgICAgKEpTQzo6SlNWYWx1ZTo6dG9XVEZTdHJpbmdTbG93Q2Fz ZSBjb25zdCk6CisKIDIwMjEtMDQtMTMgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCBjYXN0aW5nIHRvIHVuc2lnbmVkIGxvbmcgbG9uZyB0 byBzdXBwcmVzcyB3YXJuaW5nCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0NKU1ZhbHVlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU0NKU1ZhbHVlLmNwcAkocmV2aXNpb24gMjc1ODY2KQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvSlNDSlNWYWx1ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEsNyArMSw3IEBA CiAvKgogICogIENvcHlyaWdodCAoQykgMTk5OS0yMDAxIEhhcnJpIFBvcnRlbiAocG9ydGVuQGtk ZS5vcmcpCiAgKiAgQ29weXJpZ2h0IChDKSAyMDAxIFBldGVyIEtlbGx5IChwbWtAcG9zdC5jb20p Ci0gKiAgQ29weXJpZ2h0IChDKSAyMDAzLTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2Vy dmVkLgorICogIENvcHlyaWdodCAoQykgMjAwMy0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyBy ZXNlcnZlZC4KICAqCiAgKiAgVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4g cmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2Yg dGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCkBAIC0zMiw2ICszMiw3IEBACiAjaW5jbHVk ZSAiTnVtYmVyT2JqZWN0LmgiCiAjaW5jbHVkZSAiUGFyc2VJbnQuaCIKICNpbmNsdWRlICJUeXBl RXJyb3IuaCIKKyNpbmNsdWRlICJWTUVudHJ5U2NvcGUuaCIKIAogbmFtZXNwYWNlIEpTQyB7CiAK QEAgLTUwNyw2ICs1MDgsOCBAQCBTdHJpbmcgSlNWYWx1ZTo6dG9XVEZTdHJpbmdTbG93Q2FzZShK U0dsCiB7CiAgICAgVk0mIHZtID0gZ2xvYmFsT2JqZWN0LT52bSgpOwogICAgIGF1dG8gc2NvcGUg PSBERUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKKyAgICBWTUVudHJ5U2NvcGUgZW50cnlTY29wZSh2 bSwgZ2xvYmFsT2JqZWN0KTsKKwogICAgIGlmIChpc0ludDMyKCkpCiAgICAgICAgIHJldHVybiB2 bS5udW1lcmljU3RyaW5ncy5hZGQoYXNJbnQzMigpKTsKICAgICBpZiAoaXNEb3VibGUoKSkK 425919 2021-04-13 14:57:09 -0700 2021-04-13 18:43:20 -0700 proposed patch. bug-224494.patch text/plain 2607 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc1OTEyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDIxLTA0LTEzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBU aGUgd2F0Y2hkb2cgc2hvdWxkIG5vdCBmaXJlIHdoZW4gaXQncyBub3QgYWN0aXZlLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NDk0CisgICAgICAg IHJkYXI6Ly83NjU4MTI1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSB3YXRjaGRvZyBpcyBvbmx5IGFjdGl2ZSB3aGVuIHdlIGhhdmUgZW50ZXJl ZCB0aGUgVk0uICBJZiB3ZSBoYXZlbid0IGVudGVyZWQKKyAgICAgICAgdGhlIFZNLCB3ZSBwb3N0 cG9uZSBzdGFydGluZyB0aGUgd2F0Y2hkb2cuICBGb3IgZXhhbXBsZSwgc2VlIFdhdGNoZG9nOjpl bnRlcmVkVk0oKQorICAgICAgICBhbmQgV2F0Y2hkb2c6OmV4aXRlZFZNKCkuCisKKyAgICAgICAg VGhlIHVuZGVybHlpbmcgdGltZXIgbWF5IHN0aWxsIGZpcmUgdGhlIE5lZWRXYXRjaGRvZ0NoZWNr IGV2ZW50IGFmdGVyCisgICAgICAgIFdhdGNoZG9nOjpzdG9wVGltZXIoKSBpcyBjYWxsZWQuICBT bywgd2UgbmVlZCB0byBqdXN0IGlnbm9yZSB0aGUgZXZlbnQgaWYgdGhlCisgICAgICAgIHdhdGNo ZG9nIGlzbid0IGFjdGl2ZS4KKworICAgICAgICAqIHJ1bnRpbWUvVk1UcmFwcy5jcHA6CisgICAg ICAgIChKU0M6OlZNVHJhcHM6OmhhbmRsZVRyYXBzKToKKyAgICAgICAgKiBydW50aW1lL1dhdGNo ZG9nLmg6CisgICAgICAgIChKU0M6OldhdGNoZG9nOjppc0FjdGl2ZSBjb25zdCk6CisKIDIwMjEt MDQtMTMgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBhIEpT U3RyaW5nIGZvciB0aGUgVGVybWluYXRpb25FeGNlcHRpb24gdmFsdWUgaW5zdGVhZCBvZiBhIFN5 bWJvbC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNVHJhcHMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNVHJhcHMuY3BwCShy ZXZpc2lvbiAyNzU4OTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTVRyYXBz LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzgwLDggKzM4MCw3IEBAIHZvaWQgVk1UcmFwczo6aGFu ZGxlVHJhcHMoVk1UcmFwczo6Qml0RmkKIAogICAgICAgICBjYXNlIE5lZWRXYXRjaGRvZ0NoZWNr OgogICAgICAgICAgICAgQVNTRVJUKHZtLndhdGNoZG9nKCkpOwotICAgICAgICAgICAgQVNTRVJU KHZtLmVudHJ5U2NvcGUtPmdsb2JhbE9iamVjdCgpKTsKLSAgICAgICAgICAgIGlmIChMSUtFTFko IXZtLndhdGNoZG9nKCktPnNob3VsZFRlcm1pbmF0ZSh2bS5lbnRyeVNjb3BlLT5nbG9iYWxPYmpl Y3QoKSkpKQorICAgICAgICAgICAgaWYgKExJS0VMWSghdm0ud2F0Y2hkb2coKS0+aXNBY3RpdmUo KSB8fCAhdm0ud2F0Y2hkb2coKS0+c2hvdWxkVGVybWluYXRlKHZtLmVudHJ5U2NvcGUtPmdsb2Jh bE9iamVjdCgpKSkpCiAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgICAgICB2bS5z ZXRUZXJtaW5hdGlvbkluUHJvZ3Jlc3ModHJ1ZSk7CiAgICAgICAgICAgICBGQUxMVEhST1VHSDsK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1dhdGNoZG9nLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2F0Y2hkb2cuaAkocmV2aXNpb24g Mjc1ODk2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2F0Y2hkb2cuaAkod29y a2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTMtMjAx NyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTMt MjAyMSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRp b24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAg KiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5n IGNvbmRpdGlvbnMKQEAgLTUwLDYgKzUwLDggQEAgcHVibGljOgogCiAgICAgYm9vbCBzaG91bGRU ZXJtaW5hdGUoSlNHbG9iYWxPYmplY3QqKTsKIAorICAgIGJvb2wgaXNBY3RpdmUoKSBjb25zdCB7 IHJldHVybiBtX2hhc0VudGVyZWRWTTsgfQorCiAgICAgYm9vbCBoYXNUaW1lTGltaXQoKTsKICAg ICB2b2lkIGVudGVyZWRWTSgpOwogICAgIHZvaWQgZXhpdGVkVk0oKTsK