224491 2021-04-13 09:58:26 -0700 Fix typo in GPUProcessConnection::enableVP9Decoders() 2021-04-13 10:43:13 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez darin eric.carlson jer.noble kkinnunen peng.liu6 webkit-bug-importer youennf oldest_to_newest 1749720 0 cdumez 2021-04-13 09:58:26 -0700 Fix typo in GPUProcessConnection::enableVP9Decoders(). 1749721 1 425880 cdumez 2021-04-13 09:59:37 -0700 Created attachment 425880 Patch 1749723 2 425880 peng.liu6 2021-04-13 10:04:48 -0700 Comment on attachment 425880 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=425880&action=review > Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:271 > + m_enableVP8Decoder = enableVP8Decoder; Thanks for the fix. By the way, not relevant to this bug, I think we can use a better function name, e.g., enableVPxDecoders(). :-) 1749724 3 425880 darin 2021-04-13 10:05:38 -0700 Comment on attachment 425880 Patch Surprised there is no symptom of this bug. Seems like we might be able to test it. 1749727 4 cdumez 2021-04-13 10:10:02 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 425880 [details] > Patch > > Surprised there is no symptom of this bug. Seems like we might be able to > test it. It may well be but I'd appreciate if a media person could take a look at that. I uploaded a fix because the issue was spotted during a review on one of my patch. However, I am not familiar with this code at all. That said, I think the bug would be fairly subtle since we're sending the correct value over IPC. We're merely caching the wrong value on the connection. I guess the bug would be when changing the setting value. In some cases, it may not take the change into account on GPUProcess side. 1749734 5 ews-feeder 2021-04-13 10:42:43 -0700 Committed r275893 (236458@main): <https://commits.webkit.org/236458@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425880. 1749735 6 webkit-bug-importer 2021-04-13 10:43:13 -0700 <rdar://problem/76599225> 425880 2021-04-13 09:59:37 -0700 2021-04-13 10:42:44 -0700 Patch bug-224491-20210413095936.patch text/plain 1597 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc1ODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY2ZWE5NDE3MDhjMzhjZTRj YWMwYTFiMGJjZjcwZDY3MDcwMDQ2NzQuLjg4ZGQ5ZTUzYTBjNzc2M2M0M2E4MGVmNmE5MTNlNTlm MTU3YjZjZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDQtMTMgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggdHlwbyBpbiBHUFVQcm9jZXNz Q29ubmVjdGlvbjo6ZW5hYmxlVlA5RGVjb2RlcnMoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NDkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS9HUFVQcm9jZXNzQ29ubmVj dGlvbi5jcHA6CisgICAgICAgIChXZWJLaXQ6OkdQVVByb2Nlc3NDb25uZWN0aW9uOjplbmFibGVW UDlEZWNvZGVycyk6CisKIDIwMjEtMDQtMTMgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjc1ODg5LgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9HUFVQcm9jZXNzQ29ubmVjdGlv bi5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL0dQVVByb2Nlc3NDb25uZWN0aW9u LmNwcAppbmRleCAxNDI4ZDRjZDA4OTI2NDM3ODdiNTdkOGU3ZjQ2Mjc0MjViNDAzZjgxLi41Mjcx ZmM2MGYyNWNkYmZlZTVhYTExNWRmNzVhODBkM2Y1MjdjM2VjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvR1BVL0dQVVByb2Nlc3NDb25uZWN0aW9uLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL0dQVVByb2Nlc3NDb25uZWN0aW9uLmNwcApAQCAtMjY4 LDcgKzI2OCw3IEBAIHZvaWQgR1BVUHJvY2Vzc0Nvbm5lY3Rpb246OmVuYWJsZVZQOURlY29kZXJz KGJvb2wgZW5hYmxlVlA4RGVjb2RlciwgYm9vbCBlbmFibGVWCiAgICAgaWYgKG1fZW5hYmxlVlA4 RGVjb2RlciA9PSBlbmFibGVWUDhEZWNvZGVyICYmIG1fZW5hYmxlVlA5RGVjb2RlciA9PSBlbmFi bGVWUDlEZWNvZGVyICYmIG1fZW5hYmxlVlA5U1dEZWNvZGVyID09IGVuYWJsZVZQOVNXRGVjb2Rl cikKICAgICAgICAgcmV0dXJuOwogCi0gICAgbV9lbmFibGVWUDlEZWNvZGVyID0gZW5hYmxlVlA4 RGVjb2RlcjsKKyAgICBtX2VuYWJsZVZQOERlY29kZXIgPSBlbmFibGVWUDhEZWNvZGVyOwogICAg IG1fZW5hYmxlVlA5RGVjb2RlciA9IGVuYWJsZVZQOURlY29kZXI7CiAgICAgbV9lbmFibGVWUDlT V0RlY29kZXIgPSBlbmFibGVWUDlTV0RlY29kZXI7CiAgICAgY29ubmVjdGlvbigpLnNlbmQoTWVz c2FnZXM6OkdQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OkVuYWJsZVZQOURlY29kZXJzKGVuYWJs ZVZQOERlY29kZXIsIGVuYWJsZVZQOURlY29kZXIsIGVuYWJsZVZQOVNXRGVjb2RlciksIHsgfSk7 Cg==