224490 2021-04-13 09:57:04 -0700 Use a JSString for the TerminationException value instead of a Symbol. 2021-04-13 12:58:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1749718 0 mark.lam 2021-04-13 09:57:04 -0700 This makes it convertible to a String for clients that wish to report the exception. Clients, in this case, does not apply to JS code, only C++ code that catches the exception at the outermost point to handle the termination. The TerminationException value is not visible to JS code because the TerminationException cannot be caught. So, this change is transparent to JS code. 1749746 1 425885 mark.lam 2021-04-13 11:02:36 -0700 Created attachment 425885 proposed patch. 1749771 2 425885 ysuzuki 2021-04-13 11:43:25 -0700 Comment on attachment 425885 proposed patch. r=me 1749801 3 425885 mark.lam 2021-04-13 12:37:33 -0700 Comment on attachment 425885 proposed patch. Thanks for the review. Landing now. 1749817 4 ews-feeder 2021-04-13 12:57:03 -0700 Committed r275902 (236467@main): <https://commits.webkit.org/236467@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425885. 1749819 5 webkit-bug-importer 2021-04-13 12:58:15 -0700 <rdar://problem/76605985> 425885 2021-04-13 11:02:36 -0700 2021-04-13 12:57:04 -0700 proposed patch. bug-224490.patch text/plain 2029 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjc1ODkwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDIxLTA0LTEzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBV c2UgYSBKU1N0cmluZyBmb3IgdGhlIFRlcm1pbmF0aW9uRXhjZXB0aW9uIHZhbHVlIGluc3RlYWQg b2YgYSBTeW1ib2wuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjQ0OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIG1ha2VzIGl0IGNvbnZlcnRpYmxlIHRvIGEgU3RyaW5nIGZvciBjbGllbnRzIHRo YXQgd2lzaCB0byByZXBvcnQgdGhlIGV4Y2VwdGlvbi4KKyAgICAgICAgQ2xpZW50cywgaW4gdGhp cyBjYXNlLCBkb2VzIG5vdCBhcHBseSB0byBKUyBjb2RlLCBvbmx5IEMrKyBjb2RlIHRoYXQgY2F0 Y2hlcyB0aGUKKyAgICAgICAgZXhjZXB0aW9uIGF0IHRoZSBvdXRlcm1vc3QgcG9pbnQgdG8gaGFu ZGxlIHRoZSB0ZXJtaW5hdGlvbi4gIFRoZSBUZXJtaW5hdGlvbkV4Y2VwdGlvbgorICAgICAgICB2 YWx1ZSBpcyBub3QgdmlzaWJsZSB0byBKUyBjb2RlIGJlY2F1c2UgdGhlIFRlcm1pbmF0aW9uRXhj ZXB0aW9uIGNhbm5vdCBiZSBjYXVnaHQuCisgICAgICAgIFNvLCB0aGlzIGNoYW5nZSBpcyB0cmFu c3BhcmVudCB0byBKUyBjb2RlLgorCisgICAgICAgICogcnVudGltZS9WTS5jcHA6CisgICAgICAg IChKU0M6OlZNOjplbnN1cmVUZXJtaW5hdGlvbkV4Y2VwdGlvbik6CisKIDIwMjEtMDQtMTMgIFl1 c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBj YXN0aW5nIHRvIHVuc2lnbmVkIGxvbmcgbG9uZyB0byBzdXBwcmVzcyB3YXJuaW5nCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk0uY3BwCShyZXZpc2lvbiAyNzU4NjYpCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9WTS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc2Mywx MiArNzYzLDExIEBAIFNhbXBsaW5nUHJvZmlsZXImIFZNOjplbnN1cmVTYW1wbGluZ1Byb2YKIH0K ICNlbmRpZiAvLyBFTkFCTEUoU0FNUExJTkdfUFJPRklMRVIpCiAKLXN0YXRpYyBTeW1ib2xJbXBs OjpTdGF0aWNTeW1ib2xJbXBsIHRlcm1pbmF0aW9uRXJyb3JTeW1ib2wgeyAiVGVybWluYXRpb25F cnJvciIsIFN5bWJvbEltcGw6OnNfZmxhZ0lzUHJpdmF0ZSB9OwotCitzdGF0aWMgU3RyaW5nSW1w bDo6U3RhdGljU3RyaW5nSW1wbCB0ZXJtaW5hdGlvbkVycm9yU3RyaW5nIHsgIkphdmFTY3JpcHQg ZXhlY3V0aW9uIHRlcm1pbmF0ZWQuIiB9OwogRXhjZXB0aW9uKiBWTTo6ZW5zdXJlVGVybWluYXRp b25FeGNlcHRpb24oKQogewogICAgIGlmICghbV90ZXJtaW5hdGlvbkV4Y2VwdGlvbikgewotICAg ICAgICBTeW1ib2wqIHRlcm1pbmF0aW9uRXJyb3IgPSBTeW1ib2w6OmNyZWF0ZSgqdGhpcywgdGVy bWluYXRpb25FcnJvclN5bWJvbCk7CisgICAgICAgIEpTU3RyaW5nKiB0ZXJtaW5hdGlvbkVycm9y ID0ganNOb250cml2aWFsU3RyaW5nKCp0aGlzLCB0ZXJtaW5hdGlvbkVycm9yU3RyaW5nKTsKICAg ICAgICAgbV90ZXJtaW5hdGlvbkV4Y2VwdGlvbiA9IEV4Y2VwdGlvbjo6Y3JlYXRlKCp0aGlzLCB0 ZXJtaW5hdGlvbkVycm9yLCBFeGNlcHRpb246OkRvTm90Q2FwdHVyZVN0YWNrKTsKICAgICB9CiAg ICAgcmV0dXJuIG1fdGVybWluYXRpb25FeGNlcHRpb247Cg==