22449 2008-11-24 01:38:21 -0800 Implement repatching for get by id chain. 2008-11-24 02:29:08 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 99910 0 barraclough 2008-11-24 01:38:21 -0800 Will be a 3% progression on deltablue. 99911 1 25417 barraclough 2008-11-24 01:38:44 -0800 Created attachment 25417 The patch 99912 2 25417 zwarich 2008-11-24 01:50:46 -0800 Comment on attachment 25417 The patch Add a reference to the bug number in the ChangeLog. I also think that an explanation of the code changes in the ChangeLog would be nice as well. > for (unsigned i = 0; i<count; ++i) { There should be spaces on either side of '<'. I prefer currentStructure to currStructure, but we use currStructure elsewhere, so you might as well stick with it for this patch. r=me 99913 3 25417 zwarich 2008-11-24 01:50:46 -0800 Comment on attachment 25417 The patch Add a reference to the bug number in the ChangeLog. I also think that an explanation of the code changes in the ChangeLog would be nice as well. > for (unsigned i = 0; i<count; ++i) { There should be spaces on either side of '<'. I prefer currentStructure to currStructure, but we use currStructure elsewhere, so you might as well stick with it for this patch. r=me 99920 4 barraclough 2008-11-24 02:29:08 -0800 Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/jit/JIT.cpp Transmitting file data .. Committed revision 38700. 25417 2008-11-24 01:38:44 -0800 2008-11-24 01:50:46 -0800 The patch patch.chain.txt text/plain 5938 barraclough SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4Njk5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTEt MjQgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCByZXBhdGNo aW5nIGZvciBnZXQgYnkgaWQgY2hhaW4uCisgICAgICAgIDMlIHByb2dyZXNzaW9uIG9uIGRlbHRh Ymx1ZS4KKworICAgICAgICAqIGppdC9KSVQuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OnByaXZh dGVDb21waWxlR2V0QnlJZFByb3RvKToKKyAgICAgICAgKEpTQzo6SklUOjpwcml2YXRlQ29tcGls ZUdldEJ5SWRDaGFpbik6CisKIDIwMDgtMTEtMjQgIEpvZXJnIEJvcm5lbWFubiAgPGpvZXJnLmJv cm5lbWFubkB0cm9sbHRlY2guY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNt YW5uLgpJbmRleDogaml0L0pJVC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gaml0L0pJVC5jcHAJKHJldmlz aW9uIDM4Njk5KQorKysgaml0L0pJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxNDYsMTEgKzMx NDYsOCBAQCB2b2lkIEpJVDo6cHJpdmF0ZUNvbXBpbGVHZXRCeUlkUHJvdG8oU3RyCiAgICAgU3Ry dWN0dXJlU3R1YkluZm8mIGluZm8gPSBtX2NvZGVCbG9jay0+Z2V0U3R1YkluZm8ocmV0dXJuQWRk cmVzcyk7CiAKICAgICAvLyBXZSBkb24ndCB3YW50IHRvIHJlcGF0Y2ggbW9yZSB0aGFuIG9uY2Ug LSBpbiBmdXR1cmUgZ28gdG8gY3RpX29wX3B1dF9ieV9pZF9nZW5lcmljLgotI2lmIFVTRShDVElf UkVQQVRDSF9QSUMpCiAgICAgY3RpUmVwYXRjaENhbGxCeVJldHVybkFkZHJlc3MocmV0dXJuQWRk cmVzcywgcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oSW50ZXJwcmV0ZXI6OmN0aV9vcF9nZXRfYnlf aWRfcHJvdG9fbGlzdCkpOwotI2Vsc2UKLSAgICBjdGlSZXBhdGNoQ2FsbEJ5UmV0dXJuQWRkcmVz cyhyZXR1cm5BZGRyZXNzLCByZWludGVycHJldF9jYXN0PHZvaWQqPihJbnRlcnByZXRlcjo6Y3Rp X29wX2dldF9ieV9pZF9wcm90b19mYWlsKSk7Ci0jZW5kaWYKKwogICAgIC8vIFRoZSBwcm90b3R5 cGUgb2JqZWN0IGRlZmluaXRlbHkgZXhpc3RzIChpZiB0aGlzIHN0dWIgZXhpc3RzIHRoZSBDb2Rl QmxvY2sgaXMgcmVmZXJlbmNpbmcgYSBTdHJ1Y3R1cmUgdGhhdCBpcwogICAgIC8vIHJlZmVyZW5j aW5nIHRoZSBwcm90b3R5cGUgb2JqZWN0IC0gbGV0J3Mgc3BlY3VsYXRpdmVseSBsb2FkIGl0J3Mg dGFibGUgbmljZSBhbmQgZWFybHkhKQogICAgIEpTT2JqZWN0KiBwcm90b09iamVjdCA9IGFzT2Jq ZWN0KHN0cnVjdHVyZS0+cHJvdG90eXBlRm9yTG9va3VwKGNhbGxGcmFtZSkpOwpAQCAtMzIxNCwx NSArMzIxMSw5IEBAIHZvaWQgSklUOjpwcml2YXRlQ29tcGlsZUdldEJ5SWRQcm90byhTdHIKIAog ICAgIHZvaWQqIGNvZGUgPSBfXyBleGVjdXRhYmxlQ29weSgpOwogCi0jaWYgVVNFKENUSV9SRVBB VENIX1BJQykKLSAgICBYODZBc3NlbWJsZXI6OmxpbmsoY29kZSwgZmFpbHVyZUNhc2VzMSwgcmVp bnRlcnByZXRfY2FzdDx2b2lkKj4oSW50ZXJwcmV0ZXI6OmN0aV9vcF9nZXRfYnlfaWRfcHJvdG9f bGlzdCkpOwotICAgIFg4NkFzc2VtYmxlcjo6bGluayhjb2RlLCBmYWlsdXJlQ2FzZXMyLCByZWlu dGVycHJldF9jYXN0PHZvaWQqPihJbnRlcnByZXRlcjo6Y3RpX29wX2dldF9ieV9pZF9wcm90b19s aXN0KSk7Ci0gICAgWDg2QXNzZW1ibGVyOjpsaW5rKGNvZGUsIGZhaWx1cmVDYXNlczMsIHJlaW50 ZXJwcmV0X2Nhc3Q8dm9pZCo+KEludGVycHJldGVyOjpjdGlfb3BfZ2V0X2J5X2lkX3Byb3RvX2xp c3QpKTsKLSNlbHNlCiAgICAgWDg2QXNzZW1ibGVyOjpsaW5rKGNvZGUsIGZhaWx1cmVDYXNlczEs IHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KEludGVycHJldGVyOjpjdGlfb3BfZ2V0X2J5X2lkX3By b3RvX2ZhaWwpKTsKICAgICBYODZBc3NlbWJsZXI6OmxpbmsoY29kZSwgZmFpbHVyZUNhc2VzMiwg cmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oSW50ZXJwcmV0ZXI6OmN0aV9vcF9nZXRfYnlfaWRfcHJv dG9fZmFpbCkpOwogICAgIFg4NkFzc2VtYmxlcjo6bGluayhjb2RlLCBmYWlsdXJlQ2FzZXMzLCBy ZWludGVycHJldF9jYXN0PHZvaWQqPihJbnRlcnByZXRlcjo6Y3RpX29wX2dldF9ieV9pZF9wcm90 b19mYWlsKSk7Ci0jZW5kaWYKIAogICAgIG1fY29kZUJsb2NrLT5nZXRTdHViSW5mbyhyZXR1cm5B ZGRyZXNzKS5zdHViUm91dGluZSA9IGNvZGU7CiAKQEAgLTMzMDcsNiArMzI5OCwxMiBAQCB2b2lk IEpJVDo6cHJpdmF0ZUNvbXBpbGVHZXRCeUlkUHJvdG9MaXN0CiAKIHZvaWQgSklUOjpwcml2YXRl Q29tcGlsZUdldEJ5SWRDaGFpbihTdHJ1Y3R1cmUqIHN0cnVjdHVyZSwgU3RydWN0dXJlQ2hhaW4q IGNoYWluLCBzaXplX3QgY291bnQsIHNpemVfdCBjYWNoZWRPZmZzZXQsIHZvaWQqIHJldHVybkFk ZHJlc3MsIENhbGxGcmFtZSogY2FsbEZyYW1lKQogeworI2lmIFVTRShDVElfUkVQQVRDSF9QSUMp CisgICAgU3RydWN0dXJlU3R1YkluZm8mIGluZm8gPSBtX2NvZGVCbG9jay0+Z2V0U3R1YkluZm8o cmV0dXJuQWRkcmVzcyk7CisKKyAgICAvLyBXZSBkb24ndCB3YW50IHRvIHJlcGF0Y2ggbW9yZSB0 aGFuIG9uY2UgLSBpbiBmdXR1cmUgZ28gdG8gY3RpX29wX3B1dF9ieV9pZF9nZW5lcmljLgorICAg IGN0aVJlcGF0Y2hDYWxsQnlSZXR1cm5BZGRyZXNzKHJldHVybkFkZHJlc3MsIHJlaW50ZXJwcmV0 X2Nhc3Q8dm9pZCo+KEludGVycHJldGVyOjpjdGlfb3BfZ2V0X2J5X2lkX2dlbmVyaWMpKTsKKwog ICAgIEFTU0VSVChjb3VudCk7CiAgICAgCiAgICAgVmVjdG9yPEptcFNyYz4gYnVja2V0c09mRmFp bDsKQEAgLTMzMzMsOSArMzMzMCw1NCBAQCB2b2lkIEpJVDo6cHJpdmF0ZUNvbXBpbGVHZXRCeUlk Q2hhaW4oU3RyCiAgICAgUHJvcGVydHlTdG9yYWdlKiBwcm90b1Byb3BlcnR5U3RvcmFnZSA9ICZw cm90b09iamVjdC0+bV9wcm9wZXJ0eVN0b3JhZ2U7CiAgICAgX18gbW92bF9tcihzdGF0aWNfY2Fz dDx2b2lkKj4ocHJvdG9Qcm9wZXJ0eVN0b3JhZ2UpLCBYODY6OmVkeCk7CiAgICAgX18gbW92bF9t cihjYWNoZWRPZmZzZXQgKiBzaXplb2YoSlNWYWx1ZSopLCBYODY6OmVkeCwgWDg2OjplYXgpOwot ICAgIF9fIHJldCgpOworICAgIEptcFNyYyBzdWNjZXNzID0gX18gam1wKCk7CisKKyAgICB2b2lk KiBjb2RlID0gX18gZXhlY3V0YWJsZUNvcHkoKTsKKworICAgIC8vIFVzZSB0aGUgcmVwYXRjaCBp bmZvcm1hdGlvbiB0byBsaW5rIHRoZSBmYWlsdXJlIGNhc2VzIGJhY2sgdG8gdGhlIG9yaWdpbmFs IHNsb3cgY2FzZSByb3V0aW5lLgorICAgIHZvaWQqIHNsb3dDYXNlQmVnaW4gPSByZWludGVycHJl dF9jYXN0PGNoYXIqPihpbmZvLmNhbGxSZXR1cm5Mb2NhdGlvbikgLSByZXBhdGNoT2Zmc2V0R2V0 QnlJZFNsb3dDYXNlQ2FsbDsKKworICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBidWNrZXRz T2ZGYWlsLnNpemUoKTsgKytpKQorICAgICAgICBYODZBc3NlbWJsZXI6OmxpbmsoY29kZSwgYnVj a2V0c09mRmFpbFtpXSwgc2xvd0Nhc2VCZWdpbik7CisKKyAgICAvLyBPbiBzdWNjZXNzIHJldHVy biBiYWNrIHRvIHRoZSBob3QgcGF0Y2ggY29kZSwgYXQgYSBwb2ludCBpdCB3aWxsIHBlcmZvcm0g dGhlIHN0b3JlIHRvIGRlc3QgZm9yIHVzLgorICAgIGludHB0cl90IHN1Y2Nlc3NEZXN0ID0gcmVp bnRlcnByZXRfY2FzdDxpbnRwdHJfdD4oaW5mby5ob3RQYXRoQmVnaW4pICsgcmVwYXRjaE9mZnNl dEdldEJ5SWRQcm9wZXJ0eU1hcE9mZnNldDsKKyAgICBYODZBc3NlbWJsZXI6OmxpbmsoY29kZSwg c3VjY2VzcywgcmVpbnRlcnByZXRfY2FzdDx2b2lkKj4oc3VjY2Vzc0Rlc3QpKTsKKworICAgIC8v IFRyYWNrIHRoZSBzdHViIHdlIGhhdmUgY3JlYXRlZCBzbyB0aGF0IGl0IHdpbGwgYmUgZGVsZXRl ZCBsYXRlci4KKyAgICBpbmZvLnN0dWJSb3V0aW5lID0gY29kZTsKKworICAgIC8vIEZpbmFsbHkg cmVwYXRjaCB0aGUganVtcCB0byBzbG93IGNhc2UgYmFjayBpbiB0aGUgaG90IHBhdGggdG8ganVt cCBoZXJlIGluc3RlYWQuCisgICAgaW50cHRyX3Qgam1wTG9jYXRpb24gPSByZWludGVycHJldF9j YXN0PGludHB0cl90PihpbmZvLmhvdFBhdGhCZWdpbikgKyByZXBhdGNoT2Zmc2V0R2V0QnlJZEJy YW5jaFRvU2xvd0Nhc2U7CisgICAgWDg2QXNzZW1ibGVyOjpyZXBhdGNoQnJhbmNoT2Zmc2V0KGpt cExvY2F0aW9uLCBjb2RlKTsKKyNlbHNlCisgICAgQVNTRVJUKGNvdW50KTsKKyAgICAKKyAgICBW ZWN0b3I8Sm1wU3JjPiBidWNrZXRzT2ZGYWlsOworCisgICAgLy8gQ2hlY2sgZWF4IGlzIGFuIG9i amVjdCBvZiB0aGUgcmlnaHQgU3RydWN0dXJlLgorICAgIF9fIHRlc3RsX2kzMnIoSlNJbW1lZGlh dGU6OlRhZ01hc2ssIFg4Njo6ZWF4KTsKKyAgICBidWNrZXRzT2ZGYWlsLmFwcGVuZChfXyBqbmUo KSk7CisgICAgYnVja2V0c09mRmFpbC5hcHBlbmQoY2hlY2tTdHJ1Y3R1cmUoWDg2OjplYXgsIHN0 cnVjdHVyZSkpOworCisgICAgU3RydWN0dXJlKiBjdXJyU3RydWN0dXJlID0gc3RydWN0dXJlOwor ICAgIFJlZlB0cjxTdHJ1Y3R1cmU+KiBjaGFpbkVudHJpZXMgPSBjaGFpbi0+aGVhZCgpOworICAg IEpTT2JqZWN0KiBwcm90b09iamVjdCA9IDA7CisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaTxj b3VudDsgKytpKSB7CisgICAgICAgIHByb3RvT2JqZWN0ID0gYXNPYmplY3QoY3VyclN0cnVjdHVy ZS0+cHJvdG90eXBlRm9yTG9va3VwKGNhbGxGcmFtZSkpOworICAgICAgICBjdXJyU3RydWN0dXJl ID0gY2hhaW5FbnRyaWVzW2ldLmdldCgpOwogCi0gICAgYnVja2V0c09mRmFpbC5hcHBlbmQoX18g am1wKCkpOworICAgICAgICAvLyBDaGVjayB0aGUgcHJvdG90eXBlIG9iamVjdCdzIFN0cnVjdHVy ZSBoYWQgbm90IGNoYW5nZWQuCisgICAgICAgIFN0cnVjdHVyZSoqIHByb3RvdHlwZVN0cnVjdHVy ZUFkZHJlc3MgPSAmKHByb3RvT2JqZWN0LT5tX3N0cnVjdHVyZSk7CisgICAgICAgIF9fIGNtcGxf aTMybShyZWludGVycHJldF9jYXN0PHVpbnQzMl90PihjdXJyU3RydWN0dXJlKSwgc3RhdGljX2Nh c3Q8dm9pZCo+KHByb3RvdHlwZVN0cnVjdHVyZUFkZHJlc3MpKTsKKyAgICAgICAgYnVja2V0c09m RmFpbC5hcHBlbmQoX18gam5lKCkpOworICAgIH0KKyAgICBBU1NFUlQocHJvdG9PYmplY3QpOwor CisgICAgUHJvcGVydHlTdG9yYWdlKiBwcm90b1Byb3BlcnR5U3RvcmFnZSA9ICZwcm90b09iamVj dC0+bV9wcm9wZXJ0eVN0b3JhZ2U7CisgICAgX18gbW92bF9tcihzdGF0aWNfY2FzdDx2b2lkKj4o cHJvdG9Qcm9wZXJ0eVN0b3JhZ2UpLCBYODY6OmVkeCk7CisgICAgX18gbW92bF9tcihjYWNoZWRP ZmZzZXQgKiBzaXplb2YoSlNWYWx1ZSopLCBYODY6OmVkeCwgWDg2OjplYXgpOworICAgIF9fIHJl dCgpOwogCiAgICAgdm9pZCogY29kZSA9IF9fIGV4ZWN1dGFibGVDb3B5KCk7CiAKQEAgLTMzNDUs NiArMzM4Nyw3IEBAIHZvaWQgSklUOjpwcml2YXRlQ29tcGlsZUdldEJ5SWRDaGFpbihTdHIKICAg ICBtX2NvZGVCbG9jay0+Z2V0U3R1YkluZm8ocmV0dXJuQWRkcmVzcykuc3R1YlJvdXRpbmUgPSBj b2RlOwogCiAgICAgY3RpUmVwYXRjaENhbGxCeVJldHVybkFkZHJlc3MocmV0dXJuQWRkcmVzcywg Y29kZSk7CisjZW5kaWYKIH0KIAogdm9pZCBKSVQ6OnByaXZhdGVDb21waWxlUHV0QnlJZFJlcGxh Y2UoU3RydWN0dXJlKiBzdHJ1Y3R1cmUsIHNpemVfdCBjYWNoZWRPZmZzZXQsIHZvaWQqIHJldHVy bkFkZHJlc3MpCg==