224487 2021-04-13 07:48:45 -0700 [GTK4] WTR crash in PlatformWebView::dismissAllPopupMenus() 2021-04-13 08:31:14 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply pnormand webkit-bug-importer oldest_to_newest 1749680 0 cgarcia 2021-04-13 07:48:45 -0700 This is because we are using a for loop to iterate children that are destroyed. We should not be destroying the children, though, we should just hide them, since they are owned by the web view. Thread 1 (Thread 0x7f652fd72f00 (LWP 14765)): #0 0x00007f6532bfc29e in gtk_widget_get_next_sibling (widget=0x55e0bee56260) at ../gtk/gtkwidget.c:11879 #1 0x000055e0b80df0f5 in WTR::PlatformWebView::dismissAllPopupMenus() () #2 0x000055e0b80dfb65 in WTR::TestController::platformResetStateToConsistentValues(WTR::TestOptions const&) () #3 0x000055e0b80b8bb3 in WTR::TestController::resetStateToConsistentValues(WTR::TestOptions const&, WTR::TestController::ResetStage) () #4 0x000055e0b80c6d85 in WTR::TestInvocation::invoke() () #5 0x000055e0b80afbaa in WTR::TestController::runTest(char const*) () #6 0x000055e0b80b027f in WTR::TestController::runTestingServerLoop() () #7 0x000055e0b80b0848 in WTR::TestController::TestController(int, char const**) () #8 0x000055e0b80a004c in main () 1749681 1 425872 cgarcia 2021-04-13 07:50:09 -0700 Created attachment 425872 Patch 1749688 2 ews-feeder 2021-04-13 08:30:56 -0700 Committed r275885 (236450@main): <https://commits.webkit.org/236450@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425872. 1749689 3 webkit-bug-importer 2021-04-13 08:31:14 -0700 <rdar://problem/76592882> 425872 2021-04-13 07:50:09 -0700 2021-04-13 08:30:57 -0700 Patch wkgtk4-wtr-crash.diff text/plain 1476 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMDQw MTAxMjJiNjYuLmZmODE5NGFjMWE3NiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA0LTEzICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLNF0gV1RSIGNy YXNoIGluIFBsYXRmb3JtV2ViVmlldzo6ZGlzbWlzc0FsbFBvcHVwTWVudXMoKQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI0NDg3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBiZWNhdXNlIHdl IGFyZSB1c2luZyBhIGZvciBsb29wIHRvIGl0ZXJhdGUgY2hpbGRyZW4gdGhhdCBhcmUgZGVzdHJv eWVkLiBXZSBzaG91bGQgbm90IGJlIGRlc3Ryb3lpbmcgdGhlCisgICAgICAgIGNoaWxkcmVuLCB0 aG91Z2gsIHdlIHNob3VsZCBqdXN0IGhpZGUgdGhlbSwgc2luY2UgdGhleSBhcmUgb3duZWQgYnkg dGhlIHdlYiB2aWV3LgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9ndGsvUGxhdGZvcm1X ZWJWaWV3R3RrLmNwcDoKKyAgICAgICAgKFdUUjo6UGxhdGZvcm1XZWJWaWV3OjpkaXNtaXNzQWxs UG9wdXBNZW51cyk6CisKIDIwMjEtMDQtMTEgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjc1ODAxLgpkaWZm IC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9ndGsvUGxhdGZvcm1XZWJWaWV3R3RrLmNw cCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1BsYXRmb3JtV2ViVmlld0d0ay5jcHAKaW5k ZXggNTQ5NzFkNDI4NmRhLi5mNmUzYjc3ZmJhY2YgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvZ3RrL1BsYXRmb3JtV2ViVmlld0d0ay5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9ndGsvUGxhdGZvcm1XZWJWaWV3R3RrLmNwcApAQCAtMjUwLDcgKzI1MCw3IEBAIHZv aWQgUGxhdGZvcm1XZWJWaWV3OjpkaXNtaXNzQWxsUG9wdXBNZW51cygpCiAjaWYgVVNFKEdUSzQp CiAgICAgZm9yIChhdXRvKiBjaGlsZCA9IGd0a193aWRnZXRfZ2V0X2ZpcnN0X2NoaWxkKEdUS19X SURHRVQobV92aWV3KSk7IGNoaWxkOyBjaGlsZCA9IGd0a193aWRnZXRfZ2V0X25leHRfc2libGlu ZyhjaGlsZCkpIHsKICAgICAgICAgaWYgKEdUS19JU19QT1BPVkVSKGNoaWxkKSkKLSAgICAgICAg ICAgIGd0a193aWRnZXRfdW5wYXJlbnQoY2hpbGQpOworICAgICAgICAgICAgZ3RrX3dpZGdldF9o aWRlKGNoaWxkKTsKICAgICB9CiAjZWxzZQogICAgIC8vIGd0a19tZW51X3BvcGRvd24gZG9lc24n dCBtb2RpZnkgdGhlIEdMaXN0IG9mIGF0dGFjaGVkIG1lbnVzLCBzbyBpdCBzaG91bGQK