224485 2021-04-13 06:34:08 -0700 Web Inspector: Forced color scheme should reset on page refresh 2023-06-07 03:44:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 1 rcaliman rcaliman bburg inspector-bugzilla-changes webkit-bug-importer yurys oldest_to_newest 1749669 0 rcaliman 2021-04-13 06:34:08 -0700 <rdar://76227216> 1749674 1 425871 rcaliman 2021-04-13 07:11:48 -0700 Created attachment 425871 Patch 1749803 2 425871 bburg 2021-04-13 12:38:05 -0700 Comment on attachment 425871 Patch r=me 1749828 3 ews-feeder 2021-04-13 13:09:41 -0700 Committed r275904 (236468@main): <https://commits.webkit.org/236468@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 425871. 1754423 4 yurys 2021-04-26 16:12:35 -0700 (In reply to EWS from comment #3) > Committed r275904 (236468@main): <https://commits.webkit.org/236468@main> > This change regresses current behavior: there is no way to override color scheme preference in the early stage of page load as there is inherent delay between navigation commit and when the front-end can set the override back. Basically this code will always give wrong result if run early during page load: // Send Page.setForcedAppearance with "appearance":"Light" // navigate to a page with the following code in its inline script: console.log(matchMedia('(prefers-color-scheme: light)').matches); 1960248 5 rcaliman 2023-06-07 03:44:15 -0700 (In reply to Yury Semikhatsky from comment #4) > This change regresses current behavior: there is no way to override color > scheme preference in the early stage of page load as there is inherent delay > between navigation commit and when the front-end can set the override back. > Basically this code will always give wrong result if run early during page > load: > > // Send Page.setForcedAppearance with "appearance":"Light" > // navigate to a page with the following code in its inline script: > console.log(matchMedia('(prefers-color-scheme: light)').matches); This has been addressed in the patch for Bug 254457. The color scheme override will persist on page refresh. 425871 2021-04-13 07:11:48 -0700 2021-04-13 13:09:41 -0700 Patch bug-224485-20210413161147.patch text/plain 1354 rcaliman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0MTk5YzU4M2RjMGNjZjIwMmNhNjUzZjgzNmZkNDJkMDNkOTcyMjM5Li5k Nzg5ZWJlMjNjOGIyYjAzMTkxMzY3OWEzMGNhOGFkZDgyYWZmMGUyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMjEtMDQtMTMgIFJhenZhbiBDYWxpbWFuICA8cmNhbGltYW5AYXBwbGUu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEZvcmNlZCBjb2xvciBzY2hlbWUgc2hvdWxk IHJlc2V0IG9uIHBhZ2UgcmVmcmVzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjI0NDg1CisgICAgICAgIDxyZGFyOi8vNzYyMjcyMTY+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVzZXQgdGhlIGZvcmNl ZCBjb2xvciBzY2hlbWUgb24gcGFnZSByZWxvYWQgdG8ga2VlcCBpbiBzeW5jIHdpdGggV2ViIElu c3BlY3RvcgorICAgICAgICBiZWhhdmlvciBmb3Igb3RoZXIgZm9yY2VkIHN0YXRlcywgbGlrZSBw c2V1ZG8tY2xhc3Nlcy4KKworICAgICAgICAqIHBhZ2UvUGFnZS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpQYWdlOjpkaWRDb21taXRMb2FkKToKKwogMjAyMS0wNC0xMiAgQ2hyaXMgTG9yZCAgPGNs b3JkQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmVmYWN0b3IgZm9udCBsb2FkaW5nIHRvIG1ha2Ug aXQgcG9zc2libGUgZm9yIFdvcmtlciB0byBpbXBsZW1lbnQgaXQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCmlu ZGV4IGVhZjU2Y2RlMjMwNjY1MzgzOTg1NTUyNjE1ZTEyNTgwMDI1OGE4NmMuLmJkOWU1MzgyYmM5 ZGNjYmFmZmVjNmIzOTQyMjI0YzhkNWVhNjZiOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcApAQCAtMTI1 Miw2ICsxMjUyLDExIEBAIHZvaWQgUGFnZTo6ZGlkQ29tbWl0TG9hZCgpCiAjaWYgRU5BQkxFKEVE SVRBQkxFX1JFR0lPTikKICAgICBtX2lzRWRpdGFibGVSZWdpb25FbmFibGVkID0gZmFsc2U7CiAj ZW5kaWYKKworI2lmIEhBVkUoT1NfREFSS19NT0RFX1NVUFBPUlQpCisgICAgc2V0VXNlRGFya0Fw cGVhcmFuY2VPdmVycmlkZShXVEY6Om51bGxvcHQpOworI2VuZGlmCisKICAgICByZXNldFNlZW5Q bHVnaW5zKCk7CiAgICAgcmVzZXRTZWVuTWVkaWFFbmdpbmVzKCk7CiB9Cg==